active-fedora 9.4.2 → 9.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 35b37e4ce4fb55f72c525f6868b769f60af55d98
-  data.tar.gz: 8705a17f008927df6c005fe327825c70479b1abe
+  metadata.gz: de5b5046afb1dd762565465806e9b98a67c21727
+  data.tar.gz: 46a49e17d79a44566e95a61403b233b61a37e556
 SHA512:
-  metadata.gz: 4a534d6c9f2710b9ec7f5802bff389f3fbe8d42152a15d9494eb1c1003acc92d66b9d6727cf2c56986b7ada339ef8e7b5871fe26dcd6fee1bd7b115aee0a58ee
-  data.tar.gz: 6ee26660bc33f7c8bd21f2c2618f3e0b3bc74355ae022b55bd201da6a85304509a577cd28710995442e78969251a7946ba2fdfd162b810330b5beacd398e3251
+  metadata.gz: fa2eec62f59fde87474c31cf72c28ba1f8bfbc3dc8377869d1d9f5bf2d26de643e834d4e34e5b9db1dfa432d3d5bc620791a92bedfcfff24ce2ed23646a99051
+  data.tar.gz: ad05b8ba63965874e5d56e8d2096954705088fc2b19f6fab47aaaaa7cf3fa300d523e2e27141dd78061246a66df7f94d9bdf938b0494013bc51c3aa1c5d5fb03

data/History.txt

@@ -1,3 +1,9 @@
+v9.4.3
+  2015-09-30: Don't mark an attribute as changed if it's set to the same value
+  [Justin Coyne]
+
+  2015-09-28: Remove unnecessary whitespace [Justin Coyne]
+
 v9.4.2
   2015-09-25: Refactor nested_attribute test for easier reading [Justin Coyne]
 

data/README.md

@@ -64,7 +64,7 @@ integration server. To do that, unzip a copy of hydra-jetty first. This includes
 used during the testing process.
 
 ```bash
-rake jetty:unzip 
+rake jetty:unzip
 ```
 
 Once hydra-jetty is unzipped, the ci rake task will spin up jetty,

data/lib/active_fedora/attribute_methods/dirty.rb

@@ -6,7 +6,7 @@ module ActiveFedora
       def set_value(*val)
         attribute = val.first
         unless [:has_model, :modified_date].include? attribute
-          attribute_will_change!(attribute)
+          attribute_will_change!(attribute) unless self[val.first] == val.last
         end
         super
       end

data/lib/active_fedora/attributes/property_builder.rb

@@ -28,6 +28,7 @@ module ActiveFedora::Attributes
       mixin.class_eval <<-CODE, __FILE__, __LINE__ + 1
         def #{name}(*args)
           vals = get_values(:#{name})
+          return nil unless vals
           raise ActiveFedora::ConstraintError, "Expected \\"#{name}\\" to have 0-1 statements, but there are \#{vals.size}" if vals.size > 1
           vals.first
         end

data/lib/active_fedora/version.rb

@@ -1,3 +1,3 @@
 module ActiveFedora
-  VERSION = "9.4.2"
+  VERSION = "9.4.3"
 end

data/spec/unit/attributes_spec.rb

@@ -228,10 +228,28 @@ describe ActiveFedora::Base do
           }.to change { subject.fubar_changed? }.from(false).to(true)
         end
 
-        it "should work for properties" do
-          expect {
-            subject.goose = ["honk!"]
-          }.to change { subject.goose_changed? }.from(false).to(true)
+        context "when a change is made to a property" do
+          it "is marked changed" do
+            expect {
+              subject.goose = ["honk!"]
+            }.to change { subject.goose_changed? }.from(false).to(true)
+          end
+        end
+
+        context "when a property is set to the same value" do
+          before do
+            subject.goose = ['honk!', 'Honk']
+            if ActiveModel.version < Gem::Version.new('4.2.0')
+              subject.send(:reset_changes)
+            else
+              subject.send(:clear_changes_information)
+            end
+          end
+
+          it "is not marked changed" do
+            subject.goose = ['honk!', 'Honk']
+            expect(subject.goose_changed?).to be false
+          end
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active-fedora
 version: !ruby/object:Gem::Version
-  version: 9.4.2
+  version: 9.4.3
 platform: ruby
 authors:
 - Matt Zumwalt
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-25 00:00:00.000000000 Z
+date: 2015-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rsolr