active-fedora 13.0.0 → 13.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61e9e73d569fd4d2c553d84d8edf1005cceb73912478bd45bd5b7ae451d28d63
-  data.tar.gz: 82d9d52da4b6cb81bb2ef1748542305dce3a6ffd5ed81fc2bae598cb6114a405
+  metadata.gz: 348a0e08947c00eccf81f00a6ef14a951260e6fe0c270ef02be5a5f8156c81cd
+  data.tar.gz: 5ed0e0750973f23363d957ad805258fb57136458d180b5f370ae3623cefd8c46
 SHA512:
-  metadata.gz: 526c020760edeb2703961ad0a34e85ddfcd2de5535a753c15598afd45c503640c89527dc5ad239522d051d522e1072cbd10f8a054361bbee437f70378f317940
-  data.tar.gz: 9c6a6b796268853d5b594804dd5036e82d2cf085888f82eac0924108cdce8f152ddc5de85fae385f03590c5ee857345cf031df529684df1490eeae746869b71b
+  metadata.gz: 5ac3f364558f417839460eda83db111641d629f238855679801af8bb82d69ac03489025e5c7508cc2853bf4ccdbb0bab06e4cb053845b6b0c3d72815f5a1b563
+  data.tar.gz: fe5ba83bea823f33caa89fd02005db0961bea7f8e2dc4ab2fee962d0941d349991c9e88718d98d36cda319725664b72870e904601d6d3cf003663996538b63f2

data/.circleci/config.yml

@@ -46,18 +46,14 @@ workflows:
           ruby_version: 2.5.5
           rails_version: 5.2.3
       - bundle_lint_test:
-          name: ruby2-4_rails5-2
-          ruby_version: 2.4.6
-          rails_version: 5.2.3
-      - bundle_lint_test:
-          name: ruby2-6_rails5-1
+          name: ruby2-6_rails6-0
           ruby_version: 2.6.3
-          rails_version: 5.1.7
+          rails_version: 6.0.0
       - bundle_lint_test:
-          name: ruby2-5_rails5.1
+          name: ruby2-5_rails6.0
           ruby_version: 2.5.5
-          rails_version: 5.1.7
+          rails_version: 6.0.0
       - bundle_lint_test:
-          name: ruby2-4_rails5-1
-          ruby_version: 2.4.6
-          rails_version: 5.1.7
+          name: ruby2-4_rails5-2
+          ruby_version: 2.4.7
+          rails_version: 5.2.3

data/active-fedora.gemspec

@@ -12,11 +12,11 @@ Gem::Specification.new do |s|
   s.summary     = %q{A convenience libary for manipulating documents in the Fedora Repository.}
   s.description = %q{ActiveFedora provides for creating and managing objects in the Fedora Repository Architecture.}
   s.license = "Apache-2.0"
-  s.required_ruby_version = '~> 2.0'
+  s.required_ruby_version = '~> 2.4'
 
   s.add_dependency 'rsolr', '>= 1.1.2', '< 3'
-  s.add_dependency "activesupport", '>= 4.2.4', '< 5.3'
-  s.add_dependency "activemodel", '>= 4.2.10', '< 5.3'
+  s.add_dependency "activesupport", '>= 5.2'
+  s.add_dependency "activemodel", '>= 5.2'
   s.add_dependency "active-triples", '>= 0.11.0', '< 2.0.0'
   s.add_dependency "deprecation"
   s.add_dependency "ldp", '>= 0.7.0', '< 2'

data/lib/active_fedora/aggregation/list_source.rb

@@ -12,9 +12,11 @@ module ActiveFedora
         super
       end
 
-      # Overriding so that we don't track previously_changed, which was
-      # rather expensive.
+      ##
+      # @deprecated use #changes_applied instead
       def clear_changed_attributes
+        Deprecation.warn self.class, "#clear_changed_attributes is deprecated, use ActiveModel::Dirty#changes_applied instead."
+
         clear_changes_information
       end
 

data/lib/active_fedora/attributes.rb

@@ -9,11 +9,30 @@ module ActiveFedora
       include Serializers
       include PrimaryKey
 
-      after_save :clear_changed_attributes
+      after_save :clear_changed_attributes_or_changes_applied
+      # @deprecated use #changes_applied instead
       def clear_changed_attributes
+        Deprecation.warn ActiveFedora::Attributes, "#clear_changed_attributes is deprecated, use ActiveModel::Dirty#changes_applied instead."
         @previously_changed = changes
         clear_attribute_changes(changes.keys)
       end
+
+      ##
+      # Call the deprecated method
+      #
+      # @deprecated use #changes_applied instead
+      # @api private
+      def clear_changed_attributes_or_changes_applied
+        return changes_applied if
+          method(:clear_changed_attributes).super_method.nil? ||
+          method(:clear_changed_attributes).owner == ActiveFedora::Aggregation::ListSource
+
+        Deprecation.warn self.class, "after_save callbacks to #clear_changed_attributes are deprecated. " /
+                                     "These calls will be removed in 14.0.0. If you are running Rails 6.0, " /
+                                     "it's likely your #clear_changed_attributes implementation is in " /
+                                     "conflict with new ActiveModel::Dirty behavior."
+        clear_changed_attributes
+      end
     end
 
     def attribute_names

data/lib/active_fedora/file.rb

@@ -97,11 +97,6 @@ module ActiveFedora
       attribute_will_change! :ldp_source
     end
 
-    def attribute_will_change!(attr)
-      return super unless attr == 'content'
-      attributes_changed_by_setter[:content] = true
-    end
-
     def remote_content
       return if new_record?
       @ds_content ||= retrieve_content

data/lib/active_fedora/version.rb

@@ -1,3 +1,3 @@
 module ActiveFedora
-  VERSION = "13.0.0".freeze
+  VERSION = '13.1.0'.freeze
 end

data/lib/active_fedora/with_metadata/metadata_node.rb

@@ -15,7 +15,7 @@ module ActiveFedora
         @file = file
         super(file.uri, ldp_source.graph)
         return unless self.class.type && !type.include?(self.class.type)
-        attributes_changed_by_setter[:type] = true if type.present?
+        attribute_will_change!(:type) if type.present?
         # Workaround for https://github.com/ActiveTriples/ActiveTriples/issues/123
         get_values(:type) << self.class.type
       end

data/spec/unit/with_metadata/metadata_node_spec.rb

@@ -19,7 +19,7 @@ describe ActiveFedora::WithMetadata::MetadataNode do
         generated_schema.configure type: book
       end
 
-      it { is_expected.to eq('type' => true) }
+      it { is_expected.to match('type' => be_truthy) }
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active-fedora
 version: !ruby/object:Gem::Version
-  version: 13.0.0
+  version: 13.1.0
 platform: ruby
 authors:
 - Matt Zumwalt
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-19 00:00:00.000000000 Z
+date: 2019-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rsolr
@@ -38,40 +38,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.4
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.4
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.10
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.10
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: active-triples
   requirement: !ruby/object:Gem::Requirement
@@ -725,14 +713,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubyforge_project: 
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A convenience libary for manipulating documents in the Fedora Repository.