actionview 5.1.7 → 5.2.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 653bc5c6f534a3b66e9bc0517e1dae96591c0afc046eb4af21c2bfde0aa5436d
-  data.tar.gz: 3f6ac20820ff6a4d61dcf499bff23acf931f3a6ea65822720f63e0e522f1b77d
+SHA1:
+  metadata.gz: c934acdfba1e347532a218260fcdb7a2270b368d
+  data.tar.gz: 607d5d00fdf3f2f529789ffb93d332c7bf056db8
 SHA512:
-  metadata.gz: c21cc5b6ec4a492a753325d9c732c9c8900ef7e07134bc259becbd040df51afd0ff3bb27141bcd9ac87c02537eae789161e7e5241f4bfadd230a29aabc3a36fa
-  data.tar.gz: dcd3864b5a9216b19021272876564be5170b6d3e6af094a0a744517d01d89c58629156e6b4a87ebf593e37ae2478eb6687e9e923fe675d22d740e555ea91e64e
+  metadata.gz: 9fb6af6781f3581601deaf9157e9725b2fa1cb345c071dbe9bba8ca3dc51bc8af6a8271b3ab36ad4c1335684076e018e18acec7d5efd9db2d1ef65165da22068
+  data.tar.gz: d6bc2a0f3ef3f395e1dfb2ba5784f43e922796fd163f756bc6293279e2689cb8fc672590f56bea8c0836d652373df468ec8dd06f0b711fd5288baeff768b7896

data/CHANGELOG.md

@@ -1,74 +1,42 @@
-## Rails 5.1.7 (March 27, 2019) ##
+## Rails 5.2.0.beta1 (November 27, 2017) ##
 
-*   Fix issue with `button_to`'s `to_form_params`
+*   Change `form_with` to generates ids by default.
 
-    `button_to` was throwing exception when invoked with `params` hash that
-    contains symbol and string keys. The reason for the exception was that
-    `to_form_params` was comparing the given symbol and string keys.
+    When `form_with` was introduced we disabled the automatic generation of ids
+    that was enabled in `form_for`. This usually is not an good idea since labels don't work
+    when the input doesn't have an id and it made harder to test with Capybara.
 
-    The issue is fixed by turning all keys to strings inside
-    `to_form_params` before comparing them.
+    You can still disable the automatic generation of ids setting `config.action_view.form_with_generates_ids`
+    to `false.`
 
-    *Georgi Georgiev*
+    *Nick Pezza*
 
-## Rails 5.1.6.2 (March 11, 2019) ##
+*   Fix issues with `field_error_proc` wrapping `optgroup` and select divider `option`.
 
-*   No changes.
+    Fixes #31088
 
+    *Matthias Neumayr*
 
-## Rails 5.1.6.1 (November 27, 2018) ##
+*   Remove deprecated Erubis ERB handler.
 
-*   No changes.
-
-
-## Rails 5.1.6 (March 29, 2018) ##
-
-*   No changes.
-
-
-## Rails 5.1.5 (February 14, 2018) ##
-
-*   No changes.
-
-
-## Rails 5.1.4 (September 07, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.1.4.rc1 (August 24, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.1.3 (August 03, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.1.3.rc3 (July 31, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.1.3.rc2 (July 25, 2017) ##
+    *Rafael Mendonça França*
 
-*   No changes.
+*   Remove default `alt` text generation.
 
+    Fixes #30096
 
-## Rails 5.1.3.rc1 (July 19, 2017) ##
+    *Cameron Cundiff*
 
-*   No changes.
+*   Add `srcset` option to `image_tag` helper.
 
+    *Roberto Miranda*
 
-## Rails 5.1.2 (June 26, 2017) ##
+*   Fix issues with scopes and engine on `current_page?` method.
 
-*   Fix issues with scopes and engine on `current_page?` method. 
-    
     Fixes #29401.
-    
+
     *Nikita Savrov*
-    
+
 *   Generate field ids in `collection_check_boxes` and `collection_radio_buttons`.
 
     This makes sure that the labels are linked up with the fields.
@@ -77,230 +45,14 @@
 
     *Yuji Yaginuma*
 
-*   Update distance_of_time_in_words helper to display better error messages
-    for bad input.
-
-    *Jay Hayes*
-
-
-## Rails 5.1.1 (May 12, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.1.0 (April 27, 2017) ##
-
-*   Remove the option `encode_special_chars` misnomer from `strip_tags`
-
-    As of rails-html-sanitizer v1.0.3, the sanitizer will ignore the
-    `encode_special_chars` option.
-
-    Fixes #28060.
-
-    *Andrew Hood*
-
-*   Change the ERB handler from Erubis to Erubi.
-
-    Erubi is an Erubis fork that's svelte, simple, and currently maintained.
-    Plus it supports `--enable-frozen-string-literal` in Ruby 2.3+.
-
-    Compatibility: Drops support for `<%===` tags for debug output.
-    These were an unused, undocumented side effect of the Erubis
-    implementation.
-
-    Deprecation: The Erubis handler will be removed in Rails 5.2, for the
-    handful of folks using it directly.
-
-    *Jeremy Evans*
-
-*   Allow render locals to be assigned to instance variables in a view.
-
-    Fixes #27480.
-
-    *Andrew White*
-
-*   Add `check_parameters` option to `current_page?` which makes it more strict.
-
-    *Maksym Pugach*
-
-*   Return correct object name in form helper method after `fields_for`.
-
-    Fixes #26931.
-
-    *Yuji Yaginuma*
-
-*   Use `ActionView::Resolver.caching?` (`config.action_view.cache_template_loading`)
-    to enable template recompilation.
-
-    Before it was enabled by `consider_all_requests_local`, which caused
-    recompilation in tests.
-
-    *Max Melentiev*
+*   Add `:json` type to `auto_discovery_link_tag` to support [JSON Feeds](https://jsonfeed.org/version/1)
 
-*   Add `form_with` to unify `form_tag` and `form_for` usage.
+    *Mike Gunderloy*
 
-    Used like `form_tag` (where just the open tag is output):
-
-    ```erb
-    <%= form_with scope: :post, url: super_special_posts_path %>
-    ```
-
-    Used like `form_for`:
-
-    ```erb
-    <%= form_with model: @post do |form| %>
-      <%= form.text_field :title %>
-    <% end %>
-    ```
-
-    *Kasper Timm Hansen*, *Marek Kirejczyk*
-
-*   Add `fields` form helper method.
-
-    ```erb
-    <%= fields :comment, model: @comment do |fields| %>
-      <%= fields.text_field :title %>
-    <% end %>
-    ```
-
-    Can also be used within form helpers such as `form_with`.
-
-    *Kasper Timm Hansen*
-
-*   Removed deprecated `#original_exception` in `ActionView::Template::Error`.
-
-    *Rafael Mendonça França*
-
-*   Render now accepts any keys for locals, including reserved keywords.
-
-    Only locals with valid variable names get set directly. Others
-    will still be available in `local_assigns`.
-
-    Example of render with reserved keywords:
-
-    ```erb
-    <%= render "example", class: "text-center", message: "Hello world!" %>
-
-    <!-- _example.html.erb: -->
-    <%= tag.div class: local_assigns[:class] do %>
-      <p><%= message %></p>
-    <% end %>
-    ```
-
-    *Peter Schilling*, *Matthew Draper*
-
-*   Add `:skip_pipeline` option to several asset tag helpers
-
-    `javascript_include_tag`, `stylesheet_link_tag`, `favicon_link_tag`,
-    `image_tag` and `audio_tag` now accept a `:skip_pipeline` option which can
-    be set to true to bypass the asset pipeline and serve the assets from the
-    public folder.
-
-    *Richard Schneeman*
-
-*   Add `:poster_skip_pipeline` option to the `video_tag` helper
-
-    `video_tag` now accepts a `:poster_skip_pipeline` option which can be used
-    in combination with the `:poster` option to bypass the asset pipeline and
-    serve the poster image for the video from the public folder.
-
-    *Richard Schneeman*
-
-*   Show cache hits and misses when rendering partials.
-
-    Partials using the `cache` helper will show whether a render hit or missed
-    the cache:
-
-    ```
-    Rendered messages/_message.html.erb in 1.2 ms [cache hit]
-    Rendered recordings/threads/_thread.html.erb in 1.5 ms [cache miss]
-    ```
-
-    This removes the need for the old fragment cache logging:
-
-    ```
-    Read fragment views/v1/2914079/v1/2914079/recordings/70182313-20160225015037000000/d0bdf2974e1ef6d31685c3b392ad0b74 (0.6ms)
-    Rendered messages/_message.html.erb in 1.2 ms [cache hit]
-    Write fragment views/v1/2914079/v1/2914079/recordings/70182313-20160225015037000000/3b4e249ac9d168c617e32e84b99218b5 (1.1ms)
-    Rendered recordings/threads/_thread.html.erb in 1.5 ms [cache miss]
-    ```
-
-    Though that full output can be reenabled with
-    `config.action_controller.enable_fragment_cache_logging = true`.
-
-    *Stan Lo*
-
-*   Changed partial rendering with a collection to allow collections which
-    implement `to_a`.
-
-    Extracting the collection option had an optimization to avoid unnecessary
-    queries of ActiveRecord Relations by calling `#to_ary` on the given
-    collection. Instances of `Enumerator` or `Enumerable` are valid
-    collections, but they do not implement `#to_ary`. By changing this to
-    `#to_a`, they will now be extracted and rendered as expected.
-
-    *Steven Harman*
-
-*   New syntax for tag helpers. Avoid positional parameters and support HTML5 by default.
-    Example usage of tag helpers before:
-
-    ```ruby
-    tag(:br, nil, true)
-    content_tag(:div, content_tag(:p, "Hello world!"), class: "strong")
-
-    <%= content_tag :div, class: "strong" do -%>
-      Hello world!
-    <% end -%>
-    ```
-
-    Example usage of tag helpers after:
-
-    ```ruby
-    tag.br
-    tag.div tag.p("Hello world!"), class: "strong"
-
-    <%= tag.div class: "strong" do %>
-      Hello world!
-    <% end %>
-    ```
-
-    *Marek Kirejczyk*, *Kasper Timm Hansen*
-
-*   Change `datetime_field` and `datetime_field_tag` to generate `datetime-local` fields.
-
-    As a new specification of the HTML 5 the text field type `datetime` will no longer exist
-    and it is recommended to use `datetime-local`.
-    Ref: https://html.spec.whatwg.org/multipage/forms.html#local-date-and-time-state-(type=datetime-local)
-
-    *Herminio Torres*
-
-*   Raw template handler (which is also the default template handler in Rails 5) now outputs
-    HTML-safe strings.
-
-    In Rails 5 the default template handler was changed to the raw template handler. Because
-    the ERB template handler escaped strings by default this broke some applications that
-    expected plain JS or HTML files to be rendered unescaped. This fixes the issue caused
-    by changing the default handler by changing the Raw template handler to output HTML-safe
-    strings.
-
-    *Eileen M. Uchitelle*
-
-*   `select_tag`'s `include_blank` option for generation for blank option tag, now adds an empty space label,
-     when the value as well as content for option tag are empty, so that we conform with html specification.
-     Ref: https://www.w3.org/TR/html5/forms.html#the-option-element.
-
-    Generation of option before:
-
-    ```html
-    <option value=""></option>
-    ```
-
-    Generation of option after:
+*   Update `distance_of_time_in_words` helper to display better error messages
+    for bad input.
 
-    ```html
-    <option value="" label=" "></option>
-    ```
+    *Jay Hayes*
 
-    *Vipul A M*
 
-Please check [5-0-stable](https://github.com/rails/rails/blob/5-0-stable/actionview/CHANGELOG.md) for previous changes.
+Please check [5-1-stable](https://github.com/rails/rails/blob/5-1-stable/actionview/CHANGELOG.md) for previous changes.

data/README.rdoc

@@ -20,7 +20,7 @@ Source code can be downloaded as part of the Rails project on GitHub
 
 Action View is released under the MIT license:
 
-* http://www.opensource.org/licenses/MIT
+* https://opensource.org/licenses/MIT
 
 
 == Support

data/lib/action_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #--
 # Copyright (c) 2004-2017 David Heinemeier Hansson
 #
@@ -74,7 +76,6 @@ module ActionView
       autoload :MissingTemplate
       autoload :ActionViewError
       autoload :EncodingError
-      autoload :MissingRequestError
       autoload :TemplateError
       autoload :WrongEncodingError
     end
@@ -92,5 +93,5 @@ end
 require "active_support/core_ext/string/output_safety"
 
 ActiveSupport.on_load(:i18n) do
-  I18n.load_path << "#{File.dirname(__FILE__)}/action_view/locale/en.yml"
+  I18n.load_path << File.expand_path("action_view/locale/en.yml", __dir__)
 end

data/lib/action_view/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/module/attr_internal"
 require "active_support/core_ext/module/attribute_accessors"
 require "active_support/ordered_options"
@@ -140,30 +142,25 @@ module ActionView #:nodoc:
     include Helpers, ::ERB::Util, Context
 
     # Specify the proc used to decorate input tags that refer to attributes with errors.
-    cattr_accessor :field_error_proc
-    @@field_error_proc = Proc.new { |html_tag, instance| "<div class=\"field_with_errors\">#{html_tag}</div>".html_safe }
+    cattr_accessor :field_error_proc, default: Proc.new { |html_tag, instance| "<div class=\"field_with_errors\">#{html_tag}</div>".html_safe }
 
     # How to complete the streaming when an exception occurs.
     # This is our best guess: first try to close the attribute, then the tag.
-    cattr_accessor :streaming_completion_on_exception
-    @@streaming_completion_on_exception = %("><script>window.location = "/500.html"</script></html>)
+    cattr_accessor :streaming_completion_on_exception, default: %("><script>window.location = "/500.html"</script></html>)
 
     # Specify whether rendering within namespaced controllers should prefix
     # the partial paths for ActiveModel objects with the namespace.
     # (e.g., an Admin::PostsController would render @post using /admin/posts/_post.erb)
-    cattr_accessor :prefix_partial_path_with_controller_namespace
-    @@prefix_partial_path_with_controller_namespace = true
+    cattr_accessor :prefix_partial_path_with_controller_namespace, default: true
 
     # Specify default_formats that can be rendered.
     cattr_accessor :default_formats
 
     # Specify whether an error should be raised for missing translations
-    cattr_accessor :raise_on_missing_translations
-    @@raise_on_missing_translations = false
+    cattr_accessor :raise_on_missing_translations, default: false
 
     # Specify whether submit_tag should automatically disable on click
-    cattr_accessor :automatically_disable_submit_tag
-    @@automatically_disable_submit_tag = true
+    cattr_accessor :automatically_disable_submit_tag, default: true
 
     class_attribute :_routes
     class_attribute :logger
@@ -207,6 +204,7 @@ module ActionView #:nodoc:
         @view_renderer = ActionView::Renderer.new(lookup_context)
       end
 
+      @cache_hit = {}
       assign(assigns)
       assign_controller(controller)
       _prepare_context

data/lib/action_view/buffers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/string/output_safety"
 
 module ActionView

data/lib/action_view/context.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionView
   module CompiledTemplates #:nodoc:
     # holds compiled template code
@@ -17,7 +19,6 @@ module ActionView
     attr_accessor :output_buffer, :view_flow
 
     # Prepares the context by setting the appropriate instance variables.
-    # :api: plugin
     def _prepare_context
       @view_flow     = OutputFlow.new
       @output_buffer = nil
@@ -27,7 +28,6 @@ module ActionView
     # Encapsulates the interaction with the view flow so it
     # returns the correct buffer on +yield+. This is usually
     # overwritten by helpers to add more behavior.
-    # :api: plugin
     def _layout_for(name = nil)
       name ||= :layout
       view_flow.get(name).html_safe