actionview-component 1.16.0 → 1.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3ba3d4977df1eebf5c9302cd205026c2c24171573ac3e773e7842d7951a3dba3
-  data.tar.gz: 8b304a5e95a8483fa76227c6949a5d97a645ed70e7529bec41d21faee6a1b5f0
+  metadata.gz: 24d6994186bb4c3e5f6fb8c628a3d91124cc6bdcbad61b966365c9170ab3b901
+  data.tar.gz: 020ab981225e9bb34508583c2aff096b125e43bee8c5ecc935ab52c6a22eb014
 SHA512:
-  metadata.gz: 96cb83f9aa25bfc9e363b0d9fca3e62b84829514f5340f4a531b4f8709563fc85fd2990b2175c912938993a09dc9d834396589daec8839b30523156eb21250d1
-  data.tar.gz: 9e03e678effd5b1716d24f23f7c16c0b4342ba18a4c480ac93ac5bdd3e7d049285e15974642c363b8d4e3b085108ae1b5a16ccf20bd3ed553472edc70fd4a722
+  metadata.gz: 608b7e73a07c3b24c1fa273f65c1dea5f1e5d993f3db8ff3c3dde2d9d6a207604141849686cd78f4a6ac7a4a6c45567d81fb3eb054c7bccf4802565a3eb83a71
+  data.tar.gz: 8376ee07b5534e81b25c6241a0e9da6d02cf13a0b8b3b4036cdb6a062695897efaefd75a779f5d5d7009477ab03524da13f7a52fc557484dfd128cf77927e3f3

data/.github/workflows/ruby_on_rails.yml

@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         rails_version: [5.0.0, 5.2.3, 6.0.0, master]
-        ruby_version: [2.5.x, 2.6.x, 2.7.x]
+        ruby_version: [2.4.x, 2.5.x, 2.6.x, 2.7.x]
         exclude:
           - rails_version: master
             ruby_version: 2.4.x
@@ -20,6 +20,10 @@ jobs:
       uses: actions/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby_version }}
+    - name: Update rubygems when testing with Ruby 2.4.x
+      if: startsWith(matrix.ruby_version, '2.4')
+      run: |
+        gem update --system --no-document
     - name: Build and test with Rake
       run: |
         gem install bundler:1.17.3

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # master
 
+# v1.17.0
+
+* Support Ruby 2.4 in CI.
+
+    *Andrew Mason*
+
+* ViewComponent generators do not not prompt for content requirement.
+
+    *Joel Hawksley*
+
+* Add post-install message that gem has been renamed to `view_component`.
+
+    *Joel Hawksley*
+
 # v1.16.0
 
 * Add `refute_component_rendered` test helper.

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    actionview-component (1.16.0)
-      capybara (>= 3)
+    actionview-component (1.17.0)
+      capybara (~> 3)
 
 GEM
   remote: https://rubygems.org/
@@ -189,7 +189,7 @@ PLATFORMS
 DEPENDENCIES
   actionview-component!
   better_html (~> 1)
-  bundler (>= 1.14)
+  bundler (~> 1.14)
   haml (~> 5)
   minitest (= 5.1.0)
   rails (= 6.0.0)

data/README.md

@@ -33,7 +33,7 @@ This library is designed to integrate as seamlessly as possible with Rails, with
 
 ## Compatibility
 
-`actionview-component` is tested for compatibility with combinations of Ruby `2.5`/`2.6`/`2.7` and Rails `5.0.0`/`5.2.3`/`6.0.0`/`master`.
+`actionview-component` is tested for compatibility with combinations of Ruby `2.4`/`2.5`/`2.6`/`2.7` and Rails `5.0.0`/`5.2.3`/`6.0.0`/`master`.
 
 ## Installation
 

data/actionview-component.gemspec

@@ -11,8 +11,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ["GitHub Open Source"]
   spec.email         = ["opensource+view_component@github.com"]
 
-  spec.summary       = %q{View components for Rails}
-  spec.description   = %q{View components for Rails}
+  spec.summary       = %q{MOVED to view_component.}
   spec.homepage      = "https://github.com/github/view_component"
   spec.license       = "MIT"
 
@@ -34,8 +33,8 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 2.3.0"
 
-  spec.add_runtime_dependency     "capybara", ">= 3"
-  spec.add_development_dependency "bundler", ">= 1.14"
+  spec.add_runtime_dependency     "capybara", "~> 3"
+  spec.add_development_dependency "bundler", "~> 1.14"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "minitest", "= 5.1.0"
   spec.add_development_dependency "haml", "~> 5"
@@ -43,4 +42,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "better_html", "~> 1"
   spec.add_development_dependency "rubocop", "= 0.74"
   spec.add_development_dependency "rubocop-github", "~> 0.13.0"
+
+  spec.post_install_message = "WARNING: actionview-component has been renamed to view_component, and will no longer be published in this namespace. Please update your Gemfile to use view_component."
 end

data/lib/rails/generators/component/component_generator.rb

@@ -8,8 +8,6 @@ module Rails
       argument :attributes, type: :array, default: [], banner: "attribute"
       check_class_collision suffix: "Component"
 
-      class_option :require_content, type: :boolean, default: false
-
       def create_component_file
         template "component.rb", File.join("app/components", class_path, "#{file_name}_component.rb")
       end
@@ -17,7 +15,7 @@ module Rails
       hook_for :test_framework
 
       hook_for :template_engine do |instance, template_engine|
-        instance.invoke template_engine, [instance.name], require_content: instance.send(:requires_content?)
+        instance.invoke template_engine, [instance.name]
       end
 
       private
@@ -26,14 +24,6 @@ module Rails
         @_file_name ||= super.sub(/_component\z/i, "")
       end
 
-      def requires_content?
-        return if behavior == :revoke
-        return @requires_content if @asked
-
-        @asked = true
-        @requires_content = ask("Would you like #{class_name} to require content? (Y/n)").downcase == "y"
-      end
-
       def parent_class
         defined?(ApplicationComponent) ? "ApplicationComponent" : "ViewComponent::Base"
       end

data/lib/rails/generators/component/templates/component.rb.tt

@@ -1,8 +1,4 @@
 class <%= class_name %>Component < <%= parent_class %>
-  <%- if requires_content? -%>
-  validates :content, presence: true
-  <%- end -%>
-
   def initialize(<%= initialize_signature %>)
     <%= initialize_body %>
   end

data/lib/rails/generators/erb/component_generator.rb

@@ -7,18 +7,12 @@ module Erb
     class ComponentGenerator < Base
       source_root File.expand_path("templates", __dir__)
 
-      class_option :require_content, type: :boolean, default: false
-
       def copy_view_file
         template "component.html.erb", File.join("app/components", class_path, "#{file_name}_component.html.erb")
       end
 
       private
 
-      def requires_content?
-        options["require_content"]
-      end
-
       def file_name
         @_file_name ||= super.sub(/_component\z/i, "")
       end

data/lib/rails/generators/erb/templates/component.html.erb.tt

@@ -1,5 +1 @@
-<%- if requires_content? -%>
-<%= "<%= content %%>" %>
-<%- else -%>
 <div>Add <%= class_name %> template here</div>
-<%- end -%>

data/lib/rails/generators/haml/component_generator.rb

@@ -7,18 +7,12 @@ module Haml
     class ComponentGenerator < Erb::Generators::ComponentGenerator
       source_root File.expand_path("templates", __dir__)
 
-      class_option :require_content, type: :boolean, default: false
-
       def copy_view_file
         template "component.html.haml", File.join("app/components", class_path, "#{file_name}_component.html.haml")
       end
 
       private
 
-      def requires_content?
-        options["require_content"]
-      end
-
       def file_name
         @_file_name ||= super.sub(/_component\z/i, "")
       end

data/lib/rails/generators/haml/templates/component.html.haml.tt

@@ -1,5 +1 @@
-<%- if requires_content? -%>
-<%= "= content" %>
-<%- else -%>
 %div Add <%= class_name %> template here
-<%- end -%>

data/lib/rails/generators/slim/component_generator.rb

@@ -7,18 +7,12 @@ module Slim
     class ComponentGenerator < Erb::Generators::ComponentGenerator
       source_root File.expand_path("templates", __dir__)
 
-      class_option :require_content, type: :boolean, default: false
-
       def copy_view_file
         template "component.html.slim", File.join("app/components", class_path, "#{file_name}_component.html.slim")
       end
 
       private
 
-      def requires_content?
-        options["require_content"]
-      end
-
       def file_name
         @_file_name ||= super.sub(/_component\z/i, "")
       end

data/lib/rails/generators/slim/templates/component.html.slim.tt

@@ -0,0 +1 @@
+div Add <%= class_name %> template here

data/lib/rails/generators/test_unit/templates/component_test.rb.tt

@@ -3,8 +3,8 @@ require "test_helper"
 class <%= class_name %>ComponentTest < ViewComponent::TestCase
   test "component renders something useful" do
     # assert_equal(
-    #   %(<span title="my title">Hello, components!</span>),
-    #   render_inline(<%= class_name %>Component.new(attr: "value")) { "Hello, components!" }.css("span").to_html
+    #   %(<span>Hello, components!</span>),
+    #   render_inline(<%= class_name %>Component.new(message: "Hello, components!")).css("span").to_html
     # )
   end
 end

data/lib/view_component/version.rb

@@ -3,7 +3,7 @@
 module ViewComponent
   module VERSION
     MAJOR = 1
-    MINOR = 16
+    MINOR = 17
     PATCH = 0
 
     STRING = [MAJOR, MINOR, PATCH].join(".")

metadata

@@ -1,41 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: actionview-component
 version: !ruby/object:Gem::Version
-  version: 1.16.0
+  version: 1.17.0
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-20 00:00:00.000000000 Z
+date: 2020-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.14'
 - !ruby/object:Gem::Dependency
@@ -136,7 +136,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.13.0
-description: View components for Rails
+description: 
 email:
 - opensource+view_component@github.com
 executables: []
@@ -175,7 +175,7 @@ files:
 - lib/rails/generators/rspec/component_generator.rb
 - lib/rails/generators/rspec/templates/component_spec.rb.tt
 - lib/rails/generators/slim/component_generator.rb
-- lib/rails/generators/slim/templates/component.html.slim
+- lib/rails/generators/slim/templates/component.html.slim.tt
 - lib/rails/generators/test_unit/component_generator.rb
 - lib/rails/generators/test_unit/templates/component_test.rb.tt
 - lib/railties/lib/rails.rb
@@ -204,7 +204,9 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message: 'WARNING: actionview-component has been renamed to view_component,
+  and will no longer be published in this namespace. Please update your Gemfile to
+  use view_component.'
 rdoc_options: []
 require_paths:
 - lib
@@ -219,8 +221,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: View components for Rails
+summary: MOVED to view_component.
 test_files: []

data/lib/rails/generators/slim/templates/component.html.slim

@@ -1,5 +0,0 @@
-<%- if requires_content? -%>
-= content
-<%- else -%>
-div Add <%= class_name %> template here
-<%- end -%>