actionmessage 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 541663cfd718619f12884cf71b9b1eab26a50934
-  data.tar.gz: 639cf6fdfd983a529865af6087c78f28031ce341
+  metadata.gz: 6a20899cfb228e2de0504bf9ecee99c606fdd2e7
+  data.tar.gz: fc4096a29713a90392fecf6a9c3f287f58ee4494
 SHA512:
-  metadata.gz: 7d86a171aa51ca87e459db55086f7c6f35c540cea33ee4924db098a781267fadee0060106eefb659691b8dcee32ba49bed02fe0eb666c4bce894b5da65615741
-  data.tar.gz: 15878051ae3735d4aed69548b7b806d2aaf8b9bb560d4ec245851e3e6fd9c0b8892f694d5e3e6fd61831f4e80e0246a34ffd4c72d849eb68582e662d32c98e12
+  metadata.gz: c56cb488263cc97197279f195278577fbc416d1df8b29b5b01b186ebcf24a50688d546bb6ec1c24379c6f0ba4326d98514f681e8d14af97c7366cf6f74fa73d3
+  data.tar.gz: 9c2d038de96a0386a1aa12f41d3115399674a9533242cc7b5248349b44e670c623f425a7987da381c473205ea6ee21c66c08719e412786f33f1c95b90cc9ee7b

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+actionmessage-*

data/README.md

@@ -1,23 +1,23 @@
 # ActionMessage
 
-This is a pet project – an ActionMailer heavily-inspired gem for working with SMS/Text messages.
+ActionMessage is heavily-inspired on ActionMailer.
+It's a gem for sending SMS/Text messages like we do for sending e-mails on ActionMailer.
 Pull requests are more than welcome!
 
+[![Gem Version](https://badge.fury.io/rb/actionmessage.svg)](https://badge.fury.io/rb/actionmessage)
+[![Build Status](https://travis-ci.org/dballona/actionmessage.svg?branch=master)](https://travis-ci.org/dballona/actionmessage)
+[![codecov](https://codecov.io/gh/dballona/actionmessage/branch/master/graph/badge.svg)](https://codecov.io/gh/dballona/actionmessage)
+[![Code Climate](https://codeclimate.com/github/dballona/actionmessage/badges/gpa.svg)](https://codeclimate.com/github/dballona/actionmessage)
+
 ## Usage
 
-Install it using bundler
+Install it using bundler:
 
-```sh
+```ruby
 # Gemfile
 gem 'actionmessage'
 ```
 
-or just require it:
-```sh
-gem install actionmessage
-require 'action_message'
-```
-
 If you're using Rails, place this on your environment file or application.rb
 ```ruby
 require 'action_message/railtie'
@@ -46,15 +46,13 @@ end
 
 Define your views under your view path, such as: app/views/merchant_message/send_welcome_sms.text.erb
 ```html
-Welcome, <%= @name %>!!!
+Welcome, <%= @name %>!
 ```
 
-TODO:
+Pending implementations:
 
-- Add tests to what we've got already;
 - Add background processing (deliver_later);
 - Log instrumentation with ActiveSupport;
 - Add generators;
-- Add delivery methods;
-- Add test helpers; 
-- Add more adapters;
+- Add test helpers for deliveries count, matching message.body, message.to, etc; 
+- Add more adapters such as Plivo;

data/actionmessage.gemspec

@@ -26,4 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.11'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'webmock', '~> 2.1.0'
+  spec.add_development_dependency 'codecov', '~> 0.1.5'
 end

data/lib/action_message/adapters.rb

@@ -3,7 +3,7 @@ require 'action_message/adapters/test'
 require 'action_message/adapters/twilio'
 
 module ActionMessage
-	module Adapters
+  module Adapters
     class << self
       def adapter_klass
         @@adapter_klass ||= adapter_params[:name].to_s.capitalize

data/lib/action_message/adapters/base.rb

@@ -5,7 +5,7 @@ module ActionMessage
         @params = params
       end
 
-      def send_message(body, params={})
+      def send_message(_body, _params={})
         raise ArgumentError, 'You should provide at least one phone for sending messages' if !senders.present?
         @from = pick_sender
       end

data/lib/action_message/adapters/test.rb

@@ -5,15 +5,9 @@ module ActionMessage
         super(params)
       end
 
-      def client
-        @client ||= OpenStruct.new
-      end
-
       def send_message(body, params={})
-        raise ArgumentError, 'you should include a receipient for sending messages' unless params[:to].present?
-
-        @to = params[:to]
-        puts "Sending message to #{@to}"
+        super(body, params)
+        puts "Sending message to #{params[:to]}"
       end
     end
   end

data/lib/action_message/adapters/twilio.rb

@@ -18,7 +18,6 @@ module ActionMessage
       end
 
       def send_message(body, params={})
-        raise ArgumentError, 'you should include a receipient for sending messages' unless params[:to].present?
         super(body, params)
 
         sms = {

data/lib/action_message/base.rb

@@ -19,32 +19,23 @@ module ActionMessage
         adapter: {
           name: :test,
           credentials: {}
-        },
-        mime_version: "1.0",
-        charset:      "UTF-8"
+        }
       }
 
       # Sets the defaults through app configuration:
-      #
-      #     config.action_message.default(from: "+11231231234")
+      # config.action_message.default(from: "+11231231234")
       #
       # Aliased by ::default_options=
+      #
       def default(value = nil)
         self.default_params = default_params.merge(value).freeze if value
         default_params
       end
       # Allows to set defaults through app configuration:
+      # config.action_message = { charset: 'ISO-8859-1' }
       #
-      #    config.action_mailer.default_options = { from: "no-reply@example.org" }
       alias :default_options= :default
 
-      def mailer_name
-        @mailer_name ||= anonymous? ? 'anonymous' : name.underscore
-      end
-      # Allows to set the name of current mailer.
-      attr_writer :mailer_name
-      alias :controller_path :mailer_name
-
       def base_paths
         %w(
           app/views 
@@ -57,11 +48,7 @@ module ActionMessage
 
       protected
         def method_missing(method_name, *args) # :nodoc:
-          if action_methods.include?(method_name.to_s)
-            MessageDelivery.new(self, method_name, *args)
-          else
-            super
-          end
+          MessageDelivery.new(self, method_name, *args) rescue super
         end
     end
 
@@ -69,19 +56,19 @@ module ActionMessage
     attr_accessor :template_name
 
     def initialize
-      super()
+      super
       @_message_was_called = false
       @_message = Message.new
     end
 
     def sms(params = {}, &block)
-      return message if @_message_was_called && params[:to].blank? && !block
+      raise ArgumentError, 'You need to provide at least a receipient' if params[:to].blank?
+      return message if @_message_was_called && !block
       
       @_message_was_called = true
 
-      lookup_context.view_paths = self.class.base_paths
+      lookup_context.view_paths = (lookup_context.view_paths.to_a + self.class.base_paths).uniq
 
-      message.headers = self.class.default_params.slice(:charset, :mime_version)
       message.to = params[:to]
       message.debug = params[:debug]
       message.body = render(template_name)

data/lib/action_message/message.rb

@@ -2,7 +2,7 @@ module ActionMessage
   include ActionMessage::Adapters
 
   class Message
-    attr_accessor :headers, :action, :args, :body, :to, :debug
+    attr_accessor :action, :args, :body, :to, :debug
     attr_reader :adapter
 
     def initialize
@@ -14,8 +14,10 @@ module ActionMessage
     end
 
     def deliver
-      puts "Sending message \"#{body}\" to number #{to}" # TODO: Switch to a decent logger
-      adapter.send_message(body, to: to) unless debug?
+      unless debug?
+        # add logger 'Sendimg message from "number" to "number"'
+        adapter.send_message(body, to: to)
+      end
     end
   end
 end

data/lib/action_message/message_delivery.rb

@@ -1,6 +1,6 @@
 module ActionMessage
   class MessageDelivery
-    attr_reader :message_class, :action, :args, :adapter
+    attr_reader :message_class, :action, :args
 
     def initialize(message_class, action, *args)
       @message_class, @action, @args = message_class, action, args

data/lib/action_message/railtie.rb

@@ -7,7 +7,6 @@ module ActionMessage
     config.eager_load_namespaces << ActionMessage
 
     initializer "action_message.set_configs" do |app|
-      paths   = app.config.paths
       options = app.config.action_message
 
       ActiveSupport.on_load(:action_message) do

data/lib/action_message/version.rb

@@ -1,3 +1,3 @@
 module ActionMessage
-  VERSION = "0.0.2".freeze
+  VERSION = "0.0.3".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionmessage
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Diego Ballona
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-17 00:00:00.000000000 Z
+date: 2016-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -94,6 +94,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.1.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.1.0
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.5
 description: ActionMailer heavily-inspired gem to handle SMS/Text Messages
 email:
 - root@dballona.com
@@ -109,8 +137,6 @@ files:
 - README.md
 - Rakefile
 - actionmessage.gemspec
-- app/messages/merchant_message.rb
-- app/views/merchant_message/send_welcome_sms.text.erb
 - bin/console
 - bin/setup
 - lib/action_message.rb

data/app/messages/merchant_message.rb

@@ -1,8 +0,0 @@
-require 'action_message'
-
-class MerchantMessage < ActionMessage::Base
-  def send_welcome_sms(name)
-    @name = name
-    sms(to: "+5531982726767")
-  end
-end

data/app/views/merchant_message/send_welcome_sms.text.erb

@@ -1 +0,0 @@
-Yeah <%= @name %>!!!