actionmailer 7.0.0.alpha2 → 7.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63ba2823b2efea70f03f1920e9ad798e69729db4a5430330a3caa79664dc037c
-  data.tar.gz: 830f868ad57326cece793dcd0507ff50da94e87fd93c179ee70c74bd57a5e649
+  metadata.gz: eeaac20ea2d91009e6fb6e0e9f080316fe884071adc62627b3a5469699288535
+  data.tar.gz: b9db25aa1577ee0611ea79b8b4a6c1336a1102c4a0d6fd11ff4fe8ec8f38ecf5
 SHA512:
-  metadata.gz: 260ce90dfc30dc03c68534ae1fd360abb61f66a8bfceb0c04d4546ec49a06af0f5fc70d4632007475a7f97fde2563f3a0f6ea6a78b33f6df5236bf74c31ac619
-  data.tar.gz: 3737e7223af639c4517c0bc1efb0d7a7fe6218efbd5773285e774e030602c0ce1154c5501772edb5913ff85d5e90bf83a65bb5cc1754e36370860a76f3d0bfe2
+  metadata.gz: 9b30795e1a90f4de721aa9c1b1dbdfba9d7faa2b61b0623260d29be422f4b35f3fb7e3b074c79c35cadf5f6c4a666767462751326f76229e2cd9af2d5e6fc1e5
+  data.tar.gz: 6769fe17016fe9a091648514721b17d77daeb928cf20ff37af6e0a406de6c783159ac4567b3a3e4e3970bf673986b1df9e2d50a8aeeb335b21c92c70a68ab7e5

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+*   Remove deprecated `ActionMailer::DeliveryJob` and `ActionMailer::Parameterized::DeliveryJob`
+    in favor of `ActionMailer::MailDeliveryJob`.
+
+    *Rafael Mendonça França*
+
+*   `email_address_with_name` returns just the address if name is blank.
+
+    *Thomas Hutterer*
+
+
 ## Rails 7.0.0.alpha2 (September 15, 2021) ##
 
 *   No changes.

data/lib/action_mailer/base.rb

@@ -435,6 +435,9 @@ module ActionMailer
   # * <tt>deliveries</tt> - Keeps an array of all the emails sent out through the Action Mailer with
   #   <tt>delivery_method :test</tt>. Most useful for unit and functional testing.
   #
+  # * <tt>delivery_job</tt> - The job class used with <tt>deliver_later</tt>. Defaults to
+  #   +ActionMailer::MailDeliveryJob+.
+  #
   # * <tt>deliver_later_queue_name</tt> - The name of the queue used with <tt>deliver_later</tt>.
   class Base < AbstractController::Base
     include DeliveryMethods
@@ -459,7 +462,7 @@ module ActionMailer
 
     helper ActionMailer::MailHelper
 
-    class_attribute :delivery_job, default: ::ActionMailer::DeliveryJob
+    class_attribute :delivery_job, default: ::ActionMailer::MailDeliveryJob
     class_attribute :default_params, default: {
       mime_version: "1.0",
       charset:      "UTF-8",
@@ -563,10 +566,12 @@ module ActionMailer
       end
 
       # Returns an email in the format "Name <email@example.com>".
+      #
+      # If the name is a blank string, it returns just the address.
       def email_address_with_name(address, name)
         Mail::Address.new.tap do |builder|
           builder.address = address
-          builder.display_name = name
+          builder.display_name = name.presence
         end.to_s
       end
 
@@ -638,6 +643,8 @@ module ActionMailer
     end
 
     # Returns an email in the format "Name <email@example.com>".
+    #
+    # If the name is a blank string, it returns just the address.
     def email_address_with_name(address, name)
       self.class.email_address_with_name(address, name)
     end

data/lib/action_mailer/gem_version.rb

@@ -10,7 +10,7 @@ module ActionMailer
     MAJOR = 7
     MINOR = 0
     TINY  = 0
-    PRE   = "alpha2"
+    PRE   = "rc1"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/action_mailer/message_delivery.rb

@@ -62,7 +62,7 @@ module ActionMailer
     # * <tt>:queue</tt> - Enqueue the email on the specified queue
     # * <tt>:priority</tt> - Enqueues the email with the specified priority
     #
-    # By default, the email will be enqueued using <tt>ActionMailer::DeliveryJob</tt>. Each
+    # By default, the email will be enqueued using <tt>ActionMailer::MailDeliveryJob</tt>. Each
     # <tt>ActionMailer::Base</tt> class can specify the job to use by setting the class variable
     # +delivery_job+.
     #
@@ -88,7 +88,7 @@ module ActionMailer
     # * <tt>:queue</tt> - Enqueue the email on the specified queue.
     # * <tt>:priority</tt> - Enqueues the email with the specified priority
     #
-    # By default, the email will be enqueued using <tt>ActionMailer::DeliveryJob</tt>. Each
+    # By default, the email will be enqueued using <tt>ActionMailer::MailDeliveryJob</tt>. Each
     # <tt>ActionMailer::Base</tt> class can specify the job to use by setting the class variable
     # +delivery_job+.
     #
@@ -140,38 +140,8 @@ module ActionMailer
             "#deliver_later, 2. only touch the message *within your mailer " \
             "method*, or 3. use a custom Active Job instead of #deliver_later."
         else
-          job = @mailer_class.delivery_job
-
-          if use_new_args?(job)
-            job.set(options).perform_later(
-              @mailer_class.name, @action.to_s, delivery_method.to_s, args: @args)
-          elsif job <= DeliveryJob
-            job.set(options).perform_later(
-              @mailer_class.name, @action.to_s, delivery_method.to_s, *@args)
-          else
-            ActiveSupport::Deprecation.warn(<<~EOM)
-              In Rails 7.0, Action Mailer will pass the mail arguments inside the `:args` keyword argument.
-              The `perform` method of the #{job} needs to change and forward the mail arguments
-              from the `args` keyword argument.
-
-              The `perform` method should now look like:
-
-              `def perform(mailer, mail_method, delivery, args:)`
-            EOM
-
-            job.set(options).perform_later(
-              @mailer_class.name, @action.to_s, delivery_method.to_s, *@args)
-          end
-        end
-      end
-
-      def use_new_args?(job)
-        parameters = job.public_instance_method(:perform).parameters
-
-        parameters.find do |key, name|
-          return true if key == :keyreq && name == :args
-
-          key == :keyrest
+          @mailer_class.delivery_job.set(options).perform_later(
+            @mailer_class.name, @action.to_s, delivery_method.to_s, args: @args)
         end
       end
   end

data/lib/action_mailer/parameterized.rb

@@ -122,13 +122,6 @@ module ActionMailer
         end
     end
 
-    class DeliveryJob < ActionMailer::DeliveryJob # :nodoc:
-      def perform(mailer, mail_method, delivery_method, params, *args)
-        mailer.constantize.with(params).public_send(mail_method, *args).send(delivery_method)
-      end
-      ruby2_keywords(:perform)
-    end
-
     class MessageDelivery < ActionMailer::MessageDelivery # :nodoc:
       def initialize(mailer_class, action, params, *args)
         super(mailer_class, action, *args)
@@ -148,23 +141,8 @@ module ActionMailer
           if processed?
             super
           else
-            job = delivery_job_class
-
-            if job <= MailDeliveryJob
-              job.set(options).perform_later(
-                @mailer_class.name, @action.to_s, delivery_method.to_s, params: @params, args: @args)
-            else
-              job.set(options).perform_later(
-                @mailer_class.name, @action.to_s, delivery_method.to_s, @params, *@args)
-            end
-          end
-        end
-
-        def delivery_job_class
-          if @mailer_class.delivery_job <= MailDeliveryJob
-            @mailer_class.delivery_job
-          else
-            Parameterized::DeliveryJob
+            @mailer_class.delivery_job.set(options).perform_later(
+              @mailer_class.name, @action.to_s, delivery_method.to_s, params: @params, args: @args)
           end
         end
     end

data/lib/action_mailer/test_helper.rb

@@ -155,8 +155,7 @@ module ActionMailer
       def delivery_job_filter(job)
         job_class = job.is_a?(Hash) ? job.fetch(:job) : job.class
 
-        Base.descendants.map(&:delivery_job).include?(job_class) ||
-          ActionMailer::Parameterized::DeliveryJob == job_class
+        Base.descendants.map(&:delivery_job).include?(job_class)
       end
   end
 end

data/lib/action_mailer.rb

@@ -51,7 +51,6 @@ module ActionMailer
   autoload :TestCase
   autoload :TestHelper
   autoload :MessageDelivery
-  autoload :DeliveryJob
   autoload :MailDeliveryJob
 
   def self.eager_load!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionmailer
 version: !ruby/object:Gem::Version
-  version: 7.0.0.alpha2
+  version: 7.0.0.rc1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-15 00:00:00.000000000 Z
+date: 2021-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.0.0.alpha2
+        version: 7.0.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.0.0.alpha2
+        version: 7.0.0.rc1
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.0.0.alpha2
+        version: 7.0.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.0.0.alpha2
+        version: 7.0.0.rc1
 - !ruby/object:Gem::Dependency
   name: actionview
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.0.0.alpha2
+        version: 7.0.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.0.0.alpha2
+        version: 7.0.0.rc1
 - !ruby/object:Gem::Dependency
   name: activejob
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.0.0.alpha2
+        version: 7.0.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.0.0.alpha2
+        version: 7.0.0.rc1
 - !ruby/object:Gem::Dependency
   name: mail
   requirement: !ruby/object:Gem::Requirement
@@ -113,7 +113,6 @@ files:
 - lib/action_mailer.rb
 - lib/action_mailer/base.rb
 - lib/action_mailer/collector.rb
-- lib/action_mailer/delivery_job.rb
 - lib/action_mailer/delivery_methods.rb
 - lib/action_mailer/gem_version.rb
 - lib/action_mailer/inline_preview_interceptor.rb
@@ -137,10 +136,11 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v7.0.0.alpha2/actionmailer/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v7.0.0.alpha2/
+  changelog_uri: https://github.com/rails/rails/blob/v7.0.0.rc1/actionmailer/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v7.0.0.rc1/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v7.0.0.alpha2/actionmailer
+  source_code_uri: https://github.com/rails/rails/tree/v7.0.0.rc1/actionmailer
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -157,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements:
 - none
-rubygems_version: 3.1.6
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Email composition and delivery framework (part of Rails).

data/lib/action_mailer/delivery_job.rb

@@ -1,45 +0,0 @@
-# frozen_string_literal: true
-
-require "active_job"
-
-module ActionMailer
-  # The <tt>ActionMailer::DeliveryJob</tt> class is used when you
-  # want to send emails outside of the request-response cycle.
-  #
-  # Exceptions are rescued and handled by the mailer class.
-  class DeliveryJob < ActiveJob::Base # :nodoc:
-    queue_as { ActionMailer::Base.deliver_later_queue_name }
-
-    rescue_from StandardError, with: :handle_exception_with_mailer_class
-
-    before_perform do
-      ActiveSupport::Deprecation.warn <<~MSG.squish
-        Sending mail with DeliveryJob and Parameterized::DeliveryJob
-        is deprecated and will be removed in Rails 7.0.
-        Please use MailDeliveryJob instead.
-      MSG
-    end
-
-    def perform(mailer, mail_method, delivery_method, *args) # :nodoc:
-      mailer.constantize.public_send(mail_method, *args).send(delivery_method)
-    end
-    ruby2_keywords(:perform)
-
-    private
-      # "Deserialize" the mailer class name by hand in case another argument
-      # (like a Global ID reference) raised DeserializationError.
-      def mailer_class
-        if mailer = Array(@serialized_arguments).first || Array(arguments).first
-          mailer.constantize
-        end
-      end
-
-      def handle_exception_with_mailer_class(exception)
-        if klass = mailer_class
-          klass.handle_exception exception
-        else
-          raise exception
-        end
-      end
-  end
-end