actionmailer-instyle 0.0.1 → 0.5.0

data/Guardfile

@@ -1,7 +1,7 @@
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
-guard 'rspec', :version => 2 do
+guard 'rspec', version: 2 do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }

data/README.md

@@ -1,46 +1,137 @@
 # ActionMailer::InStyle
 
-![TestPilot Build Status](http://testpilot.me/testpilot/actionmailer-instyle.png)
+[![TestPilot Build Status](http://testpilot.me/testpilot/actionmailer-instyle.png)](http://testpilot.me/testpilot/actionmailer-instyle)
 
-HTML Email is hard, especially when you find yourself wrestling with inline CSS to make it look good, luckily for you we're here to make it easy, ActionMailer::InStyle
-lets you write standard CSS, using Sass or the likes within the Rails 3.1 Asset Pipeline and automatically converts it to inline CSS using Premailer.
+HTML Emails can be a PITN, especially when you want maximum email client compatibility, of which the best way to achieve this is inline CSS. Unfortunately nobody actually wants to be forced into writing crap like that so we've created **InStyle**, it will automatically intercept your emails and look for a `stylesheet` linking to something inside your assets folder, extract all the styles, and convert them to inline styles on the fly.
 
-## Requirements
+_There are a couple of other projects which do this, some have not been updated for a while and none of them work with the Rails 3.1 asset pipeline._ *InStyle* uses Sprockets to render CSS which means you can use Sass, Compass, and any other CSS hackery you desire, including using stylesheets you would usually only use within your views e.g If you want to email an activity digest and make it look the same as what the user is used to seeing within your application (think Yammer).
 
-This gem is built specifically to take advantage of the Rails 3.1 Asset Pipeline, as such you must be using Rails ~>3.1
+## Requirements
 
+This gem is built specifically to take advantage of the Rails 3.1 Asset Pipeline, as such you must be using Rails ~>3.1 and have the Asset Pipeline enabled (default)
 _Additonally Ruby 1.8.7 is not supported due to favouring the Ruby 1.9 Hash syntax. If you want 1.8.7 support, issue a pull request._
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'actionmailer-instyle'
+```ruby
+gem 'actionmailer-instyle', :require => 'action_mailer/in_style'
+```
 
 And then execute:
 
-    $ bundle
+```bash
+$ bundle
+```
 
 ## Usage
 
-Once installed it will add the required hooks out of the box.
+Once installed it will add the required hooks out of the box to intercept each email being sent.
 
-*Stylesheets*
+**Stylesheets**
 
 As with all your other stylesheets, put them in `app/assets/stylesheets` and include them into your mailer
-template using `stylesheet_include_tag "account_mailer"`, where `account_mailer` is the filename less the extension of the stylesheet you want to
-include.
+template using `stylesheet_link_tag "account_mailer"`, where `account_mailer` is the filename less the extension of the stylesheet you want to use.
 
 Everything runs through the Asset Pipeline so you can use Sass simply by adding the `.scss` extension as you would with all other stylesheets.
 
-*Compass*
+**Compass**
 
-Because Sass works out of the box, you can also include compass for browser specific mixins, keeping in mind that some email client (Outlook for example)
-use very crappy rendering engines and some CSS properties may have undesired effects or not work at all.
+Because Sass works out of the box, you can also include Compass for browser specific mixins and useful CSS3 helpers, keeping in mind that some email clients (Outlook for example) use very dated rendering engines and a lot of CSS properties may have undesired effects or not work at all.
 
 For a complete rundown on what is supported, checkout this guide which CampaignMonitor has compiled.
 
-(CampaignMonitor's guide to CSS support in email)[http://www.campaignmonitor.com/css/]
+[CampaignMonitor's guide to CSS support in email](http://www.campaignmonitor.com/css/)
+
+## Tutorial
+
+**1. Generate a Mailer:**
+
+    rails g mailer account_mailer account_created_email
+
+**2. Create a template to be used for emails this Mailer sends:**
+
+In `app/views/layouts/account_mailer.html.haml`
+
+```haml
+%html
+  %head
+    = stylesheet_link_tag "account_mailer"
+
+  %body
+    %table.main
+      %tr
+        %td= yield
+```
+
+You will notice that we have added a stylesheet link in the `head`, this location is not crucial, but the use of `stylesheet_link_tag` is because it will generate a link which we can process and feed through Sprockets in order to generate the inline styles.
+
+**3. The stylesheet.**
+
+You can use any style off CSS you like, we're using Sass.
+
+`app/assets/stylesheets/account_mailer.css.scss`:
+
+```css
+body {
+  font-family: 'Helvetica Neue', Helvetica, sans-serif;
+  -webkit-font-smoothing: antialiased;
+  width: 100%;
+  background: darken(white, 8%);
+}
+
+table {
+  background: white;
+  &.main {
+    width: 430px;
+    tr td {
+      padding: 5px;
+    }
+  }
+}
+```
+
+**4. Email views.**
+
+In order to take advantage of all this fancy work, you must define a html view for your email, and optionally a text version. By default we will automatically generate a text version from the text content of the html view if none is supplied.
+
+`app/views/account_mailer/account_created_email.html.haml`:
+
+```haml
+%p Hi #{@user.first_name},
+%p Your account has been successfully created, so don't waste any time, #{link_to "Get started now", get_started_url}
+```
+
+**5. Send**
+
+```ruby
+AccountMailer.account_created_email(@user).deliver
+```
+
+**6. Send awesome emails.**
+
+The resulting email will look something like this:
+
+```html
+<html>
+<head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head>
+<body style="font-family: 'Helvetica Neue', Helvetica, sans-serif; -webkit-font-smoothing: antialiased; width: 100%; background-color: #ebebeb;" bgcolor="#ebebeb">
+  <table style="width: 430px; background-color: white;" bgcolor="white">
+    <tr>
+      <td style="padding: 5px;">
+        <p>Hi Michael,</p>
+        <p>Your account has been successfully created, so don't waste any time, <a href="/started">Get started now</a></p>
+      </td>
+    </tr>
+  </table>
+</body>
+</html>
+```
+
+**7. Grab a beer.**
+
+As above.
 
 ## Contributing
 
@@ -49,3 +140,9 @@ For a complete rundown on what is supported, checkout this guide which CampaignM
 3. Commit your changes (`git commit -am 'Added some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+## Meta
+
+| Author | Twitter |
+|------:|:------------|
+| Ivan Vanderbyl | [@IvanVanderbyl](http://twitter.com/ivanvanderbyl) |

data/Rakefile

@@ -4,5 +4,4 @@ require "bundler/gem_tasks"
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
-
+task default: :spec

data/lib/action_mailer/in_style/processor.rb

@@ -17,7 +17,7 @@ module ActionMailer
         @message = message
 
         @existing_html_part = message.html_part || (message.content_type =~ /text\/html/ && message)
-        @premailer = ActionMailer::InStyle::Premailer.new(html_part.body.to_s, :with_html_string => true, :remove_classes => true)
+        @premailer = ActionMailer::InStyle::Premailer.new(html_part.body.to_s, with_html_string: true, remove_classes: true)
       end
 
       def html_part
@@ -35,8 +35,8 @@ module ActionMailer
         capture_existing_message_parts
         reset_message_body!
 
-        add_html_part!
         add_text_part!
+        add_html_part!
         add_attachments!
 
         message
@@ -47,8 +47,7 @@ module ActionMailer
         part = Mail::Part.new
         part.body = premailer.to_inline_css
         part.content_type = "text/html; charset=#{@msg_charset}"
-
-        message.add_part(part)
+        message.html_part = part
       end
 
       # Add a text part with either the pre-existing text part, or one generated with premailer.
@@ -56,7 +55,7 @@ module ActionMailer
         part = Mail::Part.new
         part.body = @existing_text_part || premailer.to_plain_text
         part.content_type = "text/plain; charset=#{@msg_charset}"
-        message.add_part(part)
+        message.text_part = part
       end
 
       # Re-add any attachments

data/lib/action_mailer/in_style/version.rb

@@ -1,5 +1,5 @@
 module ActionMailer
   module InStyle
-    VERSION = "0.0.1"
+    VERSION = "0.5.0"
   end
 end

data/lib/action_mailer/instyle.rb

@@ -0,0 +1 @@
+require "action_mailer/in_style"

data/lib/actionmailer-instyle.rb

@@ -0,0 +1,3 @@
+require "action_mailer/in_style"
+
+# This file serves only one purpose: TO allow bunder to automatically include this gem

data/spec/internal/app/mailers/notification_mailer.rb

@@ -4,15 +4,15 @@ class NotificationMailer < ActionMailer::Base
   default from: "Johnny Quids<quidlicker@example.com>"
 
   def welcome_email
-    mail(to: "archie@example.com", :subject => "We need dry ice")
+    mail(to: "archie@example.com", subject: "We need dry ice")
   end
 
   def email_with_html_only
-    mail(to: "archie@example.com", :subject => "We need dry ice")
+    mail(to: "archie@example.com", subject: "We need dry ice")
   end
 
   def welcome_html_email
-    mail(to: "archie@example.com", :subject => "We need dry ice")
+    mail(to: "archie@example.com", subject: "We need dry ice")
   end
 
 end

data/spec/internal/app/mailers/notification_mailer_no_layout.rb

@@ -4,7 +4,7 @@ class NotificationMailerNoStyle < ActionMailer::Base
   default from: "Johnny Quids<quidlicker@example.com>"
 
   def email_with_no_style
-    mail(to: "archie@example.com", :subject => "We need dry ice")
+    mail(to: "archie@example.com", subject: "We need dry ice")
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: actionmailer-instyle
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-27 00:00:00.000000000 Z
+date: 2012-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: premailer
-  requirement: &70322805055240 !ruby/object:Gem::Requirement
+  requirement: &70161609476920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '1.7'
   type: :runtime
   prerelease: false
-  version_requirements: *70322805055240
+  version_requirements: *70161609476920
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &70322805054720 !ruby/object:Gem::Requirement
+  requirement: &70161609476400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '3.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70322805054720
+  version_requirements: *70161609476400
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &70322805054260 !ruby/object:Gem::Requirement
+  requirement: &70161609475940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 2.8.0
   type: :development
   prerelease: false
-  version_requirements: *70322805054260
+  version_requirements: *70161609475940
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &70322805053880 !ruby/object:Gem::Requirement
+  requirement: &70161609475560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70322805053880
+  version_requirements: *70161609475560
 - !ruby/object:Gem::Dependency
   name: sass
-  requirement: &70322805053340 !ruby/object:Gem::Requirement
+  requirement: &70161609475020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '3.1'
   type: :development
   prerelease: false
-  version_requirements: *70322805053340
+  version_requirements: *70161609475020
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70322805052840 !ruby/object:Gem::Requirement
+  requirement: &70161609474520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -76,10 +76,10 @@ dependencies:
         version: 1.3.5
   type: :development
   prerelease: false
-  version_requirements: *70322805052840
+  version_requirements: *70161609474520
 - !ruby/object:Gem::Dependency
   name: mail
-  requirement: &70322805052460 !ruby/object:Gem::Requirement
+  requirement: &70161609474140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70322805052460
+  version_requirements: *70161609474140
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70322805052000 !ruby/object:Gem::Requirement
+  requirement: &70161609473680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +98,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70322805052000
+  version_requirements: *70161609473680
 - !ruby/object:Gem::Dependency
   name: combustion
-  requirement: &70322938609240 !ruby/object:Gem::Requirement
+  requirement: &70161605530780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,7 +109,7 @@ dependencies:
         version: 0.3.1
   type: :development
   prerelease: false
-  version_requirements: *70322938609240
+  version_requirements: *70161605530780
 description: Easily create HTML emails in Rails ~>3.1
 email:
 - ivanvanderbyl@me.com
@@ -130,6 +130,8 @@ files:
 - lib/action_mailer/in_style/premailer.rb
 - lib/action_mailer/in_style/processor.rb
 - lib/action_mailer/in_style/version.rb
+- lib/action_mailer/instyle.rb
+- lib/actionmailer-instyle.rb
 - spec/internal/app/assets/stylesheets/notification_mailer.css.scss
 - spec/internal/app/mailers/notification_mailer.rb
 - spec/internal/app/mailers/notification_mailer_no_layout.rb