actionfacade 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cbeefd227bc757cf74621b1d5526369fabc3a2fdb531f6b63f43e4c76f5a287f
-  data.tar.gz: 8b0bf77381017a78f1dbe3f160662b055b82a9cf330e66509b6e51fbabf82fbd
+  metadata.gz: 64d3cea1d22a692b72218f19db02d5d39de09d53a3a5fc98da0803d9bbd217bb
+  data.tar.gz: 94ce319ac7540e225e535e89aef50e636359a00c02d1c8bc9ad21cb799767bd2
 SHA512:
-  metadata.gz: eddd017a737576e62ef72c738ec994336dae0f751ec340919dfbf2fe39222acd06643e2e96b84c14b3e4e1247adf58ee9402bbc79da95468e9ebc3645ba11fa5
-  data.tar.gz: 9c97a487c85b5cc65ac17cecc56c6848712f22e9b13cdb0e88c44a78cc98e56b4b4bd1fa45df286cd7124a9fd7ab811801821297a73bb217dbe8105982697c11
+  metadata.gz: 6ad6c5032c237f64311a7efd20e8fa26e3ae612a7ccc9e1e258aa8d325c8aa20825de3b1e42dc346ecd10b1c9b3d39ed89a6785e18e031806d9b12d051b37701
+  data.tar.gz: d141b6a9fccad09c49dc57eb6d20835be189c3064edfc016f75e1a851a37890ac13f90c14297933d685454b6ce1200d788383573ba888f879ff1ca8aa7c32366

data/actionfacade.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |s|
   s.test_files  = s.files.grep(/^test/)
 
   s.add_dependency "bundler", ">= 1.3"
+  s.add_dependency "activesupport", ">= 5.2"
   s.add_development_dependency "rake", ">= 12.3.3"
   s.add_development_dependency "test-unit", ">= 3.3"
 end

data/lib/action_facade/retrieval.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "active_support/core_ext/string/inflections"
+
 module ActionFacade
   # == Action \Facade \Retrieval
   #
@@ -19,5 +21,50 @@ module ActionFacade
         instance_variable_set("@#{name}", facade.send(name.to_sym))
       end
     end
+
+    # Retrieve data from given payload
+    #
+    # If the class which includes the module is Rails controller,
+    # guessed facade name will be "Controller" is replaced by the action name + "Facade".
+    # If the class is not Rails controller, the name will be suffixed by "Facade".
+    #
+    # `payload` is the initialization parameter for the facade.
+    #
+    # `variable_names` are symbols for the method names in the facade and
+    # they will be set as instance variables in the class that
+    # includes the module.
+    def retrieve_from(payload, *variable_names)
+      facade = guess_facade
+      if facade.nil?
+        raise FacadeNotFoundError.new("Could not find Facade class #{guess_facade_name}.")
+      end
+      retrieve(facade.new(payload), *variable_names)
+    end
+
+    class FacadeNotFoundError < StandardError; end
+
+    private
+
+    def guess_facade
+      facade_name = guess_facade_name
+      begin
+        facade_name.constantize
+      rescue NameError
+        nil
+      end
+    end
+
+    def guess_facade_name
+      klass_name = self.class.name
+      if klass_name.end_with?("Controller")
+        if defined?(params) && params[:action]
+          klass_name.delete_suffix("Controller") + "::#{params[:action].camelize}Facade"
+        else
+          klass_name.delete_suffix("Controller") + "Facade"
+        end
+      else
+        klass_name + "Facade"
+      end
+    end
   end
 end

data/test/retrieval_test.rb

@@ -2,14 +2,22 @@ require "test/unit"
 require_relative "../lib/action_facade/base.rb"
 require_relative "../lib/action_facade/retrieval.rb"
 
-USER_DATA = [{ id: 1, name: "john" }]
+USER_DATA = [{ id: 1, name: "john" }, { id: 2, name: "bob" }]
 
-class UserFacade < ActionFacade::Base
+class UsersFacade < ActionFacade::Base
   def john
     USER_DATA.find { |user| user[:name] == "john" }
   end
 end
 
+module Admin
+  class ShowFacade < ActionFacade::Base
+    def bob
+      USER_DATA.find { |user| user[:name] == "bob" }
+    end
+  end
+end
+
 class UsersController
   include ActionFacade::Retrieval
 
@@ -17,9 +25,31 @@ class UsersController
 
   def show
     payload = {}
-    facade = UserFacade.new(payload)
+    facade = UsersFacade.new(payload)
     retrieve(facade, :john)
   end
+
+  def show_from
+    payload = {}
+    retrieve_from(payload, :john)
+  end
+end
+
+class AdminController
+  include ActionFacade::Retrieval
+
+  attr_reader :bob
+
+  def show
+    payload = {}
+    retrieve_from(payload, :bob)
+  end
+
+  private
+
+  def params
+    { action: 'show' }
+  end
 end
 
 class RetrievalTest < Test::Unit::TestCase
@@ -33,4 +63,18 @@ class RetrievalTest < Test::Unit::TestCase
     controller.show
     assert_equal(controller.john, { id: 1, name: "john" })
   end
+
+  test "@john is set after retrieve_from(payload, :john)" do
+    controller = UsersController.new
+    assert_nil(controller.john)
+    controller.show_from
+    assert_equal(controller.john, { id: 1, name: "john" })
+  end
+
+  test "@bob is set after retrieve_from(payload, :bob)" do
+    controller = AdminController.new
+    assert_nil(controller.bob)
+    controller.show
+    assert_equal(controller.bob, { id: 2, name: "bob" })
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionfacade
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Ryo Hashimoto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-06 00:00:00.000000000 Z
+date: 2020-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement