actioncable 5.1.0.rc1 → 5.1.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ddd3032fd66feb385f3c135ce9677fa26b7d5e60
-  data.tar.gz: 8269dca8cc74d32cc8a7082679bd280520f30c9d
+  metadata.gz: c59f2d253dfbe338426dd07b120a101ca9cc16c5
+  data.tar.gz: 322b955c668f9e187fba5d514fac8ed5ab15cbc0
 SHA512:
-  metadata.gz: afecb562901648e694975993307395f898fa10f52ec97a3158e0545b488095c58b0b4833e5b42cea311724da4dccd8f5a5c783ee2e11abef990ba308285c87f6
-  data.tar.gz: 683a014d35abd0a8e027ae7a97f8130df0e1a021a3c8b2c88a2fbf2256661381c096b0c6406335c2128dace4c3ee6cf83fb054574f06f021d13ba95874a0d307
+  metadata.gz: 3d9688391ce75b1a17b285345cd146bd492cd4a4ac71590f528c3111c84e8ae217a6d366addf870c079d60e07936c3803d341ea8374ff6dd8e574e650ba85b24
+  data.tar.gz: fcc766ab9e9ad91b8d7f38b6cd2037a07d48737b0a3b6846d3d1a0e4895dc738a9a5120ed32ad3e2c0626f23d70b6a4ab197f05c9196c367e4cef125ab6d22f4

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## Rails 5.1.0.rc2 (April 20, 2017) ##
+
+*   ActionCable socket errors are now logged to the console
+
+    Previously any socket errors were ignored and this made it hard to diagnose socket issues (e.g. as discussed in #28362).
+
+    *Edward Poot*
+
+
 ## Rails 5.1.0.rc1 (March 20, 2017) ##
 
 *   No changes.

data/README.md

@@ -53,8 +53,8 @@ module ApplicationCable
 
     private
       def find_verified_user
-        if current_user = User.find_by(id: cookies.signed[:user_id])
-          current_user
+        if verified_user = User.find_by(id: cookies.signed[:user_id])
+          verified_user
         else
           reject_unauthorized_connection
         end

data/lib/action_cable/connection/authorization.rb

@@ -3,11 +3,11 @@ module ActionCable
     module Authorization
       class UnauthorizedError < StandardError; end
 
-      private
-        def reject_unauthorized_connection
-          logger.error "An unauthorized connection attempt was rejected"
-          raise UnauthorizedError
-        end
+      # Closes the \WebSocket connection if it is open and returns a 404 "File not Found" response.
+      def reject_unauthorized_connection
+        logger.error "An unauthorized connection attempt was rejected"
+        raise UnauthorizedError
+      end
     end
   end
 end

data/lib/action_cable/connection/base.rb

@@ -126,7 +126,8 @@ module ActionCable
       end
 
       def on_error(message) # :nodoc:
-        # ignore
+        # log errors to make diagnosing socket errors easier
+        logger.error "WebSocket error occurred: #{message}"
       end
 
       def on_close(reason, code) # :nodoc:

data/lib/action_cable/gem_version.rb

@@ -8,7 +8,7 @@ module ActionCable
     MAJOR = 5
     MINOR = 1
     TINY  = 0
-    PRE   = "rc1"
+    PRE   = "rc2"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: actioncable
 version: !ruby/object:Gem::Version
-  version: 5.1.0.rc1
+  version: 5.1.0.rc2
 platform: ruby
 authors:
 - Pratik Naik
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-20 00:00:00.000000000 Z
+date: 2017-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.1.0.rc1
+        version: 5.1.0.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.1.0.rc1
+        version: 5.1.0.rc2
 - !ruby/object:Gem::Dependency
   name: nio4r
   requirement: !ruby/object:Gem::Requirement