action_policy 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 782d6e62c1723d8aa9b128cf054d90ace4a52a65467db205a079f898a9e068a8
-  data.tar.gz: e581bec4f5a7aaa782229f85aa34d09d7ed27eb19c870dcc9d3982c3271205d8
+  metadata.gz: 272123a33fae55ffd9e6e09b1098862fbbf353a6ed5ff71d090bc5fd01396244
+  data.tar.gz: ec53e2634999660b46c95dddc85bcf71055e336fdae5a8ea47023a671bba55ce
 SHA512:
-  metadata.gz: 8178fe440e7b7b8f1b60a858e503ad65e37eaa3157dca0f48b772a626704f66763392d60a2f18758d9e903d19e687f292c0b261f5c531d81693ee5e1df38472c
-  data.tar.gz: 8126f417658773d0deeca4d927881d8a9bf504853d89d58d1d43dd07d6f1328bc355b81bd9f12e7742ce753d20d6c17caf07a0ce2f4fd6df50e2fb0bb70ca034
+  metadata.gz: 62353ff2be45386257efcd127a43c7eac61d1cb7fc3cfcbf1acc6d6563e6d0a0a91873a0593b8ff62d51adc70b730e1799eb5a1565e3a1ed3c1f2593d46a05ff
+  data.tar.gz: 837e717de9323e7131c535a41fe848aaa9501ad8f10471f082ff1355ae824afa7691b44bb9c8db71cb0b33898ad126963f3518b8cfcc1207e34469a282648d62

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## master
 
+## 0.3.4 (2019-11-27)
+
+- Fix Rails generators. ([@palkan][])
+
+  Only invoke install generator if `application_policy.rb` is missing.
+  Fix hooking into test frameworks.
+
 ## 0.3.3 (2019-11-27)
 
 - Improve pretty print functionality. ([@palkan][])

data/lib/action_policy/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActionPolicy
-  VERSION = "0.3.3"
+  VERSION = "0.3.4"
 end

data/lib/generators/action_policy/install/USAGE

@@ -1,2 +1,2 @@
 Description:
-    Generates an application policy for your application.
+    Generates a base policy class (ApplicationPolicy) for your application.

data/lib/generators/action_policy/install/templates/application_policy.rb

@@ -1,2 +1,18 @@
+# Base class for application policies
 class ApplicationPolicy < ActionPolicy::Base
+  # Configure additional authorization contexts here
+  # (`user` is added by default).
+  #
+  #   authorize :account, optional: true
+  #
+  # Read more about authoriztion context: https://actionpolicy.evilmartians.io/#/authorization_context
+
+  private
+
+  # Define shared methods useful for most policies.
+  # For example:
+  #
+  #  def owner?
+  #    record.user_id == user.id
+  #  end
 end

data/lib/generators/action_policy/policy/policy_generator.rb

@@ -7,7 +7,10 @@ module ActionPolicy
     class PolicyGenerator < ::Rails::Generators::NamedBase
       source_root File.expand_path("templates", __dir__)
 
-      invoke "action_policy:install"
+      def run_install_if_needed
+        return if ::Rails.root.join("app/policies/application_policy.rb").exist?
+        generate "action_policy:install"
+      end
 
       def create_policy
         template "policy.rb", File.join("app/policies", class_path, "#{file_name}_policy.rb")

data/lib/generators/{action_policy/rspec → rspec}/templates/policy_spec.rb

@@ -1,6 +1,8 @@
-require '<%= File.exists?("spec/rails_helper.rb") ? "rails_helper" : "spec_helper" %>'
+require "<%= File.exists?('spec/rails_helper.rb') ? 'rails_helper' : 'spec_helper' %>"
 
 RSpec.describe <%= class_name %>Policy, type: :policy do
+  # See https://actionpolicy.evilmartians.io/#/testing?id=rspec-dsl
+  #
   # let(:user) { build_stubbed :user }
   # let(:record) { build_stubbed :post, draft: false }
   # let(:context) { {user: user} }

data/lib/generators/{action_policy/test_unit → test_unit}/templates/policy_test.rb

@@ -1,5 +1,6 @@
-require 'test_helper'
+require "test_helper"
 
+# See https://actionpolicy.evilmartians.io/#/testing?id=testing-policies
 class <%= class_name %>PolicyTest < ActiveSupport::TestCase
   def test_index
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_policy
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Vladimir Dementyev
@@ -273,10 +273,10 @@ files:
 - lib/generators/action_policy/policy/USAGE
 - lib/generators/action_policy/policy/policy_generator.rb
 - lib/generators/action_policy/policy/templates/policy.rb
-- lib/generators/action_policy/rspec/policy_generator.rb
-- lib/generators/action_policy/rspec/templates/policy_spec.rb
-- lib/generators/action_policy/test_unit/policy_generator.rb
-- lib/generators/action_policy/test_unit/templates/policy_test.rb
+- lib/generators/rspec/policy_generator.rb
+- lib/generators/rspec/templates/policy_spec.rb
+- lib/generators/test_unit/policy_generator.rb
+- lib/generators/test_unit/templates/policy_test.rb
 homepage: https://github.com/palkan/action_policy
 licenses:
 - MIT