action_policy-graphql 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5ed86f1884fc8a9468ed78e7476afc81cf68af0f65a549df4e213f5ab50b53f
-  data.tar.gz: 1991a6c3c2414a85bf3738cbdc600fda90d989a059f613200445d6b1d2c47c9e
+  metadata.gz: eb2f4793062ddef25c116e0591d97613174a3c39e18a62e7982f4a41d9f9afc1
+  data.tar.gz: 2e776a3a49781309094a4cee8d3824391913b57d5fcdef64edc6425eb476b280
 SHA512:
-  metadata.gz: f7a9012c86bcaad3c1220a7f9621655f3ae3ecc7f314672bf58c3f60d09112aa9605f3c361259bc8a7fb39d147ca696409ca20bb6fe92cf88c0cf1bc8c90d5a0
-  data.tar.gz: 967fa7b9dfc0638469744b810b0329f703eacebd6ba66f960448953b172476c183d1bda2e25841c61e963da6bbf8e091243fce0bb0c0409e3c3b53a38d1bc47b
+  metadata.gz: f02980395258ccf616d7508d24615d54162045e2f9abbea4cebcdd5d8976a19213f04ca8b0a7775fe99b03741ea91213dbe27e3e0994ae645e1656abb76212cd
+  data.tar.gz: 892b01138e996004cd1a218e06af56435f0f6cd662af14b295fa4162204da350d8a4fb2d192d014b30bd06f9f1e8798f580f272a203fbdbc75813e107463ac14

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master (unreleased)
 
+## 0.5.1 (2020-10-08)
+
+- Fix mutations authorization (clean up around `authorize_mutation_raise_exception` configuration parameter). ([@rzaharenkov][])
+
+- Add deprecation for using `authorize` for mutation fields. ([@rzaharenkov][])
+
 ## 0.5.0 (2020-10-07)
 
 - Add `preauthorize_mutation_raise_exception` configuration parameter. ([@palkan][])

data/README.md

@@ -80,6 +80,8 @@ You can customize the authorization options, e.g. `authorize: {to: :preview?, wi
 
 If you don't want to raise an exception but return a null instead, you should set a `raise: false` option.
 
+Note: it does not make too much sense to use `authorize` in mutations since it's checking authorization rules after mutation is executed. Therefore `authorize` marked as deprecated when used in mutations and will raise error in future releases.
+
 ### `authorized_scope: *`
 
 You can add `authorized_scope: true` option to the field (list or _connection_ field) to

data/lib/action_policy/graphql/authorized_field.rb

@@ -22,17 +22,29 @@ module ActionPolicy
       end
 
       class AuthorizeExtension < Extension
-        def apply
-          @to = extract_option(:to) { ::ActionPolicy::GraphQL.default_authorize_rule }
-          @raise = extract_option(:raise) do
-            if field.mutation
-              ::ActionPolicy::GraphQL.authorize_mutation_raise_exception
+        DEPRECATION_MESSAGE = "`authorize: *` for mutation fields is deprecated.  Please use `preauthorize: *` instead."
+
+        class << self
+          def show_authorize_mutation_deprecation
+            return if defined?(@authorize_mutation_deprecation_shown)
+
+            if defined?(ActiveSupport::Deprecation)
+              ActiveSupport::Deprecation.warn(DEPRECATION_MESSAGE)
             else
-              ::ActionPolicy::GraphQL.authorize_raise_exception
+              warn(DEPRECATION_MESSAGE)
             end
+
+            @authorize_mutation_deprecation_shown = true
           end
         end
 
+        def apply
+          self.class.show_authorize_mutation_deprecation if field.mutation
+
+          @to = extract_option(:to) { ::ActionPolicy::GraphQL.default_authorize_rule }
+          @raise = extract_option(:raise) { ::ActionPolicy::GraphQL.authorize_raise_exception }
+        end
+
         def after_resolve(value:, context:, object:, **_rest)
           return value if value.nil?
 

data/lib/action_policy/graphql/behaviour.rb

@@ -36,7 +36,7 @@ module ActionPolicy
 
         base.authorize :user, through: :current_user
 
-        if base.respond_to?(:field_class)
+        if base.respond_to?(:field_class) && !(base.field_class < ActionPolicy::GraphQL::AuthorizedField)
           base.field_class.prepend(ActionPolicy::GraphQL::AuthorizedField)
           base.include ActionPolicy::GraphQL::Fields
         end

data/lib/action_policy/graphql/version.rb

@@ -2,6 +2,6 @@
 
 module ActionPolicy
   module GraphQL
-    VERSION = "0.5.0"
+    VERSION = "0.5.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: action_policy-graphql
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Vladimir Dementyev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-07 00:00:00.000000000 Z
+date: 2020-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: action_policy