action_network_rest 0.8.2 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 805ab89baf0bfa4fe4635e963cd112a0ffeef25764d200d1d62b759f258db9ec
-  data.tar.gz: 48bcee71e1c6f0bda6e19a7d2dfa3efdc46040f60c6647a1ec030210a456536e
+  metadata.gz: f9016ae9e2c22b78c042639d589683ff591c4098712cad0861dc8faab843c82a
+  data.tar.gz: 114f680aead1e7b3500c26fb61175784046bf68db57ac62137df455f98f1789e
 SHA512:
-  metadata.gz: 01df31dc26e22c1b9aaad6399ed5a8fbffdf37f17876640aca512840d1e3e73f6da51b0455b830b2c07c6d3b31bf62572ddd19c57753a26aa3fb7de818d0096d
-  data.tar.gz: 85ac9b3aaf713840db2314813ca71ee479e0c0fd8643ca61d96b587a6a1523937d81d0da31d34dcb2cf93b6c655ba5a1c999a13b154500e2f764d2a831f098a1
+  metadata.gz: 7f811528d9ffe857652121e3c3bf42b517b9991a5335dd52fd99c02d36b3a75688bbc403c16aca0cdd619a4efc96fc3d5f50cb7d4fcddc2b01731c068c85e03b
+  data.tar.gz: b4db252bd30f7aeee2f3d402f287104212e51a7cf2e745773767d63f577a9d1c9131b4162b671b0568108b1b7d6e7e23434ed5d1016c949eb5e613238722c5fb

data/lib/action_network_rest/attendances.rb

@@ -2,6 +2,8 @@
 
 module ActionNetworkRest
   class Attendances < Base
+    class CreateError < StandardError; end
+
     attr_accessor :event_campaign_id, :event_id
 
     def base_path
@@ -14,7 +16,15 @@ module ActionNetworkRest
 
     def create(attendance_data)
       response = client.post_request base_path, attendance_data
-      object_from_response(response)
+      new_attendance = object_from_response(response)
+
+      # Action Network treats the attendance create helper endpoint as an unauthenticated
+      # "blind" POST (see https://actionnetwork.org/docs/v2/unauthenticated-post/). For this
+      # reason they don't return a status code with error to avoid leaking private data. Instead
+      # they return 200 OK with an empty body (vs. the newly created attendance's data for successful calls)
+      raise CreateError if new_attendance.empty?
+
+      new_attendance
     end
 
     def update(id, attendance_data)

data/lib/action_network_rest/response/raise_error.rb

@@ -15,6 +15,8 @@ module ActionNetworkRest
             if error_message == 'You must specify a valid person id'
               raise MustSpecifyValidPersonId, error_message(response)
             end
+          elsif status_code == 404
+            raise NotFoundError, error_message(response)
           else
             raise ResponseError, error_message(response)
           end
@@ -29,6 +31,8 @@ module ActionNetworkRest
 
     class MustSpecifyValidPersonId < StandardError; end
 
+    class NotFoundError < StandardError; end
+
     class ResponseError < StandardError; end
   end
 end

data/lib/action_network_rest/signatures.rb

@@ -2,6 +2,8 @@
 
 module ActionNetworkRest
   class Signatures < Base
+    class CreateError < StandardError; end
+
     attr_accessor :petition_id
 
     def base_path
@@ -13,7 +15,15 @@ module ActionNetworkRest
       post_body['add_tags'] = tags if tags.any?
 
       response = client.post_request(base_path, post_body)
-      object_from_response(response)
+      new_signature = object_from_response(response)
+
+      # Action Network treats the signature create helper endpoint as an unauthenticated
+      # "blind" POST (see https://actionnetwork.org/docs/v2/unauthenticated-post/). For this
+      # reason they don't return a status code with error to avoid leaking private data. Instead
+      # they return 200 OK with an empty body (vs. the newly created signature's data for successful calls)
+      raise CreateError if new_signature.empty?
+
+      new_signature
     end
 
     def update(id, signature_data)

data/lib/action_network_rest/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActionNetworkRest
-  VERSION = '0.8.2'
+  VERSION = '0.9.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: action_network_rest
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.9.0
 platform: ruby
 authors:
 - Grey Moore
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-23 00:00:00.000000000 Z
+date: 2021-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: vertebrae
@@ -136,7 +136,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.8.3
-description:
+description: 
 email:
 - grey@controlshiftlabs.com
 executables: []
@@ -178,7 +178,7 @@ homepage: https://github.com/controlshift/action-network-rest
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -194,7 +194,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.6
-signing_key:
+signing_key: 
 specification_version: 4
 summary: Ruby client for interacting with the ActionNetwork REST API
 test_files: []