action_meta_tags 0.1.1 → 0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb0724440db0b13d505e59a9fe781a80a9eeb9e0
-  data.tar.gz: d8e07d80da23e246ca2f9ced17282bcebb847e48
+  metadata.gz: 559c6f20f592f5ac0bc6e4c81931f903510cdfa5
+  data.tar.gz: 671728b9a3a0b43d8f2f7a5e2b7fc1845f23673c
 SHA512:
-  metadata.gz: 961925683903b5c9fb188825debee30848353eb847154e769945abd3a42c81ee84d8097a9b84892bd88382d0ac9cd7b22c7a39887aca3563051cb6eb36735d60
-  data.tar.gz: f866b0cbc6643574a4c287dd2775673e375535d30b539386029aadc0a688707a43fb5f007260c982f32454e1a1a71cf318050cd51d6070e2d9f23644d0d36674
+  metadata.gz: 5f372a497d58cc7e5ad89635cd97ca20155571b5b78653f8ba5b10ea1aae201c264693dab2fe29e7b0d75ffbeece38a2caf3a66de2d935a8add67e600fd82c81
+  data.tar.gz: be3ff875898c30e91c1b9a1f0117e1e251e5e95ad65f1431dec178f42d5931e7a2eae2f6d09fbefd5ee62f0fdce624b813cec414ba64fd78868494b53ecc7df0

data/.travis.yml

@@ -3,3 +3,6 @@ rvm:
   - 2.1.0
   - 2.0.0
   - 1.9.3
+addons:
+  code_climate:
+    repo_token: 3c1a819d00be5f50af98652a9efc9e6d5004332346d0b0c4669aa64a027ae920

data/README.md

@@ -1,7 +1,10 @@
+Better SEO for the content pages of your Rails app with less code and better design.
+
 # ActionMetaTags
 
 [![Build Status](https://travis-ci.org/andrewgr/action_meta_tags.png)](https://travis-ci.org/andrewgr/action_meta_tags)
 [![Code Climate](https://codeclimate.com/github/andrewgr/action_meta_tags/badges/gpa.svg)](https://codeclimate.com/github/andrewgr/action_meta_tags)
+[![Test Coverage](https://codeclimate.com/github/andrewgr/action_meta_tags/badges/coverage.svg)](https://codeclimate.com/github/andrewgr/action_meta_tags/coverage)
 
 ## Installation
 

data/action_meta_tags.gemspec

@@ -21,6 +21,4 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'actionpack', '~> 4'
   gem.add_development_dependency 'rubocop', '~> 0.30'
   gem.add_development_dependency 'cane', '~> 2.6', '>= 2.6.1'
-  gem.add_development_dependency 'shoulda', '~> 3.5'
-  gem.add_development_dependency 'shoulda-matchers', '~> 2.8', '>= 2.8.0'
 end

data/lib/action_meta_tags.rb

@@ -1,6 +1,8 @@
 require 'active_support'
 require 'action_meta_tags/version'
 require 'action_meta_tags/helpers'
+require 'action_meta_tags/tags/self_closing_tag'
+require 'action_meta_tags/tags/link'
 require 'action_meta_tags/tags/meta'
 require 'action_meta_tags/tags/title'
 require 'action_meta_tags/base'

data/lib/action_meta_tags/base.rb

@@ -4,36 +4,36 @@ module ActionMetaTags
       @object = object
     end
 
-    def self.title(&block)
-      tags << Tags::Title.new(&block)
-    end
-
-    def self.meta(attrs, &block)
-      tags << Tags::Meta.new(attrs, &block)
-    end
-
-    def self.keywords(&block)
-      tags << Tags::Meta.new(name: 'keywords', &block)
-    end
-
-    def self.description(&block)
-      tags << Tags::Meta.new(name: 'description', &block)
-    end
-
-    def self.og_title(&block)
-      tags << Tags::Meta.new(property: 'og:title', &block)
-    end
-
-    def self.og_image(&block)
-      tags << Tags::Meta.new(property: 'og:image', &block)
-    end
-
-    def self.og_description(&block)
-      tags << Tags::Meta.new(property: 'og:description', &block)
-    end
-
-    def self.tags
-      @tags ||= []
+    class << self
+      def tags
+        @tags ||= []
+      end
+
+      def title(&block)
+        tags << Tags::Title.new(&block)
+      end
+
+      def meta(attrs, &block)
+        tags << Tags::Meta.new(attrs, &block)
+      end
+
+      def link(attrs, &block)
+        tags << Tags::Link.new(attrs, &block)
+      end
+
+      %w(keywords description).each do |method|
+        define_method method do |&block|
+          meta(name: method, &block)
+        end
+      end
+
+      %w(og:title og:image og:description).each do |property|
+        method = property.gsub(':', '_')
+
+        define_method method do |&block|
+          meta(property: property, &block)
+        end
+      end
     end
 
     def render(view)

data/lib/action_meta_tags/helpers.rb

@@ -3,18 +3,8 @@ module ActionMetaTags
     extend ActiveSupport::Concern
 
     def meta_tags(object)
-      class_name = [
-        'Meta',
-        params[:controller].capitalize,
-        params[:action].capitalize
-      ].join('::')
+      class_name = ['Meta', params[:controller].classify, params[:action].classify].join('::')
       class_name.constantize.new(object).render(self)
     end
-
-    private
-
-    def find_domain(host)
-      host
-    end
   end
 end

data/lib/action_meta_tags/tags/link.rb

@@ -0,0 +1,10 @@
+module ActionMetaTags
+  module Tags
+    class Link < SelfClosingTag
+      def render(view, object)
+        href = object.instance_exec(&renderer)
+        view.tag(:link, attrs.merge(href: href))
+      end
+    end
+  end
+end

data/lib/action_meta_tags/tags/meta.rb

@@ -1,17 +1,10 @@
 module ActionMetaTags
   module Tags
-    class Meta
-      def initialize(attrs, &block)
-        @attrs = attrs
-        @renderer = block
-      end
-
+    class Meta < SelfClosingTag
       def render(view, object)
         content = object.instance_exec(&renderer)
         view.tag(:meta, attrs.merge(content: content))
       end
-
-      attr_reader :renderer, :attrs
     end
   end
 end

data/lib/action_meta_tags/tags/self_closing_tag.rb

@@ -0,0 +1,18 @@
+module ActionMetaTags
+  module Tags
+    class SelfClosingTag
+      def initialize(attrs, &block)
+        @attrs    = attrs
+        @renderer = block
+      end
+
+      def render(view, object)
+        fail NotImplementedError
+      end
+
+      protected
+
+      attr_reader :renderer, :attrs
+    end
+  end
+end

data/lib/action_meta_tags/tags/title.rb

@@ -10,6 +10,8 @@ module ActionMetaTags
         view.content_tag(:title, content)
       end
 
+      private
+
       attr_reader :renderer
     end
   end

data/lib/action_meta_tags/version.rb

@@ -1,4 +1,4 @@
 module ActionMetaTags
   # Gem version
-  VERSION = '0.1.1'
+  VERSION = '0.2'
 end

data/spec/action_meta_tags/base_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+class ResourceTags < ActionMetaTags::Base
+  title { "#{title} | Site" }
+
+  meta('http-equiv' => 'refresh') { "0;URL='http://example.com/'".html_safe }
+
+  keywords       { 'key,words' }
+  description    { description }
+  og_title       { title }
+  og_image       { 'http://example.org/i.png' }
+  og_description { description }
+
+  link(
+    rel: 'search',
+    type: 'application/opensearchdescription+xml',
+    title: 'Site') { '/opensearch.xml' }
+end
+
+RSpec.describe ActionMetaTags::Base do
+  let(:view)     { ActionView::Base.new }
+  let(:resource) { OpenStruct.new(title: 'Title', description: 'Lorem Ipsum.') }
+  subject        { ResourceTags.new(resource).render(view) }
+
+  specify '#title renders the title tag' do
+    is_expected.to include('<title>Title | Site</title>')
+  end
+
+  specify '#meta renders a meta tag' do
+    is_expected.to include(%q(<meta http-equiv="refresh" content="0;URL='http://example.com/'" />))
+  end
+
+  specify '#link renders a link tag' do
+    is_expected.to include('<link rel="search" type="application/opensearchdescription+xml" title="Site" href="/opensearch.xml" />')
+  end
+
+  specify '#keywords renders the appropriate meta tag' do
+    is_expected.to include('<meta name="keywords" content="key,words" />')
+  end
+
+  specify '#description renders the appropriate meta tag' do
+    is_expected.to include('<meta name="description" content="Lorem Ipsum." />')
+  end
+
+  specify '#og_title renders the appropriate meta tag' do
+    is_expected.to include('<meta property="og:title" content="Title" />')
+  end
+
+  specify '#og_image renders the appropriate meta tag' do
+    is_expected.to include('<meta property="og:image" content="http://example.org/i.png" />')
+  end
+
+  specify '#og_description renders the appropriate meta tag' do
+    is_expected.to include('<meta property="og:description" content="Lorem Ipsum." />')
+  end
+end

data/spec/action_meta_tags/helpers_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+module Meta
+  module Post
+    class Show < ActionMetaTags::Base
+      title { title }
+    end
+  end
+end
+
+RSpec.describe ActionMetaTags::Helpers do
+  describe '#meta_tags' do
+    let(:view) do
+      ActionView::Base.new.tap do |view|
+        params = { controller: 'posts', action: 'show' }
+        view.controller = OpenStruct.new(params: params)
+      end
+    end
+    let(:resource) { OpenStruct.new(title: 'Title') }
+    subject { view.meta_tags(resource) }
+
+    specify do
+      is_expected.to eq('<title>Title</title>')
+    end
+  end
+end

data/spec/action_meta_tags/tags/link_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+RSpec.describe ActionMetaTags::Tags::Link do
+  let(:view)     { ActionView::Base.new }
+  let(:resource) { OpenStruct.new(url: 'http://example.org/') }
+  subject(:tag)  { described_class.new(rel: :canonical) { url } }
+
+  specify do
+    expected = '<link rel="canonical" href="http://example.org/" />'
+    expect(tag.render(view, resource)).to eq(expected)
+  end
+end

data/spec/action_meta_tags/tags/meta_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+RSpec.describe ActionMetaTags::Tags::Meta do
+  let(:view)     { ActionView::Base.new }
+  let(:resource) { OpenStruct.new(description: 'Lorem ipsum.') }
+  subject(:tag)  { described_class.new(name: :description) { description } }
+
+  specify do
+    expected = '<meta name="description" content="Lorem ipsum." />'
+    expect(tag.render(view, resource)).to eq(expected)
+  end
+end

data/spec/action_meta_tags/tags/self_closing_tag_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+RSpec.describe ActionMetaTags::Tags::SelfClosingTag do
+  let(:view)     { ActionView::Base.new }
+  let(:resource) { OpenStruct.new(url: 'http://example.org/') }
+  subject(:tag)  { described_class.new(rel: :canonical) { url } }
+
+  specify do
+    expect { tag.render(view, resource) }.to raise_error(NotImplementedError)
+  end
+end

data/spec/action_meta_tags/tags/title_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+RSpec.describe ActionMetaTags::Tags::Title do
+  let(:view)     { ActionView::Base.new }
+  let(:resource) { OpenStruct.new(title: 'Title') }
+  subject(:tag)  { described_class.new { title } }
+
+  specify do
+    expect(tag.render(view, resource)).to eq('<title>Title</title>')
+  end
+end

data/spec/spec_helper.rb

@@ -1,2 +1,3 @@
-require 'current_domain'
-require 'action_controller'
+require 'action_meta_tags'
+require 'action_view'
+require 'ostruct'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: action_meta_tags
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: '0.2'
 platform: ruby
 authors:
 - Andrei Gridnev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-06 00:00:00.000000000 Z
+date: 2015-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -86,40 +86,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.1
-- !ruby/object:Gem::Dependency
-  name: shoulda
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
-- !ruby/object:Gem::Dependency
-  name: shoulda-matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.8.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.8.0
 description: Well structured meta tags for your Rails app views
 email:
 - andrew.gridnev@gmail.com
@@ -140,9 +106,17 @@ files:
 - lib/action_meta_tags.rb
 - lib/action_meta_tags/base.rb
 - lib/action_meta_tags/helpers.rb
+- lib/action_meta_tags/tags/link.rb
 - lib/action_meta_tags/tags/meta.rb
+- lib/action_meta_tags/tags/self_closing_tag.rb
 - lib/action_meta_tags/tags/title.rb
 - lib/action_meta_tags/version.rb
+- spec/action_meta_tags/base_spec.rb
+- spec/action_meta_tags/helpers_spec.rb
+- spec/action_meta_tags/tags/link_spec.rb
+- spec/action_meta_tags/tags/meta_spec.rb
+- spec/action_meta_tags/tags/self_closing_tag_spec.rb
+- spec/action_meta_tags/tags/title_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/andrewgr/action_meta_tags/
 licenses:
@@ -169,4 +143,10 @@ signing_key:
 specification_version: 4
 summary: Meta tags
 test_files:
+- spec/action_meta_tags/base_spec.rb
+- spec/action_meta_tags/helpers_spec.rb
+- spec/action_meta_tags/tags/link_spec.rb
+- spec/action_meta_tags/tags/meta_spec.rb
+- spec/action_meta_tags/tags/self_closing_tag_spec.rb
+- spec/action_meta_tags/tags/title_spec.rb
 - spec/spec_helper.rb