action_kit_rest 0.4.6 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2116d0818685f8278921f966f7f4dfb53d4121c983642bb431a13267de077195
-  data.tar.gz: 19e5351054a60071bef7926ea245ad4f1392a7aa33e929ef44fbb590f18335d1
+  metadata.gz: 1817fcc57f6d22b7c399e0face9405049f77417e6ea2b27c9e32218be76af124
+  data.tar.gz: 0eb382953e3c3c691191ce9f9c0ff61f5d39cefac40e77921ba2bc4d5366068f
 SHA512:
-  metadata.gz: 61722ea2d57c2da9e942351d1651ddfc8b3c2d8df337736aab9d9ce57d4f28993ac8be1f83f6e2f5b88a6f463e21849d5df353ac3d155791be8e57ce4ce2884d
-  data.tar.gz: efa307aa27a974fa7a93eba9ebf3ebacc6e6b4ba7a11abc63cbaed748c27d5346477dfa19cc8d01d93e4e3986363fed50de7b110f4d02b621e9301e0f14229e9
+  metadata.gz: f07602cc5779ae7eb6c7cfd5bad09ec780443c8b0e702a36264035a92add5b4ca06135196e4ea41aa6dcfa0e2d8ea7effa4777adc57e0842666199989db9bd39
+  data.tar.gz: cd5c4e3b3e70f5979cd42981b9c116ef475cf9af06ebd8e8c857b594d7a43f15dc9e12fec86de117adda5b691cc0b52571c461ef46035bee8ab97b09742e76ee

data/action_kit_rest.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: action_kit_rest 0.4.6 ruby lib
+# stub: action_kit_rest 0.4.7 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "action_kit_rest".freeze
-  s.version = "0.4.6"
+  s.version = "0.4.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Nathan Woodhull".freeze, "Diego Marcet".freeze, "Grey Moore".freeze]
-  s.date = "2021-09-29"
+  s.date = "2021-10-05"
   s.description = "Gem for interacting with the ActionKit API".freeze
   s.email = "systems@controlshiftlabs.com".freeze
   s.extra_rdoc_files = [
@@ -77,6 +77,7 @@ Gem::Specification.new do |s|
     "spec/lib/action_kit_rest/actions/event_create_action_spec.rb",
     "spec/lib/action_kit_rest/actions/event_signup_action_spec.rb",
     "spec/lib/action_kit_rest/allowed_user_field_spec.rb",
+    "spec/lib/action_kit_rest/api_spec.rb",
     "spec/lib/action_kit_rest/logger_spec.rb",
     "spec/lib/action_kit_rest/page_spec.rb",
     "spec/lib/action_kit_rest/pages/event_campaign_page_spec.rb",

data/lib/action_kit_rest/response/raise_error.rb

@@ -8,7 +8,7 @@ module ActionKitRest
         if (400...600).include? status_code
           if status_code == 400
             response_body = response[:body]
-            if JSON.parse(response_body)['errors'] == { 'mailing_id' => ['Unable to associate this mailing ID with account.'] }
+            if ActionKitRest::Response::InvalidAkidError.matches?(JSON.parse(response_body)['errors'])
               raise ActionKitRest::Response::InvalidAkidError.new(url: response[:url].to_s, body: response_body)
             else
               raise ActionKitRest::Response::ValidationError.new(url: response[:url].to_s, body: response_body)

data/lib/action_kit_rest/response/validation_error.rb

@@ -7,7 +7,7 @@ module ActionKitRest
 
       def initialize(params)
         self.url = params[:url]
-        self.body = params[:body]
+        self.body = params[:body].dup
         self.errors = JSON.parse(params[:body])['errors']
         super()
       end
@@ -23,6 +23,17 @@ module ActionKitRest
     end
 
     class InvalidAkidError < ValidationError
+      MATCHING_ERRORS = ['Unable to associate this mailing ID with account.',
+                         'לא הצלחנו לקשר בין מספר הזיהוי של רשימת הדיוור הזו לבין החשבון.'].freeze
+
+      def self.matches?(errors)
+        return false unless errors.keys == ['mailing_id']
+
+        mailing_id_errors = errors['mailing_id']
+        return false unless mailing_id_errors.size == 1
+
+        MATCHING_ERRORS.include?(mailing_id_errors.first)
+      end
     end
   end
 end

data/lib/action_kit_rest/version.rb

@@ -4,7 +4,7 @@ module ActionKitRest
   module VERSION
     MAJOR = 0
     MINOR = 4
-    PATCH = 6
+    PATCH = 7
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.')

data/spec/lib/action_kit_rest/api_spec.rb

@@ -0,0 +1,95 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'support/shared_contexts/stub_logger'
+
+describe ActionKitRest::API do
+  include_context 'stub_logger'
+
+  subject { ActionKitRest::API.new(host: 'example.com', username: 'foo', password: 'bar') }
+
+  describe 'error detection' do
+    let(:request_body) { {some: 'data'} }
+
+    before :each do
+      stub_request(:post, 'https://example.com/rest/v1/something/')
+        .to_return(status: response_status, body: response_body,
+                   headers: { content_type: 'application/json; charset=utf-8' })
+    end
+
+    context 'successful response' do
+      let(:response_status) { 200 }
+      let(:response_body) { '{"message": "good job!"}' }
+
+      it 'should not raise' do
+        subject.post_request('something/', request_body)
+      end
+    end
+
+    context '400 response' do
+      let(:response_status) { 400 }
+
+      context 'unable to associate mailing ID' do
+        let(:response_body) { '{"errors": {"mailing_id": ["Unable to associate this mailing ID with account."]}}' }
+
+        it 'should raise an InvalidAkidError' do
+          expect{ subject.post_request('something/', request_body) }.to raise_error(ActionKitRest::Response::InvalidAkidError)
+        end
+      end
+
+      context 'unable to associate mailing ID error in Hebrew' do
+        let(:response_body) { '{"errors": {"mailing_id": ["לא הצלחנו לקשר בין מספר הזיהוי של רשימת הדיוור הזו לבין החשבון."]}}' }
+
+        it 'should raise an InvalidAkidError' do
+          expect{ subject.post_request('something/', request_body) }.to raise_error(ActionKitRest::Response::InvalidAkidError)
+        end
+      end
+
+      context 'other error' do
+        let(:response_body) { '{"errors": {"zip": ["There is something wrong with your ZIP code!"]}}' }
+
+        it 'sould raise a ValidationError' do
+          expect{ subject.post_request('something/', request_body) }.to raise_error(ActionKitRest::Response::ValidationError)
+        end
+      end
+    end
+
+    context '401 response' do
+      let(:response_status) { 401 }
+      let(:response_body) { '{"error": "Your API key is no good"}' }
+
+      it 'should raise an Unauthorized exception' do
+        expect{ subject.post_request('something/', request_body) }.to raise_error(ActionKitRest::Response::Unauthorized)
+      end
+    end
+
+    context '404 response' do
+      let(:response_status) { 404 }
+      let(:response_body) { '{"error": "not found"}' }
+
+      it 'should raise a NotFound exception' do
+        expect{ subject.post_request('something/', request_body) }.to raise_error(ActionKitRest::Response::NotFound)
+      end
+    end
+
+    context '500 response' do
+      let(:response_status) { 500 }
+
+      context 'Try Again Later message' do
+        let(:response_body) { '{"error": "Sorry, this request could not be processed. Please try again later."}' }
+
+        it 'should raise a TryAgainLater exception' do
+          expect{ subject.post_request('something/', request_body) }.to raise_error(ActionKitRest::Response::TryAgainLater)
+        end
+      end
+
+      context 'other error message' do
+        let(:response_body) { '{"error": "Something is wrong, we will fix it!"}' }
+
+        it 'should raise a StandardError' do
+          expect{ subject.post_request('something/', request_body) }.to raise_error(StandardError)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_kit_rest
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors:
 - Nathan Woodhull
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-29 00:00:00.000000000 Z
+date: 2021-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: vertebrae
@@ -242,6 +242,7 @@ files:
 - spec/lib/action_kit_rest/actions/event_create_action_spec.rb
 - spec/lib/action_kit_rest/actions/event_signup_action_spec.rb
 - spec/lib/action_kit_rest/allowed_user_field_spec.rb
+- spec/lib/action_kit_rest/api_spec.rb
 - spec/lib/action_kit_rest/logger_spec.rb
 - spec/lib/action_kit_rest/page_spec.rb
 - spec/lib/action_kit_rest/pages/event_campaign_page_spec.rb