action_kit_api 0.1.1 → 0.1.2

data/lib/action_kit_api/connection.rb

@@ -5,6 +5,32 @@ require 'xmlrpc/client'
 # required for ... well every operation ... this is a remote API
 # gem :)
 
+# This seems silly and dangerous right? Overwriting something in the ruby
+# standard libraries? Well ActionKit is doing XMLRPC wrong. This is almost
+# identical to the Ruby standard library version however it drops the type
+# check on the faultCode and the faultString. The XMLRPC standard indicates
+# that yes the faultCode has to be an integer and faultString has to be a
+# string. ActionKit WILL RETURN A STRING AS THE faultCode.
+#
+# References:
+#   XMLRPC Spec:
+#     http://xmlrpc.scripting.com/spec.html
+#   ActionKit (just an example, see second sentence under 'get'
+#     https://roboticdogs.actionkit.com/docs/manual/api/users.html?highlight=faultcode
+module XMLRPC
+  module Convert 
+    def self.fault(hash)
+      if hash.kind_of? Hash and hash.size == 2 and
+        hash.has_key? "faultCode" and hash.has_key? "faultString"
+
+        XMLRPC::FaultException.new(hash["faultCode"], hash["faultString"])
+      else
+        raise "wrong fault-structure: #{hash.inspect}"
+      end
+    end
+  end
+end
+
 module ActionKitApi
   class NoConnection < Exception
     # Nothing special, will be raised in the event something

data/lib/action_kit_api/searchable.rb

@@ -23,7 +23,12 @@ module ActionKitApi
         class_name = self.to_s.split("::").last
 
         search = parse_attributes(attrs, args)
-        response = ActionKitApi::Connection.call("#{class_name}.get", search)
+
+        begin
+          response = ActionKitApi::Connection.call("#{class_name}.get", search)
+        rescue RuntimeError => error
+          response = nil
+        end
 
         # Build a new object with the response, this might be an empty
         # object if the search failed or was invalid

data/lib/action_kit_api/version.rb

@@ -1,3 +1,3 @@
 module ActionKitApi
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 1
-  version: 0.1.1
+  - 2
+  version: 0.1.2
 platform: ruby
 authors: 
 - Sam Stelfox