action_form 0.6.5 → 0.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72382d4935502742cc4736c21c7964185e8fdb154972bc4ae38ae9497c18009d
-  data.tar.gz: a28f5cc2229551ce6a116721d8c34a4d134a2acc1bea9c1b081e633c20f60834
+  metadata.gz: a30578d111d84b9c748248c82a65eac75389b0696f27dbb3a36a3c437b5643e3
+  data.tar.gz: 2da98bb16f9368a0f07a70d1c47f904b80421f584c024ae69ea18db009f23bf3
 SHA512:
-  metadata.gz: 6efb2e07f6de58b2d25af0e9dcaf3d0c779a7a72ea7d70acf0a840ceb70d74053902742b659369e99d7b723660e2bcac87784a9c17b1bfa3ad2f876d7e92d93b
-  data.tar.gz: 4fd0ede2b1ef5bc8a74f12ceefd75e4d5af245abe4a26cf60fa294320198904af6f2be66245beac5a96f45c7bb72f4f0409a2f352e6f068e0cdf3f558f338dd8
+  metadata.gz: 8c9a05b8349c2072c787d95102fd047e6a067e4d367b79c4284c326c75abc2cd05c1a09b38c41dac2d52536cdbb737c927b4f9231a38472cfda66690ed82085f
+  data.tar.gz: e654910d6f00232ee6995955f48c2089edc70de5151c07ccb247b48758b1ed5c2ad6f3306807b37ac3008d9e0bc722c6ebb7ca1b208ea49aa105d448143133d5

data/lib/action_form/base.rb

@@ -27,9 +27,7 @@ module ActionForm
       def inherited(subclass)
         super
         subclass.elements = elements.dup
-        subclass.scope = scope.dup
-        subclass.params_definition = Class.new(params_definition)
-        subclass.params_definition.form_class = subclass
+        subclass.scope = scope&.dup
       end
     end
 

data/lib/action_form/elements_dsl.rb

@@ -24,7 +24,6 @@ module ActionForm
 
       # TODO: add support for outputless elements
       def element(name, &block)
-        @params_definition = nil
         elements[name] = Class.new(ActionForm::Element)
         elements[name].class_eval(&block)
         define_singleton_method(:"#{name}_element") do |klass = nil, &block|
@@ -33,7 +32,6 @@ module ActionForm
       end
 
       def many(name, default: nil, &block)
-        @params_definition = nil
         subform_definition = Class.new(ActionForm::SubformsCollection)
         subform_definition.host_class = self
         subform_definition.class_eval(&block) if block
@@ -45,7 +43,6 @@ module ActionForm
       end
 
       def subform(name, default: nil, &block)
-        @params_definition = nil
         elements[name] = Class.new(subform_class)
         elements[name].class_eval(&block)
         elements[name].default = default if default

data/lib/action_form/rails/base.rb

@@ -50,18 +50,6 @@ module ActionForm
         end
       end
 
-      def params_definition(scope: self.scope)
-        return super unless scope
-
-        @params_definitions ||= Hash.new do |h, key|
-          h[key] = begin
-            klass = super
-            Class.new(self.class.params_class) { has scope, klass }
-          end
-        end
-        @params_definitions[scope]
-      end
-
       private
 
       def subform_html_name(name, index: nil)

data/lib/action_form/schema_dsl.rb

@@ -17,14 +17,27 @@ module ActionForm
         @params_definition ||= create_params_definition
       end
 
+      def params_blocks
+        @params_blocks ||= []
+      end
+
       def params(&block)
-        @params_definition = Class.new(params_definition, &block) if block
+        params_blocks << block if block
+      end
+
+      def inherited_params_blocks
+        parent = superclass
+        blocks = []
+        while parent.respond_to?(:params_blocks)
+          parent.params_blocks.each { |block| blocks.unshift(block) }
+          parent = parent.superclass
+        end
+        blocks
       end
 
-      def create_params_definition # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def create_params_definition(elements_definitions: elements) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
         schema = Class.new(params_class)
-        schema.form_class = self
-        elements.each do |name, element_definition|
+        elements_definitions.each do |name, element_definition|
           if element_definition < ActionForm::SubformsCollection
             # nested forms are passed as a hash that looks like this:
             # { "0" => { "id" => "1" }, "1" => { "id" => "2" } }
@@ -44,40 +57,25 @@ module ActionForm
             schema.public_send(method_name, name, **options)
           end
         end
+        patches = inherited_params_blocks + params_blocks
+        patches.each do |block|
+          schema = Class.new(schema, &block)
+        end
+        schema.form_class = self
         schema
       end
     end
 
     module InstanceMethods # rubocop:disable Style/Documentation
-      def params_definition(*)
+      def params_definition
         @params_definition ||= create_params_definition
       end
 
-      def create_params_definition # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def create_params_definition
         schema = Class.new(self.class.params_class)
         schema.form_class = self.class
-        elements_instances.select(&:render?).each do |element|
-          case element
-          when ActionForm::SubformsCollection
-            # nested forms are passed as a hash that looks like this:
-            # { "0" => { "id" => "1" }, "1" => { "id" => "2" } }
-            # it is coercing to an array of hashes:
-            # [['0', { "id" => "1" }], ['1', { "id" => "2" }]]
-            # we need to normalize it to an array of hashes:
-            # [ { "id" => "1" }, { "
-            # id" => "2" } ]
-            schema.each(:"#{element.name}_attributes", element.subforms.first.params_definition,
-                        normalize: ->(value) { value.flatten.select { |v| v.is_a?(Hash) } },
-                        default: element.class.default)
-          when ActionForm::Subform
-            schema.has(:"#{element.name}_attributes", element.params_definition, default: element.class.default)
-          when ActionForm::Element
-            options = element.class.output_options.dup
-            method_name = options.delete(:type)
-            schema.public_send(method_name, element.name, **options)
-          end
-        end
-        schema
+        renderable_elements = elements_instances.select(&:render?).to_h { |element| [element.name, element.class] }
+        self.class.create_params_definition(elements_definitions: renderable_elements)
       end
     end
   end

data/lib/action_form/subforms_collection.rb

@@ -22,7 +22,7 @@ module ActionForm
 
       def inherited(subclass)
         super
-        subclass.subform_definition = subform_definition
+        subclass.subform_definition = Class.new(subform_definition) if subform_definition
         subclass.default = default
         subclass.host_class = host_class
       end

data/lib/action_form/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActionForm
-  VERSION = "0.6.5"
+  VERSION = "0.6.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_form
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 0.6.6
 platform: ruby
 authors:
 - Andrii Baran