acting 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ef5b67668bb5848b366ab7b029fca9ea5a2c6d9b
-  data.tar.gz: 5eb68911bb33de5f3ff5afaece87bad4413c437d
+  metadata.gz: 22283894c1dc87a10cdf0f6d806b11d07098bd3d
+  data.tar.gz: e95812f00bf97328e93afa6c3c5f46a993a5e5d0
 SHA512:
-  metadata.gz: 7ea10a69df14c3ee6000b2c4c91f5c6c1d3feec6b89c90c4f2ce37a6d6dced813289b02d692d46a36508e68f034f6fa30ae6c2b328d825298fed687b5338f47a
-  data.tar.gz: 15cc11a46691c3270cb9793798f3dbd7c44b360703df8f1a4195e8bd0dcdd5b7e9eadbb33e0586a82ebc5ab49f1093a0b661cea7058d3fd6f588bfb295f1576f
+  metadata.gz: fd619483fc20e9e961b3c7f4dc5759f03e07bdb41bd2a96dc57b5e3bf07923a647e2c6a1d9c730c8d72d4d4d5deab88d93dc1c6e129c2346f42c70ddcaa25db5
+  data.tar.gz: c4000ebd6ad3871a3009b594a17c1d6a12dcfcbb7d0a958375ae6ac5e51edda4c732f400d403ff878537c5d43b72e0e6bfaf2aaf60d212a5e8f91e5a2d2cbe29

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 2.0.0
+  - 1.9.3
+  - 1.9.2
+  # - jruby-19mode # JRuby in 1.9 mode
+  # - rbx-19mode

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    acting (0.0.1)
+    acting (0.0.2)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,5 +1,9 @@
 # Acting
 
+[![Build Status](https://travis-ci.org/featurefabrik/acting.png?branch=master)](https://travis-ci.org/featurefabrik/acting)
+[![Code Climate](https://codeclimate.com/github/featurefabrik/acting.png)](https://codeclimate.com/github/featurefabrik/acting)
+[![Gem Version](https://badge.fury.io/rb/acting.png)](http://badge.fury.io/rb/acting)
+
 Acting lets your objects play a role. But just for a specific duration.
 One of the main-concepts for a clean DCI implementation.
 
@@ -37,6 +41,15 @@ It is as simple as this:
 
     model1.speak # => NoMethodError
 ```
+
+## TODO:
+
+For now, we are only running on MRI 1.9.2/1.9.3/2.0.0.
+jRuby and RBX need to be configured.
+
+There is the case of overriding a previously define method by a role, that 
+needs to be fixed, too.
+
 ## Contributing
 
 1. Fork it

data/lib/acting/version.rb

@@ -1,3 +1,3 @@
 class Acting
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/acting.rb

@@ -1,37 +1,62 @@
 class Acting
   def initialize(cast)
-    actors = cast.map do |actor, role|
+    @actors = cast.map do |actor, role|
       Actor.new(actor, role)
     end
-
-    @cast = Cast.new(actors)
   end
 
   def play(&block)
-    @cast.play
+    if block_given?
+      play_with_block(&block)
+    else
+      @actors.each(&:play)
+    end
+  end
 
-    block.call
+  def quit
+    @actors.each(&:quit)
+  end
+
+  private
+  def play_with_block(&block)
+    @actors.each(&:play)
 
+    block.call
   ensure
-    @cast.quit
+    quit
   end
 
-  class Cast
-    def initialize(actors)
-      @actors = actors
+  module Cast
+    private
+    def __inject_methods__(methods)
+      methods.each do |method|
+        __injected_methods__[method.name] = method
+      end
     end
 
-    def play
-      @actors.each(&:play)
+    def __remove_methods__(methods)
+      methods.each do |method|
+        __injected_methods__.delete method.name
+      end
     end
 
-    def quit
-      @actors.each(&:quit)
+    def __injected_methods__
+      @__injected_methods__ ||= {}
+    end
+
+    def method_missing(meth, *args, &blk)
+      method = __injected_methods__[meth]
+      if method
+        method.bind(self).call(*args)
+      else
+        super
+      end
     end
   end
 
   class Actor
     def initialize(actor, role)
+      raise "#{actor.inspect} not kind of Acting::Cast" unless actor.kind_of? Cast
       @actor = actor
       @role = role
     end
@@ -45,43 +70,35 @@ class Acting
     end
 
     private
-    def actor_singleton_class
-      @singleton_class ||= (class << @actor; self; end)
-    end
-
     def role_methods
       unless @role_methods
-        if RUBY_VERSION =~ /^2/
-          object = @role
-          retrieval = :instance_method
-          method_names = @role.instance_methods
+        method_names = @role.instance_methods
+
+        if RUBY_VERSION =~ /2\.0/
+          @role_methods = method_names.map do |name|
+            @role.instance_method name
+          end
         else
+          # interim object so we can bind the method
+          # willy nilly (no 'kind_of?(@role) == true' required)
           object = Object.new
           object.extend @role
-          retrieval = :method
-          method_names = object.methods - Object.methods
-        end
 
-        @role_methods = method_names.map do |name|
-          object.send retrieval, name
+          @role_methods = method_names.map do |name|
+            object.method(name).unbind
+          end
         end
+
       end
       @role_methods
     end
 
     def assign_behaviour
-      role_methods.each do |method|
-        actor_singleton_class.send :define_method, method.name, method
-      end
-
+      @actor.send :__inject_methods__, role_methods
     end
 
     def revoke_behaviour
-      role_methods.each do |method|
-        if @actor.respond_to?(method.name)
-          actor_singleton_class.send :remove_method,  method.name
-        end
-      end
+      @actor.send :__remove_methods__, role_methods
     end
   end
 end

data/spec/acting_spec.rb

@@ -1,28 +1,65 @@
 require 'helper'
 
 describe Acting do
-  it 'lets the whole cast play for duration of a block' do
-    Positivist = Module.new do
-      def speak
-        'YES'
-      end
+  Positivist = Module.new do
+    def speak
+      'YES'
     end
+  end
 
-    Negativist = Module.new do
-      def speak
-        'NO'
-      end
+  Negativist = Module.new do
+    def speak
+      'NO'
     end
+  end
 
-    model1 = Object.new
-    model2 = Object.new
+  it 'lets the whole cast play for duration of a block' do
+    model1 = new_model
+    model2 = new_model 
 
     Acting.new(model1 => Positivist, model2 => Negativist).play do
       assert_equal 'YES', model1.speak
-      assert_equal 'NO', model2.speak
+      assert_equal 'NO',  model2.speak
     end
 
     refute model1.respond_to?(:speak)
     refute model2.respond_to?(:speak)
   end
+
+  it 'can be manually startet/stopped by omitting a block' do
+    model1 = new_model
+    model2 = new_model 
+
+    acting = Acting.new(model1 => Positivist, model2 => Negativist)
+
+    refute model1.respond_to?(:speak)
+    refute model2.respond_to?(:speak)
+
+    acting.play
+
+    assert_equal 'YES', model1.speak
+    assert_equal 'NO',  model2.speak
+
+    acting.quit
+
+    refute model1.respond_to?(:speak)
+    refute model2.respond_to?(:speak)
+  end
+
+  it 'fails when actor is no cast' do
+    model = Object.new
+
+    error = assert_raises RuntimeError do
+      Acting.new(model => Positivist)
+    end
+
+    assert_match(/kind of Acting::Cast/, error.message)
+  end
+
+  private
+  def new_model
+    model = Object.new
+    model.extend Acting::Cast
+    model
+  end
 end

data/spec/helper.rb

@@ -2,3 +2,5 @@ require 'minitest/spec'
 require 'minitest/autorun'
 
 require 'acting'
+
+puts "Running on #{RUBY_VERSION.inspect}"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acting
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Jakob Holderbaum
@@ -46,6 +46,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - Gemfile.lock
 - README.md