acme_nsupdate 0.4.3 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c2c9a4882555e5998835255c9d0a0a1433b1369e7b3cb5c16a3e17074d092b3
-  data.tar.gz: e6df0ac6c9d93f478b25165aff982f0db4e686e6f1c3415d921b28c129270aa8
+  metadata.gz: fcf1ae51c7808408407ff607d7415766088e1060ce3cb63e0f9f362b652a538c
+  data.tar.gz: 6719543b5ec0b4cbf197b227f36286f817b947915e09ff3eb0695e0f3660581d
 SHA512:
-  metadata.gz: dae4322617100f7644bfa625a8a17a16f2d569721815a4282a16fc36cdb7632377f058da20437ccd54f09fb0446af0b658f270fa377ee3cae94e4f2b76b32f16
-  data.tar.gz: 0e8e737733fd2bbc95a4568777280d4e62bf2dcecd2cf31a26f0ad57a24dabb8b21a7c168389199c9d6b9c7d2b2c7ebef2ec478761160ef760c78462ea961343
+  metadata.gz: a6620b1037693afc4447d7be07db180e81fd4441b9431e6481f80174242c1385d22f467f4e02457816e59bff8038e0748c85b186c6a0fe085998f5cc7fdf9a47
+  data.tar.gz: 6479e09299fcd217a384d7c50e44917f643e1ee18def38322f89aa3ad950b57967bf41462eb643fa606f8575766dd6adfa1404ee00b3de540f7cfe8c24937084

data/lib/acme_nsupdate/strategies/dns01.rb

@@ -83,14 +83,20 @@ module AcmeNsupdate
           begin
             sender = requester.sender(message, name, primary, 53)
             reply, _ = requester.request(sender, 10)
-            authority = !reply.authority.empty? ? reply.authority.first.first.to_s : reply.answer.first[2].to_s
+            authority = !reply.authority.empty? ? reply.authority.first.first.to_s : reply.answer.first.first.to_s
           ensure
             requester.close
           end
         end
 
-        return [] unless authority
-        query(primary, authority, :NS).map {|record| record.name.to_s }.uniq
+        unless authority
+          @client.logger.warn "Could not determine authority for #{name}, returning empty list of nameservers"
+          return []
+        end
+
+        query(primary, authority, :NS).map {|record| record.name.to_s }.uniq.tap do |nameservers|
+          @client.logger.debug "List of nameservers to check: #{nameservers.join(', ')}"
+        end
       end
 
       def query(nameserver, name, qtype)

data/lib/acme_nsupdate/strategy.rb

@@ -48,8 +48,25 @@ module AcmeNsupdate
     def wait_for_verification challenges
       @client.logger.debug("Requesting verification")
       challenges.each_value(&:request_validation)
-      @client.logger.debug("Waiting for verification")
-      challenges.map {|_, challenge| Thread.new { sleep(5) while challenge.status == "pending" } }.each(&:join)
+
+      @client.logger.debug("Waiting 120 seconds for verification")
+      waited = 0
+      challenges.each do |domain, challenge|
+        challenge.reload
+
+        next unless challenge.status == "pending"
+
+        if waited >= 120
+          @client.logger.error "Timeout while waiting for validation of challenge for #{domain}"
+          break
+        end
+
+        @client.logger.debug "Challenge for #{domain} is pending, waiting 5 seconds"
+        sleep(5)
+        waited += 5
+        redo
+      end
+
       challenges.each do |domain, challenge|
         raise "Verification of #{domain} failed: #{challenge.error}" unless challenge.status == "valid"
       end

data/lib/acme_nsupdate/version.rb

@@ -1,3 +1,3 @@
 module AcmeNsupdate
-  VERSION = "0.4.3"
+  VERSION = "0.4.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acme_nsupdate
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.5
 platform: ruby
 authors:
 - Jonne Haß
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-11 00:00:00.000000000 Z
+date: 2023-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slop
@@ -105,7 +105,7 @@ homepage: https://github.com/jhass/acme_nsupdate
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -120,8 +120,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.4.13
+signing_key:
 specification_version: 4
 summary: ACME (Let's Encrypt) client with nsupdate (DDNS) integration.
 test_files: []