acidic_job 1.0.0.rc1 → 1.0.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ea7524fb0e637ffdf7df124528a027f41f29891e2185e8776255c1b96ee3b00d
-  data.tar.gz: f364ede10a8872ffdaa07127cd7db22ed2886ae90605aeeb9d3e35dc3a7b169a
+  metadata.gz: 91e85393ede0eb0d4100449b323a12d1d447acc339a2e365926aae4a35ca34cb
+  data.tar.gz: 2278997e2ef132f34c26f31d2d17c6d54fcce32a52cb90517e1b678f43f83ede
 SHA512:
-  metadata.gz: ffc3d7f6c3638c8a883421f7e2f82c84739c63165d110faf70c95cd77952dff804b6769c7ac637ec170935d6bf227fd04416b7a75f1b585994376f5fe4965feb
-  data.tar.gz: ca8d0848c203914fd98fd2252689488b789b24c4ada0f082ba5a3a521463e24f66ec69e1240e087766d6091b2e9d0e5748aaeef81e9a69153b7c6489a0a6e29f
+  metadata.gz: 308a693c544f5cd2cc36872aaa403762b54fe474a2f2718e3e3fd03be355df92aa3c5cfcbf4b2be7f8f20207aa847c6174fcc09d4a5e9c169277c50b85f22441
+  data.tar.gz: 6329afd0ebbd5ce72bbeeb60aeb5359ffec646723b4c01bb110ce2084557de0282b33252d8a81519637c9a11bf5b241fcf1feefac3216c119beed1b22eb9f8cd

data/.codacy.yml

@@ -0,0 +1,4 @@
+---
+exclude_paths:
+  - "**/*.md"
+  - "LICENSE"

data/Gemfile.lock

@@ -1,15 +1,23 @@
 PATH
   remote: .
   specs:
-    acidic_job (1.0.0.rc1)
+    acidic_job (1.0.0.rc2)
       activejob (>= 7.1)
       activerecord (>= 7.1)
       activesupport (>= 7.1)
+      json (>= 2.7.0)
       railties (>= 7.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    actionmailer (7.2.1.1)
+      actionpack (= 7.2.1.1)
+      actionview (= 7.2.1.1)
+      activejob (= 7.2.1.1)
+      activesupport (= 7.2.1.1)
+      mail (>= 2.8.0)
+      rails-dom-testing (~> 2.2)
     actionpack (7.2.1.1)
       actionview (= 7.2.1.1)
       activesupport (= 7.2.1.1)
@@ -51,7 +59,7 @@ GEM
     base64 (0.2.0)
     bigdecimal (3.1.8)
     builder (3.3.0)
-    chaotic_job (0.2.0)
+    chaotic_job (0.3.0)
     combustion (1.3.7)
       activesupport (>= 3.0.0)
       railties (>= 3.0.0)
@@ -59,6 +67,7 @@ GEM
     concurrent-ruby (1.3.4)
     connection_pool (2.4.0)
     crass (1.0.6)
+    date (3.4.1)
     docile (1.4.0)
     drb (2.2.1)
     erubi (1.13.0)
@@ -70,13 +79,28 @@ GEM
     irb (1.14.1)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.6.3)
+    json (2.10.2)
     logger (1.6.1)
     loofah (2.22.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
+    mail (2.8.1)
+      mini_mime (>= 0.1.1)
+      net-imap
+      net-pop
+      net-smtp
+    mini_mime (1.1.5)
     mini_portile2 (2.8.7)
     minitest (5.25.1)
+    net-imap (0.5.1)
+      date
+      net-protocol
+    net-pop (0.1.2)
+      net-protocol
+    net-protocol (0.2.2)
+      timeout
+    net-smtp (0.5.0)
+      net-protocol
     nokogiri (1.16.7)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
@@ -162,7 +186,8 @@ PLATFORMS
 
 DEPENDENCIES
   acidic_job!
-  chaotic_job (>= 0.2.0)
+  actionmailer (>= 7.1)
+  chaotic_job
   combustion
   minitest
   rake

data/README.md

@@ -24,13 +24,13 @@ With AcidicJob, you can write reliable and repeatable multi-step distributed ope
 Install the gem and add to the application's Gemfile by executing:
 
 ```sh
-bundle add acidic_job
+bundle add acidic_job --version "1.0.0.rc1"
 ```
 
 If `bundler` is not being used to manage dependencies, install the gem by executing:
 
 ```sh
-gem install acidic_job
+gem install acidic_job --pre
 ```
 
 After installing the gem, run the installer:
@@ -101,7 +101,8 @@ class RideCreateJob < AcidicJob::Base
 end
 ```
 
-The `unique_by` keyword argument is used to define the unique identifier for a particular execution of the workflow. This helps to ensure that the workflow is idempotent, as retries of the job will correctly resume the pre-existing workflow execution. The `unique_by` argument can be anything that `JSON.dump` can handle.
+> [!IMPORTANT]
+> The `unique_by` keyword argument is used to define the unique identifier for a particular execution of the workflow. This helps to ensure that the workflow is idempotent, as retries of the job will correctly resume the pre-existing workflow execution. The `unique_by` argument can **only** be something that `JSON.generate(..., strict: true)` can handle; that is, it must be made up of only the JSON native types: `Hash`, `Array`, `String`, `Integer`, `Float`, `true`, `false` and `nil`.
 
 The block passed to `execute_workflow` is where you define the steps of the workflow. Each step is defined by calling the `step` method on the yielded workflow builder object. The `step` method takes the name of a method in the job that will be executed as part of the workflow. The `transactional` keyword argument can be used to ensure that the step is executed within a database transaction.
 

data/acidic_job.gemspec

@@ -27,14 +27,16 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "json", ">= 2.7.0" # see: https://github.com/ruby/json/pull/519
   ">= 7.1".tap do |rails_version|
     spec.add_dependency "activejob", rails_version
     spec.add_dependency "activerecord", rails_version
     spec.add_dependency "activesupport", rails_version
     spec.add_dependency "railties", rails_version
+    spec.add_development_dependency "actionmailer", rails_version
   end
 
-  spec.add_development_dependency "chaotic_job", ">= 0.2.0"
+  spec.add_development_dependency "chaotic_job"
   spec.add_development_dependency "combustion"
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "rake"

data/lib/acidic_job/context.rb

@@ -6,6 +6,26 @@ module AcidicJob
       @execution = execution
     end
 
+    def set(hash)
+      AcidicJob.instrument(:set_context, **hash) do
+        AcidicJob::Value.upsert_all(
+          hash.map do |key, value|
+            { execution_id: @execution.id,
+              key: key,
+              value: value }
+          end,
+          unique_by: %i[execution_id key]
+        )
+      end
+    end
+
+    def get(*keys)
+      AcidicJob.instrument(:get_context, keys: keys) do
+        @execution.values.select(:value).where(key: keys).pluck(:value)
+      end
+    end
+
+    # TODO: deprecate these methods
     def []=(key, value)
       AcidicJob.instrument(:set_context, key: key, value: value) do
         AcidicJob::Value.upsert(

data/lib/acidic_job/errors.rb

@@ -28,9 +28,9 @@ module AcidicJob
     end
   end
 
+  # rubocop:disable Lint/MissingSuper
   class ArgumentMismatchError < Error
     def initialize(expected, existing)
-      super
       @expected = expected
       @existing = existing
     end
@@ -46,7 +46,6 @@ module AcidicJob
 
   class DefinitionMismatchError < Error
     def initialize(expected, existing)
-      super
       @expected = expected
       @existing = existing
     end
@@ -62,7 +61,6 @@ module AcidicJob
 
   class UndefinedStepError < Error
     def initialize(step)
-      super
       @step = step
     end
 
@@ -73,7 +71,6 @@ module AcidicJob
 
   class SucceededStepError < Error
     def initialize(step)
-      super
       @step = step
     end
 
@@ -84,7 +81,6 @@ module AcidicJob
 
   class UndefinedMethodError < Error
     def initialize(step)
-      super
       @step = step
     end
 
@@ -95,7 +91,6 @@ module AcidicJob
 
   class InvalidMethodError < Error
     def initialize(step)
-      super
       @step = step
     end
 
@@ -103,4 +98,5 @@ module AcidicJob
       "step method cannot expect arguments: #{@step.inspect}"
     end
   end
+  # rubocop:enable Lint/MissingSuper
 end

data/lib/acidic_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AcidicJob
-  VERSION = "1.0.0.rc1"
+  VERSION = "1.0.0.rc2"
 end

data/lib/acidic_job/workflow.rb

@@ -38,7 +38,7 @@ module AcidicJob
                            else
                              { isolation: :serializable }
                            end
-        idempotency_key = Digest::SHA256.hexdigest(JSON.dump([self.class.name, unique_by]))
+        idempotency_key = Digest::SHA256.hexdigest(JSON.fast_generate([self.class.name, unique_by], strict: true))
 
         @execution = ::ActiveRecord::Base.transaction(**transaction_args) do
           record = Execution.find_by(idempotency_key: idempotency_key)
@@ -129,12 +129,11 @@ module AcidicJob
 
       return next_step if @execution.entries.exists?(step: curr_step, action: :succeeded)
 
-      step_method = performable_step_for(step_definition)
       rescued_error = nil
       begin
         @execution.record!(step: curr_step, action: :started, timestamp: Time.now)
         result = AcidicJob.instrument(:perform_step, **step_definition) do
-          step_method.call
+          perform_step_for(step_definition)
         end
         case result
         when REPEAT_STEP
@@ -167,7 +166,7 @@ module AcidicJob
       end
     end
 
-    def performable_step_for(step_definition)
+    def perform_step_for(step_definition)
       step_name = step_definition.fetch("does")
       step_method = method(step_name)
 
@@ -175,9 +174,7 @@ module AcidicJob
 
       wrapper = step_definition["transactional"] ? @execution.method(:with_lock) : NO_OP_WRAPPER
 
-      proc do
-        catch(:repeat) { wrapper.call { step_method.call } }
-      end
+      catch(:repeat) { wrapper.call { step_method.call } }
     rescue NameError
       raise UndefinedMethodError.new(step_name)
     end

metadata

@@ -1,15 +1,28 @@
 --- !ruby/object:Gem::Specification
 name: acidic_job
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc1
+  version: 1.0.0.rc2
 platform: ruby
 authors:
 - fractaledmind
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-11-17 00:00:00.000000000 Z
+date: 2025-05-14 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.7.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.7.0
 - !ruby/object:Gem::Dependency
   name: activejob
   requirement: !ruby/object:Gem::Requirement
@@ -66,20 +79,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7.1'
+- !ruby/object:Gem::Dependency
+  name: actionmailer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '7.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: chaotic_job
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: combustion
   requirement: !ruby/object:Gem::Requirement
@@ -199,6 +226,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codacy.yml"
 - ".github/FUNDING.yml"
 - ".github/workflows/main.yml"
 - ".gitignore"
@@ -249,7 +277,6 @@ metadata:
   source_code_uri: https://github.com/fractaledmind/acidic_job
   changelog_uri: https://github.com/fractaledmind/acidic_job/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -264,8 +291,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.21
-signing_key:
+rubygems_version: 3.6.3
 specification_version: 4
 summary: Idempotent operations for Rails apps, built on top of ActiveJob.
 test_files: []