acidic_job 1.0.0.pre5 → 1.0.0.pre6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8a9a11bcedbc8703e24c32db6474dfe963d8f97120c88c90dc4712026142d61
-  data.tar.gz: c558f6b90c1044c1320efc018fe4f9886f4af7ebab6a0c1fa8a991232e2b4065
+  metadata.gz: 9247c761078c570dfbacac2542bc8b7417c816bb9928f975bf7b92722a29f6a4
+  data.tar.gz: 8d36bb7517db0493d37eaf44aee901339a5d8d77411cad0e55fefe2d940137c6
 SHA512:
-  metadata.gz: a9aef4b22eb6ee7860badda470c379d19395c60bc40072085ea3eae6ea140fd77103a07cf142a88310d90f67736300ceb3a755fe3f4283488caf36a7f872baf6
-  data.tar.gz: 8e1b7d428bc44f83274c3f64454d34c3467e7e701088aee862b71aec55c534a527d7d2e7e7a83fee4a94abe953284a092e8df24b55ae5c7fd195d8df968beb8f
+  metadata.gz: 47697f8b833d7061bacb2b6eaf1e6c15a9d6fec700db0891f881b8f945cf271e1c37adba9cde4572aed5d0e272767a690c172ece0937dbc212a90bc0dd02e8e5
+  data.tar.gz: cda551ac7a76a63199f03b19e7787ba0bfae414253b1e71b098b8304705458d0c8f21b1755f9f10c15b651d55b849469284754d6e585d13159ee4c28a17ed723

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    acidic_job (1.0.0.pre5)
+    acidic_job (1.0.0.pre6)
       activerecord (>= 6.1.0)
       activesupport
 
@@ -122,6 +122,8 @@ GEM
     nokogiri (1.12.3)
       mini_portile2 (~> 2.6.1)
       racc (~> 1.4)
+    nokogiri (1.12.3-x86_64-darwin)
+      racc (~> 1.4)
     noticed (1.5.7)
       http (>= 4.0.0)
       rails (>= 5.2.0)

data/UPGRADE_GUIDE.md

@@ -1,10 +1,10 @@
 # AcidicJob Upgrade Guide
 
-1. Update version requirements in `Gemfile`
+## 1. Update version requirements in `Gemfile`
 
-```ruby
--gem "acidic_job"
-+gem "acidic_job", "~> 1.0.0.pre1"
+```diff
+- gem "acidic_job"
++ gem "acidic_job", "~> 1.0.0.pre1"
 ```
 
 result:
@@ -13,7 +13,7 @@ Installing acidic_job 1.0.0.pre4 (was 0.7.7)
 Bundle updated!
 ```
 
-2. Generate migration for new `AcidicJob::Run` model
+## 2. Generate migration for new `AcidicJob::Run` model
 
 ```bash
 rails generate acidic_job
@@ -24,7 +24,7 @@ result:
 create  db/migrate/#{yyyymmddhhmmss}_create_acidic_job_runs.rb
 ```
 
-3. Delete any unneeded `AcidicJob::Key` records
+## 3. Delete any unneeded `AcidicJob::Key` records
 
 Typically, records that are already finished do not need to be retained. Sometimes, however, applications key finished records around for some amount of time for debugging or metrics aggregation. Whatever your application's logic is for whether or not an `AcidicJob::Key` record is still needed, for all unneeded records, delete them.
 
@@ -34,7 +34,7 @@ For example, this would delete all finished `Key` records over 1 month old:
 AcidicJob::Key.where(recovery_point: AcidicJob::Key::RECOVERY_POINT_FINISHED, last_run_at: ..1.month.ago).delete_all
 ```
 
-4. Migrate `AcidicJob::Key` to `AcidicJob::Run`
+## 4. Migrate `AcidicJob::Key` to `AcidicJob::Run`
 
 `AcidicJob` ships with an upgrade module that provides a script to migrate older `Key` records to the new `Run` model.
 
@@ -47,21 +47,21 @@ This script will prepare an `insert_all` command for `Run` records by mapping th
 result:
 ```
 {
-	run_records: <Integer>,
-	key_records: <Integer>,
-	errored_keys: <Array>
+  run_records: <Integer>,
+  key_records: <Integer>,
+  errored_keys: <Array>
 }
 ```
 
-5. Triage remaining `AcidicJob::Key` records
+## 5. Triage remaining `AcidicJob::Key` records
 
 If there were any `AcidicJob::Key` records that failed to be mapped to the new `Run` model, you will need to manually triage whatever the exception was. In all likelihood, the exception would be relating to the translation of the `Key#job_args` field to the `Run#serialized_job` field, as all other fields have a fairly straight-forward mapping. If you can't resolve the issue, please open an Issue in GitHub.
 
-6. Ensure all `AcidicJob::Staged` records are processed
+## 6. Ensure all `AcidicJob::Staged` records are processed
 
 `AcidicJob` still ships with an upgrade module that provides the older `Key` and `Staged` records, so this functionality will still be present to handle any existing records in your database when you deploy the updated version.
 
-7. Remove the old tables
+## 7. Remove the old tables
 
 Once you have successfully migrated everything over and the new system has been running smoothly for some time, you should drop the old `acidic_job_keys` and `staged_acidic_jobs` tables. We provide a migration generator just for this purpose:
 
@@ -78,4 +78,4 @@ You can then run the migration to have those tables removed:
 
 ```bash
 rails db:migrate
-```
+```

data/lib/acidic_job/run.rb

@@ -35,6 +35,19 @@ module AcidicJob
       validates :workflow, presence: true
     end
 
+    def self.purge
+      successfully_completed = where(
+        recovery_point: FINISHED_RECOVERY_POINT,
+        error_object: nil
+      )
+      count = successfully_completed.count
+
+      return 0 if count.zero?
+
+      Rails.logger.info("Deleting #{count} successfully completed AcidicJob runs")
+      successfully_completed.delete_all
+    end
+
     def finished?
       recovery_point == FINISHED_RECOVERY_POINT
     end

data/lib/acidic_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AcidicJob
-  VERSION = "1.0.0.pre5"
+  VERSION = "1.0.0.pre6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acidic_job
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre5
+  version: 1.0.0.pre6
 platform: ruby
 authors:
 - fractaledmind
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-03-03 00:00:00.000000000 Z
+date: 2022-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord