acidic_job 0.8.5 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54586a38aa48a14ef168657659a81b0db14446d011bd76085641dd4fb21f7838
-  data.tar.gz: 849af5f8e34684cd22d454f85ac816e749c3a4dd91ba58dba34ce67931916d3c
+  metadata.gz: 153e6365b6a1f1fd5aafca127047a04571c0c9a45f3320c4e17c347b7cbe84b8
+  data.tar.gz: 94238767a6f1d7066650ac117cdc7eff2cc2aac88f643b697391c411477dc1e1
 SHA512:
-  metadata.gz: fe54d708708a8316020979400dda7afd73480d34597f9416b30218b7307d8e4ce3cfbf65e14e05681810de88e21d131f06f4a3f72549a7dedef62be209b3137d
-  data.tar.gz: 58ba97af8e30c9bff0df8cf4015a3920ce722a5242048469b2224a4d9ca32c67971f03792862c2548515adc33b8407309c386ab1ff1dd509735f420029c11085
+  metadata.gz: d55ffb8c2888bb83188042a74bf95b90d70dd4c541e92308f7f1e7008f13a63261e635fe280ea1f191fd4f6645e4ed99cfe26c3e63ac3d7b61b60fb1fde9ac0c
+  data.tar.gz: d773d20887dcf3894bb005a827c8a2ccb80bb1392a34290ddf6cc4e8afaf703b331c56b1246d9059c58900cdc12a23e678b2ef1cc89537878b914a932b9f495c

data/.github/workflows/main.yml

@@ -9,9 +9,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ["2.7", "3.0", "3.1"]
+        ruby: ["2.7", "3.0", "3.1", "3.2"]
         rails: ["6.1", "7.0"]
-        sidekiq: ["6.4", "6.5"]
+        sidekiq: ["6.4", "6.5", "7.0"]
     services:
       redis:
         image: redis
@@ -27,7 +27,7 @@ jobs:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails }}_sidekiq_${{ matrix.sidekiq }}.gemfile
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Set up Ruby
       # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,

data/.rubocop.yml

@@ -13,6 +13,9 @@ Style/StringLiteralsInInterpolation:
 Layout/LineLength:
   Max: 120
 
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
 Style/Documentation:
   Enabled: false
 
@@ -35,4 +38,4 @@ Metrics/PerceivedComplexity:
   Enabled: false
 
 Metrics/ClassLength:
-  Enabled: false
+  Enabled: false

data/.tool-versions

@@ -1 +1 @@
-ruby 3.1.1
+ruby 3.1.4

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    acidic_job (0.8.5)
+    acidic_job (0.8.7)
       activejob
       activerecord
       activesupport
@@ -9,94 +9,94 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (7.0.3.1)
-      actionpack (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
+    actioncable (7.0.4.3)
+      actionpack (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
-    actionmailbox (7.0.3.1)
-      actionpack (= 7.0.3.1)
-      activejob (= 7.0.3.1)
-      activerecord (= 7.0.3.1)
-      activestorage (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
+    actionmailbox (7.0.4.3)
+      actionpack (= 7.0.4.3)
+      activejob (= 7.0.4.3)
+      activerecord (= 7.0.4.3)
+      activestorage (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
       mail (>= 2.7.1)
       net-imap
       net-pop
       net-smtp
-    actionmailer (7.0.3.1)
-      actionpack (= 7.0.3.1)
-      actionview (= 7.0.3.1)
-      activejob (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
+    actionmailer (7.0.4.3)
+      actionpack (= 7.0.4.3)
+      actionview (= 7.0.4.3)
+      activejob (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
       mail (~> 2.5, >= 2.5.4)
       net-imap
       net-pop
       net-smtp
       rails-dom-testing (~> 2.0)
-    actionpack (7.0.3.1)
-      actionview (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
+    actionpack (7.0.4.3)
+      actionview (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
       rack (~> 2.0, >= 2.2.0)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actiontext (7.0.3.1)
-      actionpack (= 7.0.3.1)
-      activerecord (= 7.0.3.1)
-      activestorage (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
+    actiontext (7.0.4.3)
+      actionpack (= 7.0.4.3)
+      activerecord (= 7.0.4.3)
+      activestorage (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
       globalid (>= 0.6.0)
       nokogiri (>= 1.8.5)
-    actionview (7.0.3.1)
-      activesupport (= 7.0.3.1)
+    actionview (7.0.4.3)
+      activesupport (= 7.0.4.3)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activejob (7.0.3.1)
-      activesupport (= 7.0.3.1)
+    activejob (7.0.4.3)
+      activesupport (= 7.0.4.3)
       globalid (>= 0.3.6)
-    activemodel (7.0.3.1)
-      activesupport (= 7.0.3.1)
-    activerecord (7.0.3.1)
-      activemodel (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
-    activestorage (7.0.3.1)
-      actionpack (= 7.0.3.1)
-      activejob (= 7.0.3.1)
-      activerecord (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
+    activemodel (7.0.4.3)
+      activesupport (= 7.0.4.3)
+    activerecord (7.0.4.3)
+      activemodel (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
+    activestorage (7.0.4.3)
+      actionpack (= 7.0.4.3)
+      activejob (= 7.0.4.3)
+      activerecord (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
       marcel (~> 1.0)
       mini_mime (>= 1.1.0)
-    activesupport (7.0.3.1)
+    activesupport (7.0.4.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
+    addressable (2.8.4)
+      public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
     builder (3.2.4)
     combustion (1.3.7)
       activesupport (>= 3.0.0)
       railties (>= 3.0.0)
       thor (>= 0.14.6)
-    concurrent-ruby (1.1.10)
-    connection_pool (2.2.5)
+    concurrent-ruby (1.2.2)
+    connection_pool (2.4.0)
     crass (1.0.6)
-    digest (3.1.0)
+    date (3.3.3)
     docile (1.4.0)
     domain_name (0.5.20190701)
       unf (>= 0.0.5, < 1.0.0)
-    erubi (1.10.0)
+    erubi (1.12.0)
     ffi (1.15.5)
     ffi-compiler (1.0.1)
       ffi (>= 1.0.0)
       rake
-    globalid (1.0.0)
+    globalid (1.1.0)
       activesupport (>= 5.0)
-    http (5.1.0)
+    http (5.1.1)
       addressable (~> 2.8)
       http-cookie (~> 1.0)
       http-form_data (~> 2.2)
@@ -106,123 +106,124 @@ GEM
     http-form_data (2.3.0)
     i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    json (2.6.2)
+    json (2.6.3)
     llhttp-ffi (0.4.0)
       ffi-compiler (~> 1.0)
       rake (~> 13.0)
-    loofah (2.18.0)
+    loofah (2.20.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
-    mail (2.7.1)
+    mail (2.8.1)
       mini_mime (>= 0.1.1)
+      net-imap
+      net-pop
+      net-smtp
     marcel (1.0.2)
     method_source (1.0.0)
     mini_mime (1.1.2)
-    mini_portile2 (2.8.0)
-    minitest (5.16.2)
-    net-imap (0.2.3)
-      digest
+    mini_portile2 (2.8.1)
+    minitest (5.18.0)
+    net-imap (0.3.4)
+      date
       net-protocol
-      strscan
-    net-pop (0.1.1)
-      digest
+    net-pop (0.1.2)
       net-protocol
+    net-protocol (0.2.1)
       timeout
-    net-protocol (0.1.3)
-      timeout
-    net-smtp (0.3.1)
-      digest
+    net-smtp (0.3.3)
       net-protocol
-      timeout
-    nio4r (2.5.8)
-    nokogiri (1.13.7)
+    nio4r (2.5.9)
+    nokogiri (1.14.3)
       mini_portile2 (~> 2.8.0)
       racc (~> 1.4)
-    nokogiri (1.13.7-x86_64-darwin)
+    nokogiri (1.14.3-x86_64-darwin)
       racc (~> 1.4)
-    noticed (1.5.9)
+    noticed (1.6.0)
       http (>= 4.0.0)
       rails (>= 5.2.0)
     parallel (1.22.1)
-    parser (3.1.2.0)
+    parser (3.2.2.0)
       ast (~> 2.4.1)
-    public_suffix (4.0.7)
-    racc (1.6.0)
-    rack (2.2.4)
-    rack-test (2.0.2)
+    public_suffix (5.0.1)
+    racc (1.6.2)
+    rack (2.2.6.4)
+    rack-test (2.1.0)
       rack (>= 1.3)
-    rails (7.0.3.1)
-      actioncable (= 7.0.3.1)
-      actionmailbox (= 7.0.3.1)
-      actionmailer (= 7.0.3.1)
-      actionpack (= 7.0.3.1)
-      actiontext (= 7.0.3.1)
-      actionview (= 7.0.3.1)
-      activejob (= 7.0.3.1)
-      activemodel (= 7.0.3.1)
-      activerecord (= 7.0.3.1)
-      activestorage (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
+    rails (7.0.4.3)
+      actioncable (= 7.0.4.3)
+      actionmailbox (= 7.0.4.3)
+      actionmailer (= 7.0.4.3)
+      actionpack (= 7.0.4.3)
+      actiontext (= 7.0.4.3)
+      actionview (= 7.0.4.3)
+      activejob (= 7.0.4.3)
+      activemodel (= 7.0.4.3)
+      activerecord (= 7.0.4.3)
+      activestorage (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
       bundler (>= 1.15.0)
-      railties (= 7.0.3.1)
+      railties (= 7.0.4.3)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
-    rails-html-sanitizer (1.4.3)
-      loofah (~> 2.3)
-    railties (7.0.3.1)
-      actionpack (= 7.0.3.1)
-      activesupport (= 7.0.3.1)
+    rails-html-sanitizer (1.5.0)
+      loofah (~> 2.19, >= 2.19.1)
+    railties (7.0.4.3)
+      actionpack (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
       method_source
       rake (>= 12.2)
       thor (~> 1.0)
       zeitwerk (~> 2.5)
     rainbow (3.1.1)
     rake (13.0.6)
-    redis (4.7.1)
-    regexp_parser (2.5.0)
+    redis-client (0.14.1)
+      connection_pool
+    regexp_parser (2.8.0)
     rexml (3.2.5)
-    rubocop (1.31.2)
+    rubocop (1.50.2)
       json (~> 2.3)
       parallel (~> 1.10)
-      parser (>= 3.1.0.0)
+      parser (>= 3.2.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.18.0, < 2.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.19.1)
-      parser (>= 3.1.1.0)
-    rubocop-minitest (0.20.1)
-      rubocop (>= 0.90, < 2.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.28.0)
+      parser (>= 3.2.1.0)
+    rubocop-minitest (0.30.0)
+      rubocop (>= 1.39, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    ruby-progressbar (1.11.0)
-    sidekiq (6.5.3)
-      connection_pool (>= 2.2.2)
-      rack (~> 2.0)
-      redis (>= 4.5.0)
-    simplecov (0.21.2)
+    ruby-progressbar (1.13.0)
+    sidekiq (7.0.8)
+      concurrent-ruby (< 2)
+      connection_pool (>= 2.3.0)
+      rack (>= 2.2.4)
+      redis-client (>= 0.11.0)
+    simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
-    sqlite3 (1.4.4)
-    strscan (3.0.3)
+    sqlite3 (1.6.2)
+      mini_portile2 (~> 2.8.0)
+    sqlite3 (1.6.2-x86_64-darwin)
     thor (1.2.1)
-    timeout (0.3.0)
-    tzinfo (2.0.4)
+    timeout (0.3.2)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.8.2)
-    unicode-display_width (2.2.0)
+    unicode-display_width (2.4.2)
     websocket-driver (0.7.5)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
-    zeitwerk (2.6.0)
+    zeitwerk (2.6.7)
 
 PLATFORMS
   ruby

data/README.md

@@ -238,7 +238,7 @@ class RideCreateJob < AcidicJob::Base
   end
 
   def create_ride_and_audit_record
-    self.ride = Ride.create!
+    self.ride = @user.rides.create(@params)
   end
 
   def create_stripe_charge
@@ -419,6 +419,23 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+You can run a specific combination of Rails version and Sidekiq version using one of the Gemfiles defined in the `/gemfiles` directory via the `BUNDLE_GEMFILE` ENV variable, e.g.:
+```sh
+BUNDLE_GEMFILE=gemfiles/rails_7.0_sidekiq_6.5.gemfile bundle exec rake test
+```
+
+You can likewise test only one particular test file using the `TEST` ENV variable, e.g.:
+```sh
+TEST=test/acidic_job/extensions/noticed_test.rb
+```
+
+Finally, if you need to only run one particular test case itself, use the `TESTOPTS` ENV variable with the `--name` option, e.g.:
+```sh
+TESTOPTS="--name=test_deliver_acidicly_on_noticed_notification_with_only_database_delivery"
+```
+
+These options can of course be combined to help narrow down your debugging when you find a failing test in CI.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/acidic_job.

data/gemfiles/rails_6.1_sidekiq_7.0.gemfile

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+gem "activemodel", "~> 6.1.0"
+gem "railties", "~> 6.1.0"
+
+gem "sidekiq", "~> 7.0.0"
+
+gemspec path: "../"

data/gemfiles/rails_7.0_sidekiq_7.0.gemfile

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+gem "activemodel", "~> 7.0.0"
+gem "railties", "~> 7.0.0"
+
+gem "sidekiq", "~> 7.0.0"
+
+gemspec path: "../"

data/gemfiles/rails_7.1_sidekiq_7.0.gemfile

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+gem "activemodel", "~> 7.1.0"
+gem "railties", "~> 7.1.0"
+
+gem "sidekiq", "~> 7.0.0"
+
+gemspec path: "../"

data/lib/acidic_job/perform_wrapper.rb

@@ -4,7 +4,7 @@ module AcidicJob
   # NOTE: it is essential that this be a bare module and not an ActiveSupport::Concern
   # WHY?
   module PerformWrapper
-    def perform(*args)
+    ruby2_keywords def perform(*args)
       @arguments = args
 
       # we don't want to run the `perform` callbacks twice, since ActiveJob already handles that for us

data/lib/acidic_job/{rails.rb → railtie.rb}

@@ -3,7 +3,7 @@
 require "rails/railtie"
 
 module AcidicJob
-  class Rails < ::Rails::Railtie
+  class Railtie < ::Rails::Railtie
     initializer "acidic_job.action_mailer_extension" do
       ::ActiveSupport.on_load(:action_mailer) do
         # Add `deliver_acidicly` to ActionMailer

data/lib/acidic_job/run.rb

@@ -15,6 +15,10 @@ module AcidicJob
     STAGED_JOB_ID_PREFIX = "STG"
     STAGED_JOB_ID_DELIMITER = "__"
     IDEMPOTENCY_KEY_LOCK_TIMEOUT_SECONDS = 2
+    RAILS_VERSION = Gem::Version.new(Rails.version)
+    TARGET_VERSION = Gem::Version.new("7.1")
+    REQUIRES_CODER_FOR_SERIALIZE = RAILS_VERSION >= TARGET_VERSION ||
+                                   RAILS_VERSION.segments[..1] == TARGET_VERSION.segments
 
     self.table_name = "acidic_job_runs"
 
@@ -47,7 +51,11 @@ module AcidicJob
 
         after_update_commit :proceed_with_parent, if: :finished?
 
-        serialize :returning_to, AcidicJob::Serializer
+        if REQUIRES_CODER_FOR_SERIALIZE
+          serialize :returning_to, coder: AcidicJob::Serializer
+        else
+          serialize :returning_to, AcidicJob::Serializer
+        end
       end
 
       class_methods do
@@ -142,8 +150,13 @@ module AcidicJob
 
     concerning :Workflowable do
       included do
-        serialize :workflow, AcidicJob::Serializer
-        serialize :error_object, AcidicJob::Serializer
+        if REQUIRES_CODER_FOR_SERIALIZE
+          serialize :workflow, coder: AcidicJob::Serializer
+          serialize :error_object, coder: AcidicJob::Serializer
+        else
+          serialize :workflow, AcidicJob::Serializer
+          serialize :error_object, AcidicJob::Serializer
+        end
         store :attr_accessors, coder: AcidicJob::Serializer
 
         with_options unless: :staged? do
@@ -188,7 +201,11 @@ module AcidicJob
 
     concerning :Jobbable do
       included do
-        serialize :serialized_job, JSON
+        if REQUIRES_CODER_FOR_SERIALIZE
+          serialize :serialized_job, coder: JSON
+        else
+          serialize :serialized_job, JSON
+        end
 
         validates :serialized_job, presence: true
         validates :job_class, presence: true

data/lib/acidic_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AcidicJob
-  VERSION = "0.8.5"
+  VERSION = "0.8.7"
 end

data/lib/acidic_job.rb

@@ -31,7 +31,7 @@ require_relative "acidic_job/serializers/recovery_point_serializer"
 require_relative "acidic_job/serializers/worker_serializer"
 require_relative "acidic_job/serializers/active_kiq_serializer"
 
-require_relative "acidic_job/rails"
+require_relative "acidic_job/railtie"
 
 module AcidicJob
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acidic_job
 version: !ruby/object:Gem::Version
-  version: 0.8.5
+  version: 0.8.7
 platform: ruby
 authors:
 - fractaledmind
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-08-31 00:00:00.000000000 Z
+date: 2023-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -245,10 +245,13 @@ files:
 - combustion/log/test.log
 - gemfiles/rails_6.1_sidekiq_6.4.gemfile
 - gemfiles/rails_6.1_sidekiq_6.5.gemfile
+- gemfiles/rails_6.1_sidekiq_7.0.gemfile
 - gemfiles/rails_7.0_sidekiq_6.4.gemfile
 - gemfiles/rails_7.0_sidekiq_6.5.gemfile
+- gemfiles/rails_7.0_sidekiq_7.0.gemfile
 - gemfiles/rails_7.1_sidekiq_6.4.gemfile
 - gemfiles/rails_7.1_sidekiq_6.5.gemfile
+- gemfiles/rails_7.1_sidekiq_7.0.gemfile
 - lib/acidic_job.rb
 - lib/acidic_job/active_kiq.rb
 - lib/acidic_job/arguments.rb
@@ -264,7 +267,7 @@ files:
 - lib/acidic_job/perform_acidicly.rb
 - lib/acidic_job/perform_wrapper.rb
 - lib/acidic_job/processor.rb
-- lib/acidic_job/rails.rb
+- lib/acidic_job/railtie.rb
 - lib/acidic_job/recovery_point.rb
 - lib/acidic_job/run.rb
 - lib/acidic_job/serializer.rb
@@ -308,7 +311,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: Idempotent operations for Rails apps, built on top of ActiveJob.