acidic_job 0.5.5 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79d8997dd3c0922319cbfc2408804a935e302a74c6fc0664811dce1a59bb272d
-  data.tar.gz: bfce5d294e9831fff9e40fc8b6aa1cda59eb31262640f2530906b30b21ceea79
+  metadata.gz: 739d9a393b9dfcf91c6e941e188cab965a2800cf7a729e70a5d30542c76b1237
+  data.tar.gz: 6fb81e32e31e6db7001a11d607f33d3bc7f1cb5ddc147d48f8ead84ae15fc7d1
 SHA512:
-  metadata.gz: c97fed527770260bfd63f1ef3702419c81168e9b2f08da603ed22e328d22f85dc0a745bdc523725317ac3ac77fa4a3005581cd82a7bc85cd573552ba158e473f
-  data.tar.gz: 1e5a63b40b7e6b98e10bf9c98db06686b0468fd559ccdd0834309b2a2e5e40c4d9366632806c845e72cb43924fb34059155d67b2fa5bd5717ed5f6c523589082
+  metadata.gz: bc2d1796950ffb4640d49dc61e05771b2a72f6b6776d96dda4fa35f93720e0687102e08bc8ad39a176d44be828528048df03c4492cbd0b1d121865ef929e5b8f
+  data.tar.gz: 32db6d94ca8a8a70d48a7afa863f85f50ebdf05320c9461b1f8c647d4681e697d7d5bc814864fb8846b516482db7057e8659598387f661e43764115f1525e840

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    acidic_job (0.5.5)
+    acidic_job (0.6.0)
       activerecord (>= 4.0.0)
       activesupport
 

data/lib/acidic_job/perform_transactionally_extension.rb

@@ -9,13 +9,13 @@ module AcidicJob
     class_methods do
       # rubocop:disable Metrics/MethodLength
       def perform_transactionally(*args)
-        attributes = if self < ActiveJob::Base
+        attributes = if defined?(ActiveJob) && self < ActiveJob::Base
                        {
                          adapter: "activejob",
                          job_name: name,
                          job_args: job_or_instantiate(*args).serialize
                        }
-                     elsif include? Sidekiq::Worker
+                     elsif defined?(Sidekiq) && include?(Sidekiq::Worker)
                        {
                          adapter: "sidekiq",
                          job_name: name,

data/lib/acidic_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AcidicJob
-  VERSION = "0.5.5"
+  VERSION = "0.6.0"
 end

data/lib/acidic_job.rb

@@ -67,6 +67,7 @@ module AcidicJob
 
     # set accessors for each argument passed in to ensure they are available
     # to the step methods the job will have written
+    # THIS HAPPENS OUTSIDE OF ANY TRANSACTION
     define_accessors_for_passed_arguments(with, @key)
 
     # otherwise, we will enter a loop to process each required step of the job
@@ -141,7 +142,7 @@ module AcidicJob
     ActiveRecord::Base.transaction(isolation: isolation_level) do
       @key = Key.find_by(idempotency_key: key_val)
 
-      if @key
+      if @key.present?
         # Programs enqueuing multiple jobs with different parameters but the
         # same idempotency key is a bug.
         raise MismatchedIdempotencyKeyAndJobArguments if @key.job_args != @arguments_for_perform
@@ -215,8 +216,7 @@ module AcidicJob
     return job_id if defined?(job_id) && !job_id.nil?
     return jid if defined?(jid) && !jid.nil?
 
-    require "securerandom"
-    SecureRandom.hex
+    Digest::SHA1.hexdigest [self.class.name, arguments_for_perform].flatten.join
   end
 end
 # rubocop:enable Metrics/ModuleLength, Metrics/AbcSize, Metrics/MethodLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acidic_job
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 0.6.0
 platform: ruby
 authors:
 - fractaledmind
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-10-13 00:00:00.000000000 Z
+date: 2021-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord