acidic_job 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8aa8aee9c23bc58be992813f139864afdb057442ee9c359263f3ff45029e3f28
-  data.tar.gz: 9dbb8017fcbf91ce5cbcc5c96968e3b880340c1e1cc7a8c36cb11e744d6b405d
+  metadata.gz: 82e7abf5e57a4a6b68691e3c6c69ee8a6bbc2eabcedb69a3ef29e91ac0e99e8c
+  data.tar.gz: b73584561b8a558529b2e057e449896dedfff2c21ab859dacf82b070f75c7910
 SHA512:
-  metadata.gz: 4bb2298f924a2aa2d5db31c7c05201188872333c36dd3e0bafb598ed087ec9a686695c27b1cdd2d33f067f2bbb47178c5bc700201406db856392997ef6605dbc
-  data.tar.gz: f842586dc2d669196ce58bcbc279bc2b967fd0c8973d296323622c993e8d08422ce65f55b85cf96407aa4a668af15dea005fdf3f8917e520ca020c2851dd4bfa
+  metadata.gz: 6e42251e87faff4790ecfba572eca0dd70251fc58a4293b906560b526efa4bc14db00e01ee0e90c43a0d3f3dc355b36b8db3a4be5129529c071711f3a0b2506f
+  data.tar.gz: 167aa9f07dd033a5a3646edcff171a8dffea485d9cbb943c230526214c6d4eaa68761418321cc4e7795a0326361699181bd142377516ceadaa430d286628aea5

data/.rubocop.yml

@@ -12,3 +12,6 @@ Style/StringLiteralsInInterpolation:
 
 Layout/LineLength:
   Max: 120
+
+Style/Documentation:
+  Enabled: false

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    acidic_job (0.3.1)
+    acidic_job (0.4.0)
       activerecord (>= 4.0.0)
       activesupport
 

data/acidic_job.gemspec

@@ -27,8 +27,8 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activesupport"
   spec.add_dependency "activerecord", ">= 4.0.0"
+  spec.add_dependency "activesupport"
   spec.add_development_dependency "railties", ">= 4.0"
 
   # For more information and examples about making a new gem, checkout our

data/lib/acidic_job/key.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module AcidicJob
+  class Key < ActiveRecord::Base
+    RECOVERY_POINT_FINISHED = "FINISHED"
+
+    self.table_name = "acidic_job_keys"
+
+    serialize :error_object
+    serialize :job_args
+
+    validates :idempotency_key, presence: true, uniqueness: { scope: %i[job_name job_args] }
+    validates :job_name, presence: true
+    validates :last_run_at, presence: true
+    validates :recovery_point, presence: true
+
+    def finished?
+      recovery_point == RECOVERY_POINT_FINISHED
+    end
+
+    def succeeded?
+      finished? && !failed?
+    end
+
+    def failed?
+      error_object.present?
+    end
+  end
+end

data/lib/acidic_job/staging.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module AcidicJob
+  class Staging < ActiveRecord::Base
+    self.table_name = "acidic_job_stagings"
+
+    validates :serialized_params, presence: true
+
+    serialize :serialized_params
+
+    after_create_commit :enqueue_job
+
+    def enqueue_job
+      job = ActiveJob::Base.deserialize(serialized_params)
+      job.enqueue
+      delete
+    end
+  end
+end

data/lib/acidic_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AcidicJob
-  VERSION = "0.3.1"
+  VERSION = "0.4.0"
 end

data/lib/acidic_job.rb

@@ -4,9 +4,11 @@ require_relative "acidic_job/version"
 require_relative "acidic_job/no_op"
 require_relative "acidic_job/recovery_point"
 require_relative "acidic_job/response"
+require_relative "acidic_job/key"
+require_relative "acidic_job/staging"
 require "active_support/concern"
 
-# rubocop:disable Metrics/ModuleLength, Style/Documentation, Metrics/AbcSize, Metrics/MethodLength
+# rubocop:disable Metrics/ModuleLength, Metrics/AbcSize, Metrics/MethodLength
 module AcidicJob
   class MismatchedIdempotencyKeyAndJobArguments < StandardError; end
 
@@ -18,43 +20,27 @@ module AcidicJob
 
   class SerializedTransactionConflict < StandardError; end
 
-  class Key < ActiveRecord::Base
-    RECOVERY_POINT_FINISHED = "FINISHED"
-
-    self.table_name = "acidic_job_keys"
-
-    serialize :error_object
-    serialize :job_args
-
-    validates :idempotency_key, presence: true, uniqueness: {scope: [:job_name, :job_args]}
-    validates :job_name, presence: true
-    validates :last_run_at, presence: true
-    validates :recovery_point, presence: true
-
-    def finished?
-      recovery_point == RECOVERY_POINT_FINISHED
-    end
+  extend ActiveSupport::Concern
 
-    def succeeded?
-      finished? && !failed?
-    end
+  module ActiveJobExtension
+    extend ActiveSupport::Concern
 
-    def failed?
-      error_object.present?
+    class_methods do
+      def perform_transactionally(*args)
+        AcidicJob::Staging.create!(
+          serialized_params: job_or_instantiate(*args).serialize
+        )
+      end
     end
   end
 
-  extend ActiveSupport::Concern
-
   included do
     attr_reader :key
 
-    # discard_on MismatchedIdempotencyKeyAndJobArguments
-    # discard_on UnknownRecoveryPoint
-    # discard_on UnknownAtomicPhaseType
-    # discard_on MissingRequiredAttribute
-    # retry_on LockedIdempotencyKey
-    # retry_on ActiveRecord::SerializationFailure
+    # Extend ActiveJob only once it has been loaded
+    ActiveSupport.on_load(:active_job) do
+      send(:include, ActiveJobExtension)
+    end
   end
 
   # Number of seconds passed which we consider a held idempotency key lock to be
@@ -64,7 +50,8 @@ module AcidicJob
   IDEMPOTENCY_KEY_LOCK_TIMEOUT = 90
 
   # &block
-  def idempotently(with:) # &block
+  # &block
+  def idempotently(with:)
     # set accessors for each argument passed in to ensure they are available
     # to the step methods the job will have written
     define_accessors_for_passed_arguments(with)
@@ -126,7 +113,7 @@ module AcidicJob
 
         phase_result.call(key: key)
       end
-    rescue => e
+    rescue StandardError => e
       error = e
       raise e
     ensure
@@ -134,7 +121,7 @@ module AcidicJob
       # key right away so that another request can try again.
       begin
         key.update_columns(locked_at: nil, error_object: error) if error.present?
-      rescue => e
+      rescue StandardError => e
         # We're already inside an error condition, so swallow any additional
         # errors from here and just send them to logs.
         puts "Failed to unlock key #{key.id} because of #{e}."
@@ -148,7 +135,7 @@ module AcidicJob
                         :read_uncommitted
                       else
                         :serializable
-    end
+                      end
     serialized_job_info = serialize
 
     ActiveRecord::Base.transaction(isolation: isolation_level) do
@@ -207,4 +194,4 @@ module AcidicJob
     end
   end
 end
-# rubocop:enable Metrics/ModuleLength, Style/Documentation, Metrics/AbcSize, Metrics/MethodLength
+# rubocop:enable Metrics/ModuleLength, Metrics/AbcSize, Metrics/MethodLength

data/lib/generators/acidic_job_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails/generators"
 require "rails/generators/active_record"
 
@@ -22,8 +24,8 @@ class AcidicJobGenerator < ActiveRecord::Generators::Base
 
   # Copies the migration template to db/migrate.
   def copy_files
-    migration_template "migration.rb",
-      "db/migrate/create_acidic_job_keys.rb"
+    migration_template "migration.rb.erb",
+                       "db/migrate/create_acidic_job_keys.rb"
   end
 
   protected

data/lib/generators/templates/{migration.rb → migration.rb.erb}

@@ -13,6 +13,9 @@ class CreateAcidicJobKeys < <%= migration_class %>
       t.index %i[idempotency_key job_name job_args],
         unique: true,
         name: "idx_acidic_job_keys_on_idempotency_key_n_job_name_n_job_args"
+
+    create_table :acidic_job_stagings do |t|
+      t.text :serialized_params, null: false
     end
   end
 end

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: acidic_job
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - fractaledmind
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-09-02 00:00:00.000000000 Z
+date: 2021-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -72,12 +72,14 @@ files:
 - bin/console
 - bin/setup
 - lib/acidic_job.rb
+- lib/acidic_job/key.rb
 - lib/acidic_job/no_op.rb
 - lib/acidic_job/recovery_point.rb
 - lib/acidic_job/response.rb
+- lib/acidic_job/staging.rb
 - lib/acidic_job/version.rb
 - lib/generators/acidic_job_generator.rb
-- lib/generators/templates/migration.rb
+- lib/generators/templates/migration.rb.erb
 homepage: https://github.com/fractaledmind/acidic_job
 licenses:
 - MIT