ach_client 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1592b86e14d743c487591e1a205a85ac072cf23a43e27a8dc8e6a7d8dd860acc
-  data.tar.gz: e4ad0a3ae01d345b4dbd8e224fd4d336737d297d82669af08a58d1b858c04dfc
+  metadata.gz: 2ebc1c8a970fae00ba2d286d1a44d9b21dccfe153943112cf5aa8c2b55684944
+  data.tar.gz: '0479726dff32adff969b8e5411aa4df9752d122ebc29dea6942bdf2afa894114'
 SHA512:
-  metadata.gz: 9a6cbf086b1b6424fcdd034a4131403c00d5e04bf74a01a86176b6c9ff0d24cc8e40020005b3bb06c194b9dd890999c08d82d2c79cd271e510d73cfe9975f910
-  data.tar.gz: 7130cdd271cecff3efd4297284ccca59d36985eca2868b1df9c3dc2ce1eed6d986b1b633127e025b8bea175387be9a25d5b4eaa1f925be27f847e5c6ff90bf96
+  metadata.gz: 6cac06e017d5919800b050cbd0f839e1b288df41391fe4876766f7c26c2d4bd5910755abfd41c44c17b41c5114e29b31ec6944fc8e197a36b6ce5ebba3ee5226
+  data.tar.gz: 440a98bc9db3ee2cc0158ecd05665e6c80105d6fd35d48becfe41de1cd69f97f9675d25449850294b8e040d5059f05e7567ff0d14914d5d0bc55c2a9817ecde2

data/lib/ach_client/providers/sftp/ach_transaction.rb

@@ -13,20 +13,36 @@ module AchClient
       # @return [ACH::EntryDetail] ACH gem's ach transaction record
       def to_entry_detail
         entry = ACH::EntryDetail.new
-        entry.transaction_code = transaction_code
-        entry.routing_number = routing_number
-        entry.account_number = account_number
+        entry.transaction_code = remove_newlines(transaction_code)
+        entry.routing_number = remove_newlines(routing_number)
+        entry.account_number = remove_newlines(account_number)
         entry.amount = amount_in_cents
-        entry.individual_id_number = external_ach_id # Doesn't need to be a number
-        entry.individual_name = merchant_name
-        entry.originating_dfi_identification =
+        entry.individual_id_number = remove_newlines(external_ach_id) # Doesn't need to be a number
+        entry.individual_name = remove_newlines(merchant_name)
+        entry.originating_dfi_identification = remove_newlines(
           self.class.parent.originating_dfi_identification
-        entry.trace_number = external_ach_id.gsub(/\D/, '').to_i # Does need to be a number
+        )
+        entry.trace_number = remove_non_digits(external_ach_id).to_i # Must be number
         entry
       end
 
       private
 
+      # Removes newlines from given string
+      # @param value [String] value to remove newline characters from
+      # @return [String] input value with no \n or \r characters
+      def remove_newlines(value)
+        value.gsub(/[\n\r]/, '')
+      end
+
+
+      # Removes non-digit characters from given string
+      # @param value [String] value to remove non-digit characters from
+      # @return [String] input value with no non-digit characters
+      def remove_non_digits(value)
+        value.gsub(/\D/, '')
+      end
+
       def amount_in_cents
         # Take absolute value in case amount is negative
         Helpers::DollarsToCents.dollars_to_cents(amount.abs)

data/lib/ach_client/version.rb

@@ -1,4 +1,4 @@
 module AchClient
   # Increment this when changes are published
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ach_client
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Zach Cotter
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-02 00:00:00.000000000 Z
+date: 2019-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ach