ach 0.4.8 → 0.4.9

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NzUzNDkyMzc0ZDk4ODk2MzhjZTY0MGE5Y2ZlMmFkNmE0NjZiNjVjNw==
-  data.tar.gz: !binary |-
-    YzQ4ZGQ1MTAwNGYwOTAxZTFlZDk1OGFkMjJhNDgzNGNiNzBjNWJiYQ==
+SHA1:
+  metadata.gz: c4049660c0f3f3ed764549f2ca4841153182b687
+  data.tar.gz: 4e0965b436351a9fa3b6362483e98a02b3a5791c
 SHA512:
-  metadata.gz: !binary |-
-    MjUwMTUwM2U4NmFkZDI3ZGVjMTgzMDRhZWZkNWMzY2IwYTJiNjU4MjA3YjU2
-    MzYwYjVhYzdkMDVmZDVlMzEyZDEwNWM0YmY4YTU3ODhiMjhmZTgxMWYwOGQ5
-    NmE0NjQxN2RjNTNhODIyYTg4ZWJjYTE5N2NlZTJiNmRhYjYyOGI=
-  data.tar.gz: !binary |-
-    ODFmY2MzYmM3NTlkMWMwNWU2OTAzYmU1ZTRlZDgyMGMzNzVlZmE5YjE0YzBj
-    NmZjNjhlN2VlNTI0MjNiYzU5NDZhZDU3YWNmYWU1MDFlODBmMGQzMmE4MGQ0
-    ZWQxZjI0ZWQxNjkwNTJlOWUyMjEwZDg5MmQ2OTViYzJiNDEzODY=
+  metadata.gz: 40dcf0cbeb86791665f58c43dd5caa6c53397dc1f3c31193e412aab997069f3ddc170d116645912528e7ffabeb8c1f4a46f00daa8af2d87946f96088cc913825
+  data.tar.gz: 1bcd9d3197f705d6ff97aa4556956494efd58b1ac48e7a2ffa7c9170a0403646e136a22748eeb047e0db318220cb5db6c19c7750f3f3883529899ac1b1b7ddd4

data/README.md

@@ -16,6 +16,8 @@ You should consult a copy of the [ACH Rules](http://www.nacha.org) for details
 on individual fields. You can probably obtain a copy from your bank.
 
 ```ruby
+require 'ach'
+
 # Create ACH file
 ach = ACH::ACHFile.new
 trace_number = 0

data/lib/ach/ach_file.rb

@@ -76,7 +76,6 @@ module ACH
     end
 
     def parse data
-      trace_number = 0
       fh =  self.header
       batch = nil
       bh = nil
@@ -140,7 +139,6 @@ module ACH
       end
 
       self.batches << batch unless batch.nil?
-      batch.entries.each{ |entry| entry.trace_number = (trace_number += 1) }
       to_s
     end
   end

data/lib/ach/records/batch_header.rb

@@ -25,7 +25,8 @@ module ACH::Records
         lambda { Time.now }
     field :effective_entry_date, Time,
         lambda { |f| f.strftime('%y%m%d')}
-    const_field :settlement_date, '   '
+    field :settlement_date, String,
+        lambda { |f| f.to_s }, '   ', /\A([0-9]{3}| {3})\z/
     const_field :originator_status_code, '1'
     field :originating_dfi_identification, String,
         nil, nil, /\A\d{8}\z/

data/lib/ach/records/entry_detail.rb

@@ -1,4 +1,6 @@
 module ACH::Records
+  # PPD Entry Detail. Some other entry details, such as CCD, are close enough
+  # to use this class. Version 1.x will have support for other types.
   class EntryDetail < Record
     CREDIT_RECORD_TRANSACTION_CODE_ENDING_DIGITS = ["0", "1", "2", "3", "4"]
 
@@ -18,6 +20,13 @@ module ACH::Records
     field :discretionary_data, String, lambda { |f| left_justify(f, 2)}, '  '
     field :addenda_record_indicator, Integer,
         lambda { |f| sprintf('%01d', f)}, 0
+    # There's not actually an originating DFI identification field for PPD
+    # entries. Instead, it is suggested by the ACH spec that the ODFI be used
+    # as the first 8 digits of the 15-digit trace number. I (Jared Morgan)
+    # initially decided to treat the two elements of the trace number as
+    # diffent fields, but that has caused confusion. I now intend to make this
+    # an optional field which can used in generating the trace number, although
+    # I haven't actually worked out how that will function.
     field :originating_dfi_identification, String,
         nil, nil, /\A\d{8}\z/
     field :trace_number, Integer, lambda { |f| sprintf('%07d', f)}, nil,

data/lib/ach/version.rb

@@ -1,3 +1,3 @@
 module ACH
-  VERSION = '0.4.8'.freeze
+  VERSION = '0.4.9'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ach
 version: !ruby/object:Gem::Version
-  version: 0.4.8
+  version: 0.4.9
 platform: ruby
 authors:
 - Jared Morgan
@@ -9,34 +9,34 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2015-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 description: ach is a Ruby helper for building and parsing ACH files. In particular,
@@ -51,7 +51,6 @@ files:
 - README.md
 - lib/ach.rb
 - lib/ach/ach_file.rb
-- lib/ach/ach_file.rb.orig
 - lib/ach/batch.rb
 - lib/ach/field_identifiers.rb
 - lib/ach/records/addendum.rb
@@ -72,17 +71,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Helper for building ACH files

data/lib/ach/ach_file.rb.orig

@@ -1,150 +0,0 @@
-require 'date'
-
-module ACH
-  class ACHFile
-    include FieldIdentifiers
-
-    attr_reader :batches
-    attr_reader :header
-    attr_reader :control
-
-    def initialize data=nil
-      @batches = []
-      @header = Records::FileHeader.new
-      @control = Records::FileControl.new
-
-      if data
-        if (data =~ /\n|\r\n/).nil?
-          parse_fixed(data)
-        else
-          parse(data)
-        end
-      end
-    end
-
-    def to_s
-      records = []
-      records << @header
-      @batches.each { |b| records += b.to_ach }
-      records << @control
-
-      nines_needed = 10 - (records.length % 10)
-      nines_needed = nines_needed % 10
-      nines_needed.times { records << Records::Nines.new() }
-
-      @control.batch_count = @batches.length
-      @control.block_count = (records.length / 10).ceil
-
-      @control.entry_count = 0
-      @control.debit_total = 0
-      @control.credit_total = 0
-      @control.entry_hash = 0
-
-      @batches.each do | batch |
-        @control.entry_count += batch.entries.length
-        @control.debit_total += batch.control.debit_total
-        @control.credit_total += batch.control.credit_total
-        @control.entry_hash += batch.control.entry_hash
-      end
-
-
-      records.collect { |r| r.to_ach }.join("\r\n") + "\r\n"
-    end
-
-    def report
-      to_s # To ensure correct records
-      lines = []
-
-      @batches.each do | batch |
-        batch.entries.each do | entry |
-          lines << left_justify(entry.individual_name + ": ", 25) +
-              sprintf("% 7d.%02d", entry.amount / 100, entry.amount % 100)
-        end
-      end
-      lines << ""
-      lines << left_justify("Debit Total: ", 25) +
-          sprintf("% 7d.%02d", @control.debit_total / 100, @control.debit_total % 100)
-      lines << left_justify("Credit Total: ", 25) +
-          sprintf("% 7d.%02d", @control.credit_total / 100, @control.credit_total % 100)
-
-      lines.join("\r\n")
-    end
-
-    def parse_fixed data
-      parse data.scan(/.{94}/).join("\n")
-    end
-
-    def parse data
-      trace_number = 0
-      fh =  self.header
-      batch = nil
-      bh = nil
-      ed = nil
-
-      data.strip.split(/\n|\r\n/).each do |line|
-        type = line[0].chr
-        case type
-        when '1'
-          fh.immediate_destination          = line[03..12].strip
-          fh.immediate_origin               = line[13..22].strip
-          fh.transmission_datetime          = Time.utc('20'+line[23..24], line[25..26], line[27..28], line[29..30], line[31..32])
-          fh.file_id_modifier               = line[33..33]
-          fh.immediate_destination_name     = line[40..62].strip
-          fh.immediate_origin_name          = line[63..85].strip
-          fh.reference_code                 = line[86..93].strip
-        when '5'
-          self.batches << batch unless batch.nil?
-          batch = ACH::Batch.new
-          bh = batch.header
-          bh.company_name                   = line[4..19].strip
-<<<<<<< HEAD
-          bh.company_identification         = line[40..49].strip.gsub(/\A1/, '')
-=======
-          bh.company_identification         = line[41..49]# .strip - do not strip need to preserve trailing spaces
->>>>>>> 2dd27ff1c45679b6544a088c4a21f2689123ddf8
-          bh.standard_entry_class_code      = line[50..52].strip
-          bh.company_entry_description      = line[53..62].strip
-          bh.company_descriptive_date       = Date.parse(line[63..68]) rescue nil # this can be various formats
-          bh.effective_entry_date           = Date.parse(line[69..74])
-          bh.originating_dfi_identification = line[79..86].strip
-        when '6'
-          ed = ACH::CtxEntryDetail.new
-          ed.transaction_code               = line[1..2]
-          ed.routing_number                 = line[3..11]
-          ed.account_number                 = line[12..28].strip
-          ed.amount                         = line[29..38].to_i # cents
-          ed.individual_id_number           = line[39..53].strip
-          ed.individual_name                = line[54..75].strip
-          ed.originating_dfi_identification = line[79..86]
-          ed.trace_number                   = line[87..93].to_i
-          batch.entries << ed
-        when '7'
-          type_code = line[1..2]
-          ad = case type_code
-          when '98'
-            ACH::Addendum::NotificationOfChange.new
-          when '99'
-            ACH::Addendum::Return.new
-          else
-            ACH::Addendum.new
-          end
-          ad.type_code                      = type_code
-          ad.payment_data                   = line[3..82].strip
-          ad.sequence_number                = line[83..86].strip.to_i
-          ad.entry_detail_sequence_number   = line[87..93].to_i
-          ed.addenda << ad
-        when '8'
-          # skip
-        when '9'
-          # skip
-        else
-          raise "Didn't recognize type code #{type} for this line:\n#{line}"
-        end
-      end
-
-      self.batches << batch unless batch.nil?
-      batch.entries.each{ |entry| entry.trace_number = (trace_number += 1) }
-      to_s
-    end
-  end
-end