acfs 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81eada64bf268a7ee4bdec316baf65e2f8ca0ac8cd80120474dfede36d4b4f51
-  data.tar.gz: b5a0d11f1eb60c8bfb16ccd66a8d7ee8f09fcaeea8976f47540239725a08d08b
+  metadata.gz: '099f37ed68e218d04f91c2f9f636e7b177b84feb8b8e0be4c4403da004937760'
+  data.tar.gz: bfbf0d3dc7f77eb38f16043051350a468baab870b3b002c35bc9f96df492eb07
 SHA512:
-  metadata.gz: 2cb0a9482b37b1a57bfad86f4213040d27babbf2cd6d4496a93b3260e50435ff1c575d57ba4a0d48b22ada2a3fbda44289283da1032fe3ecdc6010fe39f7646e
-  data.tar.gz: b21823474d56cdda6ca816f21d3f76674aa00a4d2636ec0dedc15deecd17469ef55716688306a654952bee4438b5ce338cc2471b4db644852daaa09e0b2bbc4c
+  metadata.gz: 29c45b69c95afd11cb58af0e02a383a2c1adcfeefb2521a917e1b7f6606a694c66fa0e2d56796e59127d453f4a1f95ab36c6a2e9a384657992b6a821c946c357
+  data.tar.gz: cba2e6df7a7988d2d06fc8ca303aa63875736c6d0fc6c0013ecbb36038b559bcfc085058c086468389905947aba375d6add11f3e8010ab2cff1b70628edd8770

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+
+
+## Unreleased
+---
+
+### New
+
+### Changes
+
+### Fixes
+
+### Breaks
+
+
+## 1.3.1 - (2019-07-02)
+---
+
+### Fixes
+* Improve URL argument encoding when building resource requests
+
 ## 1.3.0
 
 * Change default error messages to a more compact representation to ease integration with error reporting services.

data/acfs.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'rack'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'bundler'
 
   if ENV['TRAVIS_BUILD_NUMBER'] && !ENV['TRAVIS_TAG']
     # Append travis build number for auto-releases

data/lib/acfs/location.rb

@@ -33,7 +33,7 @@ module Acfs
 
     def str
       uri = raw.dup
-      uri.path = URI.escape '/' + struct.map {|s| lookup_arg(s, args) }.join('/')
+      uri.path = '/' + struct.map {|s| lookup_arg(s, args) }.join('/')
       uri.to_s
     end
 
@@ -58,7 +58,7 @@ module Acfs
 
     def lookup_replacement(sym, args)
       value = get_replacement(sym, args).to_s
-      return value unless value.empty?
+      return ::URI.encode_www_form_component(value) unless value.empty?
 
       raise ArgumentError.new "Cannot replace path argument `#{sym}' with empty string."
     end

data/lib/acfs/version.rb

@@ -2,7 +2,7 @@ module Acfs
   module VERSION
     MAJOR = 1
     MINOR = 3
-    PATCH = 0
+    PATCH = 1
     STAGE = nil
 
     STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.')

data/spec/acfs/location_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe ::Acfs::Location do
+  let(:location) { described_class.new(uri, args) }
+  let(:uri)      { 'http://localhost/users/:id' }
+  let(:args)     { {id: 4} }
+
+  describe '#str' do
+    subject(:str) { location.str }
+
+    it 'replaces variables with values' do
+      expect(str).to eq 'http://localhost/users/4'
+    end
+
+    context 'with special characters' do
+      let(:args) { {id: '4 [@(\/!^$'} }
+
+      it 'escapes special characters' do
+        expect(str).to eq 'http://localhost/users/4+%5B%40%28%5C%2F%21%5E%24'
+      end
+    end
+  end
+end

data/spec/acfs/resource/query_methods_spec.rb

@@ -398,7 +398,7 @@ describe Acfs::Resource::QueryMethods do
           expect(block).not_to receive(:call)
 
           model.find_by! age: 24, &block
-          expect { Acfs.run }.to raise_error
+          expect { Acfs.run }.to raise_error Acfs::ResourceNotFound
         end
       end
     end

data/spec/spec_helper.rb

@@ -1,11 +1,14 @@
 require 'rspec'
 require 'webmock/rspec'
 
-if ENV['CI'] || (defined?(:RUBY_ENGINE) && RUBY_ENGINE != 'rbx')
-  require 'coveralls'
-  Coveralls.wear! do
-    add_filter 'spec'
-  end
+require 'simplecov'
+SimpleCov.start do
+  add_filter 'spec'
+end
+
+if ENV['CI']
+  require 'codecov'
+  SimpleCov.formatter = SimpleCov::Formatter::Codecov
 end
 
 require 'bundler'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acfs
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-27 00:00:00.000000000 Z
+date: 2019-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -98,16 +98,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 description: API Client For Services
 email:
 - jg@altimos.de
@@ -174,6 +174,7 @@ files:
 - spec/acfs/collection_spec.rb
 - spec/acfs/configuration_spec.rb
 - spec/acfs/global_spec.rb
+- spec/acfs/location_spec.rb
 - spec/acfs/middleware/json_spec.rb
 - spec/acfs/middleware/msgpack_spec.rb
 - spec/acfs/operation_spec.rb
@@ -237,6 +238,7 @@ test_files:
 - spec/acfs/collection_spec.rb
 - spec/acfs/configuration_spec.rb
 - spec/acfs/global_spec.rb
+- spec/acfs/location_spec.rb
 - spec/acfs/middleware/json_spec.rb
 - spec/acfs/middleware/msgpack_spec.rb
 - spec/acfs/operation_spec.rb