acfs 0.29.0.1.b254 → 0.29.0.1.b256

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ODA1MDU2MWE0YTA2Y2Q0MzZhNTgxNmQ4YzIxOTQzOTNmNGExYjg0YQ==
+    NDkwYWEyMjJhMWQ1MDE4NjZkMTE1NWJlZWNiNjA1MTFlYTk4YjNiMg==
   data.tar.gz: !binary |-
-    ZjY0OTllYzNhOTNjNzEzMjg0YjRiY2E4Yzc1ZWRmNjIzZjkyNWFiYw==
+    YjdkYmRmMDZjYjQ0YzMxMDMwMTlhN2JiY2QxZDcwNGE5ODA0OGYwMA==
 SHA512:
   metadata.gz: !binary |-
-    MzUxNmIzMmNiYTRlOGJiYTgzNmRlYmExMDAzZDM2OWYyODAyODhmODM2ZGNh
-    ZmYzMzFmMGI3MDEzZDlkMGM2MzdiYWE5OTdkNmIyNzYzYmE1YTFkODM3NDFm
-    OTQzZjBiMzE5NDhkZTQ0Y2Y4YWY4MjgxMTk2ZGY4ZTBmMDRmMjk=
+    NmZlYjliNTRkYmViZDlhYzM4ZWE0YmNlMDk0NDI4M2YxNmE2NjNiZjZkMzA5
+    NWI1MzNlYThlOGYxOTk4M2U5YThiZDBjYWFhNzJmYTAxYjdjMDk3OTUyY2Ex
+    Y2ViOTA5YTVlNzA1YzIwZDE2YmQzMzY2YmMzYzQzYjViOThhOTI=
   data.tar.gz: !binary |-
-    MTcxOTQwYjllMTEwMDhlN2NiMWQ2YWZhY2I3ZTI0ZGEwMzAzYTNiYjkyYTY5
-    MGZjYTU2NDlhZDdlZWQzZjM0MjYxZWYxOWE0YTU2ODUyOWEwNTVjNjQ0NzBl
-    MDhkMTM5NTkwM2M1OTg0Y2RlMTc3YThhNTkwMjg5ZjZiNDlhN2Y=
+    MDZhZDY3MDY2Njc2ZWJiMmQwYzU2YzRmZWZkZDQwZjc1MzZiYzY0MTcwNDRm
+    NDJhODBmNmRmNGQzM2NkZjlmZTIzNjYyZjU0YzUyM2QxNGRkMDNlZTQ1YmM5
+    NGI2YjYzZDc4ODY1ZmFmYzYzZjkyOGZiNGJkYTliY2Q4YzNjZmI=

data/lib/acfs/errors.rb

@@ -96,7 +96,7 @@ module Acfs
     def initialize(opts = {})
       @base_class    = opts.delete :base_class
       @type_name     = opts.delete :type_name
-      opts[:message] = "Recieved ressource type #{type_name} is no subclass of #{base_class}"
+      opts[:message] = "Recieved ressource type `#{type_name}` is no subclass of #{base_class}"
       super
     end
   end

data/lib/acfs/model/query_methods.rb

@@ -179,6 +179,8 @@ module Acfs::Model
         klass = type.camelize.constantize
         raise Acfs::ResourceTypeError.new type_name: type, base_class: self unless klass <= self
         klass
+      rescue NameError, NoMethodError
+        raise Acfs::ResourceTypeError.new type_name: type, base_class: self
       end
 
     end

data/spec/acfs/model/query_methods_spec.rb

@@ -151,13 +151,32 @@ describe Acfs::Model::QueryMethods do
       end
 
       context 'with invalid type set' do
-        before do
-          stub_request(:get, 'http://computers.example.org/computers').to_return response([{ id: 1, type: 'MyUser' }, { id: 2, type: 'Computer' }, { id: 3, type: 'Mac' }])
+        shared_examples 'with invalid type' do
+          it 'should raise error if type is no subclass' do
+            Computer.all
+            expect { Acfs.run }.to raise_error(Acfs::ResourceTypeError)
+          end
+        end
+
+        context 'with another resource as type instead' do
+          before do
+            stub_request(:get, 'http://computers.example.org/computers').to_return response([{ id: 1, type: 'MyUser' }, { id: 2, type: 'Computer' }, { id: 3, type: 'Mac' }])
+          end
+          it_behaves_like 'with invalid type'
         end
 
-        it 'should raise error if type is no subclass' do
-          Computer.all
-          expect { Acfs.run }.to raise_error(Acfs::ResourceTypeError)
+        context 'with a random string as type instead' do
+          before do
+            stub_request(:get, 'http://computers.example.org/computers').to_return response([{ id: 1, type: 'PC' }, { id: 2, type: 'noValidType' }, { id: 3, type: 'Mac' }])
+          end
+          it_behaves_like 'with invalid type'
+        end
+
+        context 'with a non-string as type instead' do
+          before do
+            stub_request(:get, 'http://computers.example.org/computers').to_return response([{ id: 1, type: 'PC' }, { id: 2, type: 'Computer' }, { id: 3, type: 42 }])
+          end
+          it_behaves_like 'with invalid type'
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acfs
 version: !ruby/object:Gem::Version
-  version: 0.29.0.1.b254
+  version: 0.29.0.1.b256
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-04 00:00:00.000000000 Z
+date: 2014-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport