acfs 0.17.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 879fbc544d14669fd0db86a7705c1ff10e997a56
-  data.tar.gz: 6424e9a7fcc978e739e80a0ee009fa141ce2ad25
+  metadata.gz: dfb99fe53f15f18d5bb38f6d14aab35df106395b
+  data.tar.gz: 822c5e1fd59b02589aa946252d57302d5afd0ca5
 SHA512:
-  metadata.gz: 697f3c7d31e1aa7081eb0e471e1065dcb2a9ec0be7e57b0f9f130cea0c40bb96dba91bbbb9faaf30eaec0aac29de99ee5b27df8b278696d7d43a9c8d1d4e2826
-  data.tar.gz: da505f1e0fcf03d21f594d81f32527dbe0b991dea6b310a400c0d5182cd573a9f3bfabeb3fddd5438a69dee344ef0dcbd540bc8994ee61cadf92e04a3238f436
+  metadata.gz: 114ea5f3dc9cf97f99ee2b920810f8ea7dabe2264ea2e17d64cdfe9e26ea729339b4de31e32ce9deeb460d6c3be57c865199f32101644a5c2dba4d854eb7e9b9
+  data.tar.gz: c32d14d4f25013beebb3aa60fe6edcaeb6de071597b0f41cc276cae51e5bd4b363b875f3f0ccd919172a9b84a24bbae14e4b4e423be2c28476cef25e4942fe3f

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.18.0
+
+* Basic DELETE operations
+
 ## 0.17.0
 
 * Basic messaging

data/lib/acfs/model/persistence.rb

@@ -26,7 +26,7 @@ module Acfs
       #   user2.save
       #   user2.persisted? # => true
       #
-      # @return [ Boolean ] True if resource has no changes and is not newly created, false otherwise.
+      # @return [TrueClass, FalseClass] True if resource has no changes and is not newly created, false otherwise.
       #
       def persisted?
         !new? && !changed?
@@ -36,7 +36,7 @@ module Acfs
       #
       # Return true if model is a new record and was not saved yet.
       #
-      # @return [ Boolean ] True if resource is newly created, false otherwise.
+      # @return [TrueClass, FalseClass] True if resource is newly created, false otherwise.
       #
       def new?
         read_attribute(:id).nil?
@@ -52,7 +52,7 @@ module Acfs
       #
       # Saving a resource is a synchronous operation.
       #
-      # @return [ Boolean ] True if save operation was successful, false otherwise.
+      # @return [TrueClass, FalseClass] True if save operation was successful, false otherwise.
       # @see #save! See #save! for available options.
       #
       def save(*args)
@@ -68,12 +68,12 @@ module Acfs
       #
       # Saving a resource is a synchronous operation.
       #
-      # @param [ Hash ] opts Hash with additional options.
-      # @option opts [ Hash ] :data Data to send to remote service. Default will be resource attributes.
+      # @param [Hash] opts Hash with additional options.
+      # @option opts [Hash] :data Data to send to remote service. Default will be resource attributes.
       #
-      # @raise [ Acfs::InvalidResource ]
+      # @raise [Acfs::InvalidResource]
       #   If remote services respond with 422 response. Will fill errors with data from response
-      # @raise [ Acfs::ErroneousResponse ]
+      # @raise [Acfs::ErroneousResponse]
       #   If remote service respond with not successful response.
       #
       # @see #save
@@ -88,6 +88,44 @@ module Acfs
         end
       end
 
+      # @api public
+      #
+      # Destroy resource by sending a DELETE request.
+      #
+      # Deleting a resource is a synchronous operation.
+      #
+      # @return [TrueClass, FalseClass]
+      # @see #delete!
+      #
+      def delete(opts = {})
+        delete! opts
+        true
+      rescue Acfs::Error
+        false
+      end
+
+      # @api public
+      #
+      # Destroy resource by sending a DELETE request.
+      # Will raise an error in case something goes wrong.
+      #
+      # Deleting a resource is a synchronous operation.
+
+      # @raise [Acfs::ErroneousResponse]
+      #   If remote service respond with not successful response.
+      # @return [undefined]
+      # @see #delete
+      #
+      def delete!(opts = {})
+        opts[:params] ||= {}
+        opts[:params].merge! id: id
+
+        operation :delete, opts do |data|
+          update_with data
+          freeze
+        end
+      end
+
       module ClassMethods
 
         # @api public
@@ -97,12 +135,12 @@ module Acfs
         #
         # Saving a resource is a synchronous operation.
         #
-        # @param [ Hash{ Symbol, String => Object }] data Data to send in create request.
-        # @return [ self ] Newly resource object.
+        # @param [Hash{Symbol, String => Object}] data Data to send in create request.
+        # @return [self] Newly resource object.
         #
-        # @raise [ Acfs::InvalidResource ]
+        # @raise [Acfs::InvalidResource]
         #   If remote services respond with 422 response. Will fill errors with data from response
-        # @raise [ Acfs::ErroneousResponse ]
+        # @raise [Acfs::ErroneousResponse]
         #   If remote service respond with not successful response.
         #
         # @see Acfs::Model::Persistence#save! Available options. `:data` will be overridden with provided data hash.
@@ -122,10 +160,10 @@ module Acfs
         #
         # Saving a resource is a synchronous operation.
         #
-        # @param [ Hash{ Symbol, String => Object }] data Data to send in create request.
-        # @return [ self ] Newly resource object.
+        # @param [Hash{Symbol, String => Object}] data Data to send in create request.
+        # @return [self] Newly resource object.
         #
-        # @raise [ Acfs::ErroneousResponse ]
+        # @raise [Acfs::ErroneousResponse]
         #   If remote service respond with not successful response.
         #
         # @see Acfs::Model::Persistence#save! Available options. `:data` will be overridden with provided data hash.

data/lib/acfs/stub.rb

@@ -60,7 +60,7 @@ module Acfs
         stub = stub_for op
         unless stub
           return false if allow_requests?
-          raise RealRequestsNotAllowedError, "No stub found for `#{op.resource.name}` with params `#{op.params}`"
+          raise RealRequestsNotAllowedError, "No stub found for `#{op.resource.name}` with params `#{op.params}` and id `#{op.id}`."
         end
 
         if (data = stub[:return])

data/lib/acfs/version.rb

@@ -1,7 +1,7 @@
 module Acfs
   module VERSION
     MAJOR = 0
-    MINOR = 17
+    MINOR = 18
     PATCH = 0
     STAGE = nil
 

data/spec/acfs/messaging/receiver_spec.rb

@@ -29,7 +29,7 @@ describe Acfs::Messaging::Receiver do
           rcv_class.instance.should_receive(:receive).with(anything, anything, { message: 'Hello!'})
 
           Acfs::Messaging::Client.instance.publish('my.custom_receiver', { message: 'Hello!' })
-          sleep 1 # Nothing better?
+          sleep 3 # Nothing better?
         end
       end
 
@@ -38,7 +38,7 @@ describe Acfs::Messaging::Receiver do
           rcv_class.instance.should_receive(:receive).with(anything, anything, { message: 'Hello!'})
 
           Acfs::Messaging::Client.instance.publish('my.different', { message: 'Hello!' })
-          sleep 1 # Nothing better?
+          sleep 3 # Nothing better?
         end
       end
     end
@@ -48,7 +48,7 @@ describe Acfs::Messaging::Receiver do
         rcv_class.instance.should_not_receive(:receive)
 
         Acfs::Messaging::Client.instance.publish('abc.cde', { message: 'Hello!' })
-        sleep 1 # Nothing better?
+        sleep 3 # Nothing better?
       end
     end
   end

data/spec/acfs/model/persistance_spec.rb

@@ -3,28 +3,31 @@ require 'spec_helper'
 describe Acfs::Model::Persistence do
   let(:model_class) { MyUser }
   before do
-    @get_stub = stub_request(:get, "http://users.example.org/users/1").to_return response({ id: 1, name: "Anon", age: 12 })
+    @get_stub = stub_request(:get, 'http://users.example.org/users/1').to_return response({ id: 1, name: "Anon", age: 12 })
 
     @patch_stub = stub_request(:put, 'http://users.example.org/users/1')
-        .with(
-          body: '{"id":1,"name":"Idefix","age":12}')
-        .to_return response({ id: 1, name: 'Idefix', age: 12 })
+      .with(body: '{"id":1,"name":"Idefix","age":12}')
+      .to_return response({ id: 1, name: 'Idefix', age: 12 })
 
     @post_stub = stub_request(:post, 'http://users.example.org/users')
-    .with(body: '{"id":null,"name":"Idefix","age":12}')
-    .to_return response({ id: 5, name: 'Idefix', age: 12 })
+      .with(body: '{"id":null,"name":"Idefix","age":12}')
+      .to_return response({ id: 5, name: 'Idefix', age: 12 })
 
     stub_request(:post, 'http://users.example.org/users')
-    .with(body: '{"id":null,"name":"Anon","age":null}')
-    .to_return response({ id: 5, name: 'Anon', age: 12 })
+      .with(body: '{"id":null,"name":"Anon","age":null}')
+      .to_return response({ id: 5, name: 'Anon', age: 12 })
 
     stub_request(:post, 'http://users.example.org/users')
-    .with(body: '{"name":"Idefix","age":12}')
-    .to_return response({ id: 5, name: 'Idefix', age: 12 })
+      .with(body: '{"name":"Idefix","age":12}')
+      .to_return response({ id: 5, name: 'Idefix', age: 12 })
 
     stub_request(:post, 'http://users.example.org/users')
-    .with(body: '{"age":12}')
-    .to_return response({ errors: { name: [ 'required' ] }}, status: 422)
+      .with(body: '{"age":12}')
+      .to_return response({ errors: { name: [ 'required' ] }}, status: 422)
+
+    @del = stub_request(:delete, 'http://users.example.org/users/1')
+      .with(body: '{}')
+      .to_return response({ id: 1, name: 'Idefix', age: 12 }, status: 200)
   end
 
   context 'new model' do
@@ -79,11 +82,26 @@ describe Acfs::Model::Persistence do
 
     context 'with changes' do
       let(:model) { model_class.find 1 }
-      before { model; Acfs.run; model.name = "dhh" }
+      before { model; Acfs.run; model.name = 'dhh' }
 
       it { expect(model).to_not be_persisted }
       it { expect(model).to_not be_new }
     end
+
+    describe '#delete!' do
+      let(:model) { model_class.find 1 }
+      before { model; Acfs.run }
+
+      it 'should trigger DELETE request' do
+        model.delete!
+        expect(@del).to have_been_requested
+      end
+
+      it 'should be frozen after DELETE' do
+        model.delete!
+        expect(model).to be_frozen
+      end
+    end
   end
 
   describe '.create!' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acfs
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.0
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-27 00:00:00.000000000 Z
+date: 2013-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport