ace-overseer 0.11.0 → 0.13.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94a8d4155aa2c5385f768be8044cec7375bf45be9f3e4c710635600426482e4b
-  data.tar.gz: 55918116f099345f95b94156da6ca9be5afbd65d94b34116ccaa39dbaeddf9e7
+  metadata.gz: 88de815647c2cab7c69771f682d046320853108aaf88e2ce441bd6e82cf73de1
+  data.tar.gz: cf5dd24e95177473c95906caaf9eb0236e9e40f2c5d53b236097aa40a20a2dfc
 SHA512:
-  metadata.gz: 10974ac46524c8555ce64a47867ba1a0bee986b6b63114ae7dde29202ef190bcadfb3c57310a1ada3631b4476e5b7329361b2660c09b0d4fcc1047bdbaaded55
-  data.tar.gz: 5f25ff7e081379033014d606eae9f28f611ae35e01b4be77dff516ecccfbb6c2916027453ee07e31a30234114ea0ef53454ee833c3308ce6f373913c2240c8c5
+  metadata.gz: 9596ef81f280c9c834070a112cdd58055f963bcec89b6dc569cc0ee61ab5cf48ef824e6b1fd7caed11247bb4302b9fb956c47a60138722a89d3e7ee17a20503a
+  data.tar.gz: 2ab4047d48a95c905e0331b9b753360e4215ad4d1c2691f3906a3e8a464ae7bfeb671539efd264cadead2e94c3d1b810130f749a2324a7c037489f2873147534

data/CHANGELOG.md

@@ -7,6 +7,51 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.13.3] - 2026-03-28
+
+### Fixed
+- Added an explicit git-repository guard for operational commands so `work-on`, `status`, and `prune` fail cleanly outside a repo or worktree instead of leaking raw `git` errors.
+
+### Technical
+- Added command coverage for non-repo failure paths and updated launcher fixtures to initialize real git repos in temporary worktree test directories.
+
+## [0.13.2] - 2026-03-27
+
+### Fixed
+- Preserved taskref-only preset compatibility by collapsing launcher task refs to the primary task when a preset does not declare `taskrefs`.
+
+## [0.13.1] - 2026-03-27
+
+### Fixed
+- Updated work-on preset guard checks to evaluate active resolved refs after terminal filtering, preventing false single-task preset rejections on mixed terminal/non-terminal inputs.
+- Preserved parent refs during taskref expansion when all subtasks are terminal, preventing empty expansion results from valid parent-task inputs.
+
+## [0.13.0] - 2026-03-27
+
+### Changed
+- Routed `ace-overseer work-on` assignment launch through the shared `ace-assign create --task ...` creation path while preserving the existing CLI and pre-side-effect validation behavior.
+- Updated package docs to describe the shared task-driven assignment creation flow with `ace-assign`.
+
+### Technical
+- Added launcher and orchestrator coverage for the shared creator path and explicit task fixture resolution.
+
+## [0.12.1] - 2026-03-26
+
+### Fixed
+- Tightened `ace-assign` gemspec constraint from `~> 0.16` to `~> 0.38` to match the runtime dependency introduced in v0.12.0.
+
+## [0.12.0] - 2026-03-26
+
+### Added
+- Terminal task filtering in `WorkOnOrchestrator`: tasks with `done`, `skipped`, or `cancelled` status are automatically excluded before assignment creation, with user-visible skip reporting via progress callbacks.
+
+### Changed
+- `resolve_requested_refs` now returns skipped terminal refs alongside resolved refs, raising an error when all requested refs are terminal.
+- `expand_task_refs_in_order` and `extract_subtask_refs` filter out terminal subtasks during parent-to-subtask expansion.
+
+### Technical
+- Added 4 tests covering single-terminal rejection, all-terminal rejection, mixed-set filtering, and subtask-level terminal filtering.
+
 ## [0.11.0] - 2026-03-23
 
 ### Changed

data/README.md

@@ -3,7 +3,7 @@
 
   One command to provision a worktree, open a tmux window, and start working on a task.
 
-  <img src="https://raw.githubusercontent.com/cs3b/ace/main/docs/brand/AgenticCodingEnvironment.Logo.XS.jpg" alt="ACE Logo" width="480">
+  <img src="../docs/brand/AgenticCodingEnvironment.Logo.XS.jpg" alt="ACE Logo" width="480">
   <br><br>
 
   <a href="https://rubygems.org/gems/ace-overseer"><img alt="Gem Version" src="https://img.shields.io/gem/v/ace-overseer.svg" /></a>
@@ -23,7 +23,7 @@ Starting task work means creating a worktree, opening a tmux window, and prepari
 ## How It Works
 
 1. Resolve task refs and create a scoped worktree.
-2. Expand the assignment preset into concrete steps under `.ace-local/assign/`, then open a dedicated tmux window mapped to that worktree.
+2. Route assignment creation through `ace-assign create --task ...`, which expands the assignment preset into concrete steps under `.ace-local/assign/`, then open a dedicated tmux window mapped to that worktree.
 3. Instruct the agent inside the tmux window to act as an orchestrator and drive the assignment step-by-step.
 
 ## Use Cases

data/docs/usage.md

@@ -29,6 +29,8 @@ Options:
 - `--debug`, `-d`: show debug output
 - `--help`, `-h`: show help
 
+Internally, `work-on` now routes assignment creation through `ace-assign create --task ...`, so direct `ace-assign` and `ace-overseer` task flows use the same preset expansion behavior.
+
 ## `ace-overseer status`
 
 Show status for active task worktrees.

data/lib/ace/overseer/atoms/repo_guard.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module Ace
+  module Overseer
+    module Atoms
+      module RepoGuard
+        MESSAGE = "ace-overseer must be run inside a git repository or worktree. Change into your project repo and retry."
+
+        def self.ensure_repo!(cwd: Dir.pwd)
+          return true if inside_repo?(cwd: cwd)
+
+          raise Ace::Support::Cli::Error.new(MESSAGE)
+        end
+
+        def self.inside_repo?(cwd: Dir.pwd)
+          system(
+            "git", "-C", cwd.to_s, "rev-parse", "--is-inside-work-tree",
+            out: File::NULL, err: File::NULL
+          )
+        rescue SystemCallError
+          false
+        end
+      end
+    end
+  end
+end

data/lib/ace/overseer/cli/commands/prune.rb

@@ -26,6 +26,8 @@ module Ace
           end
 
           def call(**options)
+            Atoms::RepoGuard.ensure_repo!
+
             targets = Array(options[:targets] || [])
             progress = options[:quiet] ? nil : ->(msg) { puts msg }
             result = @orchestrator.call(

data/lib/ace/overseer/cli/commands/status.rb

@@ -23,6 +23,7 @@ module Ace
           end
 
           def call(format:, **options)
+            Atoms::RepoGuard.ensure_repo!
             return if options[:quiet]
 
             if options[:watch] && format != "json"

data/lib/ace/overseer/cli/commands/work_on.rb

@@ -21,6 +21,8 @@ module Ace
           end
 
           def call(task: nil, preset: nil, **options)
+            Atoms::RepoGuard.ensure_repo!
+
             task_refs = normalize_task_refs(task)
             if task_refs.empty?
               raise Ace::Support::Cli::Error.new("--task is required. Usage: ace-overseer work-on --task <ref>")

data/lib/ace/overseer/molecules/assignment_launcher.rb

@@ -1,122 +1,65 @@
 # frozen_string_literal: true
 
-require "yaml"
-require "fileutils"
-require "tempfile"
 require "ace/support/fs"
 
 module Ace
   module Overseer
     module Molecules
       class AssignmentLauncher
-        def initialize(assignment_executor: nil)
+        def initialize(assignment_executor: nil, task_manager: nil)
           @assignment_executor = assignment_executor
+          @task_manager = task_manager
         end
 
         def launch(worktree_path:, preset_name:, task_ref:, subtask_refs: nil, task_refs: nil)
           with_worktree_context(worktree_path) do
-            preset = load_preset!(preset_name)
-            params = build_parameters(preset, task_ref, subtask_refs, task_refs)
-            validate_parameters!(preset, params)
-
-            steps = Ace::Assign::Atoms::PresetExpander.expand(preset, params)
-            session_name = "#{preset_name}-#{task_ref}"
-            job_path = write_job_file(session_name: session_name, description: preset["description"], steps: steps)
-
-            executor = @assignment_executor || Ace::Assign::Organisms::AssignmentExecutor.new
-            result = executor.start(job_path)
+            requested_refs = effective_task_refs(task_ref, subtask_refs, task_refs)
+            requested_refs = [task_ref] unless preset_supports_taskrefs?(preset_name: preset_name)
+
+            creator = Ace::Assign::Organisms::TaskAssignmentCreator.new(
+              task_manager: @task_manager,
+              executor: @assignment_executor
+            )
+            result = creator.call(
+              task_refs: requested_refs,
+              preset_name: preset_name,
+              primary_task_ref: task_ref
+            )
             current = result[:current]
 
             {
               assignment_id: result[:assignment].id,
               first_step: current ? "#{current.number}-#{current.name}" : nil,
-              job_path: job_path
+              job_path: result[:job_path]
             }
           end
+        rescue Ace::Support::Cli::Error => e
+          raise Error, e.message
         end
 
         def preset_supports_taskrefs?(preset_name:, worktree_path: nil)
           if worktree_path
             with_worktree_context(worktree_path) do
-              parameter_names(load_preset!(preset_name)).include?("taskrefs")
+              parameter_names(Ace::Assign::Atoms::PresetLoader.load(preset_name)).include?("taskrefs")
             end
           else
-            parameter_names(load_preset!(preset_name)).include?("taskrefs")
+            parameter_names(Ace::Assign::Atoms::PresetLoader.load(preset_name)).include?("taskrefs")
           end
+        rescue Ace::Support::Cli::Error => e
+          raise Error, e.message
         end
 
         private
 
-        def build_parameters(preset, task_ref, subtask_refs, task_refs)
-          param_defs = preset["parameters"] || {}
-          params = {}
-          params["taskref"] = task_ref if param_defs.key?("taskref")
-          if param_defs.key?("taskrefs")
-            params["taskrefs"] = if task_refs&.any?
-              task_refs
-            elsif subtask_refs&.any?
-              subtask_refs
-            else
-              [task_ref]
-            end
-          end
-          params
-        end
-
         def parameter_names(preset)
           (preset["parameters"] || {}).keys
         end
 
-        def validate_parameters!(preset, params)
-          errors = Ace::Assign::Atoms::PresetExpander.validate_parameters(preset, params)
-          return if errors.empty?
-
-          raise Error, errors.join(", ")
-        end
-
-        def write_job_file(session_name:, description:, steps:)
-          job = {
-            "session" => {
-              "name" => session_name,
-              "description" => description || "Prepared by ace-overseer"
-            },
-            "steps" => steps
-          }
-
-          dir = File.join(Ace::Support::Fs::Molecules::ProjectRootFinder.find_or_current, ".ace-local", "overseer")
-          FileUtils.mkdir_p(dir)
-          path = File.join(dir, "#{session_name}-job.yml")
-          payload = YAML.dump(job)
-          Tempfile.create(["#{session_name}-job", ".yml"], dir) do |tmp|
-            tmp.write(payload)
-            tmp.flush
-            tmp.fsync
-            FileUtils.mv(tmp.path, path)
-          end
-          path
-        end
-
-        def load_preset!(preset_name)
-          path = preset_paths(preset_name).find { |candidate| File.exist?(candidate) }
-          raise Error, "Assignment preset not found: #{preset_name}" unless path
-
-          YAML.safe_load_file(path)
-        end
-
-        def preset_paths(preset_name)
-          filename = "#{preset_name}.yml"
-          paths = [
-            File.join(Dir.pwd, ".ace", "assign", "presets", filename),
-            File.join(Dir.pwd, "ace-assign", ".ace-defaults", "assign", "presets", filename),
-            File.join(Dir.pwd, ".ace-defaults", "assign", "presets", filename)
-          ]
-
-          gem_root = Gem.loaded_specs["ace-assign"]&.gem_dir
-          if gem_root
-            paths << File.join(gem_root, ".ace-defaults", "assign", "presets", filename)
-          end
+        def effective_task_refs(task_ref, subtask_refs, task_refs)
+          return task_refs if task_refs&.any?
+          return subtask_refs if subtask_refs&.any?
 
-          paths.uniq
+          [task_ref]
         end
 
         def with_worktree_context(worktree_path)

data/lib/ace/overseer/organisms/work_on_orchestrator.rb

@@ -24,8 +24,17 @@ module Ace
           raise Error, "No valid task references provided" if requested_refs.empty?
 
           progress.call("Loading task #{requested_refs.join(", ")}...")
-          resolved_refs = resolve_requested_refs(requested_refs)
-          primary_ref = requested_refs.first
+          resolved_refs, skipped_terminal = resolve_requested_refs(requested_refs)
+
+          if resolved_refs.empty?
+            raise Error, "All requested tasks are already terminal (done/skipped/cancelled): #{skipped_terminal.join(", ")}. No assignment created."
+          end
+
+          if skipped_terminal.any?
+            progress.call("Skipped terminal tasks (done/skipped/cancelled): #{skipped_terminal.join(", ")}")
+          end
+
+          primary_ref = resolved_refs.first[:ref]
           primary_task = resolved_refs.first[:task]
 
           preset_name = Atoms::PresetResolver.resolve(
@@ -33,7 +42,7 @@ module Ace
             cli_preset: cli_preset,
             default: @config["default_assign_preset"] || "work-on-task"
           )
-          guard_multi_task_preset!(preset_name, requested_refs.length)
+          guard_multi_task_preset!(preset_name, resolved_refs.length)
 
           expanded_taskrefs = expand_task_refs_in_order(resolved_refs)
           primary_subtask_refs = extract_subtask_refs(primary_task)
@@ -97,7 +106,8 @@ module Ace
           subtasks = task.respond_to?(:subtasks) ? task.subtasks : nil
           return nil unless subtasks&.any?
 
-          subtasks.map(&:id)
+          active = subtasks.reject { |st| Ace::Task::Atoms::TaskValidationRules.terminal_status?(st.status.to_s) }
+          active.any? ? active.map(&:id) : nil
         end
 
         def normalize_requested_refs(task_ref, task_refs)
@@ -109,7 +119,10 @@ module Ace
         end
 
         def resolve_requested_refs(requested_refs)
-          requested_refs.map do |ref|
+          resolved = []
+          skipped_terminal = []
+
+          requested_refs.each do |ref|
             is_subtask = subtask_ref?(ref)
             task = @task_manager.show(ref.to_s)
             raise Error, "Task not found: #{ref}" unless task
@@ -120,8 +133,15 @@ module Ace
                            "(or ace-bundle wfi://task/review), then retry."
             end
 
-            {ref: ref.to_s, task: task, is_subtask: is_subtask}
+            if Ace::Task::Atoms::TaskValidationRules.terminal_status?(task.status.to_s)
+              skipped_terminal << ref.to_s
+              next
+            end
+
+            resolved << {ref: ref.to_s, task: task, is_subtask: is_subtask}
           end
+
+          [resolved, skipped_terminal]
         end
 
         def subtask_ref?(ref)
@@ -136,7 +156,10 @@ module Ace
             if entry[:is_subtask]
               [ref]
             elsif task.respond_to?(:subtasks) && task.subtasks&.any?
-              task.subtasks.map(&:id)
+              active_subtasks = task.subtasks
+                .reject { |st| Ace::Task::Atoms::TaskValidationRules.terminal_status?(st.status.to_s) }
+                .map(&:id)
+              active_subtasks.empty? ? [ref] : active_subtasks
             else
               [ref]
             end

data/lib/ace/overseer/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module Overseer
-    VERSION = "0.11.0"
+    VERSION = "0.13.3"
   end
 end

data/lib/ace/overseer.rb

@@ -12,6 +12,7 @@ require_relative "overseer/version"
 require_relative "overseer/models/work_context"
 require_relative "overseer/models/prune_candidate"
 require_relative "overseer/models/assignment_prune_candidate"
+require_relative "overseer/atoms/repo_guard"
 require_relative "overseer/atoms/preset_resolver"
 require_relative "overseer/atoms/status_formatter"
 require_relative "overseer/molecules/worktree_provisioner"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ace-overseer
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.13.3
 platform: ruby
 authors:
 - Michal Czyz
@@ -71,14 +71,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.16'
+        version: '0.40'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.16'
+        version: '0.40'
 - !ruby/object:Gem::Dependency
   name: ace-git
   requirement: !ruby/object:Gem::Requirement
@@ -127,14 +127,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
 - !ruby/object:Gem::Dependency
   name: ace-support-test-helpers
   requirement: !ruby/object:Gem::Requirement
@@ -217,6 +217,7 @@ files:
 - handbook/workflow-instructions/overseer.wf.md
 - lib/ace/overseer.rb
 - lib/ace/overseer/atoms/preset_resolver.rb
+- lib/ace/overseer/atoms/repo_guard.rb
 - lib/ace/overseer/atoms/status_formatter.rb
 - lib/ace/overseer/cli.rb
 - lib/ace/overseer/cli/commands/prune.rb