ace-git-forgejo 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec7d89b79d4c95330a4610f04ce163e8dcd402f3ff72bb468b27dac082d086ea
-  data.tar.gz: b9a7a5d29fa5fbd4b559ef532018d18e07d9a3b8de20dbd5860938408158d6e9
+  metadata.gz: 5e06e7ebace5fc96a24f3e1ea11c26a858864acc02be4ff0e8da43823fdc4a01
+  data.tar.gz: 98b6f9244d4d965302a22bd9a7ef0faf1ca91d55801043e961cc9409c66feb0f
 SHA512:
-  metadata.gz: f7a145c24c9720d4748f32cc921f42983f2dc20c56dc0c007de0536972b4b318bba6d35c52b2b360ece6846b24cf4cd6d5b819493a7471d14e13bd59e08dc060
-  data.tar.gz: e308d391be1d1057de4176e58a698cfef161ed9474e46bb29dd1ab0a5ef83efb13af1f51b8d4bccb53d8322c0ffce89db71438f777762f49a6cadb07bab9880a
+  metadata.gz: b07df628f1428cf4599ec991429c0767c03787196e866260ce8efeebb7dc948a0adfee15d22f290b8978c1ad46205147f7b01262929f02d78b135b5449b17527
+  data.tar.gz: 3a4308e47ec2fe95cf9e2f15cc41562a3d627aab7b4466d5029334e0b0b33c280255dd7f6b0542edf8dd4d2c6f5cc1bcdffa2abde9d6b3f22a410f8dab6a75db

data/CHANGELOG.md

@@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.8.0] - 2026-10-23
+
+### Added
+
+- Formal reviewer-owned, exact-head provider approval and read-only approval verification through the forge-neutral review flow; comments do not substitute for approval.
+
+
+### Fixed
+
+- Publish formal approval directly at explicit commit_id instead of rebinding pending-submit; retain safe comment-free owned pending recovery, refuse unrelated pending, ignore request/team rows, and require the verified formal-review API floor.
+
 ## [0.7.0] - 2026-10-16
 
 ### Added

data/lib/ace/git/forgejo/provider.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "json"
+require "ace/git/providers/formal_approval"
 require "uri"
 require "ace/git/atoms/server_url"
 require_relative "cli_executor"
@@ -340,6 +341,14 @@ module Ace
           raise Ace::Git::ProviderMalformedOutputError, "Malformed Forgejo repository file content: #{e.message}"
         end
 
+        def approve_pull_request(number:, expected_head:, body:, correlation:)
+          formal_approval.approve(number: number, expected_head: expected_head, body: body, correlation: correlation)
+        end
+
+        def pull_request_approval(number:, expected_head:, review_id:)
+          formal_approval.read(number: number, expected_head: expected_head, review_id: review_id)
+        end
+
         def create_pull_request_comment(number:, expected_head:, body:, correlation:)
           number = request_number!(number)
           pr = verify_expected_head!(pull_request(number: number), expected_head)
@@ -914,6 +923,25 @@ module Ace
             "Cannot post review comment to PR ##{pr.number} in #{pr.state} state"
         end
 
+        def formal_approval
+          pr_api.ensure_formal_review_supported!
+          request = lambda do |method, path, payload|
+            path = "/api/v1/user" if path == :actor
+            payload = payload.merge("event" => "APPROVED") if method == :post
+            review_http.request(method, path, body: payload)
+          end
+          Ace::Git::Providers::FormalApproval.new(provider: self, request: request,
+            list: method(:formal_review_rows), official: true, pending_reuse: true)
+        end
+
+        # Forgejo lists review requests alongside actual reviews. User and
+        # team requests have no reviewed commit; they are not approval evidence.
+        def formal_review_rows(path)
+          review_http.paginate(path).reject do |row|
+            row.is_a?(Hash) && row["state"] == "REQUEST_REVIEW"
+          end
+        end
+
         def review_http
           @review_http ||= HttpClient.new(server: server, timeout: timeout, runner: runner)
         end

data/lib/ace/git/forgejo/pull_request_api.rb

@@ -70,9 +70,21 @@ module Ace
               "Forgejo server reports #{version}; PR delivery requires #{MINIMUM_SERVER_VERSION} " \
               "(server-enforced expected-head merge is not documented below it)"
           end
+          @server_version = version
           @version_supported = true
         end
 
+        # Formal create-with-event preserves explicit commit_id in the
+        # inspected Forgejo v11.0.0 and v16.0.5 router/service/model sources.
+        # Pending submission does not: it rebinds to current HEAD and is unused.
+        def ensure_formal_review_supported!
+          ensure_version_supported!
+          unless @server_version >= Gem::Version.new("11.0.0")
+            raise Ace::Git::ProviderUnsupportedCapabilityError,
+              "Formal exact-commit approval requires Forgejo 11.0.0 or newer"
+          end
+        end
+
         # @return [Hash] the raw validated pull request payload
         # @raise [Ace::Git::ProviderObjectNotFoundError] when absent
         # @raise [Ace::Git::ProviderMalformedOutputError] on schema violation

data/lib/ace/git/forgejo/version.rb

@@ -3,7 +3,7 @@
 module Ace
   module Git
     module Forgejo
-      VERSION = "0.7.0"
+      VERSION = "0.8.0"
     end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-git-forgejo
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-10-16 00:00:00.000000000 Z
+date: 2026-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-git
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.30'
+        version: '0.31'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.30'
+        version: '0.31'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement