accumulators 0.4.0 → 0.5.0

data/README.md

@@ -89,6 +89,7 @@ Available accumulators
 
 * Count
 * Sum
+* MinMax
 * Mean
 * MeanVariance
 
@@ -97,7 +98,6 @@ TODO
 
 * Skew?
 * Weighted Means
-* min, max, and min-max
 
 Contributing to accumulators
 ----------------------------

data/VERSION

@@ -1 +1 @@
-0.4.0
+0.5.0

data/accumulators.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{accumulators}
-  s.version = "0.4.0"
+  s.version = "0.5.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Gavin Heavyside"]
@@ -31,10 +31,12 @@ Gem::Specification.new do |s|
     "lib/accumulators/count.rb",
     "lib/accumulators/mean.rb",
     "lib/accumulators/mean_variance.rb",
+    "lib/accumulators/minmax.rb",
     "lib/accumulators/sum.rb",
     "spec/lib/accumulators/count_spec.rb",
     "spec/lib/accumulators/mean_spec.rb",
     "spec/lib/accumulators/mean_variance_spec.rb",
+    "spec/lib/accumulators/min_max_spec.rb",
     "spec/lib/accumulators/sum_spec.rb",
     "spec/spec_helper.rb"
   ]

data/lib/accumulators.rb

@@ -1,6 +1,7 @@
 module Accumulators
   autoload :Count, "accumulators/count"
   autoload :Sum, "accumulators/sum"
+  autoload :MinMax, "accumulators/minmax"
   autoload :Mean, "accumulators/mean"
   autoload :MeanVariance, "accumulators/mean_variance"
 end

data/lib/accumulators/minmax.rb

@@ -0,0 +1,18 @@
+module Accumulators
+  class MinMax
+    attr_reader :min
+    attr_reader :max
+
+    def add(rhs)
+      if rhs.is_a? Numeric
+        @min = [@min, rhs].min rescue rhs
+        @max = [@max, rhs].max rescue rhs
+      elsif rhs.is_a? self.class
+        @min = [@min, rhs.min].min rescue rhs.min
+        @max = [@max, rhs.max].max rescue rhs.max
+      else
+        raise ArgumentError.new("You may not add #{rhs.class} to #{self.class}")
+      end
+    end
+  end
+end

data/spec/lib/accumulators/min_max_spec.rb

@@ -0,0 +1,77 @@
+require 'spec_helper'
+
+module Accumulators
+  describe MinMax do
+    let(:minmax){ MinMax.new }
+
+    context "Creation" do
+      it "can be created" do
+        lambda{ MinMax.new }.should_not raise_error
+      end
+
+      it "returns a min and max of nil before anything is added to it" do
+        minmax.min.should be_nil
+        minmax.max.should be_nil
+      end
+    end
+
+    context "adding numbers or distributions" do
+      it "allows integers to be added" do
+        lambda { minmax.add 5 }.should_not raise_error
+      end
+
+      it "allows floats to be added" do
+        lambda { minmax.add 3.4 }.should_not raise_error
+      end
+
+      it "allows other MinMax distributions to be added" do
+        lambda { minmax.add MinMax.new }.should_not raise_error
+      end
+
+      it "raises an ArgumentError if a String is added" do
+        lambda { minmax.add "1.5" }.should raise_error(
+          ArgumentError,
+          "You may not add String to Accumulators::MinMax")
+      end
+    end
+
+    context "correctness of int min/max" do
+      it "returns Integer -3, 76 when 3,23,-3,-2,75,76,1 are added" do
+        [3,23,-3,-2,75,76,1].each{|n| minmax.add n }
+        minmax.min.should be_a Integer
+        minmax.min.should == -3
+        minmax.max.should be_a Integer
+        minmax.max.should == 76
+      end
+    end
+
+    context "correctness of float min/max" do
+      it "returns Integer -3.2, 76.2 when 3.2,23.2,-3.2,-2.2,75.2,76.2,1.2 are added" do
+        [3.2,23.2,-3.2,-2.2,75.2,76.2,1.2].each{|n| minmax.add n }
+        minmax.min.should be_a Float
+        minmax.min.should == -3.2
+        minmax.max.should be_a Float
+        minmax.max.should == 76.2
+      end
+    end
+
+    context "Correctness of MinMax additions" do
+      it "combines two MinMaxes correctly" do
+        mm2 = MinMax.new
+        vals = []
+        500.times do 
+          vals << rand * 1000*1000
+          minmax.add vals.last
+          vals << rand(100*1000)
+          mm2.add vals.last
+        end
+
+        minmax.add(mm2)
+        minmax.min.class.should == vals.min.class
+        minmax.min.should == vals.min
+        minmax.max.class.should == vals.max.class
+        minmax.max.should == vals.max
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -7,7 +7,7 @@ require 'accumulators'
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
-EPSILON = 0.00001
+EPSILON = 0.000001
 
 RSpec.configure do |config|
   

metadata

@@ -2,7 +2,7 @@
 name: accumulators
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors: 
 - Gavin Heavyside
@@ -103,10 +103,12 @@ files:
 - lib/accumulators/count.rb
 - lib/accumulators/mean.rb
 - lib/accumulators/mean_variance.rb
+- lib/accumulators/minmax.rb
 - lib/accumulators/sum.rb
 - spec/lib/accumulators/count_spec.rb
 - spec/lib/accumulators/mean_spec.rb
 - spec/lib/accumulators/mean_variance_spec.rb
+- spec/lib/accumulators/min_max_spec.rb
 - spec/lib/accumulators/sum_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
@@ -123,7 +125,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -3603142917674474649
+      hash: -2545635480310131054
       segments: 
       - 0
       version: "0"