accepts_nested_attributes_for_public_id 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c66a87c5663498998b2263ec28d9f1f1bafde4101e93190b1d3e336c2c12605
-  data.tar.gz: bed9e7a6048e6d2f9761acc39156f2bc359e2ba5bac144505061d592792faaa5
+  metadata.gz: f30d194a7b2fb866d90ad1f136123a1778941ff1fd48105f1a4068e667110884
+  data.tar.gz: f60c0932253ce1879bcb0d187866edf6b530944ffa2221e471857ee62fd820a4
 SHA512:
-  metadata.gz: 45592a78a5438ef544dd687dbf52624efaf8e194d31a083736ace28dba20eb254670bb584e71d72bc2c141a078cbf7127d5909c8feb19f88d03feb85147b5868
-  data.tar.gz: a14e83ac5d39575dde70a0c0ec4ab5b0833ca681efc8b64a198d2417528cd03903c7f2818996f75cc56d1531c5011d00e26705600d63ecca1f092956a0512612
+  metadata.gz: b3e83a88567e8550394ced1c5220cd876f8f14172a282ba2803a5474af62e3c95bb0e54bcc39a6145fb0c588247bb8a36c1d10911c97e9b9097e5a89cbf8fef5
+  data.tar.gz: b47a373d9ecbb65f78f181afb61c7ee5ee3bc7c318fe71589aa5cc090861dc86d064e691ced318c13fee30f886304af410a74e72738557fecfca39d5749b788a

data/CHANGELOG.md

@@ -1,8 +1,13 @@
 # CHANGELOG
 
 - **Unreleased**
-  * [View Diff](https://github.com/westonganger/accepts_nested_attributes_for_public_id/compare/v1.0.0...master)
+  * [View Diff](https://github.com/westonganger/accepts_nested_attributes_for_public_id/compare/v1.0.1...master)
   * Nothing yet
 
+- **v1.0.1**
+  * [View Diff](https://github.com/westonganger/accepts_nested_attributes_for_public_id/compare/v1.0.0...v1.0.1)
+  * Add a couple allowed method contract violations for Rails 6.1 and below
+  * Resolve filter_map usage for compatibility with Ruby 2.6 and below
+
 - **v1.0.0**
   * Initial gem release

data/lib/accepts_nested_attributes_for_public_id/method_contracts.rb

@@ -1,7 +1,13 @@
 module AcceptsNestedAttributesForPublicId
+  ALLOWED_VIOLATIONS = [
+    ->(method) { Rails::VERSION::MAJOR < 7 && method.name == :assign_nested_attributes_for_collection_association }, ### small change from `map.compact` to `filter_map`
+    ->(method) { Rails::VERSION::MAJOR < 7 && method.name == :fields_for_with_nested_attributes }, ### small syntax change
+  ]
+
   def verify_method_contract!(method, contract)
     if method.source.strip.gsub(/^\s*/, "") != contract.strip.gsub(/^\s*/, "")
-      raise RuntimeError.new("Method definition contract violated for '#{self.class.name}##{method.name}', cannot apply patch for accepts_nested_attribute_for_public_id")
+      return if ALLOWED_VIOLATIONS.any?{|x| x.call(method) }
+      raise RuntimeError.new("Method definition contract violated for '#{method.owner}##{method.name}', cannot apply patch for accepts_nested_attributes_for_public_id")
     end
   end
   module_function :verify_method_contract!

data/lib/accepts_nested_attributes_for_public_id/method_patches.rb

@@ -188,7 +188,7 @@ ActiveSupport.on_load(:active_record) do
         existing_records = if association.loaded?
           association.target
         else
-          attribute_ids = attributes_collection.filter_map { |a| a["id"] || a[:id] }
+          attribute_ids = attributes_collection.map { |a| a["id"] || a[:id] }.compact
           ### ORIGINAL
           # attribute_ids.empty? ? [] : association.scope.where(association.klass.primary_key => attribute_ids)
           ### NEW

data/lib/accepts_nested_attributes_for_public_id/version.rb

@@ -1,3 +1,3 @@
 module AcceptsNestedAttributesForPublicId
-  VERSION = "1.0.0".freeze
+  VERSION = "1.0.1".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: accepts_nested_attributes_for_public_id
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Weston Ganger