abstract_notifier 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a36463d0a1ed93c6f48229bed9135f6c1ec3e301c76dc5b9edcc28f19d75cc3e
-  data.tar.gz: 7c56ec837be932967f22c592018b2210912fb2e53a40e5b8526b619dff70c4b1
+  metadata.gz: 4b04d84548a4895eb31535c7f50540916aa956b6609c5a2970404b4978720215
+  data.tar.gz: 6298d48963f69f556d9b26d7f81d67e8b67083bc18bd5ef587f3633a866a2678
 SHA512:
-  metadata.gz: 4a191cf257f1691d8df1b395ed14610246e2ae8614bde594abd359fea8104fe3c903a9332060545563e289652b45716d76c89d2f763a8bd0c911d305641c594d
-  data.tar.gz: 888f89197efafc92cbbfffc220959c449fcd405c8fea6932ab3f1dde4ed4f1d726e2c19ce4c43e68ca2021a8cc040a53831506c05a5272ce7f43330e4b054364
+  metadata.gz: 66f870bd767fba06773a9be991a5c0a6a0cd7f25f2a375a7f21b4e323bfceee3bf43de1c431ae43dc528964237d73f3d19876d1f94059b3afb3e43760e8cbdfb
+  data.tar.gz: 4686c9145b53a42ba6b649e93ff49d1c48a6c31b1c6056b40ce5fc778b8eb24aeb8bab707639f14d48c689181e15e5a5cf06ed1cffc9ae8129f980a2d650a230

data/.rubocop.yml

@@ -11,7 +11,9 @@ AllCops:
     - 'Gemfile'
     - 'node_modules/**/*'
     - 'vendor/**/*'
+    - 'gemfiles/**/*'
   DisplayCopNames: true
+  TargetRubyVersion: 2.5
 
 Standard/SemanticBlocks:
   Enabled: false
@@ -24,6 +26,3 @@ Style/TrailingCommaInArrayLiteral:
 
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: no_comma
-
-Layout/AlignParameters:
-  EnforcedStyle: with_first_parameter

data/.travis.yml

@@ -1,26 +1,35 @@
 sudo: false
 language: ruby
-rvm:
-  - 2.5.1
+cache: bundler
 
 notifications:
   email: false
 
+before_install:
+  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
+  - gem install bundler -v '< 2'
+
 matrix:
   fast_finish: true
   include:
     - rvm: ruby-head
       gemfile: gemfiles/railsmaster.gemfile
-    - rvm: 2.5.1
+    - rvm: 2.7
+      gemfile: Gemfile
+    - rvm: 2.7
+      gemfile: gemfiles/activedeliverymaster.gemfile
+    - rvm: 2.6
       gemfile: Gemfile
-    - rvm: 2.5.1
+    - rvm: 2.5
       gemfile: Gemfile
       env:
         - NO_RAILS=1
-    - rvm: 2.4.3
-      gemfile: Gemfile
-    - rvm: 2.3.1
+    - rvm: 2.5
+      gemfile: gemfiles/rails52.gemfile
+    - rvm: 2.5
       gemfile: gemfiles/rails42.gemfile
   allow_failures:
     - rvm: ruby-head
       gemfile: gemfiles/railsmaster.gemfile
+    - rvm: 2.7
+      gemfile: gemfiles/activedeliverymaster.gemfile

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master
 
+## 0.3.0 (2020-03-02)
+
+- **Drop Ruby 2.4 support**. ([@palkan][])
+
 ## 0.2.0 (2018-01-11)
 
 - Add class-level defaults. ([@palkan][])

data/Gemfile

@@ -4,12 +4,11 @@ source "https://rubygems.org"
 gemspec
 
 gem "pry-byebug"
-gem "rspec-rails"
 
 local_gemfile = File.join(__dir__, "Gemfile.local")
 
 if File.exist?(local_gemfile)
   eval(File.read(local_gemfile)) # rubocop:disable Security/Eval
 else
-  gem "rails", "~> 5.2"
+  gem "rails", "~> 6.0"
 end

data/README.md

@@ -7,11 +7,13 @@ Abstract Notifier is a tool which allows you to describe/model any text-based no
 
 Abstract Notifier (as the name states) doesn't provide any specific implementation for sending notifications. Instead, it offers tools to organize your notification-specific code and make it easily testable.
 
+📖 Read the introduction post: ["Crafting user notifications in Rails with Active Delivery"](https://evilmartians.com/chronicles/crafting-user-notifications-in-rails-with-active-delivery)
+
 <a href="https://evilmartians.com/?utm_source=action_policy">
 <img src="https://evilmartians.com/badges/sponsored-by-evil-martians.svg" alt="Sponsored by Evil Martians" width="236" height="54"></a>
 
 Requirements:
-- Ruby ~> 2.3
+- Ruby ~> 2.4
 
 **NOTE**: although most of the examples in this readme are Rails-specific, this gem could be used without Rails/ActiveSupport.
 
@@ -164,10 +166,10 @@ AbstractNotifier.delivery_mode = :test
 # you can make Abstract Notifier no-op.
 #
 # config/environments/development.rb
-ActionNotifier.delivery_mode = :noop
+AbstractNotifier.delivery_mode = :noop
 
 # Default delivery mode is "normal"
-ActionNotifier.delivery_mode = :normal
+AbstractNotifier.delivery_mode = :normal
 ```
 
 **NOTE:** we set `delivery_mode = :test` if `RAILS_ENV` or `RACK_ENV` env variable is equal to "test".

data/abstract_notifier.gemspec

@@ -5,23 +5,33 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "abstract_notifier/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "abstract_notifier"
-  spec.version       = AbstractNotifier::VERSION
-  spec.authors       = ["Vladimir Dementyev"]
-  spec.email         = ["dementiev.vm@gmail.com"]
+  spec.name = "abstract_notifier"
+  spec.version = AbstractNotifier::VERSION
+  spec.authors = ["Vladimir Dementyev"]
+  spec.email = ["dementiev.vm@gmail.com"]
 
-  spec.summary       = "ActionMailer-like interface for any type of notifications"
-  spec.description   = "ActionMailer-like interface for any type of notifications"
-  spec.homepage      = "https://github.com/palkan/abstract_notifier"
-  spec.license       = "MIT"
+  spec.summary = "ActionMailer-like interface for any type of notifications"
+  spec.description = "ActionMailer-like interface for any type of notifications"
+  spec.homepage = "https://github.com/palkan/abstract_notifier"
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.required_ruby_version = ">= 2.4"
+
+  spec.metadata = {
+    "bug_tracker_uri" => "http://github.com/palkan/abstract_notifier/issues",
+    "changelog_uri" => "https://github.com/palkan/abstract_notifier/blob/master/CHANGELOG.md",
+    "documentation_uri" => "http://github.com/palkan/abstract_notifier",
+    "homepage_uri" => "http://github.com/palkan/abstract_notifier",
+    "source_code_uri" => "http://github.com/palkan/abstract_notifier"
+  }
+
+  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "active_delivery"
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "standard", "~> 0.0.12"
+  spec.add_development_dependency "bundler", ">= 1.16"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec-rails", "~> 3.0"
+  spec.add_development_dependency "standard", "~> 0.2.0"
 end

data/gemfiles/activedeliverymaster.gemfile

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+gem "rails", "~> 6.0"
+gem "active_delivery", github: "palkan/active_delivery"
+
+gemspec path: ".."

data/gemfiles/rails42.gemfile

@@ -3,5 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~> 4.2"
+gem "bundler", "~> 1.17"
 
 gemspec path: ".."

data/gemfiles/rails52.gemfile

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.2"
+
+gemspec path: ".."

data/lib/abstract_notifier/async_adapters.rb

@@ -7,7 +7,7 @@ module AbstractNotifier
         return adapter unless adapter.is_a?(Symbol)
 
         adapter_class_name = adapter.to_s.split("_").map(&:capitalize).join
-        AsyncAdapters.const_get(adapter_class_name).new(options || {})
+        AsyncAdapters.const_get(adapter_class_name).new(**(options || {}))
       rescue NameError => e
         raise e.class, "Notifier async adapter :#{adapter} haven't been found", e.backtrace
       end

data/lib/abstract_notifier/base.rb

@@ -34,8 +34,12 @@ module AbstractNotifier
       end
 
       # rubocop:disable Style/MethodMissingSuper
-      def method_missing(method_name, *args)
-        notifier_class.new(method_name, params).public_send(method_name, *args)
+      def method_missing(method_name, *args, **kwargs)
+        if kwargs.empty?
+          notifier_class.new(method_name, **params).public_send(method_name, *args)
+        else
+          notifier_class.new(method_name, **params).public_send(method_name, *args, **kwargs)
+        end
       end
       # rubocop:enable Style/MethodMissingSuper
 
@@ -75,8 +79,8 @@ module AbstractNotifier
           end
       end
 
-      def default(method_name = nil, **hargs)
-        return @defaults_generator = Proc.new if block_given?
+      def default(method_name = nil, **hargs, &block)
+        return @defaults_generator = block if block_given?
 
         return @defaults_generator = proc { send(method_name) } unless method_name.nil?
 

data/lib/abstract_notifier/testing/rspec.rb

@@ -129,7 +129,7 @@ module AbstractNotifier
     end
   end
 
-  class HaveEqueuedNotification < HaveSentNotification
+  class HaveEnqueuedNotification < HaveSentNotification
     private
 
     def deliveries
@@ -153,7 +153,7 @@ RSpec.configure do |config|
     end
 
     def have_enqueued_notification(*args)
-      AbstractNotifier::HaveEqueuedNotification.new(*args)
+      AbstractNotifier::HaveEnqueuedNotification.new(*args)
     end
   end)
 end

data/lib/abstract_notifier/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AbstractNotifier
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/active_delivery/lines/notifier.rb

@@ -11,9 +11,9 @@ module ActiveDelivery
     class Notifier < ActiveDelivery::Lines::Base
       DEFAULT_RESOLVER = ->(name) { name.gsub(/Delivery$/, "Notifier").safe_constantize }
 
-      def initialize(*)
+      def initialize(**opts)
         super
-        @resolver = options[:resolver]
+        @resolver = opts[:resolver]
       end
 
       def resolve_class(name)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: abstract_notifier
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Vladimir Dementyev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-12 00:00:00.000000000 Z
+date: 2020-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_delivery
@@ -28,14 +28,14 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.16'
 - !ruby/object:Gem::Dependency
@@ -44,16 +44,16 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.12
+        version: 0.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.12
+        version: 0.2.0
 description: ActionMailer-like interface for any type of notifications
 email:
 - dementiev.vm@gmail.com
@@ -99,7 +99,9 @@ files:
 - abstract_notifier.gemspec
 - bin/console
 - bin/setup
+- gemfiles/activedeliverymaster.gemfile
 - gemfiles/rails42.gemfile
+- gemfiles/rails52.gemfile
 - gemfiles/railsmaster.gemfile
 - lib/abstract_notifier.rb
 - lib/abstract_notifier/async_adapters.rb
@@ -112,7 +114,12 @@ files:
 homepage: https://github.com/palkan/abstract_notifier
 licenses:
 - MIT
-metadata: {}
+metadata:
+  bug_tracker_uri: http://github.com/palkan/abstract_notifier/issues
+  changelog_uri: https://github.com/palkan/abstract_notifier/blob/master/CHANGELOG.md
+  documentation_uri: http://github.com/palkan/abstract_notifier
+  homepage_uri: http://github.com/palkan/abstract_notifier
+  source_code_uri: http://github.com/palkan/abstract_notifier
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -121,15 +128,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: ActionMailer-like interface for any type of notifications