abstract_api_wrapper 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d44dac1f1b099e9dade84a4fd871547a1778c855
-  data.tar.gz: ccf0fbf273198e999b19796f65e23f16f4899fc9
+  metadata.gz: 9cc995d436e78cb0be33beb51fa674d0f59baa8c
+  data.tar.gz: 2f65f4c68daef1550a7c8c986e17de4b9c333bbc
 SHA512:
-  metadata.gz: 9594e279953f13a993239b5bf7b0ec10df2bcf4d75a8fdb91e024752b70c89282313d6444809b540d612f2bcea1d2f04e9b2d8e6ccfb5386bae21ab41f477bf5
-  data.tar.gz: f41d40d4cb674ebc1160c8b542d1557c7bacc18003ec91b7b607644bd03d7e94df32596f39de1b98dd9811596b09917d173018fdd271bf62d7ec1a56780eb956
+  metadata.gz: 64fd33e5276da4c8cae1f98dfa4b97647af04c0389386ac7417a388fc7e8dd09b8c58baa285f8ddb6406236a17cb7e74cef45592093de9a239c7e573447d1f65
+  data.tar.gz: a2bebcf9e5c72acad74c6c4340288d82f55582e9889403e66e4b7213ee046e8011e193b93f146857eba5fd1747debfcea611c975d5ce4512d6e94ed4c2fee4b9

data/lib/abstract_api_wrapper.rb

@@ -19,7 +19,7 @@ class AbstractApiWrapper
   end
 
   class Request
-    attr_accessor :path, :filters, :chain
+    attr_accessor :path, :filters, :chain, :params
 
     METHODS_MAP = {
       'all'     => 'get',
@@ -65,8 +65,8 @@ class AbstractApiWrapper
           @params = Hashie::Mash.new(params.first || {})
         end
       when 'destroy'
-        if chain[-2] == 'find'
-          path.push(params.first.to_s)
+        if chain[-2] != 'find'
+          raise NoResourceGiven.new('Missing resource id to destroy')
         end
       else
         path.push(method_name)
@@ -106,6 +106,8 @@ class AbstractApiWrapper
 
       "#{@client.base_url}/#{path.join('/')}?#{query_string}"
     end
+
+    class NoResourceGiven < StandardError; end
   end
 
   class Response
@@ -150,7 +152,7 @@ class AbstractApiWrapper
       end
 
       def headers
-        @headers ||= @request.headers
+        @headers ||= Hashie::Mash.new(@request.headers)
       end
 
       def pagination

data/lib/abstract_api_wrapper/version.rb

@@ -1,3 +1,3 @@
 class AbstractApiWrapper
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

data/spec/abstract_api_wrapper_spec.rb

@@ -36,6 +36,22 @@ describe 'AbstractApiWrapper' do
       expect(user.object_id).to eq(project.object_id)
     end
 
+    it 'should set a Collection instance for an array response' do
+      stub_request(:get, "#{TEST_OPTIONS[:base_url]}/users?apiver=v3")
+        .to_return(status: 200, body: '[]')
+
+      users = @client.users.all.run
+      expect(users).to be_kind_of(AbstractApiWrapper::Response::Collection)
+    end
+
+    it 'should set a Resource instance for an object response' do
+      stub_request(:get, "#{TEST_OPTIONS[:base_url]}/users/1?apiver=v3")
+        .to_return(status: 200, body: '{}')
+
+      user = @client.users.find(1).run
+      expect(user).to be_kind_of(AbstractApiWrapper::Response::Resource)
+    end
+
     it 'should create a path as array' do
       request = @client.users.find(1)
       expect(request.path).to be_kind_of(Array)
@@ -49,10 +65,45 @@ describe 'AbstractApiWrapper' do
       expect(request.filters).to eq({ 'active' => true })
     end
 
-    it 'should set the path chain' do
+    it 'should set the path chain to get a collection' do
       request = @client.users.find(1).projects.all(active: true)
-      expect(request.chain).to be_kind_of(Array)
       expect(request.chain).to eq(['users', 'find', 'projects', 'all'])
+      expect(request.path).to eq(['users', '1', 'projects'])
+      expect(request.filters).to eq({'active' => true})
+    end
+
+    it 'should set the path chain to make a head request' do
+      request = @client.users.find(1).projects.all(active: true).head
+      expect(request.chain).to eq(['users', 'find', 'projects', 'all', 'head'])
+      expect(request.path).to eq(['users', '1', 'projects'])
+      expect(request.filters).to eq({'active' => true})
+    end
+
+    it 'should set the path to create resource' do
+      request = @client.users.create(name: 'Jon Snow')
+      expect(request.chain).to eq(['users', 'create'])
+      expect(request.path).to eq(['users'])
+      expect(request.params).to eq({ 'name' => 'Jon Snow' })
+    end
+
+    it 'should set the path to update a resource' do
+      request = @client.users.find(1).update(name: 'Jon Targaryen')
+      expect(request.chain).to eq(['users', 'find', 'update'])
+      expect(request.path).to eq(['users', '1'])
+      expect(request.params).to eq({ 'name' => 'Jon Targaryen' })
+    end
+
+    it 'should set the path to delete a resoure' do
+      request = @client.users.find(1).destroy
+      expect(request.chain).to eq(['users', 'find', 'destroy'])
+      expect(request.path).to eq(['users', '1'])
+      expect(request.params).to eq({})
+    end
+
+    it 'should raise an error if no resoure to destroy is given' do
+      expect {
+        request = @client.users.destroy
+      }.to raise_error(AbstractApiWrapper::Request::NoResourceGiven)
     end
   end
 
@@ -100,9 +151,24 @@ describe 'AbstractApiWrapper' do
       end
     end
 
-    # TODO: Collection tests
-    # describe 'Collection' do
-    # end
+    describe 'Collection' do
+      before(:each) do
+        @items = [
+          { id: 1, full_name: 'Jon Snow', email: 'jon@winterfell.com' },
+          { id: 1, full_name: 'Jon Snow', email: 'tyrion@lannisport.com' },
+        ]
+      end
+
+      it 'should create a new Collection instance' do
+        request = Faraday.get(TEST_OPTIONS[:base_url])
+        collection = AbstractApiWrapper::Response::Collection.new(@items, request)
+
+        expect(collection).to be_kind_of(Array)
+        expect(collection.size).to be(2)
+        expect(collection.headers).to be_kind_of(Hashie::Mash)
+        expect(collection.pagination).to be_kind_of(Hashie::Mash)
+      end
+    end
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: abstract_api_wrapper
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Juan Puelpan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-10 00:00:00.000000000 Z
+date: 2016-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json