aboutyou-sdk 0.0.17 → 0.0.18

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MDZjYTljYjAzN2FkZGIwNWQ5MTYyM2Q5N2FiN2U0MGRiOGQ4ZDE3Ng==
+    YjIwODhmODg5MDU3ZTU5YTYwMTZjMTU2ZGUyOGMxMjEwNDYxZmQ1NQ==
   data.tar.gz: !binary |-
-    MmQ2MTc4YTc3N2UwNjM2NjYwMjcwYjM1YzcwY2JkMTliMGNjMDA1Mw==
+    YzBkNjZiNzZlODM0ZDljYjc3YzIwMTJlNDk3ZDU3YmRiNTMzYWQ0YQ==
 SHA512:
   metadata.gz: !binary |-
-    OTUxNjQwYzRhN2IwZjI1ZWVlZDAzMWU1NzI3YTY0NWI1NWJhYzE0OTExY2Jh
-    OTM5MzUyZTVjZjhkZGEwNWEzYWVkNGVkZjUxYTI4MDU4NmMyNGYxNDY3NTgz
-    ZDZkYjFhY2JhY2YzYzU5MjUwMTkwNzE0M2YwMTUyODY0YWZlMzA=
+    ZTM5Nzg4OTI0YTNkMzE3ZTQ4MmEzYzNkMmYxYjY5ODIzODFmN2M4OWZmYmM4
+    MTJlNWQwN2Q4ZjZhNGQ4MjIxOGU2N2I0N2IxYjBlOTcyNjMxZmE4NWRmZDc0
+    ZTAyNWM2NDZjMDBlNGMwZmIzZjQwMThlMTBhNzUwYjFhNDA0YjI=
   data.tar.gz: !binary |-
-    NDc1MTU2Mzc4YTk1NWNkYzU5ZDg5MTcxOWQzY2RlMGE0MmRmYTAxZWZmMjhm
-    YzRhMWM0YTFlZDRhZjBlMzYwMDZmZTk0NzFlZmM0YjVkZTUyYjE5Y2U5ZDE0
-    YzFjYTQ1N2UwNzJiYjM0ZWQxNGU4Njc2YmJiMDJjNjY1ZTZlYjI=
+    YzY2ZGEwMmU4NTI1MmUwNjgwOTU5YWQ2OTBlN2Q0MTgzNTI5ZTFhOWFkMzE4
+    NzcwMDAzOTI3NGFmYjBlNDcwMDY5Yzc5YjlmYzRhNmEyNThkMTZlN2JmODk0
+    YTllYzNjNzBiODNjODU3ZjA3Y2RhODdlYTlhNTliNTZkNmU4ZDA=

data/lib/aboutyou-sdk/Model/Product.rb

@@ -33,8 +33,8 @@ module AboutYou
         attr_accessor :activeLeafCategories
 
         
-        def createFromJson(jsonObject, factory, appId)
-          product = self.new(jsonObject, factory)
+        def self.createFromJson(jsonObject, factory, appId)
+          product = self.new
 
           # these are required fields
           raise 'MalformedJsonException!' unless jsonObject["id"] || jsonObject["name"]
@@ -56,8 +56,8 @@ module AboutYou
           product.maxSavingsPrice       = jsonObject["max_savings"] ? jsonObject["max_savings"] : nil
           product.maxSavingsPercentage  = jsonObject["max_savings_percentage"] ? jsonObject["max_savings_percentage"] : nil
 
-          product.defaultImage          = jsonObject["default_image"] ? jsonObject["default_image"] : nil
-          product.defaultVariant        = jsonObject["default_variant"] ? jsonObject["default_variant"] : nil
+          product.defaultImage          = jsonObject["default_image"] ? factory.createImage(jsonObject["default_image"]) : nil
+          product.defaultVariant        = jsonObject["default_variant"] ? factory.createVariant(jsonObject["default_variant"]) : nil
           
           product.variants              = product.parseVariants(jsonObject, factory, product)
           product.inactiveVariants      = product.parseVariants(jsonObject, factory, product, 'inactive_variants')
@@ -66,15 +66,15 @@ module AboutYou
           key                           = 'categories.' + String(appId)
           product.categoryIdPaths       = jsonObject["key"] ? jsonObject["key"] : []
 
-          product.facetIds             = product.parseFacetIds(jsonObject)
+          product.facetIds              = product.parseFacetIds(jsonObject)
 
           product
         end
 
         def parseVariants(jsonObject, factory, product, attributeName = 'variants')
           variants = {}
-          unless jsonObject[attributeName].empty?
-                jsonObject["attributeName"].each do |jsonVariant|
+          if jsonObject.key?(attributeName) && !jsonObject[attributeName].empty?
+                jsonObject[attributeName].each do |jsonVariant|
                   variants[jsonVariant["id"]] = factory.createVariant(jsonVariant, product)
                 end
           end
@@ -84,7 +84,7 @@ module AboutYou
 
         def parseStyles(jsonObject, factory)
           styles = []
-          unless jsonObject["styles"].empty?
+          if jsonObject.key?("styles") && !jsonObject["styles"].empty?
             jsonObject["styles"].each do |style|
               styles.push(factory.createProduct(style))
             end
@@ -109,15 +109,15 @@ module AboutYou
         def parseFacetIds(jsonObject)
           ids = self.parseFacetIdsInAttributesMerged(jsonObject)
 
-          ids = self.parseFacetIdsInVariants(jsonObject) if ids === null
+          ids = self.parseFacetIdsInVariants(jsonObject) if ids === nil
 
-          ids = self.parseFacetIdsInBrand(jsonObject) if $ids === null
+          ids = self.parseFacetIdsInBrand(jsonObject) if $ids === nil
 
           ids != nil ? ids : []
         end
 
         def parseFacetIdsInAttributesMerged(jsonObject)
-          return nil if jsonObject["attributes_merged"].empty?
+          return nil unless jsonObject["attributes_merged"]
 
           self.parseAttributesJson(jsonObject["attributes_merged"])
         end

data/tests/testProductsByIds.rb

@@ -1,5 +1,6 @@
 require 'sinatra'
-require 'aboutyou-sdk'
+require 'pry_debug'
+require_relative '../lib/aboutyou-sdk.rb'
 
 class AY
   attr_accessor :result
@@ -26,8 +27,8 @@ shop.result = ""
 productsResult = shop.fetchProductsByIds([661132, 660971, 661367, 661361, 661350, 661345],["default_image", "variants"])
 productsResult.products.each do |key, prod|
   shop.result = shop.result + '<ul>' + '<li>' + String(prod.id) + ' : ' + prod.name + '</br>' + '<img src="' + prod.defaultImage.url + '">'
-    prod.variants.each_with_index do |var, index|
-      shop.result = shop.result + '<ul>' + '<li>' + 'Variante: '+ String(index) + String(var.id) + '</ul>'
+    prod.variants.each do |key, var|
+      shop.result = shop.result + '<ul>' + '<li>' + 'Variante: ' + String(var.id) + '</ul>'
     end
     shop.result = shop.result + '</li>' + '</ul>'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aboutyou-sdk
 version: !ruby/object:Gem::Version
-  version: 0.0.17
+  version: 0.0.18
 platform: ruby
 authors:
 - Ferenc Beutel