ably 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f42d74184e0de100d535fa3c01595727b78a6d2cd6018d1743e2593c20fe7ed7
-  data.tar.gz: db674f894bc006187816c0e51df19b84a7473d178b8360271a27640e7b3e4f6e
+  metadata.gz: 6d535fd596cbed132fc9c540fb46997c5fcaafeae4b4531ab6fbe02dba33178f
+  data.tar.gz: 1792b4e4f47d7044d0a937d3b75f9e3b9d9f1d6a436a36bfde2f9e65ae3f2552
 SHA512:
-  metadata.gz: 5950df21ad66e4c59eb6bd772ab71aa91b421679139166ddaa9076ea4fc7cc9a6eb9993a3f4e15e30a2d362a05c008587b153617c967da6a41aa6e0efdc3f091
-  data.tar.gz: a9d61d9b6c12397df274f55028a1fcbd6c285235cb489027188c799949466a6a74c4e6ea3829bd44851be48af14e05a2f7d49494ea61d1ea190176773079df23
+  metadata.gz: fad634a453ebbb3d1b05ad13fa7c3683e794635862267376920aa7d43e93afeab7c5ba06398609e048d7f421f8d10f80f9866828f07468e153be843f6b38a136
+  data.tar.gz: 1d76ae8ffe50a043b82fbb553af787a2a49665909d802f6471644e9614d81677d04c38926cb34890a2daeef2d498cabe7c39817c40fbb8d1be88070d2d103669

data/.github/workflows/check.yml

@@ -10,7 +10,7 @@ jobs:
     continue-on-error: true
     strategy:
       matrix:
-        ruby: [ '2.5', '2.6', '2.7', '3.0' ]
+        ruby: [ '2.7', '3.0', '3.1' ]
         protocol: [ 'json', 'msgpack' ]
     steps:
       - uses: actions/checkout@v2

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Change Log
 
+## [v1.2.1](https://github.com/ably/ably-ruby/tree/v1.2.1)
+
+[Full Changelog](https://github.com/ably/ably-ruby/compare/v1.2.0...v1.2.1)
+
+**Fixed bugs:**
+
+- Update Ruby version \(and Gemfile.lock dependencies\) [\#253](https://github.com/ably/ably-ruby/issues/253)
+- Error not emitted when failing to connect to an endpoint indefinitely [\#233](https://github.com/ably/ably-ruby/issues/233)
+- Connection errors when there should be warnings [\#198](https://github.com/ably/ably-ruby/issues/198)
+- Implement presence re-entry requirement change for 1.1 [\#185](https://github.com/ably/ably-ruby/issues/185)
+
+**Closed issues:**
+
+- Update urls in readme [\#353](https://github.com/ably/ably-ruby/issues/353)
+- Reconsider required Ruby version [\#344](https://github.com/ably/ably-ruby/issues/344)
+
 ## [v1.2.0](https://github.com/ably/ably-ruby/tree/v1.2.0)
 
 [Full Changelog](https://github.com/ably/ably-ruby/compare/v1.1.8...v1.2.0)
@@ -8,33 +24,11 @@ This release updates ably-ruby to be compliant with the 1.2 version of the Ably
 
 **Closed issues:**
 
-- create migration guide for the upgrade to ruby 1.2  [\#347](https://github.com/ably/ably-ruby/issues/347)
-- Write spec tests for RTL17 [\#304](https://github.com/ably/ably-ruby/issues/304)
-- Write spec tests for RTL16, RTL16a [\#303](https://github.com/ably/ably-ruby/issues/303)
-- Write spec tests for RTL4m [\#302](https://github.com/ably/ably-ruby/issues/302)
-- Write spec tests for RTL4l [\#301](https://github.com/ably/ably-ruby/issues/301)
-- Write spec tests for RTL4k, RTL4k1 [\#300](https://github.com/ably/ably-ruby/issues/300)
-- Write spec tests for RTL4j, RTL4j1, RTL4j2 [\#299](https://github.com/ably/ably-ruby/issues/299)
-- Write spec tests for RTS3c, RTS3c1 [\#298](https://github.com/ably/ably-ruby/issues/298)
-- Write spec tests for RTS3a [\#297](https://github.com/ably/ably-ruby/issues/297)
-- Add support for RTL21 [\#296](https://github.com/ably/ably-ruby/issues/296)
-- Add support for RTL17 [\#292](https://github.com/ably/ably-ruby/issues/292)
-- Add support for RTL16, RTL16a [\#291](https://github.com/ably/ably-ruby/issues/291)
-- Add support for RTL4m [\#290](https://github.com/ably/ably-ruby/issues/290)
-- Add support for RTL4l [\#289](https://github.com/ably/ably-ruby/issues/289)
-- Add support for RTL4k, RTL4k1 [\#288](https://github.com/ably/ably-ruby/issues/288)
-- Add support for RTL4j, RTL4j1, RTL4j2 [\#287](https://github.com/ably/ably-ruby/issues/287)
-- Add support for RTS3c, RTS3c1 [\#286](https://github.com/ably/ably-ruby/issues/286)
-- Add support for RTS3a [\#285](https://github.com/ably/ably-ruby/issues/285)
-- Write spec tests for RSL1a, b, h, k1, k2, l, l1 \(Channels\) [\#283](https://github.com/ably/ably-ruby/issues/283)
-- Write spec tests for RSN3a, c \(Channels\) [\#282](https://github.com/ably/ably-ruby/issues/282)
-- Write spec tests for RSA4b, b1, c, RSA16 \(Authentication\) [\#281](https://github.com/ably/ably-ruby/issues/281)
-- Add support for RSN3a, c \(Channels\) [\#269](https://github.com/ably/ably-ruby/issues/269)
-- Add support for RSA4b, b1, c, RSA16 \(Authentication\) [\#268](https://github.com/ably/ably-ruby/issues/268)
-- Add support for RSC7a, RSC7c \(RestClient\)
- [\#266](https://github.com/ably/ably-ruby/issues/266)
-- Add support for Test Guidance G4 [\#265](https://github.com/ably/ably-ruby/issues/265)
-- Add support for TO3o, TO3p [\#264](https://github.com/ably/ably-ruby/issues/264)
+- Add Channel.setOptions method [\#291](https://github.com/ably/ably-ruby/issues/291)
+- Add support for channel params [\#288](https://github.com/ably/ably-ruby/issues/288)
+- Use ATTACH_RESUME flag for unclean attaches [\#287](https://github.com/ably/ably-ruby/issues/287)
+- Add ChannelOptions param to Channels.get [\#285](https://github.com/ably/ably-ruby/issues/285)
+- Update library to adhere to new spec for token renewal (see [the spec definition](https://docs.ably.io/client-lib-development-guide/features/#RSA4b) for more info) [\#268](https://github.com/ably/ably-ruby/issues/268)
 
 **Merged pull requests:**
 

data/README.md

@@ -9,7 +9,7 @@ This is a Ruby client library for Ably. The library currently targets the [Ably
 
 ## Supported platforms
 
-This SDK supports Ruby 1.9.3+. For eventmachine and Ruby 3.0 note please visit [Ruby 3.0 support](#ruby-30-support) section.
+This SDK supports Ruby 2.7 and 3.x. For eventmachine and Ruby 3.x note please visit [Ruby 3.0 support](#ruby-30-support) section.
 
 As of v1.1.5 this library requires `libcurl` as a system dependency. On most systems this is already installed but in rare cases where it isn't (for example debian-slim Docker images such as ruby-slim) you will need to install it yourself. On debian you can install it with the command `sudo apt-get install libcurl4`.
 

data/ably.gemspec

@@ -20,41 +20,28 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'eventmachine', '~> 1.2.6'
   spec.add_runtime_dependency 'em-http-request', '~> 1.1'
-  spec.add_runtime_dependency 'statesman', '~> 8.0'
-  spec.add_runtime_dependency 'faraday', '~> 1.0'
+  spec.add_runtime_dependency 'statesman', '~> 9.0'
+  spec.add_runtime_dependency 'faraday', '~> 2.2'
+  spec.add_runtime_dependency 'faraday-typhoeus', '~> 0.2.0'
   spec.add_runtime_dependency 'typhoeus', '~> 1.4'
-
-  if RUBY_VERSION.match(/^1\./)
-    spec.add_runtime_dependency 'json', '< 2.0'
-  else
-    spec.add_runtime_dependency 'json'
-  end
+  spec.add_runtime_dependency 'json'
   spec.add_runtime_dependency 'websocket-driver', '~> 0.7'
   spec.add_runtime_dependency 'msgpack', '>= 1.3.0'
   spec.add_runtime_dependency 'addressable', '>= 2.0.0'
 
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'redcarpet', '~> 3.3'
-  spec.add_development_dependency 'rspec', '~> 3.10.0'
+  spec.add_development_dependency 'rspec', '~> 3.11.0'
   spec.add_development_dependency 'rspec-retry', '~> 0.6'
   spec.add_development_dependency 'yard', '~> 0.9'
   spec.add_development_dependency 'rspec-instafail', '~> 1.0'
   spec.add_development_dependency 'bundler', '>= 1.3.0'
-
-  if RUBY_VERSION.match(/^1\./)
-    spec.add_development_dependency 'public_suffix', '~> 1.4.6' # Later versions do not support Ruby 1.9
-    spec.add_development_dependency 'webmock', '2.2'
-    spec.add_development_dependency 'parallel_tests', '~> 2.9.0'
-  else
-    spec.add_development_dependency 'webmock', '~> 3.11'
-    spec.add_development_dependency 'simplecov', '~> 0.21.2'
-    spec.add_development_dependency 'simplecov-lcov', '~> 0.8.0'
-    spec.add_development_dependency 'parallel_tests', '~> 3.7'
-    if !RUBY_VERSION.match(/^2\.[0123]/)
-      spec.add_development_dependency 'pry', '~> 0.14.1'
-      spec.add_development_dependency 'pry-byebug', '~> 3.8.0'
-    end
-  end
+  spec.add_development_dependency 'webmock', '~> 3.11'
+  spec.add_development_dependency 'simplecov', '~> 0.21.2'
+  spec.add_development_dependency 'simplecov-lcov', '~> 0.8.0'
+  spec.add_development_dependency 'parallel_tests', '~> 3.8'
+  spec.add_development_dependency 'pry', '~> 0.14.1'
+  spec.add_development_dependency 'pry-byebug', '~> 3.8.0'
 
   if RUBY_VERSION.match(/^3\./)
     spec.add_development_dependency 'webrick', '~> 1.7.0'

data/lib/ably/auth.rb

@@ -5,9 +5,9 @@ require 'securerandom'
 require 'ably/rest/middleware/external_exceptions'
 
 module Ably
-  # Auth is responsible for authentication with {https://www.ably.io Ably} using basic or token authentication
+  # Auth is responsible for authentication with {https://www.ably.com Ably} using basic or token authentication
   #
-  # Find out more about Ably authentication at: https://www.ably.io/documentation/general/authentication/
+  # Find out more about Ably authentication at: https://www.ably.com/docs/general/authentication/
   #
   # @!attribute [r] client_id
   #   @return [String] The provided client ID, used for identifying this client for presence purposes
@@ -35,7 +35,7 @@ module Ably
 
     API_KEY_REGEX = /^[\w-]{2,}\.[\w-]{2,}:[\w-]{2,}$/
 
-    # Supported AuthOption keys, see https://www.ably.io/documentation/realtime/types#auth-options
+    # Supported AuthOption keys, see https://www.ably.com/docs/realtime/types#auth-options
     # TODO: Review client_id usage embedded incorrectly within AuthOptions.
     #       This is legacy code to configure a client with a client_id from the ClientOptions
     # TODO: Review inclusion of use_token_auth, ttl, token_params in auth options
@@ -277,7 +277,7 @@ module Ably
     #
     # @param [Hash] token_params the token params used in the token request
     # @option token_params [String]  :client_id     A client ID to associate with this token. The generated token may be used to authenticate as this +client_id+
-    # @option token_params [Integer] :ttl           validity time in seconds for the requested {Ably::Models::TokenDetails}.  Limits may apply, see {https://www.ably.io/documentation/other/authentication}
+    # @option token_params [Integer] :ttl           validity time in seconds for the requested {Ably::Models::TokenDetails}.  Limits may apply, see {https://www.ably.com/docs/general/authentication}
     # @option token_params [Hash]    :capability    canonicalised representation of the resource paths and associated operations
     # @option token_params [Time]    :timestamp     the time of the request
     # @option token_params [String]  :nonce         an unquoted, unescaped random string of at least 16 characters
@@ -285,7 +285,7 @@ module Ably
     # @param [Hash] auth_options the authentication options for the token request
     # @option auth_options [String]  :key           API key comprising the key name and key secret in a single string
     # @option auth_options [String]  :client_id     client ID identifying this connection to other clients (will use +client_id+ specified when library was instanced if provided)
-    # @option auth_options [Boolean] :query_time    when true will query the {https://www.ably.io Ably} system for the current time instead of using the local time
+    # @option auth_options [Boolean] :query_time    when true will query the {https://www.ably.com Ably} system for the current time instead of using the local time
     # @option auth_options [Hash]    :token_params  convenience to pass in +token_params+ within the +auth_options+ argument, especially useful when setting default token_params in the client constructor
     #
     # @return [Models::TokenRequest]

data/lib/ably/logger.rb

@@ -7,9 +7,9 @@ module Ably
     extend Forwardable
 
     # @param client        [Ably::Rest::Client,Ably::Realtime::Client] Rest or Realtime Ably client
-    # @param log_level     [Integer] {http://www.ruby-doc.org/stdlib-1.9.3/libdoc/logger/rdoc/Logger.html Ruby Logger} log level
+    # @param log_level     [Integer] {http://www.ruby-doc.org/stdlib-3.1.1/libdoc/logger/rdoc/Logger.html Ruby Logger} log level
     # @param custom_logger [nil,Object] A custom logger can optionally be used instead of the,
-    #                      however it must provide a {http://www.ruby-doc.org/stdlib-1.9.3/libdoc/logger/rdoc/Logger.html Ruby Logger} compatible interface.
+    #                      however it must provide a {http://www.ruby-doc.org/stdlib-3.1.1/libdoc/logger/rdoc/Logger.html Ruby Logger} compatible interface.
     #
     def initialize(client, log_level, custom_logger = nil)
       @client        = client
@@ -24,7 +24,7 @@ module Ably
       @log_mutex = Mutex.new
     end
 
-    # The logger used by this class, defaults to {http://www.ruby-doc.org/stdlib-1.9.3/libdoc/logger/rdoc/Logger.html Ruby Logger}
+    # The logger used by this class, defaults to {http://www.ruby-doc.org/stdlib-3.1.1/libdoc/logger/rdoc/Logger.html Ruby Logger}
     # @return {Object,Logger}
     attr_reader :logger
 
@@ -32,7 +32,7 @@ module Ably
     # @return {nil,Object}
     attr_reader :custom_logger
 
-    # The log level ranging from DEBUG to FATAL, refer to http://www.ruby-doc.org/stdlib-1.9.3/libdoc/logger/rdoc/Logger.html
+    # The log level ranging from DEBUG to FATAL, refer to http://www.ruby-doc.org/stdlib-3.1.1/libdoc/logger/rdoc/Logger.html
     # @return {Integer}
     attr_reader :log_level
 

data/lib/ably/models/device_details.rb

@@ -27,7 +27,7 @@ module Ably::Models
   # @!attribute [r] form_factor
   #   @return [String] Device form factor such as phone, tablet, watch
   # @!attribute [r] client_id
-  #   @return [String] The authenticated client identifier for this device. See {https://www.ably.io/documentation/general/authentication#identified-clients auth documentation}.
+  #   @return [String] The authenticated client identifier for this device. See {https://www.ably.com/docs/general/authentication#identified-clients auth documentation}.
   # @!attribute [r] metadata
   #   @return [Hash] Arbitrary metadata that can be associated with a device
   # @!attribute [r] device_secret

data/lib/ably/models/protocol_message.rb

@@ -3,7 +3,7 @@ module Ably::Models
   # A ProtocolMessage always relates to a single channel only, but
   # can contain multiple individual Messages or PresenceMessages.
   # ProtocolMessages are serially numbered on a connection.
-  # See the {http://docs.ably.io/client-lib-development-guide/protocol/ Ably client library developer documentation}
+  # See the {http://ably.com/docs/client-lib-development-guide/protocol/ Ably client library developer documentation}
   # for further details on the members of a ProtocolMessage
   #
   # @!attribute [r] action
@@ -11,7 +11,7 @@ module Ably::Models
   # @!attribute [r] auth
   #   @return [Ably::Models::AuthDetails] Authentication details used to perform authentication upgrades over an existing transport
   # @!attribute [r] count
-  #   @return [Integer] The count field is used for ACK and NACK actions. See {http://docs.ably.io/client-lib-development-guide/protocol/#message-acknowledgement message acknowledgement protocol}
+  #   @return [Integer] The count field is used for ACK and NACK actions. See {http://ably.com/docs/client-lib-development-guide/protocol/#message-acknowledgement message acknowledgement protocol}
   # @!attribute [r] error
   #   @return [ErrorInfo] Contains error information
   # @!attribute [r] channel

data/lib/ably/models/token_request.rb

@@ -98,7 +98,7 @@ module Ably::Models
 
     # @!attribute [r] mac
     # @return [String]  the Message Authentication Code for this request. See the
-    #                   {https://www.ably.io/documentation Ably Authentication documentation} for more details.
+    #                   {https://www.ably.com/docs Ably Authentication documentation} for more details.
     def mac
       attributes.fetch(:mac) { raise Ably::Exceptions::InvalidTokenRequest, 'MAC is missing' }
     end

data/lib/ably/modules/ably.rb

@@ -6,7 +6,7 @@
 module Ably
   # Fallback hosts to use when a connection to rest/realtime.ably.io is not possible due to
   # network failures either at the client, between the client and Ably, within an Ably data center, or at the IO domain registrar
-  # see https://docs.ably.io/client-lib-development-guide/features/#RSC15a
+  # see https://ably.com/docs/client-lib-development-guide/features/#RSC15a
   #
   FALLBACK_DOMAIN = 'ably-realtime.com'.freeze
   FALLBACK_IDS = %w(a b c d e).freeze

data/lib/ably/realtime/auth.rb

@@ -2,10 +2,10 @@ require 'ably/auth'
 
 module Ably
   module Realtime
-    # Auth is responsible for authentication with {https://www.ably.io Ably} using basic or token authentication
+    # Auth is responsible for authentication with {https://www.ably.com Ably} using basic or token authentication
     # This {Ably::Realtime::Auth Realtime::Auth} class wraps the {Ably::Auth Synchronous Ably::Auth} class in an EventMachine friendly way using Deferrables for all IO.  See {Ably::Auth Ably::Auth} for more information
     #
-    # Find out more about Ably authentication at: https://www.ably.io/documentation/general/authentication/
+    # Find out more about Ably authentication at: https://www.ably.com/docs/general/authentication/
     #
     # @!attribute [r] client_id
     #   (see Ably::Auth#client_id)

data/lib/ably/rest/client.rb

@@ -4,7 +4,7 @@ require 'logger'
 require 'uri'
 
 require 'typhoeus'
-require 'typhoeus/adapters/faraday'
+require 'faraday/typhoeus'
 
 require 'ably/rest/middleware/exceptions'
 
@@ -55,7 +55,7 @@ module Ably
       # @return [Symbol]
       attr_reader :protocol
 
-      # Client agent i.e. `example-gem/1.2.0 ably-ruby/1.1.5 ruby/1.9.3`
+      # Client agent i.e. `example-gem/1.2.0 ably-ruby/1.1.5 ruby/3.1.1`
       # @return [String]
       attr_reader :agent
 
@@ -139,7 +139,7 @@ module Ably
       # @option options [Symbol]                  :protocol            (:msgpack) Protocol used to communicate with Ably, :json and :msgpack currently supported
       # @option options [Boolean]                 :use_binary_protocol (true) When true will use the MessagePack binary protocol, when false it will use JSON encoding. This option will overide :protocol option
       # @option options [Logger::Severity,Symbol] :log_level           (Logger::WARN) Log level for the standard Logger that outputs to STDOUT. Can be set to :fatal (Logger::FATAL), :error (Logger::ERROR), :warn (Logger::WARN), :info (Logger::INFO), :debug (Logger::DEBUG) or :none
-      # @option options [Logger]                  :logger              A custom logger can be used however it must adhere to the Ruby Logger interface, see http://www.ruby-doc.org/stdlib-1.9.3/libdoc/logger/rdoc/Logger.html
+      # @option options [Logger]                  :logger              A custom logger can be used however it must adhere to the Ruby Logger interface, see http://www.ruby-doc.org/stdlib-3.1.1/libdoc/logger/rdoc/Logger.html
       # @option options [String]                  :client_id           client ID identifying this connection to other clients
       # @option options [String]                  :auth_url            a URL to be used to GET or POST a set of token request params, to obtain a signed token request
       # @option options [Hash]                    :auth_headers        a set of application-specific headers to be added to any request made to the +auth_url+
@@ -147,7 +147,7 @@ module Ably
       # @option options [Symbol]                  :auth_method         (:get) HTTP method to use with +auth_url+, must be either +:get+ or +:post+
       # @option options [Proc]                    :auth_callback       when provided, the Proc will be called with the token params hash as the first argument, whenever a new token is required.
       #                                                                The Proc should return a token string, {Ably::Models::TokenDetails} or JSON equivalent, {Ably::Models::TokenRequest} or JSON equivalent
-      # @option options [Boolean]                 :query_time          when true will query the {https://www.ably.io Ably} system for the current time instead of using the local time
+      # @option options [Boolean]                 :query_time          when true will query the {https://www.ably.com Ably} system for the current time instead of using the local time
       # @option options [Hash]                    :default_token_params   convenience to pass in +token_params+ that will be used as a default for all token requests. See {Auth#create_token_request}
       #
       # @option options [Integer]                 :http_open_timeout       (4 seconds) timeout in seconds for opening an HTTP connection for all HTTP requests

data/lib/ably/rest/middleware/encoder.rb

@@ -5,7 +5,7 @@ module Ably
   module Rest
     module Middleware
       # Encode the body of the message according to the mime type
-      class Encoder < ::Faraday::Response::Middleware
+      class Encoder < Faraday::Middleware
         CONTENT_TYPE = 'Content-Type'.freeze unless defined? CONTENT_TYPE
 
         def call(env)

data/lib/ably/rest/middleware/exceptions.rb

@@ -6,7 +6,7 @@ module Ably
     module Middleware
       # HTTP exceptions raised by Ably due to an error status code
       # Ably returns JSON/Msgpack error codes and messages so include this if possible in the exception messages
-      class Exceptions < Faraday::Response::Middleware
+      class Exceptions < Faraday::Middleware
         def on_complete(env)
           if env.status >= 400
             error_status_code = env.status

data/lib/ably/rest/middleware/external_exceptions.rb

@@ -5,7 +5,7 @@ module Ably
     module Middleware
       # HTTP exceptions raised due to a status code error on a 3rd party site
       # Used by auth calls
-      class ExternalExceptions < Faraday::Response::Middleware
+      class ExternalExceptions < Faraday::Middleware
         def on_complete(env)
           if env.status >= 400
             error_status_code = env.status

data/lib/ably/rest/middleware/fail_if_unsupported_mime_type.rb

@@ -4,7 +4,7 @@ require 'json'
 module Ably
   module Rest
     module Middleware
-      class FailIfUnsupportedMimeType < Faraday::Response::Middleware
+      class FailIfUnsupportedMimeType < Faraday::Middleware
         def on_complete(env)
           unless env.response_headers['Ably-Middleware-Parsed'] == true
             # Ignore empty body with success status code for no body response

data/lib/ably/rest/middleware/logger.rb

@@ -3,7 +3,7 @@ require 'faraday'
 module Ably
   module Rest
     module Middleware
-      class Logger < Faraday::Response::Middleware
+      class Logger < Faraday::Middleware
         extend Forwardable
 
         def initialize(app, logger = nil)

data/lib/ably/rest/middleware/parse_json.rb

@@ -4,7 +4,7 @@ require 'json'
 module Ably
   module Rest
     module Middleware
-      class ParseJson < Faraday::Response::Middleware
+      class ParseJson < Faraday::Middleware
         def on_complete(env)
           if env.response_headers['Content-Type'] == 'application/json'
             env.body = parse(env.body) unless env.response_headers['Ably-Middleware-Parsed'] == true

data/lib/ably/rest/middleware/parse_message_pack.rb

@@ -4,7 +4,7 @@ require 'msgpack'
 module Ably
   module Rest
     module Middleware
-      class ParseMessagePack < Faraday::Response::Middleware
+      class ParseMessagePack < Faraday::Middleware
         def on_complete(env)
           if env.response_headers['Content-Type'] == 'application/x-msgpack'
             env.body = parse(env.body) unless env.response_headers['Ably-Middleware-Parsed'] == true

data/lib/ably/version.rb

@@ -1,5 +1,5 @@
 module Ably
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
   PROTOCOL_VERSION = '1.2'
 
   # @api private

data/spec/acceptance/realtime/connection_spec.rb

@@ -482,6 +482,26 @@ describe Ably::Realtime::Connection, :event_machine do
         end
       end
 
+      context "when can't connect to host" do
+        let(:client_options) { super().merge(realtime_host: 'non-existent.ably.io') }
+
+        it 'logs error on failed connection attempt' do
+          logger_expectation = lambda do |*args, &block|
+            error_message = "Connection to non-existent.ably.io:443 failed"
+            expect(args.concat([block ? block.call : nil]).join(',')).to include(error_message)
+            stop_reactor
+          end
+
+          expect(connection.logger).to receive(:warn, &logger_expectation).at_least(:once)
+
+          connection.on(:connected) do
+            raise "Connection should not succeed"
+          end
+
+          connection.connect
+        end
+      end
+
       context 'when explicitly reconnecting disconnected/suspended connection in retry (#RTN11c)' do
         let(:close_connection_proc) do
           lambda do

data/spec/acceptance/rest/client_spec.rb

@@ -1081,7 +1081,7 @@ describe Ably::Rest::Client do
     end
 
     context 'version headers', :webmock do
-      [nil, 'ably-ruby/1.1.1 ruby/1.9.3'].each do |agent|
+      [nil, 'ably-ruby/1.1.1 ruby/3.1.1'].each do |agent|
         context "with #{agent ? "custom #{agent}" : 'default'} agent" do
           let(:client_options) { default_options.merge(key: api_key, agent: agent) }
 

data/spec/run_parallel_tests

@@ -11,13 +11,8 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
 bundle exec rspec "${DIR}/unit"
 unit_status=$?
 
-if ruby -v | grep -e "1.9"; then
-  # Output with test ID is not supported with this old version of RSpec
-  # So it will be jumbled sadly for 1.9.*
-  bundle exec parallel_rspec "${DIR}/acceptance"
-else
-  bundle exec parallel_rspec "${DIR}/acceptance" --prefix-output-with-test-env-number
-fi
+bundle exec parallel_rspec "${DIR}/acceptance" --prefix-output-with-test-env-number
+
 acceptance_status=$?
 
 if [ $unit_status -ne 0 ]; then

data/spec/unit/logger_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Ably::Logger do
+describe Ably::Logger, :prevent_log_stubbing do
   let(:rest_client) do
     instance_double('Ably::Rest::Client')
   end
@@ -18,14 +18,10 @@ describe Ably::Logger do
 
   context 'internals', :api_private do
     it 'delegates to the default Logger object' do
-      received = false
       expect(subject.logger).to be_a(::Logger)
-      allow_any_instance_of(::Logger).to receive(:warn) do |*args, &block|
-        expect(args.concat([block ? block.call : nil]).join(',')).to match(/message/)
-        received = true
-      end
+      expect(subject.logger).to receive(:warn).with('message')
+
       subject.warn 'message'
-      expect(received).to be_truthy
     end
 
     context 'formatter' do
@@ -136,18 +132,14 @@ describe Ably::Logger do
       end
 
       it 'delegates log messages to logger', :api_private do
-        received = false
-        allow(custom_logger_object).to receive(:fatal) do |*args, &block|
-          expect(args.concat([block ? block.call : nil]).join(',')).to match(/message/)
-          received = true
-        end
+        expect(custom_logger_object).to receive(:fatal).with('message')
+
         subject.fatal 'message'
-        expect(received).to be_truthy
       end
     end
   end
 
-  context 'with blocks', :prevent_log_stubbing do
+  context 'with blocks' do
     it 'does not call the block unless the log level is met' do
       log_level_blocks = []
       subject.warn { log_level_blocks << :warn }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ably
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Lewis Marshall
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-05 00:00:00.000000000 Z
+date: 2022-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -45,28 +45,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '8.0'
+        version: '9.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '8.0'
+        version: '9.0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.2'
+- !ruby/object:Gem::Dependency
+  name: faraday-typhoeus
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
@@ -171,14 +185,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.10.0
+        version: 3.11.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.10.0
+        version: 3.11.0
 - !ruby/object:Gem::Dependency
   name: rspec-retry
   requirement: !ruby/object:Gem::Requirement
@@ -283,14 +297,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -565,7 +579,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.14
 signing_key:
 specification_version: 4
 summary: A Ruby client library for ably.io realtime messaging implemented using EventMachine