ab_panel 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9cd40ac48f8a81ab3c3e25191df7fd8456f2b361
-  data.tar.gz: fafb1c9fd106b2c04f32879eeb93ecc3f2ad96cf
+  metadata.gz: 1a6384dbbb2f6f5d733852536b3eebcebff6e680
+  data.tar.gz: 2d5cac0f67172e2af1ac26d734d9f3dfad14a9a1
 SHA512:
-  metadata.gz: 9f0088ff50569782f0a3b275b21ea484b4362323e420ca2e1dbb0ab438e59e04cbdb3bddd7eb87b6e7223fbf84bd671275eebf3f921b27b38554f9322df0d8ec
-  data.tar.gz: 9fdfbab96cbfc532e34d72c42078302e94f00642433ceb29355625721a6fabba8ceb94b40476fcd8a6bbd4a847526ff8c83ab1e396b362757020ebaa32222dce
+  metadata.gz: ca426b425a10f82474e6b3f8013bf505e06754cfc75b670c6e5cd54d0d14e5b9cea90a502ffe0113e84de3fecb9be8a5e2cfc11fb24ccf35f4de8d3c81548fd0
+  data.tar.gz: b8edc3524941c3e68e3b498c1693a23030f79f24844b8221c1dafbea3c120390a1f93a9106b8a6964c4930156a77f6cf3d66803361ffdba7780823862900969d

data/ab_panel.gemspec

@@ -24,6 +24,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "byebug"
 
-  spec.add_runtime_dependency "rails", '~> 4.0'
+  spec.add_runtime_dependency "rails", '>= 4.0', '< 5.2'
   spec.add_runtime_dependency "mixpanel"
 end

data/lib/ab_panel/controller_additions.rb

@@ -27,8 +27,20 @@ module AbPanel
     #
     #   `current_user.id` for logged in users.
     def distinct_id
-      cookies.signed['distinct_id'] ||=
-        (0..4).map { |i| i.even? ? ('A'..'Z').to_a[rand(26)] : rand(10) }.join
+      distinct_id = cookies.signed['distinct_id']
+
+      return distinct_id if distinct_id
+
+      distinct_id = (0..4).map { |i| i.even? ? ('A'..'Z').to_a[rand(26)] : rand(10) }.join
+
+      cookies.signed['distinct_id'] =
+        {
+          value: distinct_id,
+          httponly: true,
+          secure: request.ssl?
+        }
+
+      distinct_id
     end
 
     def ab_panel_options
@@ -57,9 +69,18 @@ module AbPanel
           nil
         end
 
-      cookies.signed[:ab_panel_conditions] = AbPanel.serialized_conditions
+      cookies.signed[:ab_panel_conditions] = {
+        value: AbPanel.serialized_conditions,
+        httponly: true,
+        secure: request.ssl?
+      }
+
       AbPanel.funnels = Set.new(cookies.signed[:ab_panel_funnels])
-      cookies.signed[:ab_panel_funnels] = AbPanel.funnels
+      cookies.signed[:ab_panel_funnels] = {
+        value: AbPanel.funnels,
+        httponly: true,
+        secure: request.ssl?
+      }
 
       {
         'distinct_id' => distinct_id,
@@ -88,7 +109,6 @@ module AbPanel
 
       options = {
         distinct_id: distinct_id,
-        ip:          request.remote_ip,
         time:        Time.now.utc,
       }.merge(properties)
 

data/lib/ab_panel/version.rb

@@ -1,3 +1,3 @@
 module AbPanel
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

data/spec/ab_panel/controller_additions_spec.rb

@@ -13,7 +13,10 @@ describe AbPanel::ControllerAdditions do
 
   describe "#distinct_id" do
     let(:cookies) { {} }
-    before { expect(controller).to receive_message_chain(:cookies, :signed).and_return(cookies) }
+    before do
+      allow(controller).to receive_message_chain(:request, :ssl?).and_return(true)
+      allow(controller).to receive_message_chain(:cookies, :signed).and_return(cookies)
+    end
     subject { controller.distinct_id }
 
     it { is_expected.to match /^([A-Z]|[0-9])([A-Z]|[0-9])([A-Z]|[0-9])([A-Z]|[0-9])([A-Z]|[0-9])$/ }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ab_panel
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Wouter de Vos
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-13 00:00:00.000000000 Z
+date: 2018-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,16 +86,22 @@ dependencies:
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: mixpanel
   requirement: !ruby/object:Gem::Requirement
@@ -228,7 +234,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.5
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Run A/B test experiments on your Rails 4+ site using Mixpanel as a backend.