aanand-deadweight 0.0.2 → 0.0.3

data/README.rdoc

@@ -2,12 +2,13 @@
 
 Deadweight is RCov for CSS, kind of. Given a set of stylesheets and a set of URLs, it determines which selectors are actually used and reports which can be "safely" deleted.
 
-Simple example:
+=== A Simple Example
+
   # lib/tasks/deadweight.rake
 
   require 'deadweight'
 
-  description "run Deadweight (script/server needs to be running)"
+  desc "run Deadweight (script/server needs to be running)"
   task :deadweight do
     dw = Deadweight.new
     dw.stylesheets = %w( /stylesheets/style.css )
@@ -17,18 +18,24 @@ Simple example:
 
 This will output all unused selectors, one per line.
 
-Things to note:
+=== How You Install It
+
+  gem sources -a http://gems.github.com
+  sudo gem install aanand-deadweight
+
+=== Things to Note
+
 - By default, it looks at http://localhost:3000.
 - It's completely dumb about any classes, IDs or tags that are only added by your Javascript layer, but you can filter them out by setting +ignore_selectors+.
 - You can optionally tell it to use Mechanize, and set up more complicated targets for scraping by specifying them as Procs.
 
-More complex example:
+=== A More Complex Example, In Light of All That
 
   # lib/tasks/deadweight.rake
 
   require 'deadweight'
 
-  description "run Deadweight on staging server"
+  desc "run Deadweight on staging server"
   task :deadweight do
     dw = Deadweight.new
 

data/VERSION

@@ -1 +1 @@
-0.0.2
+0.0.3

data/deadweight.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{deadweight}
-  s.version = "0.0.2"
+  s.version = "0.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Aanand Prasad"]
-  s.date = %q{2009-07-21}
+  s.date = %q{2009-08-18}
   s.email = %q{aanand.prasad@gmail.com}
   s.extra_rdoc_files = [
     "LICENSE",

data/lib/deadweight.rb

@@ -33,6 +33,13 @@ class Deadweight
       end
     end
 
+    # Remove selectors with pseudo classes that already have an equivalent
+    # without the pseudo class. Keep the ones that don't, we need to test
+    # them.
+    unused_selectors.reject! do |selector|
+      has_pseudo_classes(selector) && unused_selectors.include?(strip(selector))
+    end
+
     pages.each do |page|
       case page
       when String
@@ -53,7 +60,9 @@ class Deadweight
       found_selectors = []
 
       unused_selectors.each do |selector|
-        unless doc.search(selector).empty?
+        # We test against the selector stripped of any pseudo classes,
+        # but we report on the selector with its pseudo classes.
+        unless doc.search(strip(selector)).empty?
           log.info("  #{selector}")
           found_selectors << selector
         end
@@ -86,9 +95,17 @@ class Deadweight
     else
       open(loc).read
     end
-  end    
+  end
+
+private
 
-  private
+  def has_pseudo_classes(selector)
+    selector =~ /::?[\w\-]+/
+  end
+
+  def strip(selector)
+    selector.gsub(/::?[\w\-]+/, '')
+  end
 
   def log
     @log ||= Logger.new(@log_file)
@@ -108,6 +125,6 @@ class Deadweight
 
       raise
     end
-  end    
+  end
 end
 

data/test/deadweight_test.rb

@@ -20,6 +20,17 @@ class DeadweightTest < Test::Unit::TestCase
     assert !@result.include?('#foo .bar')
   end
 
+  should 'strip pseudo classes from selectors' do
+    # #oof:hover (#oof does not exist)
+    assert @result.include?('#oof:hover'), @result.inspect
+
+    # #foo:hover (#foo does exist)
+    assert !@result.include?('#foo:hover')
+
+    # #rab:hover::selection (#rab does not exist)
+    assert @result.include?('#rab:hover::selection')
+  end
+
   should "accept Procs as targets" do
     @dw.mechanize = true
 

data/test/fixtures/index2.html

@@ -11,6 +11,10 @@
                 </div>
             </div>
         </div>
+
+        <div id="oof"></div>
+
+        <div id="rab"></div>
     </body>
 </html>
 

data/test/fixtures/style.css

@@ -10,3 +10,15 @@
     color: red;
 }
 
+/* pseudo classes */
+#foo:hover {
+    color: red;
+}
+
+#oof:hover {
+    color: white;
+}
+
+#rab:hover::selection {
+    color: black;
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: aanand-deadweight
 version: !ruby/object:Gem::Version 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Aanand Prasad
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-21 00:00:00 -07:00
+date: 2009-08-18 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -57,6 +57,7 @@ files:
 - test/test_helper.rb
 has_rdoc: false
 homepage: http://github.com/aanand/deadweight
+licenses: 
 post_install_message: 
 rdoc_options: 
 - --charset=UTF-8
@@ -77,7 +78,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.2.0
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: RCov for CSS