a9n 0.8.3 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37c61d91df158a98905540788736c8cb991ac74ad07b7e731d3cc4c90a7db51a
-  data.tar.gz: 91b249ed588ec98a51d630cc3ead8fd3940e1aac5b2a37c052fb6d90419cd9bc
+  metadata.gz: b1281f22d87f9f4d7859fc9502b63c1f0ce4b3ffc2613cffffac04439eb15ce4
+  data.tar.gz: a654029ddd734466360ff854f7a8f384ed04b4ad3d76a40b7532900ab1a1ddbf
 SHA512:
-  metadata.gz: a4c51ba32a2bd745ac6902f6ae53f0cfdb7f9f19d44fa0c35b615ba61e3d87ace7009bf5aad7cb06b16abd0a5e1c58e383210910cc186c9616dcba491a884848
-  data.tar.gz: b1ebbf900ae993a785ed432d514033c0b86d108fa3b9b94ca1ac1096cddfaf4952843bd4a21e291f934e54898efead2fd9b9f4bc88bfad8b496cd58247bbff43
+  metadata.gz: ff4729ff94e74c73b5473a2de24faae869f913a9d066f16e666c8d92c8aedbc748bf7c89821dd4197833b4a901a7111f68968b787f8eee4679b4bbed3b89e877
+  data.tar.gz: 70913ef31b6334875776970fc6b2922e9e97a8e0ccbd983672a8e120f6677ec440d8435436845efe20ac9d0f303c98249566c6a249050b43d62db93406b3cb0c

data/.rubocop.yml

@@ -1,6 +1,5 @@
 Gemspec/RequiredRubyVersion:
   Include:
-    - 2.4
     - 2.5
     - 2.6
 
@@ -12,6 +11,9 @@ Metrics/BlockLength:
 Metrics/LineLength:
   Max: 140
 
+Metrics/ModuleLength:
+  Max: 120
+
 Security/YAMLLoad:
   Enabled: false
 

data/.ruby-version

@@ -1 +1 @@
-2.6.3
+2.6.5

data/.travis.yml

@@ -1,8 +1,14 @@
+---
+sudo: false
 language: ruby
+cache: bundler
 rvm:
-  - 2.4.6
-  - 2.5.5
-  - 2.6.3
+  - 2.5.7
+  - 2.6.5
+before_install: gem install bundler -v 2.0.2
+script:
+  - bundle exec rspec
+  - bundle exec rubocop
 addons:
   code_climate:
     repo_token: 9aa2aa2432639c57772b6917ad9da468709e5536b75617575b02b35201a2eaf8

data/lib/a9n.rb

@@ -19,7 +19,13 @@ module A9n
 
   class << self
     def env
-      @env ||= ::A9n::StringInquirer.new(app_env || env_var('RAILS_ENV') || env_var('RACK_ENV') || env_var('APP_ENV') || fail(UnknownEnvError))
+      @env ||= ::A9n::StringInquirer.new(
+        app_env ||
+        env_var('RAILS_ENV') ||
+        env_var('RACK_ENV') ||
+        env_var('APP_ENV') ||
+        raise(UnknownEnvError)
+      )
     end
 
     def env=(value)
@@ -47,11 +53,11 @@ module A9n
     end
 
     def root=(path)
-      @root = path.to_s.empty? ? nil : Pathname.new(path.to_s)
+      @root = path.to_s.empty? ? nil : Pathname.new(path.to_s).freeze
     end
 
     def groups
-      ['default', env].compact
+      ['default', env].compact.freeze
     end
 
     def rails_app
@@ -62,9 +68,9 @@ module A9n
       raise A9n::MissingEnvVariableError, name if strict && !ENV.key?(name)
 
       if ENV[name].is_a?(::String)
-        ENV[name].dup.force_encoding(Encoding::UTF_8)
+        ENV[name].dup.force_encoding(Encoding::UTF_8).freeze
       else
-        ENV[name]
+        ENV[name].dup.freeze
       end
     end
 

data/lib/a9n/ext/hash.rb

@@ -19,11 +19,11 @@ module A9n
 
       def get_value(key, value, scope)
         if value.is_a?(::Hash)
-          deep_prepare(value, scope)
+          deep_prepare(value, scope).freeze
         elsif value.is_a?(Symbol) && value == :env
           A9n.env_var(scope.env_key_name(key), strict: A9n.strict?)
         else
-          value
+          value.freeze
         end
       end
     end

data/lib/a9n/loader.rb

@@ -34,13 +34,13 @@ module A9n
         common_scope = prepare_yml_scope(yml, scope, COMMON_SCOPE)
         env_scope    = prepare_yml_scope(yml, scope, env)
 
-        A9n::Hash.merge(common_scope, env_scope)
+        A9n::Hash.merge(common_scope, env_scope).freeze
       end
 
       def prepare_yml_scope(yml, scope, env)
         return nil unless yml[env].is_a?(::Hash)
 
-        A9n::Hash.deep_prepare(yml[env], scope)
+        A9n::Hash.deep_prepare(yml[env], scope).freeze
       end
     end
 

data/lib/a9n/version.rb

@@ -1,3 +1,3 @@
 module A9n
-  VERSION = '0.8.3'.freeze
+  VERSION = '0.9.0'.freeze
 end

data/spec/unit/a9n_spec.rb

@@ -39,6 +39,13 @@ RSpec.describe A9n do
     end
 
     context 'unknown env' do
+      before do
+        expect(subject).to receive(:app_env).and_return(nil)
+        expect(subject).to receive(:env_var).with('RAILS_ENV').and_return(nil)
+        expect(subject).to receive(:env_var).with('RACK_ENV').and_return(nil)
+        expect(subject).to receive(:env_var).with('APP_ENV').and_return(nil)
+      end
+
       it do
         expect { subject.env }.to raise_error(A9n::UnknownEnvError)
       end
@@ -51,7 +58,8 @@ RSpec.describe A9n do
     end
 
     it do
-      expect(subject.groups).to eq(['default', 'development'])
+      expect(subject.groups).to eq(%w[default development])
+      expect(subject.groups).to be_frozen
     end
   end
 
@@ -106,6 +114,7 @@ RSpec.describe A9n do
 
         it do
           expect(subject.root).to eq(Pathname.new('/home/knapo/workspace/a9n'))
+          expect(subject.root).to be_frozen
         end
       end
 
@@ -172,6 +181,7 @@ RSpec.describe A9n do
 
     it do
       expect(subject.env_var('FOO')).to eq('little foo')
+      expect(subject.env_var('FOO')).to be_frozen
     end
 
     it do

data/spec/unit/loader_spec.rb

@@ -114,6 +114,7 @@ RSpec.describe A9n::Loader do
       shared_examples 'non-empty config file' do
         it 'returns non-empty hash' do
           expect(subject).to be_kind_of(Hash)
+          expect(subject).to be_frozen
           expect(subject.keys).to_not be_empty
         end
       end
@@ -141,6 +142,10 @@ RSpec.describe A9n::Loader do
 
         it_behaves_like 'non-empty config file'
 
+        it 'contains only frozen values' do
+          expect(subject.values.reject(&:frozen?)).to eq([])
+        end
+
         it 'contains keys from defaults scope' do
           expect(subject[:default_foo]).to eq('default foo')
           expect(subject[:overriden_foo]).to eq('already overriden foo')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: a9n
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.9.0
 platform: ruby
 authors:
 - Krzysztof Knapik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-21 00:00:00.000000000 Z
+date: 2019-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
@@ -102,7 +102,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".hound.yml"
 - ".rspec"
 - ".rspec.example"
 - ".rubocop.yml"

data/.hound.yml

@@ -1,4 +0,0 @@
-fail_on_violations: true
-
-rubocop:
-  config_file: .rubocop.yml