ZReviewTender 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7424669fd10f388ab510a8e2dd5883fcf1341d008d3eb373935354f401bb02a
-  data.tar.gz: c71871531e5e011ae609b6fd42220a25350e7791882862f2c52329f8e3c9169e
+  metadata.gz: db501e3c9cd98014ed5ffac3c12c9eab4da8a6da03f441497322209a9e61e25f
+  data.tar.gz: 70cd96094bebe92db74f05662ee442b5b0e006f0e8a93b3b564cbf9003fe640b
 SHA512:
-  metadata.gz: 7306096441bcf8f3bdd47f4b00a5449ff3a1baaaf045159699eff5bfcde01d9876b333ca55894b976e0919061c678df3453e463f9e7a5d6fe7242f242bdaa561
-  data.tar.gz: 2f0544786b27029a3a745553a729e1f65aa7758f69cf8a917e0da26e6c7f15d96fd22039e195c09f765a4093f54f2bbd193b997a6d37af2d2ca80bac1fa080a4
+  metadata.gz: 8611b44db056e78d816a48bc495910939ea9a717fb5b248d89f4d99075dd8eed5e9e2f924ea15d26e27800d2f19c72c6b2851621d72caae4741b7d23dc768112
+  data.tar.gz: 88c4a1da0571745066e43b4ae23cfa9b3181b46f704617d22fe2e71b2e1004ce5a4226227e0abe2699feca857b71480d4841f4f1527095b0c26ef23a5b000484

data/lib/AndroidFetcher.rb

@@ -23,13 +23,6 @@ class AndroidFetcher < ReviewFetcher
 
         latestCheckTimestamp = getPlatformLatestCheckTimestamp()
 
-        # init first time, send welcome message
-        if latestCheckTimestamp == 0 
-            sendWelcomMessage()
-            setPlatformLatestCheckTimestamp(Time.now().to_i)
-            return
-        end
-
         reviews = []
         
         # Google API Bug, couldn't specify limit/offse/pagination, google only return a few recent reviews.
@@ -52,22 +45,25 @@ class AndroidFetcher < ReviewFetcher
             end
             customerReviewPlatform = "Android #{customerReview.comments[0].user_comment.android_os_version}"
             
-            if latestCheckTimestamp >= customerReviewCreatedDateTimestamp
-                break
-            else
-                url = "https://play.google.com/store/apps/details?id=#{config.packageName}&reviewId=#{customerReviewID}"
-                if !config.accountID.nil? && !config.appID.nil?
-                    url = "https://play.google.com/console/developers/#{config.accountID}/app/#{config.appID}/user-feedback/review-details?reviewId=#{customerReviewID}"
-                end
-                reviews.append(Review.new(customerReviewPlatform, customerReviewID, customerReviewReviewerNickname, customerReviewRating, customerReviewTitle, customerReviewBody, customerReviewCreatedDateTimestamp, url, customerReviewVersionString, customerReviewTerritory))
+            url = "https://play.google.com/store/apps/details?id=#{config.packageName}&reviewId=#{customerReviewID}"
+            if !config.accountID.nil? && !config.appID.nil?
+                url = "https://play.google.com/console/developers/#{config.accountID}/app/#{config.appID}/user-feedback/review-details?reviewId=#{customerReviewID}"
             end
-
+            reviews.append(Review.new(customerReviewPlatform, customerReviewID, customerReviewReviewerNickname, customerReviewRating, customerReviewTitle, customerReviewBody, customerReviewCreatedDateTimestamp, url, customerReviewVersionString, customerReviewTerritory))
         end
+
+        reviews = reviews.reject{ |review| latestCheckTimestamp >= review.createdDateTimestamp }.sort! { |a, b|  a.createdDateTimestamp <=> b.createdDateTimestamp }
       
         if reviews.length > 0
-            reviews.sort! { |a, b|  a.createdDateTimestamp <=> b.createdDateTimestamp }
+
             setPlatformLatestCheckTimestamp(reviews.last.createdDateTimestamp)
 
+            # init first time, send welcome message
+            if latestCheckTimestamp == 0 
+                sendWelcomMessage()
+                return
+            end
+
             processReviews(reviews, platform)
         end
     end

data/lib/AppleFetcher.rb

@@ -24,20 +24,18 @@ class AppleFetcher < ReviewFetcher
 
         latestCheckTimestamp = getPlatformLatestCheckTimestamp()
 
-
-        # init first time, send welcome message
-        if latestCheckTimestamp == 0 
-            sendWelcomMessage()
-            setPlatformLatestCheckTimestamp(Time.now().to_i)
-            return;
-        end
-
         reviews = fetchReviews(latestCheckTimestamp)
 
         if reviews.length > 0
             reviews.sort! { |a, b|  a.createdDateTimestamp <=> b.createdDateTimestamp }
             setPlatformLatestCheckTimestamp(reviews.last.createdDateTimestamp)
 
+            # init first time, send welcome message
+            if latestCheckTimestamp == 0 
+                sendWelcomMessage()
+                return;
+            end
+
             reviews = fullfillAppInfo(reviews)
             processReviews(reviews, platform)
         end
@@ -73,6 +71,12 @@ class AppleFetcher < ReviewFetcher
                 else
                     url = "https://appstoreconnect.apple.com/apps/#{config.appID}/appstore/activity/ios/ratingsResponses"
                     reviews.append(Review.new(nil, customerReviewID, customerReviewReviewerNickname, customerReviewRating, customerReviewTitle, customerReviewBody, customerReviewCreatedDateTimestamp, url, nil, customerReviewTerritory))
+                    
+                    # init first time, need first review to set as latestCheckTimestamp
+                    if latestCheckTimestamp == 0
+                        customerReviewsLink = nil
+                        break
+                    end
                 end
             end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ZReviewTender
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - ZhgChgLi