SingaporeBankCodes 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e7bc7de3e9adcb4fdfd1e17654464da76bb449f9
-  data.tar.gz: a24cc6957d898de788b4a6ad132354f80d74ea43
+  metadata.gz: a70b2a78642437ceebebeb9cd80d89875b2561f8
+  data.tar.gz: 4092dfb11e97cd708fc8f4c36ec6e0a5a9e66aed
 SHA512:
-  metadata.gz: d8a8a851d01e0c0cb07bb174f6e8e3b6c799ffe63a4ae5025250a9f26a796097f023f244a55ed08c84ef47a8db81bb2b1629fd5d90eb38db9147c9b148a9f2e5
-  data.tar.gz: 77fcfc7b8f87354adc515781c1b88466b04d0f603cc04f85a815fba843af7a89c391fdb82bae9f32ef3a396b9e298bbbf4908ce20c9a20a0c1ec80515f85b5e9
+  metadata.gz: a7bcefbf37060fe936dc33d3f6f6a141e7cda2431305f9b69b855a033f5420260d1a4efecaf2e615d5f751c75d00f15ef0b56079dd846ba68e2e197a871215bb
+  data.tar.gz: b18ffebac40acc3d111c2c8acf2b51283cc5fe0e7dcfd47b8945b722af65abc5649200191eea9cb23943a3737dfb4b70cb58b8a726a133062e3ff4f3e38df4ce

data/README.md

@@ -1,6 +1,6 @@
 # SingaporeBankCodes
 This gem allows you to provide a bank name and account number, and will generate the branch code, bank code, and branch name. Singapore banks only. Currently serviced banks are:
- ['OCBC', 'DBS', 'UOB', 'FEB', 'POSB', 'POSB Plus', 'HSBC', 'Standard Chartered', 'CITIBANK', 'Malayan Banking Berhad']
+ ['OCBC', 'DBS', 'UOB', 'FEB', 'POSB', 'HSBC', 'Standard Chartered', 'CITIBANK', 'Malayan Banking Berhad']
 
 ## Installation
 
@@ -20,9 +20,9 @@ Or install it yourself as:
 
 ## Usage
 ```ruby
-resolver = BankCodeResolver.new(name: 'POSB', account: '123456789')
+resolver = BankCodeResolver.new(name: 'POSB', number: '123456789')
 resolver.get_result
-#returns a hash with keys bank_code, branch_code, branch_name and resolved account number, which can be different from supplied account number
+#returns a hash with keys bank_code, branch_code, branch_name resolved account number and swift code, which can be different from supplied account number
 BankCodeResolver.bank_options #for possible bank names
 ```
 

data/lib/SingaporeBankCodes/version.rb

@@ -1,3 +1,3 @@
 module SingaporeBankCodes
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/SingaporeBankCodes.rb

@@ -5,36 +5,35 @@ require_relative './banks/hsbc'
 require_relative './banks/malayan_banking_berhad'
 require_relative './banks/ocbc'
 require_relative './banks/posb'
-require_relative './banks/posb_plus'
 require_relative './banks/uob/uob_branch_codes'
 require_relative './banks/uob/uob'
 require_relative './banks/standard_chartered'
 
 
 class BankCodeResolver
-  BANKS = ['OCBC', 'DBS', 'UOB', 'FEB', 'POSB', 'POSB Plus', 'HSBC', 'Standard Chartered', 'CITIBANK', 'Malayan Banking Berhad']
   attr_accessor :name, :number
 
   def initialize(args)
-    @name   = args.fetch(:name)
+    @name   = args.fetch(:name).delete(' ').upcase
     @number = args.fetch(:number)
-    raise ArgumentError.new "Name(#{@name}) needs to be one of #{BankCodeResolver::BANKS}" unless BankCodeResolver::BANKS.include?(@name)
+    raise ArgumentError.new "Name(#{@name}) needs to be one of #{BankCodeResolver.bank_options}" unless BankCodeResolver.bank_options.include?(@name)
     @bank_account      = Object.const_get(@name.delete(' ').upcase).new(@number)
     min_length = @bank_account.min_length
     raise ArgumentError.new "Account number needs to be at least #{min_length}" unless (@number.to_s.length >= min_length)
   end
 
   def self.bank_options
-    BankCodeResolver::BANKS
+    SingaporeBankCode::BankAccount.decendants
   end
 
   def get_result
-    bank_code, branch_code, branch_name, resolved_number = @bank_account.resolve!
+    bank_code, branch_code, branch_name, resolved_number, swift_code = @bank_account.resolve!
     {
       'bank_account' => bank_code, 
       'branch_code' => branch_code, 
       'branch_name' => branch_name,
       'resolved_account_number' => resolved_number,
+      'swift_code' => swift_code
     }
   end
   

data/lib/banks/bank_account.rb

@@ -2,6 +2,10 @@ module SingaporeBankCode
   class BankAccount
     attr_accessor :number
 
+    def self.decendants
+      ObjectSpace.each_object(Class).select { |klass| klass < self }.map(&:to_s)
+    end
+
     def initialize number
       @number = number
     end
@@ -22,8 +26,12 @@ module SingaporeBankCode
       @number
     end
 
+    def swift_code
+      'N/A'
+    end
+
     def resolve!
-      [bank_code, branch_code, branch_name, resolved_number]
+      [bank_code, branch_code, branch_name, resolved_number, swift_code]
     end
   end
 end

data/lib/banks/citibank.rb

@@ -3,6 +3,10 @@ class CITIBANK < SingaporeBankCode::BankAccount
     '7214'
   end
 
+  def swift_code
+    'CITISGSGGCB'
+  end
+
   def reference_hash_collection
     {
       '001' => 'Shenton Way - IB',

data/lib/banks/dbs.rb

@@ -7,6 +7,10 @@ class DBS < SingaporeBankCode::BankAccount
     '7171'
   end
 
+  def swift_code
+    'DBSSSGSGXXX'
+  end
+  
   def reference_hash_collection
     {
       '001' => 'DBS Shenton Way',

data/lib/banks/hsbc.rb

@@ -4,6 +4,10 @@ class HSBC < SingaporeBankCode::BankAccount
     '7232'
   end
 
+  def swift_code
+    'HSBCSGSGXXX'
+  end
+
   def resolved_number
     @number[3..-1]
   end

data/lib/banks/ocbc.rb

@@ -2,9 +2,9 @@ class OCBC < SingaporeBankCode::BankAccount
   def bank_code
     '7339'
   end
-
-  def resolved_number
-    @number[3..-1]
+  
+  def swift_code
+    'OCBCSGSGXXX'
   end
 
   def reference_hash_collection

data/lib/banks/posb.rb

@@ -7,6 +7,10 @@ class POSB < SingaporeBankCode::BankAccount
     '7171'
   end
 
+  def swift_code
+    'DBSSSGSGXXX'
+  end
+
   def branch_code
     if @number.to_s.length == 9
       '081'

data/lib/banks/standard_chartered.rb

@@ -3,14 +3,14 @@ class STANDARDCHARTERED < SingaporeBankCode::BankAccount
     10
   end
 
-  def resolved_number
-    @number
-  end
-
   def bank_code
     '7144'
   end
 
+  def swift_code
+    'SCBLSGSGXXX'
+  end
+
   def branch_code
     '0' + @number[0..1].to_s
   end

data/spec/bank_code_resolver_spec.rb

@@ -5,8 +5,7 @@ describe BankCodeResolver do
 
   describe 'Valid parameters' do
     context 'with valid bank' do
-      # 'FEB'
-      let(:name) {['OCBC', 'DBS', 'UOB', 'POSB', 'POSB Plus', 'HSBC', 'Standard Chartered', 'CITIBANK', 'Malayan Banking Berhad'].sample}
+      let(:name) {['OCBC', 'DBS', 'UOB', 'POSB', 'HSBC', 'Standard Chartered', 'CITIBANK', 'Malayan Banking Berhad'].sample}
       let(:number) {1234567890}
       it 'should not raise any error' do
         expect(subject).to be      

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: SingaporeBankCodes
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Sherwyn Goh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-22 00:00:00.000000000 Z
+date: 2015-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -78,6 +78,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- SingaporeBankCodes-0.0.1.gem
 - SingaporeBankCodes.gemspec
 - lib/SingaporeBankCodes.rb
 - lib/SingaporeBankCodes/version.rb
@@ -88,7 +89,6 @@ files:
 - lib/banks/malayan_banking_berhad.rb
 - lib/banks/ocbc.rb
 - lib/banks/posb.rb
-- lib/banks/posb_plus.rb
 - lib/banks/standard_chartered.rb
 - lib/banks/uob/uob.rb
 - lib/banks/uob/uob_branch_codes.rb

data/lib/banks/posb_plus.rb

@@ -1,6 +0,0 @@
-class POSBPLUS < SingaporeBankCode::BankAccount
-
-  def bank_code
-    '7171'
-  end
-end