Narnach-md5_wrapper 0.3.0 → 0.3.1

data/README.rdoc

@@ -28,4 +28,18 @@ Check the correct md5 hexdigest against a file.
 Check an incorrect md5 hexdigest against a file.
   Md5Wrapper.check_md5sum('foo.txt', 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa') #=> false
 
+== Changelog
+
+== Version 0.3.1
+* Made Md5Wrapper work with filenames with spaces.
+
+== Version 0.3.0
+* Md5Wrapper is now available as RubyGem as well as Rails plugin
+* Added a simple test for each method on Md5Wrapper.
+* Renamed generated code to use Md5Wrapper instead of Md5sumWrapper.
+* Added plugin.
+
+== Contributors
+* Filip 'FiXato' Slagter
+
 Copyright (c) 2008 Wes Oldenbeuving, released under the MIT license

data/lib/md5_wrapper.rb

@@ -5,23 +5,23 @@ class Md5Wrapper
     def check_md5sum(filename, md5sum)
       raise ArgumentError, "Invalid md5sum" unless md5sum.size == 32
       raise ArgumentError, "Invalid file" unless File.exist? filename and File.file? filename and File.readable? filename
-      
+
       if RUBY_PLATFORM =~ /darwin/
-        md5 = `md5 #{filename} 2>&1`.strip[-32,32]
+        md5 = `md5 "#{filename}" 2>&1`.strip[-32,32]
         return md5 == md5sum
       else # linux
         cmd = "echo \"#{md5sum} *#{filename}\" | md5sum -c --status 2>&1"
         return system(cmd)
       end
     end
-    
+
     # Extract the md5 hexdigest from a file.
     def get_md5sum(filename)
       raise ArgumentError, "Invalid file" unless File.exist? filename and File.file? filename and File.readable? filename
       if RUBY_PLATFORM =~ /darwin/
-        return `md5 #{filename} 2>&1`.strip[-32,32]
+        return `md5 "#{filename}" 2>&1`.strip[-32,32]
       else # linux
-        return `md5sum -b #{filename} 2>&1`[0,32]
+        return `md5sum -b "#{filename}" 2>&1`[0,32]
       end
     end
   end

data/md5_wrapper.gemspec

@@ -3,7 +3,7 @@ Gem::Specification.new do |s|
   s.name         = 'md5_wrapper'
   s.summary      = "Md5Wrapper wraps the command line utilities md5sum (Linux) and md5 (Mac)."
   s.description  = "It allows obtaining the md5 hexdigest of a file and checking that a file has a specific md5 hexdigest."
-  s.version      = '0.3.0'
+  s.version      = '0.3.1'
   s.date         = '2008-08-05'
   s.platform     = Gem::Platform::RUBY
   s.authors      = ["Wes Oldenbeuving"]

data/test/md5_wrapper_test.rb

@@ -1,17 +1,38 @@
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+
 require 'test/unit'
 require 'md5_wrapper'
+require 'tempfile'
 
 class Md5WrapperTest < Test::Unit::TestCase
   def setup
     @fixture = File.expand_path(File.join(File.dirname(__FILE__),'fixtures','test.txt'))
     @md5sum = 'd8e8fca2dc0f896fd7cb4cb0031ba249'
   end
-  
+
   def test_get_md5sum
     assert_equal @md5sum, Md5Wrapper.get_md5sum(@fixture)
   end
-  
+
   def test_check_md5sum
     assert Md5Wrapper.check_md5sum(@fixture, @md5sum)
   end
+
+  def test_get_md5sum_for_filenames_with_spaces
+    Tempfile.open('text file with spaces.txt') do |f|
+      File.open(f.path,'w') do |fp|
+        fp.puts 'test'
+      end
+      assert_equal @md5sum, Md5Wrapper.get_md5sum(f.path)
+    end
+  end
+
+  def test_check_md5sum_for_filenames_with_spaces
+    Tempfile.open('text file with spaces.txt') do |f|
+      File.open(f.path,'w') do |fp|
+        fp.puts 'test'
+      end
+      assert Md5Wrapper.check_md5sum(f.path,@md5sum)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: Narnach-md5_wrapper
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors: 
 - Wes Oldenbeuving