NRB_http_service 0.0.8 → 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 28f5fc0fb9e5b8d3bcc6436c27bae888dfc16128
+  data.tar.gz: f63b0efd8e14a4668e5970d78c6d83b957471b0f
+SHA512:
+  metadata.gz: 72a291dee0d0c936753c5695f6de4a1939cc354f8cdae9550b10d7327285da0fda27d493902a4ae1f40ebbcebe81c5baf2e70fe62551a59e97035a7dc427f759
+  data.tar.gz: 57c43f46501c6e13cf2cb3493820b4980ed0c5897efc66a7b2969dc2af78a12e3042fe55fb08b80f8284e97655455f210fde16e8eda104c4ec578138e25dd040

data/lib/NRB_http_service.rb

@@ -39,22 +39,30 @@ module NRB
 
 
     def make_request
-      connection = self.class.default_http_class.new @url, @connection_opts, &self.class.faraday_middleware
-      response = connection.send @verb, @url, @params
-      args = @args.merge( { body: response.body, headers: response.headers, status: response.status.to_i } )
-      @response_class.new args
+      response = connection.send verb, url, params
+      response_class.new response_args(response)
     rescue Faraday::Error::ParsingError => e
       self.class.default_response_class.new body: {error: e.message}, status: 500
     end
 
   private
 
-    attr_reader :params, :verb, :url
+    attr_reader :args, :connection_opts, :params, :response_class, :verb, :url
+
+    def connection
+      self.class.default_http_class.new url, connection_opts, &self.class.faraday_middleware
+    end
+
 
     def process_args(args)
       return args unless @verb == :post
       args.inject("") { |str,pair| str += "#{pair.first}=#{pair.last}&" }.chop
     end
 
+
+    def response_args(response)
+      args.merge( { body: response.body, headers: response.headers, status: response.status.to_i } )
+    end
+
   end
 end

data/lib/NRB_http_service/response.rb

@@ -19,7 +19,7 @@ module NRB
 
 
       def success?
-        @status >= 200 && @status < 300
+        status >= 200 && status < 300
       end
 
     end

data/lib/NRB_http_service/version.rb

@@ -1,6 +1,6 @@
 module NRB
   class HTTPService
-    VERSION = '0.0.8'
+    VERSION = '0.1.0'
     def self.version; VERSION; end
   end
 end

data/spec/cases/NRB_http_service/response_spec.rb

@@ -12,11 +12,11 @@ describe NRB::HTTPService::Response do
     let(:status) { 200 }
 
     it 'correctly answers errored?' do
-      response.should_not be_errored
+      expect(response).not_to be_errored
     end
 
     it 'correctly answers success?' do
-      response.should be_success
+      expect(response).to be_success
     end
 
   end
@@ -26,11 +26,11 @@ describe NRB::HTTPService::Response do
     let(:status) { 900 }
 
     it 'correctly answers errored?' do
-      response.should be_errored
+      expect(response).to be_errored
     end
 
     it 'correctly answers success?' do
-      response.should_not be_success
+      expect(response).not_to be_success
     end
 
   end

data/spec/cases/NRB_http_service/version_spec.rb

@@ -0,0 +1,30 @@
+describe NRB::HTTPService do
+
+  let(:version) { described_class.version }
+  let(:version_constant) { described_class.const_get(:VERSION) }
+
+  it 'responds to :version' do
+    expect(described_class).to respond_to :version
+  end
+
+
+  it "has a version" do
+    expect(version).not_to be nil
+  end
+
+
+  it "has a version string" do
+    expect(version).to be_a String
+  end
+
+
+  it 'has a VERSION constant' do
+    expect(version_constant).not_to be nil
+  end
+
+
+  it 'responds with the VERSION constant' do
+    expect(described_class.version).to eq(version_constant)
+  end
+
+end

data/spec/cases/NRB_http_service_spec.rb

@@ -5,11 +5,11 @@ describe NRB::HTTPService do
   describe 'class methods' do
 
     it 'has a default middleware' do
-      NRB::HTTPService.default_middleware.should be_a(Proc)
+      expect(described_class.default_middleware).to be_a(Proc)
     end
 
     it 'has a default response class' do
-      NRB::HTTPService.default_response_class.should eq NRB::HTTPService::Response
+      expect(described_class.default_response_class).to eq NRB::HTTPService::Response
     end
 
   end
@@ -18,25 +18,26 @@ describe NRB::HTTPService do
 
     let(:args)       { {} }
     let(:body)       { {} }
-    let(:connection) { stub "here's a beer", verb => connection_response }
+    let(:connection) { double :connection, verb: connection_response,
+                                           get: connection_response }
     let(:connection_response)   { double "skal", body: body, headers: headers, status: status }
     let(:headers)    { {} }
     let(:path)       { '/' }
-    let(:response)   { NRB::HTTPService.new(path: path, verb: verb).make_request }
+    let(:response)   { described_class.new(path: path, verb: verb).make_request }
     let(:status)     { 200 }
     let(:verb)       { :get }
 
     context 'successful requests' do
 
       before do
-        Faraday.stub(:new).and_return(connection)
+        allow(Faraday).to receive(:new).and_return(connection)
       end
       it 'returns a Response object' do
-        response.should be_a(NRB::HTTPService.default_response_class)
+        expect(response).to be_a described_class.default_response_class
       end
 
       it 'resuces with an successful Response object' do
-        response.should be_success
+        expect(response).to be_success
       end
 
     end
@@ -48,19 +49,19 @@ describe NRB::HTTPService do
       let(:message) { "!Blark!" }
 
       before do
-        Faraday.stub(:new).and_raise(error)
+        allow(Faraday).to receive(:new).and_raise(error)
       end
 
       it 'resuces with a Response object' do
-        response.should be_a(NRB::HTTPService.default_response_class)
+        expect(response).to be_a(described_class.default_response_class)
       end
 
       it 'resuces with an errored Response object' do
-        response.should be_errored
+        expect(response).to be_errored
       end
 
       it 'gives you the error' do
-        response.body[:error].should eq message
+        expect(response.body[:error]).to eq message
       end
 
     end

metadata

@@ -1,94 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: NRB_http_service
 version: !ruby/object:Gem::Version
-  version: 0.0.8
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Dean Brundage
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-28 00:00:00.000000000 Z
+date: 2016-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.0'
+- !ruby/object:Gem::Dependency
+  name: hashie
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rb-inotify
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.0'
 description: Used in some of New Republic Brewing's gems
@@ -103,37 +106,36 @@ files:
 - lib/NRB_http_service.rb
 - lib/NRB_http_service/response.rb
 - lib/NRB_http_service/version.rb
-- spec/cases/NRB_http_service_spec.rb
 - spec/cases/NRB_http_service/response_spec.rb
-- spec/cases/version_spec.rb
+- spec/cases/NRB_http_service/version_spec.rb
+- spec/cases/NRB_http_service_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/NewRepublicBrewing/http-service
-licenses: []
+licenses:
+- GPL-3
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: NRB_http_service
-rubygems_version: 1.8.24
+rubygems_version: 2.5.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: HTTP Fetcher Gem based on Faraday
 test_files:
 - spec/cases/NRB_http_service_spec.rb
 - spec/cases/NRB_http_service/response_spec.rb
-- spec/cases/version_spec.rb
+- spec/cases/NRB_http_service/version_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 

data/spec/cases/version_spec.rb

@@ -1,14 +0,0 @@
-require 'spec_helper'
-
-describe NRB::HTTPService do
-
-  it 'responds to version' do
-    NRB::HTTPService.should respond_to :version
-  end
-
-
-  it 'gives a version string' do
-    NRB::HTTPService.version.should be_a String
-  end
-
-end