MovableInkAWS 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a9d1758b9cf5639179f69e82564243522214cac3ec54d29c2eb4f8ed251bd58
-  data.tar.gz: 9df37a6e80fbdd5334d54f869a95813175206ff317ec241b1582cfb1b84f2106
+  metadata.gz: c7d373a0f4bb5821c355ae4e7c8e275131bee8250b97697b0ed3c34ec50e525d
+  data.tar.gz: 1ec3dddb8f86aa754384aed0143b86b348a5050e1f08afd6a87f12ae8c0d58cc
 SHA512:
-  metadata.gz: fde4c2cf9bf517c4825606c46a5af50d6b44c0cdeed5eeff9725bfa770cf19280668e1143bbb602cb9d0be1775171e0ec5bb0757cd3e4d1fe683f7db8552e6f2
-  data.tar.gz: af99ca315ba03df3e585a78ee5f302afe5e399cd51dbdfd8bced6329e2c1a93e62cad1706ce824996771fdd995c5f94d8d90622fb0fc7dd623179e5ac7e29f29
+  metadata.gz: 4d860a7e41e248768fe6fa687c596bfbb7519758766df047164e68c91f92a3e33d51a3520b1f8e9d3e60c2552b372c8d2cc9c2c411bbcb4c45b2c55b7cabf11a
+  data.tar.gz: 9e76bdbc11dcba4269b7408e38cb8ed3300f2e14493ecd4fe3b342712c20855a5eae6eab4931b70ddff041c969e5a4cc266579ea819ac573545d6e813d5975e9

data/lib/movable_ink/aws/sns.rb

@@ -30,9 +30,11 @@ module MovableInk
       end
 
       def notify_slack(subject:, message:)
+        required_info = " (#{instance_id}, #{my_region})"
+        subject = "#{subject.slice(0, 99-required_info.length)}#{required_info}"
         run_with_backoff do
           sns.publish(topic_arn: sns_slack_topic_arn,
-                      subject: "#{subject} (#{instance_id}, #{my_region})",
+                      subject: subject,
                       message: message)
         end
       end

data/lib/movable_ink/version.rb

@@ -1,5 +1,5 @@
 module MovableInk
   class AWS
-    VERSION = '0.2.1'
+    VERSION = '0.2.2'
   end
 end

data/spec/aws_spec.rb

@@ -4,6 +4,10 @@ describe MovableInk::AWS do
   context "outside EC2" do
     it "should raise an error if EC2 is required" do
       aws = MovableInk::AWS.new
+      allow(aws).to receive(:`).with('ec2metadata --instance-id 2>/dev/null').and_return("")
+      allow(aws).to receive(:`).with('ec2metadata --availability-zone 2>/dev/null').and_return("")
+
+
       expect{ aws.instance_id }.to raise_error(MovableInk::AWS::Errors::EC2Required)
       expect{ aws.availability_zone }.to raise_error(MovableInk::AWS::Errors::EC2Required)
     end

data/spec/ec2_spec.rb

@@ -4,6 +4,8 @@ describe MovableInk::AWS::EC2 do
   context "outside EC2" do
     it "should raise an error if trying to load mi_env outside of EC2" do
       aws = MovableInk::AWS.new
+      allow(aws).to receive(:`).with('ec2metadata --instance-id 2>/dev/null').and_return("")
+      allow(aws).to receive(:`).with('ec2metadata --availability-zone 2>/dev/null').and_return("")
       expect{ aws.mi_env }.to raise_error(MovableInk::AWS::Errors::EC2Required)
     end
 

data/spec/sns_spec.rb

@@ -26,5 +26,21 @@ describe MovableInk::AWS::SNS do
     allow(aws).to receive(:sns).and_return(sns)
 
     expect(aws.notify_slack(subject: 'Test subject', message: 'Test message').message_id).to eq('messageId')
+
+  end
+
+  it "should truncate subjects longer than 100 characters" do
+    sns.stub_responses(:list_topics, topic_data)
+    allow(aws).to receive(:my_region).and_return('us-east-1')
+    allow(aws).to receive(:instance_id).and_return('test instance')
+
+    allow(aws).to receive(:sns).and_return(sns)
+    message = 'Test message'
+    subject = "a"*100
+    expected_subject = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa (test instance, us-east-1)"
+    expect(sns).to receive(:publish).with({:topic_arn=>"slack-aws-alerts", :message=>"Test message", :subject => expected_subject})
+
+    aws.notify_slack(subject: subject, message: message)
+
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: MovableInkAWS
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Matt Chesler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-21 00:00:00.000000000 Z
+date: 2018-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk