Icarus-Mod-Tools 3.2.1 → 3.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f71d742763b16a7a6cb096f6decf06568f415909ee0830f392315523b7ab307d
-  data.tar.gz: f5afb462e86cc8452508dad64b319d4c2246cad20a5963741efa43f2b76d873a
+  metadata.gz: d922315481e0b1bd34f88773cf5ea5e49ec1117ad58ec9239643379581796752
+  data.tar.gz: 496323127ce64f211a3ccfdf38e33c8a77ff07700ad7138c87507ccf79bd03d5
 SHA512:
-  metadata.gz: 96c885457a5b1e1998eea60852d62474a48c4b1b66ec4ccd4aede80f8300314bde8eb2e9cca637cdae7d6630e00d83fa33b0157af899ef50283e3a97760c25ee
-  data.tar.gz: deac9280f7a685695dbe3704ae48b990298a4559b3dd1d5cd5277bb51fef6fe92ab71f0fc8bfb05dda43a6a170c430729c4fac7b5e5f0f291d29f627ead1dba9
+  metadata.gz: af8b4aec44f89f55c51033503287024047a15c1b9d486cf624fc9c7903e31c5a2c7cfedbd738cf64e2801456269b645d1d10bff248fdda560f6c3e00e11cb093
+  data.tar.gz: 61f3bad314fef578815e1a4e29653c36e956f812f839ba30c5ff85f1a5009bd3e035c3e65bb031147109df0bdd784ffd6baedc806896ea57b43e403de6542749

data/CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 
 ## History (reverse chronological order)
 
+### v3.2.2 - 2026-10-31
+
+- `imt validate modinfo`/`toolinfo` now hides "Invalid URL" and GitHub URL auto-fix warnings unless `-v` is given, and ends with a count of what it hid (`N URL/auto-fix warnings hidden; run with -v to see them`); other warnings and all errors still show
+- Fix `--no-verbose` crashing every subcommand with `FrozenError` (it tried to rewrite Thor's frozen options)
+
 ### v3.2.1 - 2026-10-31
 
 - Fix `imt add repos owner/repo` storing a bare `owner/repo`, which stage 1 of sync never searched (it only looked at entries containing "github"); it now stores the canonical `https://github.com/owner/repo` for any GitHub form, refuses non-GitHub repositories, and does nothing when the repository is already listed under any spelling

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    Icarus-Mod-Tools (3.2.1)
+    Icarus-Mod-Tools (3.2.2)
       google-cloud-firestore (~> 3.3)
       octokit (~> 10.0)
       ostruct (~> 0.6)

data/README.md

@@ -170,6 +170,8 @@ Commands:
   imt validate toolinfo        # Reads Toolinfo data from 'meta/toolinfo/list' and Validates syntax of toolfiles
 ```
 
+`imt validate modinfo` and `imt validate toolinfo` print every error and warning, except "Invalid URL" and GitHub URL auto-fix warnings, which only appear with `-v`; without it, the run ends with a count of how many were hidden.
+
 `imt validate repo OWNER/REPO [--json]` (a `github.com` URL also works) vets a repo someone asked to have added, before you add it. It is read-only, never touches Firestore, and needs only the GitHub token from the config. It checks that the repo exists, is public and is not archived; finds `modinfo.json` and/or `toolinfo.json` (at least one is required); validates every entry; and requests every file, image and readme link (following up to 5 redirects) to confirm it resolves. A broken download link is an error, a broken image or readme link is a warning, and a download hosted outside GitHub or a tool shipping an `.exe` is a warning. Use `-v`/`-vv` for more detail, or `--json` to print the machine-readable result (`repo`, `exists`, `private`, `archived`, `default_branch`, `info_files`, `problems`, `entries`, `valid`) and nothing else on stdout.
 
 **Exit status**: 0 when the repo is valid, 1 when it is not, 2 on usage, config or GitHub API errors (for example a rate limit or bad token).

data/lib/icarus/mod/cli/subcommand_base.rb

@@ -12,18 +12,14 @@ module Icarus
                      desc: "Increase verbosity. May be repeated for even more verbosity."
 
         no_commands do
-          def check_false
-            options[:verbose] = [] if options[:verbose].include?(false)
-          end
-
+          # --no-verbose appends false; Thor freezes options, so derive the level instead of rewriting it
           def verbose
-            check_false
-            options[:verbose]&.count || 0
+            flags = options[:verbose] || []
+            flags.include?(false) ? 0 : flags.count
           end
 
           def verbose?
-            check_false
-            options[:verbose]&.count&.positive?
+            verbose.positive?
           end
         end
 

data/lib/icarus/mod/cli/validate.rb

@@ -9,6 +9,9 @@ module Icarus
     module CLI
       # Sync CLI command definitions
       class Validate < SubcommandBase
+        # Warnings about loosely formed URLs and GitHub URLs we auto-fix; only shown with -v
+        NOISY_WARNING = /\AInvalid URL|Auto-fixed:/
+
         desc "modinfo", "Reads modinfo data from 'meta/modinfo/list' and Validates syntax of modfiles"
         def modinfo
           validate(:modinfo)
@@ -39,37 +42,41 @@ module Icarus
           exit 2
         end
 
-        no_commands do
-          def validate(type)
-            exit_code = 0
-            validator = Icarus::Mod::Tools::Validator.new(type)
+        private
 
-            puts "Validating Entries..." if verbose?
-            max_length = (validator.array.map { |info| info.uniq_name.length }.max || 0) + 1
+        def validate(type)
+          exit_code = 0
+          hidden = 0
+          validator = Icarus::Mod::Tools::Validator.new(type)
 
-            validator.array.each do |info|
-              print Paint[format("%s %-#{max_length}s", "Running validation steps on", info.uniq_name), :cyan, :bright] if verbose > 1
+          puts "Validating Entries..." if verbose?
+          max_length = (validator.array.map { |info| info.uniq_name.length }.max || 0) + 1
 
-              info.validate
+          validator.array.each do |info|
+            print Paint[format("%s %-#{max_length}s", "Running validation steps on", info.uniq_name), :cyan, :bright] if verbose > 1
 
-              unless info.errors? || info.warnings?
-                puts Paint["SUCCESS", :green, :bright] if verbose > 1
-                next
-              end
+            info.validate
+            warnings = verbose > 1 ? info.warnings : info.warnings.grep_v(NOISY_WARNING)
+            hidden += info.warnings.size - warnings.size
 
-              if info.errors?
-                exit_code = 1
-                puts Paint["ERROR", :red, :bright] if verbose? && verbose > 1
-                puts info.errors.map { |error| Paint["#{error} in #{info.uniq_name}", :red] }.join("\n")
-                puts "\n" if verbose > 1
-              end
+            unless info.errors? || warnings.any?
+              puts Paint["SUCCESS", :green, :bright] if verbose > 1
+              next
+            end
 
-              puts Paint["WARNING", :yellow, :bright] if info.warnings.any? && verbose > 1
-              puts info.warnings.map { |warning| Paint["#{warning} in #{info.uniq_name}", :yellow] }.join("\n")
+            if info.errors?
+              exit_code = 1
+              puts Paint["ERROR", :red, :bright] if verbose? && verbose > 1
+              puts info.errors.map { |error| Paint["#{error} in #{info.uniq_name}", :red] }.join("\n")
               puts "\n" if verbose > 1
             end
-            exit exit_code
+
+            puts Paint["WARNING", :yellow, :bright] if warnings.any? && verbose > 1
+            puts warnings.map { |warning| Paint["#{warning} in #{info.uniq_name}", :yellow] }.join("\n")
+            puts "\n" if verbose > 1
           end
+          puts "#{hidden} URL/auto-fix warning#{"s" unless hidden == 1} hidden; run with -v to see them" if hidden.positive? && verbose?
+          exit exit_code
         end
       end
     end

data/lib/icarus/mod/version.rb

@@ -2,6 +2,6 @@
 
 module Icarus
   module Mod
-    VERSION = "3.2.1"
+    VERSION = "3.2.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: Icarus-Mod-Tools
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 3.2.2
 platform: ruby
 authors:
 - Donovan Young