Icarus-Mod-Tools 2.5.1 → 2.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7011bea56d03dd0edd74138d193a5ad4e5628c4c8d59e94abf6e8793b397051
-  data.tar.gz: 4e9c054fe489ec2abb4aa36f7b8ea9b6d5621723a8ce0cf50563166b7ef002ee
+  metadata.gz: 791e5af8d7af9b24c8fe53d04fb97e39b14e7ac0773ce682783aeffebd4b2d85
+  data.tar.gz: 7ceede257ab9a52c15e708cf1e346c48b051a0c1c66dd781281eb3d1389ee627
 SHA512:
-  metadata.gz: 15d5e90ecb8c7f91accfb3ded406374278ab53e8b3d3d6b997e44904f4d9425acd0bd4461cf5def41dfe502ead8df5f0c54b5002380c78e7da928a39da45db8c
-  data.tar.gz: 0f9723a7821f213c70612c6510a2bc1c9508353cdf4e10ebf1568291f97e918325c12911e3621aaa4c82f7dd471c2236584d305532b40be32a84dcb0cafd90bf
+  metadata.gz: 705e7a9fb7037c1b2f36ea52e883832c56c9720c605c2d88f25c44d8483e500ef1a962d64b0774501a90b5d00495414f24acbac27eda58d4cf2e72d4024e0e61
+  data.tar.gz: 54b2d0f837368e87fc3de253a1bdfd6bb0af60da18b145158b47950a4c1b177fd0fdfab605c96cf1309d22e1f0d7f5a74f9f371d2e53b8cbaec6932343bade5b

data/CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
 
 ## History (reverse chronological order)
 
+### v2.5.2 - 2026-02-09
+
+- Fix duplicate entries created during sync operations
+  - Update Firestore cache after creating new documents to prevent duplicate creation within the same sync run
+  - Deduplicate info arrays by name+author before processing (handles duplicate/equivalent modinfo URLs)
+  - Strip empty file entries (e.g., `pak: ""`) from database writes
+  - Fix `id=` setter on Baseinfo (was silently no-op via method_missing, now uses attr_accessor)
+
 ### v2.5.1 - 2026-01-31
 
 - Fix `imt remove repo` failing to find repositories stored as full URLs

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    Icarus-Mod-Tools (2.5.0)
+    Icarus-Mod-Tools (2.5.2)
       google-cloud-firestore (~> 2.7)
       octokit (~> 6.0)
       paint (~> 2.3)

data/lib/icarus/mod/firestore.rb

@@ -106,7 +106,15 @@ module Icarus
 
         return @client.doc("#{collections.send(type)}/#{doc_id}").set(payload.to_h, merge:) if doc_id
 
-        @client.col(collections.send(type)).add(payload.to_h)
+        doc_ref = @client.col(collections.send(type)).add(payload.to_h)
+
+        # Update cache to prevent duplicate creation within the same sync run
+        payload.id = doc_ref.document_id
+        cache_var = :"@#{type}"
+        cached_collection = instance_variable_get(cache_var)
+        cached_collection&.push(payload)
+
+        doc_ref
       end
 
       def pluralize(type)

data/lib/icarus/mod/tools/baseinfo.rb

@@ -5,7 +5,8 @@ module Icarus
     module Tools
       # Base class for Modinfo and Toolinfo
       class Baseinfo
-        attr_reader :data, :id, :created_at, :updated_at
+        attr_reader :data
+        attr_accessor :id, :created_at, :updated_at
 
         HASHKEYS = %i[name author version compatibility description files imageURL readmeURL].freeze
 
@@ -78,6 +79,7 @@ module Icarus
           db_hash = HASHKEYS.each_with_object({}) { |key, hash| hash[key] = @data[key] }
 
           db_hash[:version] = "1.0" if version.nil?
+          db_hash[:files] = db_hash[:files]&.reject { |_, url| url.nil? || url.to_s.strip.empty? }
 
           db_hash
         end

data/lib/icarus/mod/tools/sync/mods.rb

@@ -21,14 +21,14 @@ module Icarus
 
           def info_array
             @info_array ||= @firestore.modinfo.map do |url|
-              retrieve_from_url(url)[:mods].map { |mod| Icarus::Mod::Tools::Modinfo.new(mod) if mod[:name].match?(/[a-z0-9]+/i) }
+              retrieve_from_url(url)[:mods].map { |mod| Icarus::Mod::Tools::Modinfo.new(mod) if /[a-z0-9]+/i.match?(mod[:name]) }
             rescue Icarus::Mod::Tools::Sync::RequestFailed
               warn "Skipped; Failed to retrieve #{url}"
               next
             rescue JSON::ParserError => e
               warn "Skipped; Invalid JSON in #{url}: #{e.message}"
               next
-            end.flatten.compact
+            end.flatten.compact.uniq { |mod| [mod.name, mod.author] }
           end
 
           def find(modinfo)

data/lib/icarus/mod/tools/sync/tools.rb

@@ -30,7 +30,7 @@ module Icarus
             rescue JSON::ParserError => e
               warn "Skipped; Invalid JSON in #{url}: #{e.message}"
               next
-            end.flatten.compact
+            end.flatten.compact.uniq { |tool| [tool.name, tool.author] }
           end
 
           def find(toolinfo)

data/lib/icarus/mod/version.rb

@@ -2,6 +2,6 @@
 
 module Icarus
   module Mod
-    VERSION = "2.5.1"
+    VERSION = "2.5.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: Icarus-Mod-Tools
 version: !ruby/object:Gem::Version
-  version: 2.5.1
+  version: 2.5.2
 platform: ruby
 authors:
 - Donovan Young