HornsAndHooves-moribus 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 458dd43da4a7bb700075f307e8bac67beea88ac91cc103d01dbc873e754c53ee
-  data.tar.gz: 699fd07e4333c5cea0c317c43f82d1f33e6b1f9629d32ff55099dd280f28a4f8
+  metadata.gz: 54e52262da75d0c70f93a440dab8adbebc1c9ccb23d8bf9eff905572ca9028ae
+  data.tar.gz: a4c982838e5ea190585f1e8d8bfe776574584bb669136f372506fec7d9e5e38e
 SHA512:
-  metadata.gz: 8379ba55ec3c949f21961b50ac3d2979a093fa2790e3e9bd134574d76f7f2ed9cd82eb06ee752771f5e265a63568fc3cb69fe01502e38fdd5ff829d5df279add
-  data.tar.gz: 533dc47aa565a5ce7b84ef924eea7a18d0a3d4776c29d6a971e1a430b7a3dd713143b7e9d4db253d00777dc5b430571dd62d3b7b3c64fd01a45b09b9ae8790a2
+  metadata.gz: 7b1bbadc5517c5309af3dd7f8dcc358e9966f5c7ef0ba6bbf3ee47b466d1771ab27620a3204ac45635bcd71f9619e16010eb5559d3b651adc951663cadeec101
+  data.tar.gz: 268eab60e758cc9f5f4dee5c44d8d60dfc6b5ec0f471d7108b73ba1bafe62b963b09724929fa3e65b5a07a400f9024545cb9a26bbc626ba944d1d4a75f65fa22

data/lib/moribus/extensions/has_current_extension.rb

@@ -6,21 +6,32 @@ module Moribus
       # Sets 'is_current' flag of overridden record to false, instead
       # of deleting it or setting foreign key to nil.
       def remove_target!(*)
+        # Use custom update to avoid running ActiveRecord optimistic locking
+        # and to avoid updating lock_version column:
         if target.new_record?
           target.is_current = false
+          target.updated_at = Time.zone.now if has_updated_at_column?
         else
-          # Use custom update to avoid running ActiveRecord optimistic locking
-          # and to avoid updating lock_version column:
           klass = target.class
 
           sql =  "UPDATE #{klass.quoted_table_name} " \
                  "SET \"is_current\" = #{klass.connection.quote(false)} "
+
+          sql << %{, "updated_at" = #{klass.connection.quote(Time.zone.now)} } if has_updated_at_column?
+
           sql << "WHERE #{klass.quoted_primary_key} = " \
                  "#{klass.connection.quote(target.send(klass.primary_key))} "
 
           klass.connection.update sql
         end
       end
+
+      # Is the record has a column with name `updated_at`
+      #
+      # @return [Boolean]
+      private def has_updated_at_column?
+        target.class.column_names.include?("updated_at")
+      end
     end
   end
 end

data/lib/moribus/version.rb

@@ -1,3 +1,3 @@
 module Moribus # :nodoc:
-  VERSION = "0.9.0" # :nodoc:
+  VERSION = "0.9.1" # :nodoc:
 end

data/spec/moribus/extensions/has_current_extension_spec.rb

@@ -16,6 +16,7 @@ describe Moribus::Extensions::HasCurrentExtension do
 
     class SpecCustomer < MoribusSpecModel(spec_status_id: :integer)
       has_one_current :spec_customer_info, inverse_of: :spec_customer, dependent: :destroy
+      delegate_associated :previous_id, to: :spec_customer_info
     end
   end
 
@@ -24,17 +25,45 @@ describe Moribus::Extensions::HasCurrentExtension do
   end
 
   let(:customer) { SpecCustomer.create }
-  let!(:info)    { SpecCustomerInfo.create(spec_customer: customer, is_current: true) }
+  let!(:info) do
+    SpecCustomerInfo.create(spec_customer: customer, is_current: true, created_at: 1.hour.ago, updated_at: 1.hour.ago)
+  end
 
   describe ".remove_target!" do
-    before do
-      allow(customer.spec_customer_info).to receive(:new_record?).and_return(true)
+    context "new record" do
+      before do
+        allow(customer.spec_customer_info).to receive(:new_record?).and_return(true)
+      end
+
+      it "sets 'is_current' flag of overridden record to false for new record" do
+        old_info = customer.spec_customer_info
+        customer.spec_customer_info = SpecCustomerInfo.new
+        expect(old_info.is_current).to be false
+      end
+
+      it "sets 'is_current' flag updates updated_at column" do
+        old_info = customer.spec_customer_info
+        customer.spec_customer_info = SpecCustomerInfo.new
+        expect(old_info.updated_at >= old_info.created_at + 1.hour).to be true
+      end
     end
 
-    it "sets 'is_current' flag of overridden record to false for new record" do
-      old_info = customer.spec_customer_info
-      customer.spec_customer_info = SpecCustomerInfo.new
-      expect(old_info.is_current).to be_falsey
+    context "persisted record" do
+      it "sets 'is_current' flag updates updated_at column" do
+        old_info = customer.spec_customer_info
+        customer.spec_customer_info = SpecCustomerInfo.new
+        old_info.reload
+        # I use 59 minutes instead of hour because there can be small difference in milliseconds
+        expect(old_info.updated_at >= old_info.created_at + 59.minutes).to be true
+      end
+
+      it "sets 'is_current' flag updates updated_at column" do
+        old_info = customer.spec_customer_info
+        customer.update!(previous_id: 123)
+        old_info.reload
+        # I use 59 minutes instead of hour because there can be small difference in milliseconds
+        expect(old_info.updated_at >= old_info.created_at + 59.minutes).to be true
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: HornsAndHooves-moribus
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - HornsAndHooves
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-11 00:00:00.000000000 Z
+date: 2022-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -208,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.9
+rubygems_version: 3.0.8
 signing_key:
 specification_version: 4
 summary: Introduces Aggregated and Tracked behavior to ActiveRecord::Base models