Fingertips-authentication-needed-san 1.0.0 → 1.1.0

data/README.rdoc

@@ -22,6 +22,10 @@ ApplicationController would look something like the following:
         authentication_needed!
       end
     end
+
+    def when_authentication_needed
+      redirect_to new_session_url
+    end
   end
 
 The authorization-san plugin is available at:

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :major: 1
-:minor: 0
+:minor: 1
 :patch: 0

data/lib/authentication_needed_san.rb

@@ -60,7 +60,11 @@ module AuthenticationNeededSan
   # redirected ‘back’ to the page she originally requested _before_
   # authentication_needed! was called.
   def finish_authentication_needed!
-    flash.discard :after_authentication
-    redirect_to after_authentication[:redirect_to]
+    if authentication_needed?
+      flash.discard :after_authentication
+      redirect_to after_authentication[:redirect_to]
+    else
+      false
+    end
   end
 end

data/test/authentication_needed_san_test.rb

@@ -15,7 +15,7 @@ class TestController < ApplicationController
   end
   
   def authenticate
-    finish_authentication_needed!
+    finish_authentication_needed! or redirect_to(some_other_url)
   end
   
   private
@@ -27,6 +27,10 @@ class TestController < ApplicationController
   def new_session_url
     "http://test/sessions/new"
   end
+  
+  def some_other_url
+    "http://test/manage/articles/new"
+  end
 end
 
 class AuthenticationNeededTest < ActionController::TestCase
@@ -82,6 +86,11 @@ class AuthenticationNeededTest < ActionController::TestCase
     get :authenticate, {}, {}, flash
   end
   
+  test "should return `false' when #finish_authentication_needed! is called but no :after_authentication data exists so the user can do something else" do
+    get :authenticate
+    assert_redirected_to some_other_url
+  end
+  
   private
   
   def url_for(action)
@@ -92,6 +101,10 @@ class AuthenticationNeededTest < ActionController::TestCase
     @controller.send :new_session_url
   end
   
+  def some_other_url
+    @controller.send :some_other_url
+  end
+  
   def stubbed_flash
     flash = { :after_authentication => { :redirect_to => new_session_url } }
     @controller.stubs(:flash).returns(flash)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: Fingertips-authentication-needed-san
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors: 
 - Eloy Duran
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-10 00:00:00 -07:00
+date: 2009-06-11 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -31,7 +31,7 @@ files:
 - rails/init.rb
 - test/authentication_needed_san_test.rb
 - test/test_helper.rb
-has_rdoc: true
+has_rdoc: false
 homepage: http://github.com/Fingertips/authentication-needed-san
 post_install_message: 
 rdoc_options: 
@@ -55,7 +55,7 @@ requirements: []
 rubyforge_project: 
 rubygems_version: 1.2.0
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: A thin wrapper around the Rails `flash' object to assist in redirecting the user `back' after authentication.
 test_files: 
 - test/authentication_needed_san_test.rb