EGP_Rates 0.3.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67e2ffa9c086a7c6a6ae0a7c23603d48d0fd8126
-  data.tar.gz: cef9ab2c432e9dda519a6bb7a910a547efe71aab
+  metadata.gz: e74254f42514b07497208b56180428b55ee1207c
+  data.tar.gz: 56de3e0b1021260b15d3046c563e339669ca672c
 SHA512:
-  metadata.gz: 05722005a91509a13adea01a5ff0686633af1662f84042a7262cc6ebcd3f432fe4b2abfa75f1a2e8dc37e91c1dbb798ded05b3dcaba2ac6e1a14ed541bbb0c42
-  data.tar.gz: a29e3075482b9d81fd76768dc4077909f38036c53f0a0c8f70152371bf5ad7dcb004b2299dac9307a8eceaf36348aff635ab25496142edd76aece62e06366bb0
+  metadata.gz: 62fb9d7476d250e3681ad735db2c0b11cb5b4a594d6c7c889717fa9f4b05670bf5af53cbbbf81ffae26309f3ceca6bc4eb7f03221ab8c87fac556f257ddf3858
+  data.tar.gz: fb3f12ce1ebdc53eb5700e71b51766ba08491c7e5b46a1549b2c85d9d9f38ec00dc6d5c696f6a45cbcde496d2f9ffcf03d4e4ddffb8fb13162e1d8cb26a8c383

data/lib/egp_rates/aaib.rb

@@ -48,24 +48,6 @@ module EGPRates
       table_rows.lazy.map(&:children).map { |cell| cell.map(&:text) }
     end
 
-    # Convert currency string to ISO symbol
-    # @param currency [String] "US Dollar"
-    # @return [Symbol] :USD ISO currency name
-    # rubocop:disable Metrics/CyclomaticComplexity
-    def currency_symbol(currency)
-      case currency
-      when /US DOLLAR/ then :USD
-      when /EURO/      then :EUR
-      when /STERLING/  then :GBP
-      when /SWISS/     then :CHF
-      when /SAUDI/     then :SAR
-      when /KUWAITI/   then :KWD
-      when /DIRHAM/    then :AED
-      else fail ResponseError, "Unknown currency #{currency}"
-      end
-    end
-    # rubocop:enable Metrics/CyclomaticComplexity
-
     # Parse the #raw_exchange_rates returned in response
     # @param [Array] of the raw_data scraped
     # @return [Hash] of exchange rates for selling and buying

data/lib/egp_rates/adib.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+module EGPRates
+  # Abu Dhabi Islamic Bank (ADIB)
+  class ADIB < EGPRates::Bank
+    def initialize
+      @sym = :ADIB
+      @uri = URI.parse('https://www.adib.eg/')
+    end
+
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def exchange_rates
+      @exchange_rates ||= parse(raw_exchange_rates)
+    end
+
+    private
+
+    # Send the request to the URL and retrun raw data of the response
+    # @return [Enumerator::Lazy] with the table row in HTML that evaluates to
+    #   [
+    #     ["\n", "USD", "\n", "17.0000", "\n", "17.5000", "\n"],
+    #     ["\n", "GBP", "\n", "20.9049", "\n", "21.7630", "\n"],
+    #     ...
+    #   ]
+    def raw_exchange_rates
+      table_rows = Oga.parse_html(response.body).css('.CallUs tbody tr')
+      # ADIB porvide 5 currencies on the home page (and 4 rows of info)
+      fail ResponseError, 'Unknown HTML' unless table_rows&.size == 9
+      table_rows.lazy.drop(4).map(&:children).map { |cell| cell.map(&:text) }
+    end
+
+    # Parse the #raw_exchange_rates returned in response
+    # @param [Array] of the raw_data scraped
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def parse(raw_data)
+      raw_data.each_with_object(sell: {}, buy: {}) do |row, result|
+        sell_rate = row[5].to_f
+        buy_rate  = row[3].to_f
+        currency  = row[1].to_sym
+
+        result[:sell][currency] = sell_rate
+        result[:buy][currency]  = buy_rate
+      end
+    end
+  end
+end

data/lib/egp_rates/al_ahli_bank_of_kuwait.rb

@@ -30,8 +30,6 @@ module EGPRates
     #   ]
     #
     def raw_exchange_rates
-      response = Net::HTTP.get_response(@uri)
-      fail ResponseError, response.code unless response.is_a? Net::HTTPSuccess
       table_rows = Oga.parse_html(response.body).css('.ORANGE_TEXT, .BLUE_TEXT')
       # AlAhliBankOfKuwait porvide 8 currencies on the home page
       fail ResponseError, 'Unknown HTML' unless table_rows&.size == 8

data/lib/egp_rates/al_baraka_bank.rb

@@ -38,24 +38,6 @@ module EGPRates
       table_rows.lazy.drop(1).map(&:children).map { |cell| cell.map(&:text) }
     end
 
-    # Convert currency string to ISO symbol
-    # @param currency [String] "US Dollar"
-    # @return [Symbol] :USD ISO currency name
-    # rubocop:disable Metrics/CyclomaticComplexity
-    def currency_symbol(currency)
-      case currency
-      when /USD/       then :USD
-      when /EURO/      then :EUR
-      when /GBP/       then :GBP
-      when /CHF/       then :CHF
-      when /JPY/       then :JPY
-      when /SAR/       then :SAR
-      when /BHD/       then :BHD
-      else fail ResponseError, "Unknown currency #{currency}"
-      end
-    end
-    # rubocop:enable Metrics/CyclomaticComplexity
-
     # Parse the #raw_exchange_rates returned in response
     # @param [Array] of the raw_data scraped
     #   [

data/lib/egp_rates/alex_bank.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+module EGPRates
+  # Bank of Alexandria
+  class AlexBank < EGPRates::Bank
+    def initialize
+      @sym = :AlexBank
+      @uri = URI.parse('https://www.alexbank.com/En/Home/ExchangeRates')
+    end
+
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def exchange_rates
+      @exchange_rates ||= parse(raw_exchange_rates)
+    end
+
+    private
+
+    # Send the request to the URL and retrun raw data of the response
+    # @return [Enumerator::Lazy] with the table row in HTML that evaluates to
+    #   ["", "US Dollar", "", ..., "17.10000", "", "17.50000", ""]
+    #   ["", "British Pound", "", ..., "21.12363", "", "21.60025", ""]
+    #   ...
+    #
+    def raw_exchange_rates
+      # AlexBank provide 17 currencies (and 1 <th>)
+      table_rows = Oga.parse_html(response.body).css('.exchangerate-table tr')
+      fail ResponseError, 'Unknown HTML' unless table_rows&.size == 18
+      table_rows.lazy.drop(1).map(&:children).map do |cell|
+        cell.map(&:text).map(&:strip)
+      end
+    end
+
+    # Parse the #raw_exchange_rates returned in response
+    # @param [Array] of the raw_data scraped
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def parse(raw_data)
+      raw_data.each_with_object(sell: {}, buy: {}) do |row, result|
+        sell_rate = row[9].to_f
+        buy_rate  = row[7].to_f
+        currency  = currency_symbol(row[1])
+
+        result[:sell][currency] = sell_rate
+        result[:buy][currency]  = buy_rate
+      end
+    end
+  end
+end

data/lib/egp_rates/bank.rb

@@ -23,6 +23,37 @@ module EGPRates
       response
     end
 
+    # Convert currency string to ISO symbol
+    # @param currency [String] "US Dollar"
+    # @return [Symbol] :USD ISO currency name
+    # rubocop:disable Metrics/CyclomaticComplexity
+    # rubocop:disable Metrics/MethodLength
+    def currency_symbol(currency)
+      case currency
+      when /UAE|EMIRATES|Dirham/i  then :AED
+      when /Australian/i           then :AUD
+      when /Bahrain|BHD/i          then :BHD
+      when /Canadian/i             then :CAD
+      when /Swiss|CHF/i            then :CHF
+      when /Chinese/               then :CNY
+      when /Danish/i               then :DKK
+      when /Euro|EUR/i             then :EUR
+      when /British|Sterling|GBP/i then :GBP
+      when /Jordanian/i            then :JOD
+      when /Japanese|JPY|YEN/i     then :JPY
+      when /Kuwait/i               then :KWD
+      when /Norwegian/i            then :NOK
+      when /Omani/i                then :OMR
+      when /Qatar/i                then :QAR
+      when /SAR|Saudi/i            then :SAR
+      when /Swidish|Swedish/i      then :SEK
+      when /US Dollar|USD/i        then :USD
+      else fail ResponseError, "Unknown currency #{currency}"
+      end
+    end
+    # rubocop:enable Metrics/CyclomaticComplexity
+    # rubocop:enable Metrics/MethodLength
+
     # Parse the #raw_exchange_rates returned in response
     # @param [Array] of the raw_data scraped
     #   [

data/lib/egp_rates/banque_du_caire.rb

@@ -34,33 +34,5 @@ module EGPRates
       fail ResponseError, 'Unknown HTML' unless table_rows&.size == 19
       table_rows.lazy.drop(2).map(&:children).map { |cell| cell.map(&:text) }
     end
-
-    # Convert currency string to ISO symbol
-    # @param currency [String] "US Dollar"
-    # @return [Symbol] :USD ISO currency name
-    # rubocop:disable Metrics/CyclomaticComplexity
-    def currency_symbol(currency)
-      case currency
-      when /EMIRATES/   then :AED
-      when /AUSTRALIAN/ then :AUD
-      when /BAHRAIN/    then :BHD
-      when /CANADIAN/   then :CAD
-      when /SWISS/      then :CHF
-      when /DANISH/     then :DKK
-      when /EURO/       then :EUR
-      when /BRITISH/    then :GBP
-      when /JORDANIAN/  then :JOD
-      when /JAPANESE/   then :JPY
-      when /KUWAITI/    then :KWD
-      when /NORWEGIAN/  then :NOK
-      when /OMANI/      then :OMR
-      when /QATAR/      then :QAR
-      when /SAUDI/      then :SAR
-      when /SWEDISH/    then :SEK
-      when /US DOLLAR/  then :USD
-      else fail ResponseError, "Unknown currency #{currency}"
-      end
-    end
-    # rubocop:enable Metrics/CyclomaticComplexity
   end
 end

data/lib/egp_rates/banque_misr.rb

@@ -48,7 +48,7 @@ module EGPRates
       when /AUSTRALIA/  then :AUD
       when /BAHRAIN/    then :BHD
       when /CANADA/     then :CAD
-      when /SWEDISH/    then :CHF
+      when /SWISS/      then :CHF
       when /DENMARK/    then :DKK
       when /EURO/       then :EUR
       when /GB POUND/   then :GBP
@@ -59,7 +59,7 @@ module EGPRates
       when /OMAN/       then :OMR
       when /QATARI/     then :QAR
       when /SAUDI/      then :SAR
-      when /SWISS/      then :SEK
+      when /SWEDISH/    then :SEK
       when /US DOLLAR/  then :USD
       else fail ResponseError, "Unknown currency #{currency}"
       end

data/lib/egp_rates/blom.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+module EGPRates
+  # Blom Bank Egypt
+  class Blom < EGPRates::Bank
+    def initialize
+      @sym = :Blom
+      @uri = URI.parse('http://www.blombankegypt.com/BlomEgypt/Exchange-rates')
+    end
+
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def exchange_rates
+      @exchange_rates ||= parse(raw_exchange_rates)
+    end
+
+    private
+
+    # Send the request to the URL and retrun raw data of the response
+    # @return [Enumerator::Lazy] with the table row in HTML that evaluates to
+    #   [
+    #     ["", "USD   02", "", "", "", ..., "17.0000", "", "17.7500", ""]
+    #     ["", "EURO  30", "", "", "", ..., "17.9690", "", "18.8896", ""]
+    #     ...
+    #   ]
+    def raw_exchange_rates
+      table_rows = Oga.parse_html(response.body).css('.tableHolder').first
+      table_rows = table_rows&.css('tr')
+      # Blom porvide 14 currencies on the home page (and 2 <th>)
+      fail ResponseError, 'Unknown HTML' unless table_rows&.size == 16
+      table_rows.lazy.drop(2).map(&:children).map do |row|
+        row.map(&:text).map(&:strip)
+      end
+    end
+
+    # Parse the #raw_exchange_rates returned in response
+    # @param [Array] of the raw_data scraped
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def parse(raw_data)
+      raw_data.each_with_object(sell: {}, buy: {}) do |row, result|
+        sell_rate = row[11].to_f
+        buy_rate  = row[9].to_f
+        currency  = row[1][0..2].to_sym
+        currency  = :JPY if currency == '100'.to_sym
+
+        result[:sell][currency] = sell_rate
+        result[:buy][currency]  = buy_rate
+      end
+    end
+  end
+end

data/lib/egp_rates/cae.rb

@@ -26,8 +26,6 @@ module EGPRates
     #     ...
     #   ]
     def raw_exchange_rates
-      response = Net::HTTP.get_response(@uri)
-      fail ResponseError, response.code unless response.is_a? Net::HTTPSuccess
       table_rows = Oga.parse_html(response.body).css('#f_box option')
       # CAE porvide 17 currencies on the home page but with header
       # and an empty row in the end

data/lib/egp_rates/cbe.rb

@@ -32,25 +32,5 @@ module EGPRates
       fail ResponseError, 'Unknown HTML' unless table_rows&.size == 9
       table_rows.lazy.map(&:children).map { |cell| cell.map(&:text) }
     end
-
-    # Convert currency string to ISO symbol
-    # @param currency [String] "US Dollar"
-    # @return [Symbol] :USD ISO currency name
-    # rubocop:disable Metrics/CyclomaticComplexity
-    def currency_symbol(currency)
-      case currency
-      when /US Dollar/ then :USD
-      when /Euro/      then :EUR
-      when /Sterling/  then :GBP
-      when /Swiss/     then :CHF
-      when /Japanese/  then :JPY
-      when /Saudi/     then :SAR
-      when /Kuwait/    then :KWD
-      when /UAE/       then :AED
-      when /Chinese/   then :CNY
-      else fail ResponseError, "Unknown currency #{currency}"
-      end
-    end
-    # rubocop:enable Metrics/CyclomaticComplexity
   end
 end

data/lib/egp_rates/edbe.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+module EGPRates
+  # Export Development Bank of Egypt (EDBE)
+  class EDBE < EGPRates::Bank
+    def initialize
+      @sym = :EDBE
+      @uri = URI.parse('http://www.edbebank.com/EN/BankingServices/TreasuryFiles/exchangerates.xml')
+    end
+
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def exchange_rates
+      @exchange_rates ||= parse(raw_exchange_rates)
+    end
+
+    private
+
+    # Send the request to the URL and retrun raw data of the response
+    # @return [Array<Oga::XML::Attribute>]
+    #   [
+    #     Attribute(name: "USDBbuy" value: "17.2500"),
+    #     Attribute(name: "USDBsell" value: "17.7000"),
+    #     Attribute(name: "USDTbuy" value: "17.2500"),
+    #     Attribute(name: "USDTsell" value: "17.6000"),
+    #     ...
+    #   ]
+    def raw_exchange_rates
+      table_rows = Oga.parse_xml(response.body).xpath('Details/rates')
+      # EDBE porvide 5 as 20 XML attributes
+      fail ResponseError, 'Unknown HTML' unless table_rows&.size == 1
+      table_rows.flat_map(&:attributes).take(20)
+    end
+
+    # Parse the #raw_exchange_rates returned in response
+    # @param [Array] of the raw_data scraped
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def parse(raw_data)
+      raw_data.each_with_object(sell: {}, buy: {}) do |row, result|
+        next unless row.name[3] == 'B'
+        currency    = row.name[0..2].to_sym
+        action      = row.name[4..-1].to_sym
+        action_rate = row.value.to_f
+        action_rate = (action_rate * 100).round(4) if currency == :JPY
+
+        result[action][currency] = action_rate
+      end
+    end
+  end
+end

data/lib/egp_rates/egb.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+module EGPRates
+  # Egyptian Gulf Bank (EGB)
+  class EGB < EGPRates::Bank
+    def initialize
+      @sym = :EGB
+      @uri = URI.parse('https://eg-bank.com/ExchangeRates/ExchangeRates/')
+    end
+
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def exchange_rates
+      @exchange_rates ||= parse(raw_exchange_rates)
+    end
+
+    private
+
+    # Send the request to the URL and retrun raw data of the response
+    # @return [Enumerator::Lazy] with the table row in HTML that evaluates to
+    #   [
+    #     ["", "USD", "", "17.00", "", "17.75", ""],
+    #     ["", "EUR", "", "17.9639", "", "18.8896", ""],
+    #     ["", "GBP", "", "20.9049", "", "22.0739", ""],
+    #     ...
+    #   ]
+    def raw_exchange_rates
+      table_rows = Oga.parse_html(response.body).css('.row.row-wrapper')
+      # EGB porvide 17 currencies (and a header row)
+      fail ResponseError, 'Unknown HTML' unless table_rows&.size == 18
+      table_rows.lazy.drop(1).map(&:children).map do |cell|
+        cell.map(&:text).map(&:strip)
+      end
+    end
+
+    # Parse the #raw_exchange_rates returned in response
+    # @param [Array] of the raw_data scraped
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def parse(raw_data)
+      raw_data.each_with_object(sell: {}, buy: {}) do |row, result|
+        sell_rate = row[5].to_f
+        buy_rate  = row[3].to_f
+        currency  = row[1].to_sym
+
+        result[:sell][currency] = sell_rate
+        result[:buy][currency]  = buy_rate
+      end
+    end
+  end
+end

data/lib/egp_rates/faisal_bank.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+module EGPRates
+  # Faisal Islamic Bank of Egypt
+  class FaisalBank < EGPRates::Bank
+    def initialize
+      @sym = :FaisalBank
+      @uri = URI.parse('http://www.faisalbank.com.eg/FIB/arabic/rate.html')
+    end
+
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def exchange_rates
+      @exchange_rates ||= parse(raw_exchange_rates)
+    end
+
+    private
+
+    # Send the request to the URL and retrun raw data of the response
+    # @return [Enumerator::Lazy] with the table row in HTML that evaluates to
+    #   [
+    #     ["", "USD", "", "17.2500", "", "17.7500", ...]
+    #     ["", "SAR", "", "4.5745", "", "4.7849" ... ]
+    #     ...
+    #   ]
+    def raw_exchange_rates
+      table_rows = Oga.parse_html(response.body).css('.even')
+      # FaisalBank porvide 13 currencies
+      fail ResponseError, 'Unknown HTML' unless table_rows&.size == 13
+      table_rows.lazy.map(&:children).map do |cell|
+        cell.to_a.drop(2).map(&:text).map(&:strip)
+      end
+    end
+
+    # Parse the #raw_exchange_rates returned in response
+    # @param [Array] of the raw_data scraped
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def parse(raw_data)
+      raw_data.each_with_object(sell: {}, buy: {}) do |row, result|
+        sell_rate = row[5].to_f
+        buy_rate  = row[3].to_f
+        currency  = row[1].to_sym
+
+        result[:sell][currency] = sell_rate
+        result[:buy][currency]  = buy_rate
+      end
+    end
+  end
+end

data/lib/egp_rates/midb.rb

@@ -29,8 +29,6 @@ module EGPRates
     #     ...
     #   ]
     def raw_exchange_rates
-      response = Net::HTTP.get_response(@uri)
-      fail ResponseError, response.code unless response.is_a? Net::HTTPSuccess
       table_rows = Oga.parse_html(response.body)
                       .css('#MainContent_grdcurrency tr')
       # MIDB porvide 7 currencies on the home page but with header

data/lib/egp_rates/nbg.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+module EGPRates
+  # National Bank of Greece (NBG)
+  class NBG < EGPRates::Bank
+    def initialize
+      @sym = :NBG
+      @uri = URI.parse('http://www.nbg.com.eg/en/exchange-rates')
+    end
+
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def exchange_rates
+      @exchange_rates ||= parse(raw_exchange_rates)
+    end
+
+    private
+
+    # Send the request to the URL and retrun raw data of the response
+    # @return [Enumerator::Lazy] with the table row in HTML that evaluates to
+    #   [
+    #     ["", "US Dollar", "", "USD", "", "17.2000", "", "17.8000", ...]
+    #     ["", "Euro", "", "EUR", "", "18.1030", "", "18.3039", ... ]
+    #     ...
+    #   ]
+    def raw_exchange_rates
+      table_rows = Oga.parse_html(response.body).css('.row_exchange')
+      # NBG porvide 9 currencies (and 2 header rows)
+      fail ResponseError, 'Unknown HTML' unless table_rows&.size == 11
+      table_rows.lazy.drop(2).map(&:children).map do |cell|
+        cell.map(&:text).map(&:strip)
+      end
+    end
+
+    # Parse the #raw_exchange_rates returned in response
+    # @param [Array] of the raw_data scraped
+    # @return [Hash] of exchange rates for selling and buying
+    #   {
+    #     { sell: { SYM: rate }, { SYM: rate }, ... },
+    #     { buy:  { SYM: rate }, { SYM: rate }, ... }
+    #   }
+    def parse(raw_data)
+      raw_data.each_with_object(sell: {}, buy: {}) do |row, result|
+        sell_rate = row[7].to_f
+        buy_rate  = row[5].to_f
+        currency  = row[3].to_sym
+
+        result[:sell][currency] = sell_rate
+        result[:buy][currency]  = buy_rate
+      end
+    end
+  end
+end

data/lib/egp_rates/saib.rb

@@ -30,8 +30,6 @@ module EGPRates
     #   ]
     #
     def raw_exchange_rates
-      response = Net::HTTP.get_response(@uri)
-      fail ResponseError, response.code unless response.is_a? Net::HTTPSuccess
       table_rows = Oga.parse_html(response.body).css('.cont table tbody tr')
       # SAIB porvide 6 currencies on the home page but with header
       # and an empty row in the end

data/lib/egp_rates/suez_canal_bank.rb

@@ -36,29 +36,6 @@ module EGPRates
     end
     # rubocop:enable Style/MultilineMethodCallIndentation
 
-    # Convert currency string to ISO symbol
-    # @param currency [String] "US Dollar"
-    # @return [Symbol] :USD ISO currency name
-    # rubocop:disable Metrics/CyclomaticComplexity
-    def currency_symbol(currency)
-      case currency
-      when /UAE Dirham/ then :AED
-      when /Australian/ then :AUD
-      when /Canadian/   then :CAD
-      when /Swiss/      then :CHF
-      when /Danish/     then :DKK
-      when /EUR/        then :EUR
-      when /Sterling/   then :GBP
-      when /YEN/        then :JPY
-      when /Kuwaiti/    then :KWD
-      when /Norwegian/  then :NOK
-      when /Saudi/      then :SAR
-      when /Swedish/    then :SEK
-      when /US Dollar/  then :USD
-      else fail ResponseError, "Unknown currency #{currency}"
-      end
-    end
-
     # Parse the #raw_exchange_rates returned in response
     # @param [Array] of the raw_data scraped
     # @return [Hash] of exchange rates for selling and buying

data/lib/egp_rates/ube.rb

@@ -29,8 +29,6 @@ module EGPRates
     #     ...
     #   ]
     def raw_exchange_rates
-      response = Net::HTTP.get_response(@uri)
-      fail ResponseError, response.code unless response.is_a? Net::HTTPSuccess
       table_rows = Oga.parse_html(response.body).css('table tr')
       # UBE porvide 6 currencies on the home page but with header
       # and an empty row in the end