Dutchie-Style 2.0.11 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98940de414a26efc09108619c8421782a09bf51c25032a357e854856aaaa6505
-  data.tar.gz: f6b9595bbf810983571ab1d531c0fb5d441ddb126e495df7d993c6bbd30ff398
+  metadata.gz: 66d1a3b386238c749fe8a2a57e69ac726ab64167e54fbf18fb3242e8e9988d21
+  data.tar.gz: 5590171816b08b40de46bf110d7d5e59eae4a8289a2dbd71cec88be6e94a5da7
 SHA512:
-  metadata.gz: 82715d41789f44683bf8a58f6ec92f18d17ef50c00e9d13e994f5a3dc9f5b4fdfc606d2adcc35870568059a302c7ba1053356446c68ca69678f675d360c14ee6
-  data.tar.gz: f05a26ac206b58de4b1e35777776fcb67e6a7578608c63e42e8cadd62fb386df722792146eb7ee69c3ffc2e44d083395f8f3c05cf238a3a4a3fb8d18ac661c91
+  metadata.gz: 95e9b22ce1d0f8016bb718f94145149f9f7f0daef5f8e431946559e3443e53e60935249884240dc8605293a64ee62156640bbc4923be535150213187bd6b516c
+  data.tar.gz: 906c6e5cb0961f91a2fae2b04628e42f73773f0e77e75e01cfc19a35fb4a52e6e7c403554e7abb4f1c2ae380b5c3e05d6e1af24cc1f2961e9e923d76d4114c9c

data/Dutchie-Style.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
   spec.summary       = "Rubocop Settings for all dutchie Ruby Apps"
   spec.description   = "Rubocop Settings for all dutchie Ruby Apps"
   spec.homepage      = "https://github.com/GetDutchie/Dutchie-Style"
-  spec.required_ruby_version = Gem::Requirement.new(">= 3.1.4")
+  spec.required_ruby_version = Gem::Requirement.new(">= 3.0.6")
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/GetDutchie/Dutchie-Style"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    Dutchie-Style (2.0.11)
+    Dutchie-Style (2.1.0)
       rubocop (~> 1.72)
       rubocop-capybara (~> 2.18)
       rubocop-factory_bot (~> 2.24)

data/config/default.yml

@@ -280,6 +280,10 @@ Rails/PluckId:
 Rails/PluckInWhere:
   Enabled: false
 
+# Disable I18n locale texts cop
+Rails/I18nLocaleTexts:
+  Enabled: false
+
 # RSpec
 
 # Start context description without 'when', 'with', or 'without'.
@@ -301,3 +305,22 @@ RSpec/NestedGroups:
 # Allows us to mark specs as "skip"
 RSpec/Pending:
   Enabled: false
+
+# Dutchie Custom Cops
+
+# Ensures all LaunchDarkly feature flag calls have default values
+# Supports both Armageddon (DutchieFeatureFlags) and MenuConnector (ld_client.variation) patterns
+Dutchie/LaunchDarklyDefaults:
+  Enabled: true
+  Severity: warning
+  AutoCorrect: true
+
+# Flags questionable usage of safety_assured in migrations
+# The Include directive overrides the global Exclude: db/**/* for this cop only
+Dutchie/MigrationSafetyAssured:
+  Enabled: true
+  Severity: warning
+  Include:
+    - 'db/migrate/**/*.rb'
+    - 'lib/migration_helpers.rb'
+    - 'lib/**/migration_helpers.rb'

data/lib/Dutchie/Style/version.rb

@@ -2,7 +2,7 @@
 
 module Dutchie
   module Style
-    VERSION = "2.0.11"
+    VERSION = "2.1.0"
     public_constant :VERSION
   end
 end

data/lib/dutchie-style.rb

@@ -1,3 +1,5 @@
 # frozen_string_literal: true
 
 require_relative "Dutchie/Style"
+require_relative "rubocop/cop/dutchie/launchdarkly_defaults"
+require_relative "rubocop/cop/dutchie/migration_safety_assured"

data/lib/rubocop/cop/dutchie/launchdarkly_defaults.rb

@@ -0,0 +1,291 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Dutchie
+      # Ensures all LaunchDarkly feature flag calls have default values
+      # to prevent failures during LaunchDarkly service outages
+      #
+      # This cop supports two LaunchDarkly patterns:
+      # 1. Armageddon pattern: DutchieFeatureFlags.flag(), .context_flag(), etc.
+      # 2. MenuConnector pattern: ld_client.variation(), MenuConnector::App[:launchdarkly].variation()
+      #
+      # @example Armageddon pattern
+      #   # bad
+      #   DutchieFeatureFlags.flag("some.flag")
+      #   DutchieFeatureFlags.context_flag("some.flag", dispensary_id: id)
+      #   DutchieFeatureFlags.on?("some.flag")
+      #
+      #   # good
+      #   DutchieFeatureFlags.flag("some.flag", false)
+      #   DutchieFeatureFlags.context_flag("some.flag", default: false, dispensary_id: id)
+      #   DutchieFeatureFlags.on?("some.flag", default: false)
+      #
+      # @example MenuConnector pattern
+      #   # bad
+      #   ld_client.variation("flag", context)
+      #   MenuConnector::App[:launchdarkly].variation("flag", context)
+      #
+      #   # good
+      #   ld_client.variation("flag", context, false)
+      #   MenuConnector::App[:launchdarkly].variation("flag", context, false)
+      #
+      class LaunchDarklyDefaults < ::RuboCop::Cop::Base
+        extend AutoCorrector
+
+        MSG_FLAG = 'DutchieFeatureFlags.flag must have a default value as 2nd parameter'
+        MSG_CONTEXT_FLAG = 'DutchieFeatureFlags.context_flag must have a default: parameter'
+        MSG_DISPENSARY_FLAG = 'DutchieFeatureFlags.dispensary_flag must have a default: parameter'
+        MSG_ENTERPRISE_FLAG = 'DutchieFeatureFlags.enterprise_flag must have a default: parameter'
+        MSG_ON = 'DutchieFeatureFlags.on? should have a default: parameter'
+        MSG_OFF = 'DutchieFeatureFlags.off? should have a default: parameter'
+        MSG_VARIATION = 'LaunchDarkly variation must have a default value as 3rd parameter'
+
+        # DutchieFeatureFlags.flag("key", default, ...)
+        def_node_matcher :dutchie_flag_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :flag
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.context_flag("key", ...)
+        def_node_matcher :context_flag_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :context_flag
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.dispensary_flag("key", ...)
+        def_node_matcher :dispensary_flag_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :dispensary_flag
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.enterprise_flag("key", ...)
+        def_node_matcher :enterprise_flag_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :enterprise_flag
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.on?("key", ...)
+        def_node_matcher :on_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :on?
+            $_
+            $...
+          )
+        PATTERN
+
+        # DutchieFeatureFlags.off?("key", ...)
+        def_node_matcher :off_call?, <<~PATTERN
+          (send
+            (const nil? :DutchieFeatureFlags) :off?
+            $_
+            $...
+          )
+        PATTERN
+
+        # Direct variation calls on ld_client or MenuConnector::App[:launchdarkly]
+        def_node_matcher :variation_call?, <<~PATTERN
+          (send
+            {
+              (send nil? :ld_client)
+              (send
+                (const (const nil? :MenuConnector) :App)
+                :[]
+                (sym :launchdarkly)
+              )
+              (send _ :ld_client)
+            }
+            :variation
+            $_
+            $...
+          )
+        PATTERN
+
+        # MockLaunchDarkly variation calls (for test environments)
+        def_node_matcher :mock_variation_call?, <<~PATTERN
+          (send
+            (const (const nil? :MenuConnector) :MockLaunchDarkly)
+            :variation
+            $_
+            $...
+          )
+        PATTERN
+
+        def on_send(node)
+          # Check Armageddon patterns
+          check_flag_method(node)
+          check_context_flag_method(node)
+          check_dispensary_flag_method(node)
+          check_enterprise_flag_method(node)
+          check_on_method(node)
+          check_off_method(node)
+
+          # Check MenuConnector patterns
+          check_variation_method(node)
+          check_mock_variation_method(node)
+        end
+
+        private
+
+        # Armageddon pattern checks
+
+        def check_flag_method(node)
+          flag_key, *args = dutchie_flag_call?(node)
+          return unless flag_key
+
+          # Need at least one more argument after the key (the default value)
+          return if args.any?
+
+          add_offense(node, message: MSG_FLAG) do |corrector|
+            corrector.insert_after(flag_key, ', false')
+          end
+        end
+
+        def check_context_flag_method(node)
+          flag_key, *args = context_flag_call?(node)
+          return unless flag_key
+
+          return if has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_CONTEXT_FLAG) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        def check_dispensary_flag_method(node)
+          flag_key, *args = dispensary_flag_call?(node)
+          return unless flag_key
+
+          return if has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_DISPENSARY_FLAG) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        def check_enterprise_flag_method(node)
+          flag_key, *args = enterprise_flag_call?(node)
+          return unless flag_key
+
+          return if has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_ENTERPRISE_FLAG) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        def check_on_method(node)
+          flag_key, *args = on_call?(node)
+          return unless flag_key
+
+          # on? accepts default: as keyword or as second positional argument
+          # Return if there's a positional default (non-hash arg) or default: kwarg
+          return if has_positional_default?(args) || has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_ON) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        def check_off_method(node)
+          flag_key, *args = off_call?(node)
+          return unless flag_key
+
+          # off? accepts default: as keyword or as second positional argument
+          # Return if there's a positional default (non-hash arg) or default: kwarg
+          return if has_positional_default?(args) || has_default_kwarg?(args)
+
+          add_offense(node, message: MSG_OFF) do |corrector|
+            insert_default_kwarg(corrector, flag_key, args)
+          end
+        end
+
+        # MenuConnector pattern checks
+
+        def check_variation_method(node)
+          flag_key, *args = variation_call?(node)
+          return unless flag_key
+
+          # variation(flag, context, default) - need at least 2 args after flag
+          return if args.size >= 2
+
+          add_offense(node, message: MSG_VARIATION) do |corrector|
+            if args.empty?
+              # No context provided, add both context and default
+              corrector.insert_after(flag_key, ', nil, false')
+            elsif args.size == 1
+              # Context provided but no default
+              corrector.insert_after(args.last, ', false')
+            end
+          end
+        end
+
+        def check_mock_variation_method(node)
+          # Don't check mock variation calls in test code
+          return if in_test_file?(node)
+
+          flag_key, *args = mock_variation_call?(node)
+          return unless flag_key
+
+          # Same logic as regular variation
+          return if args.size >= 2
+
+          add_offense(node, message: MSG_VARIATION) do |corrector|
+            if args.empty?
+              corrector.insert_after(flag_key, ', nil, false')
+            elsif args.size == 1
+              corrector.insert_after(args.last, ', false')
+            end
+          end
+        end
+
+        # Helper methods
+
+        def has_default_kwarg?(args)
+          args.any? do |arg|
+            next false unless arg.hash_type?
+
+            arg.pairs.any? do |pair|
+              pair.key.sym_type? && pair.key.value == :default
+            end
+          end
+        end
+
+        def has_positional_default?(args)
+          args.any? { |arg| !arg.hash_type? }
+        end
+
+        def insert_default_kwarg(corrector, flag_key, args)
+          if args.any? && args.last.hash_type?
+            # Add to existing hash
+            corrector.insert_after(args.last.source_range.end.adjust(begin_pos: -1), ', default: false')
+          elsif args.any?
+            # Add as new keyword argument after existing args
+            corrector.insert_after(args.last, ', default: false')
+          else
+            # Add as first argument after flag key
+            corrector.insert_after(flag_key, ', default: false')
+          end
+        end
+
+        def in_test_file?(node)
+          processed_source.file_path.include?('spec/')
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/dutchie/migration_safety_assured.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Dutchie
+      # Flags usage of safety_assured in migrations
+      #
+      # The safety_assured block bypasses strong_migrations safety checks,
+      # which should only be used when you're certain the operation is safe
+      # and have documented why it's necessary.
+      #
+      # @example
+      #   # bad
+      #   def change
+      #     safety_assured do
+      #       remove_column :users, :email
+      #     end
+      #   end
+      #
+      #   # good - avoid safety_assured when possible
+      #   def change
+      #     # Use strong_migrations approved patterns instead
+      #     remove_column :users, :email, type: :string
+      #   end
+      #
+      #   # acceptable - with clear documentation
+      #   def change
+      #     # This operation is safe because:
+      #     # 1. The column was already removed from the model
+      #     # 2. No code references this column anymore
+      #     # 3. We've verified in production logs that no queries use this column
+      #     safety_assured do
+      #       remove_column :users, :deprecated_field
+      #     end
+      #   end
+      #
+      class MigrationSafetyAssured < ::RuboCop::Cop::Base
+        MSG = 'Avoid `safety_assured` in migrations. It bypasses strong_migrations safety checks. ' \
+              'Ensure this operation is truly safe, consider safer alternatives, and document why ' \
+              'safety_assured is necessary.'
+
+        # Matches: safety_assured do...end or safety_assured {...}
+        def_node_matcher :safety_assured_block?, <<~PATTERN
+          (block
+            (send nil? :safety_assured)
+            ...
+          )
+        PATTERN
+
+        def on_block(node)
+          return unless safety_assured_block?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: Dutchie-Style
 version: !ruby/object:Gem::Version
-  version: 2.0.11
+  version: 2.1.0
 platform: ruby
 authors:
 - Christopher Ostrowski
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2025-11-07 00:00:00.000000000 Z
+date: 2026-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -110,6 +111,8 @@ files:
 - lib/Dutchie/Style.rb
 - lib/Dutchie/Style/version.rb
 - lib/dutchie-style.rb
+- lib/rubocop/cop/dutchie/launchdarkly_defaults.rb
+- lib/rubocop/cop/dutchie/migration_safety_assured.rb
 - old-default.yml
 homepage: https://github.com/GetDutchie/Dutchie-Style
 licenses:
@@ -119,6 +122,7 @@ metadata:
   source_code_uri: https://github.com/GetDutchie/Dutchie-Style
   changelog_uri: https://github.com/GetDutchie/Dutchie-Style/releases
   rubygems_mfa_required: 'true'
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -126,14 +130,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.1.4
+      version: 3.0.6
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.0.3.1
+signing_key: 
 specification_version: 4
 summary: Rubocop Settings for all dutchie Ruby Apps
 test_files: []